Nightly build #89 for cordova has succeeded!

Nightly build #89 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/89/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user carynbear commented on the issue: https://github.com/apache/cordova-lib/pull/474 @stevengill https://issues.apache.org/jira/browse/CB-11654 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 @vladimir-kotikov any issues you see with us moving this from cordova-lib to cordova-common? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request #470: CB-11636 Handle attributes with quotes correc...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/470 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #470: CB-11636 Handle attributes with quotes correctly

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/470 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request #473: CB-11645 added check to see if getEditConfig ...

Github user stevengill closed the pull request at: https://github.com/apache/cordova-lib/pull/473 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib issue #473: CB-11645 added check to see if getEditConfig exists ...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/473 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 Can you create a issue to remove the duplicate code + tests from cordova-lib. That can be a separate PR after cordova-common has been released. --- If your project is set up for it, you

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-camera issue #219: Dont work camera on Android

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/219 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/474 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/474?src=pr) is 80.66% (diff: 100%) > Merging [#474](https://codecov.io/gh/apache/cordova-lib/pull/474?src=pr) into

[DISCUSS] cordova-plugin-media-capture video quality

The cordova-plugin-media-capture allows a quality property on Android that accepts two values: 0 - low quality 1 - high quality (default) Those are the only values android allows iOS doesn't support quality, but there is an issue open to add that property

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib; To...

Github user carynbear commented on the issue: https://github.com/apache/cordova-lib/pull/474 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib; To...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 Two things: 1) migrate the tests over and add them to this pr 2) add the apache license header comment to the top. You will notice every other file has this. Apache requirement.

[GitHub] cordova-plugin-camera issue #226: CB-11376: (ios): fix CameraUsesGeolocation...

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/226 Thanks, merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-lib pull request #474: CB-11653 copied findProjectRoot from cordova-...

GitHub user carynbear opened a pull request: https://github.com/apache/cordova-lib/pull/474 CB-11653 copied findProjectRoot from cordova-lib; ToDo: migrate tests… … over You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-camera pull request #226: CB-11376: (ios): fix CameraUsesGeol...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios issue #239: CB-11648: Make CDVViewController send notifications

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/239 LGTM. Passes all local tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-camera issue #226: CB-11376: (ios): fix CameraUsesGeolocation...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/226 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: [DISCUSS] cordova-ios 4.2.1

As this has been postponed, can somebody review this and if it's ok include it in the next release? https://github.com/apache/cordova-ios/pull/239 2016-07-26 19:42 GMT+02:00 Jesse : > +1 > > > @purplecabbage > risingj.com > > On Tue, Jul 26, 2016 at 7:54 AM, Simon

RE: [DISCUSS] Android 5.2.2 release

This is off topic, but Steve could you please consider including this PR into new cordova-common: https://github.com/apache/cordova-lib/pull/470/files, thanks - Vladimir -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Saturday, July 30, 2016 3:25 AM To:

[GitHub] cordova-lib issue #473: CB-11645 added check to see if getEditConfig exists ...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/473 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-windows pull request #185: CB-11558 Make windows plugin rm remove Pr...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/185#discussion_r72957333 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -105,7 +105,7 @@ var handlers = { var type = obj.type;

[GitHub] cordova-windows pull request #185: CB-11558 Make windows plugin rm remove Pr...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/185#discussion_r72956629 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -105,7 +105,7 @@ var handlers = { var type = obj.type;

[GitHub] cordova-plugin-file pull request #186: CB-11305 Enable cdvfile: assets fs ro...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file issue #186: CB-11305 Enable cdvfile: assets fs root for ...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/186 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/186/commits/21298dce51568a2662adee8ff4bfc9b8c838d3a7)