[GitHub] cordova-android pull request #316: CB-11078 Empty string for BackgroundColor...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [Android] API change: Where to put a utility method?

This info is in config.xml isn't it? http://www.w3.org/ns/widgets; xmlns:cdv="http://cordova.apache.org/ns/1.0;> MyAppHasAName ... Plugins are already expected to read their own preferences, unfortuately the CordovaPreferences.java file does not appear to be the right place, as this is not

[GitHub] cordova-lib issue #459: CB-11493: Add cordova emulate option to skip prepare

Github user gruppjo commented on the issue: https://github.com/apache/cordova-lib/pull/459 Great! Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Nightly build #90 for cordova has failed

Nightly build #90 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/90/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/90/consoleFull - Jenkins for Apache Cordova

Re: [DISCUSS] cordova-plugin-media-capture video quality

+1 what Vladimir said On Mon, Aug 1, 2016 at 11:29 PM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > I think I like option 2 more than others, assuming that we also accept > values between 0 and 1 as a medium quality. Then it won't break existing > behavior on Android and would

Managing typescript typings for Cordova and plugins

Hello, I'm looking at improving our vscode extension for Cordova development. Currently we bundle a set of typings for Cordova and some plugins with the extension, and we use these typings to provide intellisense even for plain javascript projects. I would like to improve this by using the

[GitHub] cordova-plugin-contacts issue #131: CB-11455: (ios) Add mandatory iOS 10 pri...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/131 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-contacts issue #129: CB-11455: (ios) Add mandatory iOS 10 pri...

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/129 Hi. I have sent a new PR (https://github.com/apache/cordova-plugin-contacts/pull/131) where the usage description can be added as a variable on plugin install or use an

[GitHub] cordova-plugin-contacts pull request #131: CB-11455: (ios) Add mandatory iOS...

GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/131 CB-11455: (ios) Add mandatory iOS 10 privacy description ### Platforms affected iOS ### What does this PR do? Adds the mandatory

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user carynbear commented on the issue: https://github.com/apache/cordova-lib/pull/474 I would like to use it in Phonegap, but also it seems like a useful method in general for dealing with Cordova projects. In the spirit of modularizing Cordova, it seems that Plugman would be

[GitHub] cordova-plugin-statusbar issue #37: CB-9841 - Allow iOS statusbar to animate...

Github user Hirbod commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/37 Just came here to see if there is any solution to fade the status bar - and there we go. I don't understand why this isnt merged. Could you guys please add this into the plugin?

[GitHub] cordova-plugin-camera issue #219: Dont work camera on Android

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/219 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-lib issue #475: CB-11652 Update run and emulate to skip build

Github user daserge commented on the issue: https://github.com/apache/cordova-lib/pull/475 You should also check test failures if they occur after squashing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib issue #475: CB-11652 Update run and emulate to skip build

Github user daserge commented on the issue: https://github.com/apache/cordova-lib/pull/475 Yes, LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-lib issue #475: CB-11652 Update run and emulate to skip build

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/475 Thanks, @daserge, updated. Is this good to go now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-windows pull request #190: CB-11478 Parse --archs option consistentl...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib issue #475: CB-11652 Update run and emulate to skip build

Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/475 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/475?src=pr) is 80.68% (diff: 100%) > Merging [#475](https://codecov.io/gh/apache/cordova-lib/pull/475?src=pr) into

[GitHub] cordova-plugin-camera issue #219: Dont work camera on Android

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/219 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-lib pull request #475: CB-11652 Update run and emulate to skip build

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/475#discussion_r73153070 --- Diff: cordova-lib/src/cordova/emulate.js --- @@ -42,20 +46,17 @@ module.exports = function emulate(options) { }).then(function() {

[GitHub] cordova-windows pull request #190: CB-11478 Parse --archs option consistentl...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/190#discussion_r73152541 --- Diff: template/cordova/lib/run.js --- @@ -39,7 +39,7 @@ module.exports.run = function (options) { // parse arg var args

[GitHub] cordova-lib issue #475: CB-11652 Update run and emulate to skip build

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/475 @daserge. @sgrebnov, PTAL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request #475: CB-11652 Update run and emulate to skip build

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/475 CB-11652 Update run and emulate to skip build This PR moves handling of `--nobuild` option to CLI. CLI previously has delegated this logic to platform's `run` method but since

[GitHub] cordova-windows pull request #190: CB-11478 Parse --archs option consistentl...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/190#discussion_r73150144 --- Diff: template/cordova/lib/run.js --- @@ -39,7 +39,7 @@ module.exports.run = function (options) { // parse arg

[GitHub] cordova-windows pull request #190: CB-11478 Parse --archs option consistentl...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/190#discussion_r73147848 --- Diff: template/cordova/lib/run.js --- @@ -39,7 +39,7 @@ module.exports.run = function (options) { // parse arg

[GitHub] cordova-windows pull request #190: CB-11478 Parse --archs option consistentl...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/190#discussion_r73132090 --- Diff: template/cordova/lib/run.js --- @@ -39,7 +39,7 @@ module.exports.run = function (options) { // parse arg var args

[GitHub] cordova-windows issue #190: CB-11478 Parse --archs option consistently

Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/190 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/190?src=pr) is 74.21% (diff: 100%) > Merging

[GitHub] cordova-windows pull request #190: CB-11478 Parse --archs option consistentl...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/190 CB-11478 Parse --archs option consistently This PR aligns arguments parsing logic with `build` command where passing `--archs` either as CLI argument (`cordova build --archs`) or

[GitHub] cordova-windows issue #190: CB-11478 Parse --archs option consistently

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/190 @daserge, @sgrebnov, please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-windows pull request #185: CB-11558 Make windows plugin rm remove Pr...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-statusbar issue #55: Handle extended status bar on iOS

Github user medoix commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/55 @goshakkk bump. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-windows issue #185: CB-11558 Make windows plugin rm remove ProjectRe...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/185 LGTM, :ship: it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugins pull request #27: CB-11644: (ios) Set cdvtoken cookie path t...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugins/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request #185: CB-11558 Make windows plugin rm remove Pr...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/185#discussion_r73113256 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -105,7 +105,7 @@ var handlers = { var type = obj.type;

[GitHub] cordova-lib pull request #459: CB-11493: Add cordova emulate option to skip ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/459 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #459: CB-11493: Add cordova emulate option to skip prepare

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/459 Hey. I'm sorry that it took us so long to accept your PR. Merging it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-windows pull request #185: CB-11558 Make windows plugin rm remove Pr...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/185#discussion_r73102591 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -105,7 +105,7 @@ var handlers = { var type = obj.type;

[GitHub] cordova-plugins pull request #26: CB-11643: return after sending error

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugins/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/474 @stevengill, @carynbear, no issues. Just curious where do you plan to use it outside of cordova-lib :) --- If your project is set up for it, you can reply to this email and have your

RE: [DISCUSS] cordova-plugin-media-capture video quality

I think I like option 2 more than others, assuming that we also accept values between 0 and 1 as a medium quality. Then it won't break existing behavior on Android and would allow to specify all supported quality modes on iOS. - Vladimir -Original Message- From: julio cesar sanchez

[GitHub] cordova-ios pull request #238: CB-11535 CB-10361 ios: fix bug with remove fr...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/238 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request #185: CB-11558 Make windows plugin rm remove Pr...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/185#discussion_r73100316 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -105,7 +105,7 @@ var handlers = { var type = obj.type;

Re: [COMMUNITY RALLY] WKWebView localStorage will not work with file urls in iOS 10 unless...

This fix is not in iOS 10 beta 4. Hopefully beta 5 On Mon, Jul 25, 2016 at 4:18 PM, Shazron wrote: > In all the time I took to research and work on this, apparently Apple > removed the check 3 hours ago: > https://trac.webkit.org/changeset/203695 > > Thanks to Darryl Pogue