Re: [Vote] 4.3.1 iOS Release

2016-11-30 Thread Jesse
This should be in a discuss thread. @purplecabbage risingj.com On Wed, Nov 30, 2016 at 8:24 PM, Steven Gill wrote: > We don't update the deps every release. It is more just a reminder to check > them, make sure bundled deps match wanted. If releaser is feeling >

Re: [Vote] 4.3.1 iOS Release

2016-11-30 Thread Steven Gill
We don't update the deps every release. It is more just a reminder to check them, make sure bundled deps match wanted. If releaser is feeling ambitious, they can update the deps. Might require more in depth testing. We have run into issues updating deps before (like shelljs). Something like

Re: [Vote] 4.3.1 iOS Release

2016-11-30 Thread Filip Maj
The release notes in coho [1] note to check npm outdated dependencies. When I run that against commit 0c201c42344f63c7590c4190ba2285fa199300bb, I get: ~/src/cordova-ios on master via ⬢ v6.9.1 ➔ npm outdated --depth=0 Package Current Wanted Latest Location nodeunit0.8.8 0.8.8 0.10.2

[GitHub] cordova-mobile-spec pull request #142: [CB-12186] [create script] Support pa...

2016-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Nightly build #243 for cordova has succeeded!

2016-11-30 Thread Apache Jenkins Server
Nightly build #243 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/243/consoleFull - Jenkins for Apache Cordova

[Vote] 4.3.1 iOS Release

2016-11-30 Thread Shazron
Please review and vote on this 4.3.1 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-12203 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-12203 The package

Re: Hello again!

2016-11-30 Thread Filip Maj
Thanks for the clarification Alexander! I think I got confused between the PR and periodic builds. I see in the periodic builds, indeed the job is cloning down the relevant platform and using the latest HEAD from master. In the PR builds, the logs are sparser and don't explicitly log out versions

[GitHub] cordova-plugin-file-transfer issue #170: CB-12154 file-transfer progressEven...

2016-11-30 Thread erikramalho
Github user erikramalho commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/170 I've tested @daserge commit and it works perfectly! please, merge it asap! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2016-11-30 Thread jlchereau
Github user jlchereau commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Definitely ++1 for this one. https://github.com/kidoju/Kidoju-Mobile: 1) Loads a script library as text from a local file using $.ajax. 2) Executes a series

[GitHub] cordova-plugin-wkwebview-engine pull request #23: CB-11997: Add crash recove...

2016-11-30 Thread cjpearson
Github user cjpearson commented on a diff in the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90223157 --- Diff: src/ios/CDVWKWebViewEngine.m --- @@ -123,6 +123,32 @@ - (void)pluginInitialize

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-11-30 Thread jlchereau
Github user jlchereau commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 I have experienced the defect described here with oAuth flows but considering [Google deprecation of webviews for oAuth

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

2016-11-30 Thread jlchereau
Github user jlchereau commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 I have experienced the defect described here with oAuth flows but considering [Google deprecation of webviews for oAuth

[GitHub] cordova-plugin-file-transfer issue #170: CB-12154 file-transfer progressEven...

2016-11-30 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/170 @jcesarmobile, @shazron, @stevengill could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-file-transfer issue #169: CB-10974 Cordova file transfer Cont...

2016-11-30 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/169 @jcesarmobile, @shazron, @stevengill could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

RE: CB-10974 FileTransfer chunkedMode=false + HTTPS

2016-11-30 Thread Sergey Shakhnazarov (Akvelon)
Hi guys, Shazron - in fact we have the checks in the onprogress events in the doc checking if an event is computable (and it was false for chunkedMode=true), so docs are valid. Could you please review and comment on these PRs? 1. https://github.com/apache/cordova-plugin-file-transfer/pull/169