[GitHub] cordova-plugin-inappbrowser issue #215: CB-12560: (android) fix null pointer...

Github user dblood commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/215 Of course. I will work on a test script. The library I was using is https://github.com/IdentityModel/oidc-client-js with type of "id_token token" and monitoring on. This

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 @shazron This can go in to 4.4.1 now that cordova-common changes are merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-ios issue #309: CB-8980: Ensure copied resource-files are cleaned

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/309 This will go in cordova-ios@4.4.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request #696: CB-12686 - Add docs for supp...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/696#discussion_r113364011 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -470,6 +470,23 @@ Examples: ``` +## resource-file + +This tag

[GitHub] cordova-docs pull request #696: CB-12686 - Add docs for supp...

Github user fredgalvao commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/696#discussion_r113359587 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -470,6 +470,23 @@ Examples: ``` +## resource-file + +This tag

[GitHub] cordova-plugin-geolocation issue #87: Update CDVLocation.m

Github user avishekcode commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/87 @filmaj Greatly appreciate for letting me know. I just submitted the Individual Contributor License Agreement to secret...@apache.org via email. Not sure if I

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

The PR for the Plugin Audit is originally here: https://github.com/cordova/cordova-discuss/pull/58 On Tue, Apr 25, 2017 at 6:55 PM, Shazron wrote: > This is the start of a conversation: > https://issues.apache.org/jira/browse/CB-12708 > > Take these two issues below into

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/137/commits/36e4fdf22820f750d96774e0e254327aca062dec)

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

May I request that *specific plugin* discussions occur in the specific plugin issues referenced in https://issues.apache.org/jira/browse/CB-12708 and that *general* roadmap discussion occur here in this thread. We have 23 plugins so if it all occurs here, it will be chaos. On Tue, Apr 25, 2017 at

[GitHub] cordova-plugin-media pull request #132: CB-12542 - Can't record to a wav fil...

Github user shazron closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[CORE PLUGINS][DISCUSS] Roadmap 2017

This is the start of a conversation: https://issues.apache.org/jira/browse/CB-12708 Take these two issues below into consideration: 1. Cordova's plugin audit sometime back:

[GitHub] cordova-plugin-statusbar pull request #67: CB-12024: Browser platform suppor...

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/67#discussion_r113349852 --- Diff: README.md --- @@ -73,6 +73,9 @@ if (cordova.platformId == 'android') { } ``` +### Browser Support +Only a

[GitHub] cordova-plugin-statusbar pull request #67: CB-12024: Browser platform suppor...

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/67#discussion_r113349809 --- Diff: README.md --- @@ -73,6 +73,9 @@ if (cordova.platformId == 'android') { } ``` +### Browser Support --- End

[GitHub] cordova-docs issue #698: CB-12687 - cordova-ios@4.4.0 Blog Post

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/698 Note the links are not live -- since they depend on #695 and #696 and pushing the updated docs live --- If your project is set up for it, you can reply to this email and have your reply

[BLOG POST][DRAFT] cordova-ios@4.4.0

Please review: https://github.com/apache/cordova-docs/pull/698

[GitHub] cordova-docs pull request #698: CB-12687 - cordova-ios@4.4.0 Blog Post

GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/698 CB-12687 - cordova-ios@4.4.0 Blog Post ### What does this PR do? Blog post for cordova-ios@4.4.0 release ### Checklist - [X] [Reported an

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

Github user jonasof commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 > About the storage permissions I think there is no other option than to include it in the manifest What I mean is that not all people who uses inappbrowser need the

[GitHub] cordova-plugin-contacts issue #142: android doesn't support data to save pho...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/142 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-contacts pull request #142: android doesn't support data to s...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts issue #142: android doesn't support data to save pho...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/142 I have rebased this branch with latest master and merged in in 9d71756e2c6ee243d54eb2c5724c0b0c51dce369. Thanks for the PR! Will close this separately. --- If your project

[GitHub] cordova-plugin-contacts issue #142: android doesn't support data to save pho...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/142 I see the problem. Contacts plugin's tests can't handle Android 6+'s dynamic permission model. We will need to tackle that separately. It works on Android 5.1, and CI passes there no

[GitHub] cordova-plugin-inappbrowser issue #218: CB-12266: (browser platform) loadsto...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/218 Fixed in bfb33988be6dae6708a254872da3bf4081eeeb7b --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-inappbrowser pull request #218: CB-12266: (browser platform) ...

Github user filmaj closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser issue #218: CB-12266: (browser platform) loadsto...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/218 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-contacts issue #142: android doesn't support data to save pho...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/142 CI failures eh? Uh oh... hmm... looking into it. I will try to repro locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-contacts issue #142: android doesn't support data to save pho...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/142 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-inappbrowser issue #217: CB-12266 browser: Fix type for InApp...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/217 Please close this pull request - I have a PR to fix the underlying issue open over at #218. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-inappbrowser pull request #218: CB-12266: (browser platform) ...

GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/218 CB-12266: (browser platform) loadstop event.url is now a string … instead of an object, aligning it with the other platforms. ### Platforms affected Browser.

Re: [CORE PLUGINS] Expansion of features needs to be discussed in dev@

+1 as well :-) ~ Kerri > On Apr 25, 2017, at 17:34, Steven Gill wrote: > > +1. Agree to all of this. > > On Tue, Apr 25, 2017 at 3:25 PM, Filip Maj wrote: > >> I know some of the plugins (all of them?) call out at the top of the >> docs that they

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 Anything preventing this merge @matrosov-nikita ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [CORE PLUGINS] Expansion of features needs to be discussed in dev@

+1. Agree to all of this. On Tue, Apr 25, 2017 at 3:25 PM, Filip Maj wrote: > I know some of the plugins (all of them?) call out at the top of the > docs that they are based on standards. I think we should be more > dilligent in referencing those specs when

[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/76 @momomatteo can you put the issue id (CB-12562) on the title so it's linked with the original issue on JIRA? Also, can you remove one of the `#import `? you duplicated

Re: [CORE PLUGINS] Expansion of features needs to be discussed in dev@

I know some of the plugins (all of them?) call out at the top of the docs that they are based on standards. I think we should be more dilligent in referencing those specs when discussing/weighing changes to the APIs. It would be a lot easier to maintain a stance such as "this does not follow the

[GitHub] cordova-plugin-statusbar issue #77: CB-10879: (android) Enable overlaysWebVi...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/77 FYI I filed an issue for 'removal of reflection' from this plugin in [CB-12732](https://issues.apache.org/jira/browse/CB-12732). --- If your project is set up for it, you can reply

Re: [CORE PLUGINS] Expansion of features needs to be discussed in dev@

Whenever I see a PR for a new feature I tell the author to send a mail to discuss it, most of them don't do it. 2017-04-25 22:22 GMT+02:00 Simon MacDonald : > Hey Shazon, > > I agree with this goal. Our plugins were based upon W3C standards as > they existed when the

Re: [DISCUSS] Include TypeScript definitions in plugins

Vladimir, I was recently questioned about this goal/topic on the .d.ts for phonegap-push-plugin I maintain on DT, and the question I have now is: How long will we have to maintain both in-house and DT versions for? Is it a plan to remove them from DT once they are stable at home? How's the

[GitHub] cordova-lib pull request #547: CB-8978: Add option to get resource-file from...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [CORE PLUGINS] Expansion of features needs to be discussed in dev@

Hey Shazon, I agree with this goal. Our plugins were based upon W3C standards as they existed when the plugins were created. The standards have moved on and we haven't had as much time as we would like to stay in sync. A number of core plugins have been superseded by API's already available in

[CORE PLUGINS] Expansion of features needs to be discussed in dev@

Resources are limited and we can barely keep up with all the core plugin work that needs to be done, so we have to have a process with dealing with desired features that community members send out as PRs. Firstly I want to acknowledge that external contributions are valued highly by the team, but

[GitHub] cordova-docs pull request #697: Update index.md

GitHub user Teebeutel94 opened a pull request: https://github.com/apache/cordova-docs/pull/697 Update index.md ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ]

[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request #538: Emit platformAPI loading error, remove Gradle...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/538 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-statusbar issue #77: CB-10879: (android) Enable overlaysWebVi...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/77 BTW: I agree with the original author about reflection not being in Android. I think that adding reflection for compile-time bugs is one of the worst things ever, like drowning

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 @matrosov-nikita Which Samsung devices are affected? All of them? Only the Samsung Galaxy S3/4/5? If we could get more info on that, we can test for this and try and make

[GitHub] cordova-plugin-geolocation issue #85: Android: handle location service is of...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/85 Why are you returning no error message when you're sending back the ILLEGAL_ACCESS error when the permission is denied? --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-inappbrowser issue #215: CB-12560: (android) fix null pointer...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/215 @dblood OK, so what do I need to do to test this thing to verify this works? Do you have a monitor script available somewhere? Please don't check off the last box if there's

Re: [Vote] 6.2.2 Android Release

I vote +1: * Ran coho verify-archive * Ran unit tests repo * unpacked, npm i, and npm tested * built and ran hello world app via cli @purplecabbage risingj.com On Tue, Apr 25, 2017 at 10:11 AM, Shazron wrote: > I vote +1: > * Ran coho audit-license-headers over the relevant

Re: [VOTE] 4.4.0 iOS Release

I vote +1: * Ran coho verify-archive * Ran unit tests repo * unpacked, npm i, and npm tested * built and ran hello world app via cli @purplecabbage risingj.com On Tue, Apr 25, 2017 at 10:28 AM, Steven Gill wrote: > I vote +1: > * Ran coho audit-license-headers over the

Re: [VOTE] 4.4.0 iOS Release

I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran unit tests in cordova-ios repo * built and ran hello world app via cli On Mon, Apr 24, 2017 at 6:08 PM, Shazron

Re: [DISCUSS] cordova-ios@4.4.0 release

btw update your cordova-coho before verifying On Mon, Apr 24, 2017 at 11:22 PM, Shazron wrote: > Sweet!!! > > On Mon, Apr 24, 2017 at 10:56 PM, Alexander Sorokin (Akvelon) < > v-als...@microsoft.com.invalid> wrote: > >> By the way, we now do per-commit builds on the cloudapp

Re: [Vote] 6.2.2 Android Release

I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Added the platform, built, and deployed to device (using both SDK tools v25 and v26) On Mon, Apr 24, 2017 at 11:12 PM,

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

Github user hollyschinsky commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj @urmx @tobiasviehweger It's a bit confusing with iOS because the status bar styling has changed several times and the `blacktranslucent` and `blackopaque` were

Re: cordova can't see android targets

You can also do `cordova platform add https://github.com/apache/ cordova-android#6.2.2` On Tue, Apr 25, 2017 at 9:23 AM, Filip Maj wrote: > Hi Oleg, > > This is an issue caused by Google changing the Android SDK tooling in > version 26. > > If you use the latest

Re: cordova can't see android targets

Hi Oleg, This is an issue caused by Google changing the Android SDK tooling in version 26. If you use the latest cordova-android, it should be compatible with the new tools. Unfortunately, support for the new tools is unreleased at this time so you will need to use the latest cordova-android

[GitHub] cordova-ios issue #254: Expose CDVCommandStatus enum to Swift

Github user lucatorella commented on the issue: https://github.com/apache/cordova-ios/pull/254 This change isn't braking old code. The enum is still called CDVCommandStatus in Obj-C. It's just using the newer NSEnum syntax that is the recommended syntax even before Swift came out.

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 Excellent, thanks for signing the ICLA! Ping @hollyschinsky - can you check what @urmx and @tobiasviehweger mention here with respect to the blacktranslucent/blackopaque bits

[GitHub] cordova-plugin-geolocation issue #87: Update CDVLocation.m

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/87 @avishekcode in general it is required, I believe there is some wiggle room for trivial contributions, but in this case, I think the changes are significant enough that we'll need

[GitHub] cordova-plugin-camera pull request #260: CB-12650: Fix manual test for uploa...

Github user matrosov-nikita closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/260 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-camera issue #260: CB-12650: Fix manual test for uploading im...

Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/260 Merged this in. For some reason, the PR did not automatically close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

Github user urmx commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @tobiasviehweger For the blacktranslucent behavior, I used this [plugin README](https://github.com/apache/cordova-plugin-statusbar/blob/master/README.md#statusbarstyleblacktranslucent):

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

Github user urmx commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj Yes, I also did 3 days ago. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-geolocation issue #87: Update CDVLocation.m

Github user avishekcode commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/87 @filmaj Nope. Is that a requirement? I didn't think there would be any licensing issue, since I am contributing to an already open project, where the terms are already in

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

Github user MeirBon commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 @jonasof Your implementation looks indeed better. About the storage permissions, I think there is no other option than to include it in the manifest (we had it automatically

cordova can't see android targets

Hi, all. Sorry, if i chosen the wrong list for my question, but it seems here http://stackoverflow.com/questions/43348972/cordova-cant-see-android-targets nobody can help me. I have the next error with cordova: ~$ cordova requirements Requirements check results for android: Java JDK:

Re: [DISCUSS] cordova-ios@4.4.0 release

Sweet!!! On Mon, Apr 24, 2017 at 10:56 PM, Alexander Sorokin (Akvelon) < v-als...@microsoft.com.invalid> wrote: > By the way, we now do per-commit builds on the cloudapp CI for the > platforms. > Here's this revision's build (SPOILER: all tests green): >

[GitHub] cordova-lib pull request #542: CB-12663: Install latest version of plugin in...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/542 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file issue #199: CB-12355: (iOS) fix FileEntry.file.type

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file/pull/199 As long as @kerrishotts still approves, I think we can pull it in. @kerrishotts do you think we need @LightZam to sign an ICLA for this? Worth noting that the [File API w3c

[Vote] 6.2.2 Android Release

Please review and vote on this 6.2.2 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-12697 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-12697 The package

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

Github user tobiasviehweger commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj @urmx We probably should also check about the blacktranslucent one. It seems we implemented that differently, but I din't quite remember why.. Also we have other