Nightly build #363 for cordova has succeeded!

Nightly build #363 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/363/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-ios issue #317: Add logging for malformed data

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/317 This PR is missing a JIRA issue, as part of the Checklist. Please file an issue at: http://issues.apache.org/jira/browse/CB ... so it can be tracked and evaluated by the devs, and

[GitHub] cordova-lib pull request #533: CB-12250 CB-12409 iOS: Fix bug with escaping ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #555: CB-12786: Improve logic for searching plugin ...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/555#discussion_r119971709 --- Diff: cordova-fetch/index.js --- @@ -148,9 +148,15 @@ function trimID(target) { target = parts[1]; } -//If

[GitHub] cordova-ios pull request #317: Add logging for malformed data

GitHub user rafael-chavez opened a pull request: https://github.com/apache/cordova-ios/pull/317 Add logging for malformed data ### Platforms affected iOS ### What does this PR do? Prints the malformed data created by the process for further

[GitHub] cordova-lib pull request #560: CB-12762 : point package.json repo items to g...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #556: CB-12777 : Removed unneeded fixtures in cordo...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/556 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #560: CB-12762 : point package.json repo items to github m...

Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/560 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr=h1) Report > Merging [#560](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr=desc) into

[GitHub] cordova-lib pull request #559: Display deprecation message when installing a...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #560: CB-12762 : point package.json repo items to github m...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/560 @audreyso can you update the package.json in cordova-fetch, cordova-common and cordova-serve as well for this pr? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-lib issue #557: CB-12787: Fix plugin installation with --link option

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/557 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request #557: CB-12787: Fix plugin installation with --link...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #555: CB-12786: Improve logic for searching plugin ...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/555#discussion_r119950730 --- Diff: cordova-fetch/index.js --- @@ -148,9 +148,15 @@ function trimID(target) { target = parts[1]; } -//If

[GitHub] cordova-lib issue #554: CB-12738: Cordova ignores plugin dependency version ...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/554 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request #554: CB-12738: Cordova ignores plugin dependency v...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Incompatible plugin should reject the build

+1 Fail (I think principle of least surprise applies here; most devs would expect an incompatible plugin to fail the build.) ~ Kerri > On Jun 2, 2017, at 12:15, Shazron wrote: > > Consensus on this long stewing issue of 7 months? > > If you deleted the thread: > 1. Issue

Re: Incompatible plugin should reject the build

+1 Fail and freak out so everyone knows! @purplecabbage risingj.com On Fri, Jun 2, 2017 at 10:59 AM, Steven Gill wrote: > You are right in that we don't fail the build when a incompatible plugin > fails to install. > > cordova-fetch doesn't change this behavior as it

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/558 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request #558: CB-12766 Consistently write JSON with 2 space...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-osx pull request #37: CB-12762 : point package.json repo items to gi...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-wkwebview-engine pull request #36: CB-12762 : point package.j...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Re: Incompatible plugin should reject the build

You are right in that we don't fail the build when a incompatible plugin fails to install. cordova-fetch doesn't change this behavior as it is install time vs fetch time. Also this is a difference between using cordovaDependencies in package.json vs engine in config.xml. If a CordovaDependencies

[GitHub] cordova-plugin-wkwebview-engine issue #36: CB-12762 : point package.json rep...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36 Cordova CI Build has completed successfully. **Commit** -

Re: Incompatible plugin should reject the build

Consensus on this long stewing issue of 7 months? If you deleted the thread: 1. Issue https://issues.apache.org/jira/browse/CB-12122 2. Thread https://s.apache.org/ofqR +1 on engine check failing the build. Questions that need answered: Does cordova-fetch on cordova@7 do this already, like Simon

[GitHub] cordova-plugin-console issue #22: Fix for : https://issues.apache.org/jira/b...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-console/pull/22 Also, please change the title to have a prefix of "CB-12168" so it can be auto-tracked in JIRA. This was already covered in the Github Pull Request template that you erased when a

[GitHub] cordova-plugin-wkwebview-engine pull request #36: CB-12762 : point package.j...

GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36 CB-12762 : point package.json repo items to github mirrors instead of… … apache repos site ### Platforms affected ### What does this PR

[GitHub] cordova-plugin-camera pull request #269: CB-12764: (android) Adapt Appium te...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-console issue #22: Fix for : https://issues.apache.org/jira/b...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-console/pull/22 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-console pull request #22: Fix for : https://issues.apache.org...

GitHub user sruthakeerthikotla opened a pull request: https://github.com/apache/cordova-plugin-console/pull/22 Fix for : https://issues.apache.org/jira/browse/CB-12168 CB-12168: (ios) Fix to update to ios's new logging function. You can merge this pull request into a Git repository

[GitHub] cordova-plugin-camera issue #269: CB-12764: (android) Adapt Appium tests for...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/269 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-camera pull request #269: CB-12764: (android) Adapt Appium te...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/269 CB-12764: (android) Adapt Appium tests for Android 7 ### Platforms affected Android ### What does this PR do? https://issues.apache.org/jira/browse/CB-12764

[GitHub] cordova-plugin-camera issue #268: CB-12873: Add customization options for ca...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/268 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-camera issue #268: CB-12873: Add customization options for ca...

Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/268 cordova-qa: rerun tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature