[GitHub] cordova-docs pull request #708: Win8 removed + bb10 & ubuntu depreciation in...

2017-06-12 Thread awebdeveloper
Github user awebdeveloper commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/708#discussion_r121575668 --- Diff: www/docs/en/7.x/guide/support/index.md --- @@ -38,10 +38,9 @@ CLI's shorthand names. android -

Nightly build #373 for cordova has failed

2017-06-12 Thread Apache Jenkins Server
Nightly build #373 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/373/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/373/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-docs pull request #711: CB-12904 - Document in config....

2017-06-12 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/711 CB-12904 - Document in config.xml ### Platforms affected All ### What does this PR do? Document the feature in config.xml. The feature has been there for a while

[GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...

2017-06-12 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-lib/pull/562 Removing lazy load, platform command refactor, start of finer-grained unit tests. ### Platforms affected all / node ? ### What does this PR do? A lot! 1.

[GitHub] cordova-docs issue #697: Update index.md

2017-06-12 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/697 Should be both in the 7.x and dev trees as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request #710: Added instruction to install Ruby Gems local...

2017-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/710 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs issue #710: Added instruction to install Ruby Gems locally

2017-06-12 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/710 I'll update `gem install bundle` typo in this PR. I think we are good to go now. @filmaj yeah let's do that in another PR. Also I found that `node_modules/.bin/gulp serve` does not

[GitHub] cordova-docs pull request #710: Added instruction to install Ruby Gems local...

2017-06-12 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/710#discussion_r121526214 --- Diff: README.md --- @@ -101,9 +101,9 @@ Verify the installation by running: Once Ruby and JavaScript are installed, install Ruby dependencies

[GitHub] cordova-docs issue #710: Added instruction to install Ruby Gems locally

2017-06-12 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/710 Note that on my Windows 10 VM, following the exact Ruby setup instructions in here forced me to eventually update my RubyGems to a newer version - I followed

Re: [Android] Let's drop support for Jellybean

2017-06-12 Thread Simon MacDonald
Created an issue to track this https://issues.apache.org/jira/browse/CB-12914 Simon Mac Donald http://simonmacdonald.com On Mon, Jun 12, 2017 at 4:12 PM, Simon MacDonald wrote: > Right so we still with dropping JB for now. Support API levels 19-26 for >

[GitHub] cordova-docs pull request #710: Added instruction to install Ruby Gems local...

2017-06-12 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/710#discussion_r121519778 --- Diff: README.md --- @@ -101,9 +101,9 @@ Verify the installation by running: Once Ruby and JavaScript are installed, install Ruby dependencies

[GitHub] cordova-docs pull request #710: Added instruction to install Ruby Gems local...

2017-06-12 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/710#discussion_r121519526 --- Diff: README.md --- @@ -101,9 +101,9 @@ Verify the installation by running: Once Ruby and JavaScript are installed, install Ruby dependencies

[GitHub] cordova-docs pull request #710: Added instruction to install Ruby Gems local...

2017-06-12 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/710#discussion_r121519204 --- Diff: README.md --- @@ -101,9 +101,9 @@ Verify the installation by running: Once Ruby and JavaScript are installed, install Ruby dependencies

[GitHub] cordova-docs issue #697: Update index.md

2017-06-12 Thread piotrowski
Github user piotrowski commented on the issue: https://github.com/apache/cordova-docs/pull/697 @shazron Yes, great improvement on the current text. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: [Android] Let's drop support for Jellybean

2017-06-12 Thread Simon MacDonald
Right so we still with dropping JB for now. Support API levels 19-26 for Cordova-Android 7.0.0 Simon Mac Donald http://simonmacdonald.com On Mon, Jun 12, 2017 at 3:58 PM, Joe Bowser wrote: > The problem is that Kitkat is still 18.1% of the current devices out there, > which

[GitHub] cordova-docs issue #697: Update index.md

2017-06-12 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/697 Wouldn't this need to be merged into the 7.x content as well, to preserve moving forward? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request #710: Added instruction to install Ruby Gems local...

2017-06-12 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/710#discussion_r121513970 --- Diff: README.md --- @@ -101,9 +101,9 @@ Verify the installation by running: Once Ruby and JavaScript are installed, install Ruby dependencies

[GitHub] cordova-docs pull request #710: Added instruction to install Ruby Gems local...

2017-06-12 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/710#discussion_r121513335 --- Diff: README.md --- @@ -101,9 +101,9 @@ Verify the installation by running: Once Ruby and JavaScript are installed, install Ruby dependencies

[GitHub] cordova-docs pull request #708: Win8 removed + bb10 & ubuntu depreciation in...

2017-06-12 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/708#discussion_r121511805 --- Diff: www/docs/en/7.x/guide/support/index.md --- @@ -38,10 +38,9 @@ CLI's shorthand names. android -

[GitHub] cordova-docs pull request #708: Win8 removed + bb10 & ubuntu depreciation in...

2017-06-12 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/708#discussion_r121511716 --- Diff: www/docs/en/7.x/guide/support/index.md --- @@ -38,10 +38,9 @@ CLI's shorthand names. android -

[GitHub] cordova-docs issue #697: Update index.md

2017-06-12 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/697 @piotrowski I don't speak German. Is this good to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: [Android] Let's drop support for Jellybean

2017-06-12 Thread Joe Bowser
The problem is that Kitkat is still 18.1% of the current devices out there, which includes all the failed experiment devices that Google had released. That would be dropping a lot of things by the wayside. On Mon, Jun 12, 2017 at 12:48 PM, Simon MacDonald wrote: > +1

[GitHub] cordova-docs pull request #705: CB-12762 : point package.json repo items to ...

2017-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #707: Missing bracket

2017-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [Android] Let's drop support for Jellybean

2017-06-12 Thread Simon MacDonald
+1 from me as well. If we can move to Android 5.0 (API 21) and later that would be a huge win as all of those devices can use the Android System WebView which gives us a more consistent target. Simon Mac Donald

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-12 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 I see. But I figured that why we test on the next iOS before it comes out. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-12 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 We appreciate the PR, but ultimately we can't accept it. Please see this thread for a similar PR that uses undocumented/private API:

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-12 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 @shazron @stevengill any thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request #710: Added instruction to install Ruby Gems local...

2017-06-12 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/710 Added instruction to install Ruby Gems locally ### What does this PR do? Modified instruction to install the required Ruby Gems locally in a subfolder of the repo. Installing jekyll

Re: [Android] Let's drop support for Jellybean

2017-06-12 Thread Kerri Shotts
+1 ~ Kerri > On Jun 12, 2017, at 13:22, Trevor Brindle wrote: > > +1 makes sense to me. Ensuring testability and not making heroic measures > to continue support an old OS is a good reason to me. > > TrevorBrindle > Lead Hybrid Mobile Engineer > SHOP•COM powered by

Re: [Android] Let's drop support for Jellybean

2017-06-12 Thread Trevor Brindle
+1 makes sense to me. Ensuring testability and not making heroic measures to continue support an old OS is a good reason to me. TrevorBrindle Lead Hybrid Mobile Engineer SHOP•COM powered by marketamerica C: (407) 450-8700 On Mon, Jun 12, 2017 at 1:23 PM, Shazron wrote: > +1

Re: [Android] Let's drop support for Jellybean

2017-06-12 Thread Shazron
+1 On Mon, Jun 12, 2017 at 8:38 AM, julio cesar sanchez wrote: > Currently, Jellybean is 8.8%, so it's bellow the 10%. We can drop it. > > > 2017-06-12 17:22 GMT+02:00 Filip Maj : > > > Reviving this thread! Sorry for the late reply. > > > > Regarding

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-06-12 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

Re: [Android] Let's drop support for Jellybean

2017-06-12 Thread julio cesar sanchez
Currently, Jellybean is 8.8%, so it's bellow the 10%. We can drop it. 2017-06-12 17:22 GMT+02:00 Filip Maj : > Reviving this thread! Sorry for the late reply. > > Regarding Trevor's question: > > Just for consideration however, what do we actually gain by dropping > >

Re: [Android] Let's drop support for Jellybean

2017-06-12 Thread Filip Maj
Reviving this thread! Sorry for the late reply. Regarding Trevor's question: > Just for consideration however, what do we actually gain by dropping > official support? Are there compat libraries or tests we can drop after > this? >From a testing/CI perspective, it becomes much more tenable to