[GitHub] cordova-cli pull request #283: CB-12901 Cli Refactor

GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-cli/pull/283 CB-12901 Cli Refactor ### What does this PR do? - fixed failing tests. - adjusted tests to call cordova instead of cordova.raw - added tests to compare cordova.raw and

Nightly build #380 for cordova has failed

Nightly build #380 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/380/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/380/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib pull request #564: removed some circular deps, got some tests pa...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #564: removed some circular deps, got some tests passing

Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/564 Went ahead and merged this one in. Will chip away at remaining e2e test failures from here. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/386 Ahh! That's it! Very nice. Works flawlessy on my end!  --- If your

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

Github user macdonst commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r122787134 --- Diff: cordova-lib/cordova.js --- @@ -1486,6 +1486,26 @@ module.exports = { bootstrap: function() { +var cache =

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

Github user macdonst commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r122782989 --- Diff: bin/template/cordova/Api.js --- @@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

Github user macdonst commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r122785379 --- Diff: bin/template/www/cordova-sw.js --- @@ -0,0 +1,23 @@ + +// Note, these will be updated automatically at build time +var

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

Github user macdonst commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r122786300 --- Diff: bin/template/www/manifest.json --- @@ -0,0 +1,21 @@ +{ + "name": "My App", + "short_name":"My Ap", + "description":

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

Github user macdonst commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r122780778 --- Diff: bin/template/cordova/Api.js --- @@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

Github user macdonst commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r122783962 --- Diff: bin/template/cordova/Api.js --- @@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

Github user macdonst commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r122786410 --- Diff: cordova-js-src/confighelper.js --- @@ -61,14 +61,9 @@ function readConfig(success, error) { } }; -if

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

Github user macdonst commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r122782108 --- Diff: bin/template/cordova/Api.js --- @@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {

[GitHub] cordova-lib pull request #564: removed some circular deps, got some tests pa...

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/564 removed some circular deps, got some tests passing ### Platforms affected ### What does this PR do? ### What testing has been done on this change?

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

Github user audreyso commented on the issue: https://github.com/apache/cordova-android/pull/386 Ohh thank you for that clarification @filmaj . So I did the following: 1. Left the project root level eslint file to keep--> root: true 2. Removed eslint config files from spec/e2e

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 Hmm. Is JIRA down? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/386 I think one more tweak would be good: So by putting `root:true` into the spec/**/ directories' eslintrc files, when eslint searches up the directory tree to find an eslintrc file,

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

Github user audreyso commented on the issue: https://github.com/apache/cordova-android/pull/386 Thanks! @filmaj That makes sense and seems easier than having to add in /*eslint-env: jasmine*/ in every file. I made some changes and added .eslint configs where they are needed. Let me

[GitHub] cordova-plugin-wkwebview-engine pull request #37: CB-10376, CB-12037: (ios) ...

Github user ccorcos closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 @cjpearson really cool. I'll do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: [DRAFT] Apache Cordova Board Report - June 2017

Thank you! Submitting now. On Mon, Jun 19, 2017 at 7:40 AM, Filip Maj wrote: > Just one nit: > > "have request Gitbox access" --> "have requested Gitbox access" > > LGTM otherwise! > > On Sun, Jun 18, 2017 at 3:40 PM, wrote: > > LGTM. > > > > Sent

[GitHub] cordova-plugin-camera issue #271: Incorrect "JIRA issue tracker" link in Rea...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/271 Cordova CI Build has one or more failures. **Commit** -

Re: [DRAFT] Apache Cordova Board Report - June 2017

Just one nit: "have request Gitbox access" --> "have requested Gitbox access" LGTM otherwise! On Sun, Jun 18, 2017 at 3:40 PM, wrote: > LGTM. > > Sent from my phone. > > ___ > Kerri Shotts > photoKandy Studios, LLC > > On the Web:

[GitHub] cordova-plugin-camera issue #271: Incorrect "JIRA issue tracker" link in Rea...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/271 Thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-camera pull request #271: Incorrect "JIRA issue tracker" link...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media issue #138: CB-12671 iOS: Fix auto-test with stopping m...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/138 @matrosov-nikita with your new committership, feel free to merge this in yourself :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-camera pull request #271: Incorrect "JIRA issue tracker" link...

GitHub user jacquesdev opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/271 Incorrect "JIRA issue tracker" link in Readme Fixed incorrect "JIRA issue tracker" link in Readme You can merge this pull request into a Git repository by running: $ git pull

Re: Apache cordova screen size

Hi. This mail list is to talk about the Cordova project development, not for support while using it. There are plenty of ways of getting the screen size, javascript provides the screen object, window object also provides a innerHeight and innerWidth properties, also document.documentElement

RE: Nightly build #379 for cordova has failed

Someone has added coho to the list of published repos: https://builds.apache.org/job/cordova-nightly/jobConfigHistory/showDiffFiles?timestamp1=2017-05-31_05-15-50=2017-06-08_00-38-59 For some reason, it tries to publish "dev" version and not "nightly". Anyone already looking into it? I'm going to

Apache cordova screen size

Hello. Is there a plug-in or a way to get the device's screen width and height? Thank you in advance for your response, Antonis Katsikadamos | Senior software engineer --- NEW MEDIA

[GitHub] cordova-plugin-inappbrowser pull request #210: CB-12367: Modernize styling o...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/210#discussion_r122649041 --- Diff: src/ios/CDVInAppBrowser.m --- @@ -539,115 +545,212 @@ -(void)dealloc { - (void)createViews { // We create

[GitHub] cordova-plugin-inappbrowser pull request #210: CB-12367: Modernize styling o...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/210#discussion_r122648718 --- Diff: src/ios/CDVInAppBrowser.m --- @@ -539,115 +545,212 @@ -(void)dealloc { - (void)createViews { // We create

[GitHub] cordova-plugin-inappbrowser issue #210: CB-12367: Modernize styling of iOS I...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/210 Thank you for the PR. Since this is only adding a feature (tintcolor), and changing behaviour of a feature (toolbarstyle), the version should be bumped a minor to 1.8.0. (we

[GitHub] cordova-plugin-file issue #207: CB-12930: (windows) Fix getDirectory trailin...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/207 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/207/commits/6555f2a9e2bbefbd464487b9aafbe5af5093a053)