[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123426288 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

Nightly build #405 for cordova has failed

Nightly build #405 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/405/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/405/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123381062 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123380130 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'),

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123368145 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123367811 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/566#discussion_r123366796 --- Diff: src/cordova/plugin/util.js --- @@ -0,0 +1,37 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123366636 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123366148 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/566#discussion_r123359407 --- Diff: src/cordova/plugin_parser.js --- @@ -18,12 +18,14 @@ */ var xml = require('cordova-common').xmlHelpers; +var events =

[GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/566#discussion_r123357002 --- Diff: src/cordova/plugin/util.js --- @@ -0,0 +1,37 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123365358 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123364883 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123363271 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123362807 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123362714 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123362534 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123361446 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123356892 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357803 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123359362 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123356985 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123358080 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357310 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357886 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357728 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123356764 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123353714 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123352862 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123353941 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123358028 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357124 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123353162 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123350987 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123353085 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123359059 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123357065 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123352070 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123353273 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123358221 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123354184 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123354297 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123359196 --- Diff: spec-cordova/prepare.spec.js --- @@ -17,175 +17,265 @@ under the License. */ -var shell = require('shelljs'), -

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/567 CB-12361: Added unit tests for prepare.js ### What does this PR do? Add unit tests for prepare.js in prepare.spec.js. ### What testing has been done on this

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 lol. would you mind making a ticket for this? I can't seem to get it to load! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib issue #566: Refactor Plugin Command, test improvements, passing ...

Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/566 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/566?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@a7f55ec`). [Click here to learn what

Re: Cloudapp CI is down, builds moving to Travis

I know Sauce Connect pretty well from my days working at Sauce Labs :) Not sure if appropriate for the dev list - if not, message me on slack and I'd be happy to help any way I can. On Wed, Jun 21, 2017 at 11:34 AM, wrote: > Yeah, forgot to give a link to JIRA issue: >

[GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...

Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/566#discussion_r123302742 --- Diff: src/cordova/plugin/search.js --- @@ -0,0 +1,41 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

RE: Cloudapp CI is down, builds moving to Travis

Yeah, forgot to give a link to JIRA issue: https://issues.apache.org/jira/browse/CB-12935 For now, I'm wrestling with Sauce Connect and jwt plugins for Travis in an attempt to make secure variables work for PRs from external forks. Besides that, there is nothing holding us from running these

[GitHub] cordova-lib pull request #566: Plugin specs

GitHub user filmaj opened a pull request: https://github.com/apache/cordova-lib/pull/566 Plugin specs *WARNING*: Work in progress! Please review and leave comments. ### What does this PR do? A lot! The main purposes of this PR are: 1. Address removing lazy

[GitHub] cordova-lib issue #565: Platform's spec is ignored in config.xml if package....

Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/565 +1 to creating a new issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-lib issue #565: Platform's spec is ignored in config.xml if package....

Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-lib/pull/565 @filmaj, thanks for the information. I'm looking forward to getting back working CI. Also, I think that I should create a new issue for this bug. --- If your project is set up for

[GitHub] cordova-ios pull request #321: CB-12937 - (iOS) added new method handleOpenU...

Github user Giorgioshooter commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/321#discussion_r123258853 --- Diff: CordovaLib/Classes/Public/CDVAppDelegate.m --- @@ -79,8 +79,16 @@ - (BOOL)application:(UIApplication*)application openURL:(NSURL*)url

[GitHub] cordova-plugin-inappbrowser issue #165: Enable thirdparty cookies on >=Andro...

Github user ernsheong commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/165 I have a question to ask: 1. Open Cordova app 2. Open InAppBrowser, login into user management system, get cookies (C) 3. Close InAppBrowser, go back to Cordova app

[GitHub] cordova-plugin-inappbrowser issue #165: Enable thirdparty cookies on >=Andro...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/165 I believe the default on iOS is to accept all cookies, based on the description from the docs:

[GitHub] cordova-ios pull request #321: CB-12937 - (iOS) added new method handleOpenU...

Github user pbudzinsky commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/321#discussion_r123253143 --- Diff: CordovaLib/Classes/Public/CDVAppDelegate.m --- @@ -79,8 +79,16 @@ - (BOOL)application:(UIApplication*)application openURL:(NSURL*)url

[GitHub] cordova-lib issue #565: Platform's spec is ignored in config.xml if package....

Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/565 Yeah, this is a really important change. One thing to note: all the tests in cordova-lib are failing right now because @stevengill, @audreyso and I are working on changing the tests from

Re: Cloudapp CI is down, builds moving to Travis

Any JIRA issues we should look at to track progress? Alex, what can we do to assist? seems like a lot of work - let us know! On Wed, Jun 21, 2017 at 5:39 AM, wrote: > Our Plugins testing CI (Jenkins) is officially dead now. > We're migrating all the jobs to Travis and

[GitHub] cordova-plugin-file issue #208: Update README.md

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file/pull/208 Thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-file pull request #208: Update README.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android issue #388: Suppress line 'Picked up _JAVA_OPTIONS' from std...

Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/388 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/388?src=pr=h1) Report > Merging [#388](https://codecov.io/gh/apache/cordova-android/pull/388?src=pr=desc) into

[GitHub] cordova-android pull request #388: Suppress line 'Picked up _JAVA_OPTIONS' f...

GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-android/pull/388 Suppress line 'Picked up _JAVA_OPTIONS' from stderr ### Platforms affected android ### What does this PR do? If `_JAVA_OPTIONS` variable is defined,

[GitHub] cordova-lib pull request #565: Platform's spec is ignored in config.xml if p...

GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-lib/pull/565 Platform's spec is ignored in config.xml if package.json doesn't contain dependency for platform ### Platforms affected all ### What does this PR do? Steps

[GitHub] cordova-plugin-inappbrowser issue #165: Enable thirdparty cookies on >=Andro...

Github user ernsheong commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/165 Merge, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Cloudapp CI is down, builds moving to Travis

Our Plugins testing CI (Jenkins) is officially dead now. We're migrating all the jobs to Travis and AppVeyor, but for the time being, all PRs to the plugin repos are not being tested. I'm working to enable Travis and AppVeyor builds as soon as possible, but there are some unexpected hassle with

[GitHub] cordova-plugin-inappbrowser pull request #223: CB-12941: update typings

GitHub user timbru31 opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/223 CB-12941: update typings ### Platforms affected n/a - development via TypeScript ### What does this PR do? Updates the typings to match the latest published

[GitHub] cordova-plugin-file pull request #208: Update README.md

GitHub user GROL opened a pull request: https://github.com/apache/cordova-plugin-file/pull/208 Update README.md Missing character "o" in the constant "externalCacheDirect**o**ry" . The developer can copy this constant from this documentation and get error when executing

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 @ccorcos seems to be really flaky these past few days. Even the status graph has given up: http://status.apache.org/ I eventually could get it to load --- If your project is

[GitHub] cordova-plugin-battery-status pull request #54: CB-12935 Run paramedic build...

Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-battery-status issue #54: CB-12935 Run paramedic builds on Tr...

Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/54 Encrypted vars are disabled for PR builds. We'll have to find another way around (make them unencrypted?) --- If your project is set up for it, you can reply to this email

RE: Nightly build #379 for cordova has failed

The error is possibly caused by workspace being preserved between builds. I think I've fixed that. Let's see if next build succeeds. -Original Message- From: alsoro...@apache.org [mailto:alsoro...@apache.org] Sent: Monday, June 19, 2017 12:19 PM To: dev@cordova.apache.org Subject: RE: