RE: Proposal: Change Android Project Directory Structure to Android Studio style

2016-05-17 Thread Richard Knoll
This > actually has a hook that downloads and places the source code based on > the current directory structure. > > On 5/17/16, 2:53 PM, "Richard Knoll" <rikn...@microsoft.com> wrote: > > >We have a lot of plugin.xml elements that depend on the old file &g

RE: Proposal: Change Android Project Directory Structure to Android Studio style

2016-05-17 Thread Richard Knoll
We have a lot of plugin.xml elements that depend on the old file structure. Tags like config-file, source-file, resource-file, etc. all have target elements that take arbitrary paths to project files. Looking at the new project structure, it seems like most of the relevant folders have moved

RE: [DISCUSS] Cordova tools release

2016-05-17 Thread Richard Knoll
Hey everyone, This current tools release has been causing a lot of trouble with our various CI setups. We recently resolved the cordova-fetch issue that was breaking buildbot, but we are still facing build failures because cordova-common hasn't been published [1]. The Travis build for

[CI] Status for 05/16/2016

2016-05-16 Thread Richard Knoll
Hey all, No status for the Buildbot CI this week! When cordova-fetch was merged into the cordova-lib repo it required us to update the buildbot configuration files for the CI to pass. Updating those files requires some manual intervention from Infra to sync the changes with the buildbot

RE: Buildbot: buildslave cordova-osx-slave was lost

2016-04-29 Thread Richard Knoll
I need to move the machines, so be advised that both build machines are going to go offline again for a bit. Thanks, Richard -Original Message- From: Richard Knoll [mailto:rikn...@microsoft.com] Sent: Friday, April 29, 2016 10:06 AM To: dev@cordova.apache.org Subject: RE: Buildbot

RE: Buildbot: buildslave cordova-osx-slave was lost

2016-04-29 Thread Richard Knoll
Sorry everyone! The build machines were accidentally unplugged this morning, but they're back up now. Thanks, Richard -Original Message- From: build...@apache.org [mailto:build...@apache.org] Sent: Friday, April 29, 2016 8:27 AM To: dev@cordova.apache.org Subject: Buildbot: buildslave

[CI] Status for 04/11/16

2016-04-11 Thread Richard Knoll
Hey everyone, Here is the CI status for last week. Build Status (# of test failures): 0 - Android on Windows 0 - Android on OS X ? - iOS (CI failing, see CB-10898) 0 - WP 8.1 0 - Windows JIRAs that need attention: - CB-10475: iOS Contacts Permission Modal causes test failure - CB-10898: Invalid

RE: [DISCUSS] Core Plugins and Android API 23

2016-04-04 Thread Richard Knoll
=Tx2MCYz9NAhmUMBCaa6fPoOLPb8R%2be5%2f6hCvsHapVaI%3d On Mon, Apr 4, 2016 at 1:32 PM, Joe Bowser <bows...@gmail.com> wrote: > Does this require a major version change? > > On Mon, Apr 4, 2016, 10:30 AM Richard Knoll <rikn...@microsoft.com> wrote: > > > Sorry for being late to commen

RE: [DISCUSS] Core Plugins and Android API 23

2016-04-04 Thread Richard Knoll
on my camera fork: > > > > > > > > https://github.com/macdonst > > > > > /cordova-plugin-camera/commit/58b72cb5c3109481df9f337ad97607858681b37e > > > > > > > > Can we move to this approach now? Then once the downstream > > >

RE: Adding Examples for Plugins in the ReadMe

2016-03-31 Thread Richard Knoll
Hey everyone, Norm redid the PR to temporarily remove the links to the full sample apps until we figure out where to put them [1]. I'm going to go ahead and merge the rest of his changes unless anyone objects. For those interested, he's also done some samples for inAppBrowser [2]. Thanks,

RE: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

2016-03-24 Thread Richard Knoll
lybean Devices. I had to dig up a Moto RAZR running 4.0.3 to see this bug happen. On Thu, Mar 24, 2016 at 10:08 AM, Richard Knoll <rikn...@microsoft.com> wrote: > Both of the Android CI builders run KitKat. We should probably > document that somewhere or have medic print it out; I'

RE: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

2016-03-24 Thread Richard Knoll
Both of the Android CI builders run KitKat. We should probably document that somewhere or have medic print it out; I'll look into doing that. Thanks, Richard -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Thursday, March 24, 2016 8:43 AM To: dev

Blog post for plugin version selection

2016-03-21 Thread Richard Knoll
Hey everyone, I have written a blog post detailing the new plugin version selection changes in the cordova-lib release [1]. The purpose is to raise awareness of the feature and hopefully encourage adoption of the API by third-party plugins. Please take a look and let me know if you have any

RE: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

2016-03-21 Thread Richard Knoll
I agree that config-file is the way to go. After an offline discussion with Nikhil, Parashu, and Jason, one question that came up was whether all of this native config stuff belongs in config.xml or should be separated out. One idea would be to define separate files for each configuration file

RE: [DISCUSS] Plugins release

2016-03-09 Thread Richard Knoll
I just found a critical camera bug[1], so we should hold off on that one. I think the fix is pretty simple, so I'll try and get a PR for it today. Thanks, Richard [1]: https://issues.apache.org/jira/browse/CB-10825 -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com]

CI Build Status 3-7-2015

2016-03-07 Thread Richard Knoll
Hey everyone, Status of the CI was pretty good last week! We are seeing occasional build failures in the Android builder on Windows that are the result of the Android emulator failing to start up correctly, but those failures are not common and the Android OS X builder is working consistently.

RE: Test Plugin on npm

2016-03-04 Thread Richard Knoll
=9OtPzgIxlszlAMjys7rKyzySnrsjrsIupkkxNdilRrs%3d In short, what others have said is correct. Test packages do not require a vote as long as they follow the (bolded) guidelines in the link I cited above. On Fri, Mar 4, 2016 at 10:30 AM, Richard Knoll <rikn...@microsoft.com> wrote: > Hey all, > > I

Test Plugin on npm

2016-03-04 Thread Richard Knoll
Hey all, I'd like to have some better end-to-end tests for "cordova plugin add" in cordova-lib, so I wanted to publish a test plugin to npm. The plugin itself will be empty besides a plugin.xml, I just need it to exist and have engine information I can test against. Do we have an official npm

Plugin Version Selection for Cordova Lib

2016-03-01 Thread Richard Knoll
Hey everyone, The new plugin version selection implementation for cordova-lib has been in PR [1] for a while and I plan on merging it tomorrow if nobody objects. It is a pretty big update to the behavior of "cordova plugin add", so I wanted to give a heads up and make sure that people are

RE: Buildbot: buildslave cordova-osx-slave was lost

2016-02-16 Thread Richard Knoll
I took this down to debug some changes I made to medic-run for the Android CI. I'll bring it back up in a bit. Thanks, Richard -Original Message- From: build...@apache.org [mailto:build...@apache.org] Sent: Tuesday, February 16, 2016 5:42 PM To: dev@cordova.apache.org Subject:

RE: [DISCUSS] Core Plugins and Android API 23

2016-02-05 Thread Richard Knoll
ithub.com/apache/cordova-plugin-inappbrowser/pull/135 > >> >> > > >> >> > On Thu, Jan 14, 2016 at 2:02 PM, Carlos Santana < > csantan...@gmail.com <javascript:;> > >> > > >> >> > wrote: > >> >> > > >> &

RE: Android and iOS bug release

2016-02-04 Thread Richard Knoll
I have a PR open in cordova-android that should probably be merged first. It addresses a bug in the save/restore API that a few people are hitting. I still have some updates/testing to do but I hope to merge it in soon. Would love some feedback if anyone has a chance to review. The PR is here:

RE: [REVIEW] CB-10472 NullPointerException: org.apache.cordova.PluginManager.onSaveInstanceState

2016-01-28 Thread Richard Knoll
I also think we should add tests for this. Carlos, do you have a setup for this bug that you could share? It would be nice to have mobilespec tests for save/restore in general, but that ends up being sort of tricky because it requires enabling the "Don't Keep Activities" dev setting. Thanks,

RE: [DISCUSS] Android@5.1.0

2016-01-21 Thread Richard Knoll
When this release goes out, I think it's a good idea for us to point to the new Android Lifecycle Guide I added to the docs in the blog post. http://cordova.apache.org/docs/en/dev/guide/platforms/android/lifecycle.html I also have a PR open that improves it here:

[DISCUSS] Plugin version fetching improvements

2016-01-14 Thread Richard Knoll
Hey all, I wanted to draw some attention to the proposal I have up on cordova-discuss for improving the way we fetch plugins from npm. The aim is to provide a robust way for plugins to specify their project requirements so that the CLI can fetch the correct version of a plugin based on the

RE: [DISCUSS] Core Plugins and Android API 23

2016-01-13 Thread Richard Knoll
Hey all, This change has been merged into the file, camera, geolocation, and contacts plugins (media did not actually require any change). I was able to build and run mobilespec on cordova-android 4.0.0 and cordova-android's master. We should probably push for a plugins release soon, since

[DISCUSS] Core Plugins and Android API 23

2016-01-06 Thread Richard Knoll
Hey all, As has been very thoroughly discussed at this point, the cordova-android 5.0.0 update included breaking changes for plugins in response to the new permission model that Android Marshmallow introduced. Unfortunately, this means that our plugins that took advantage of the new permission

Contributor and Issue guidelines

2015-11-13 Thread Richard Knoll
Hey all, I have submitted a PR to the docs repo with some updated contributor guidelines and instructions for submitting issues to JIRA. They are mostly taken from the old wiki pages, but I updated the information based on Nikhil's JIRA triage

RE: Native vs. File URIs

2015-11-13 Thread Richard Knoll
-Original Message- From: Richard Knoll [mailto:rikn...@microsoft.com] Sent: Thursday, November 12, 2015 9:06 PM To: dev@cordova.apache.org Subject: RE: Native vs. File URIs Okay, so does that mean something like this: 1. FILE_URI always returns a file: // URI. If the URI we get from the image

RE: Native vs. File URIs

2015-11-12 Thread Richard Knoll
Subject: Re: Native vs. File URIs For the Camera plugin, FILE_URI is a file:// URI and existed even before we created the file plugin's cdvfile:// cross-platform URI. We didn't change it for backwards compat reasons. On Mon, Nov 9, 2015 at 1:52 PM, Richard Knoll <rikn...@microsoft.com> wrote:

RE: Native vs. File URIs

2015-11-09 Thread Richard Knoll
.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7ca343f6e3176f41d7d4a808d2e93e3956%7c72f988bf86f141af91ab2d7cd011db47%7c1=HJ0cDsXqCIWDzlpiv0DpZLzHMKAWAHGsn7cL%2bamJpXg%3d On Mon, Nov 9, 2015 at 9:25 AM, Richard Knoll <rikn...@microsoft.com> wrote: > Oh

RE: [DISCUSS] Plugins release

2015-11-06 Thread Richard Knoll
I plan on merging in https://github.com/apache/cordova-plugin-camera/pull/135 for the camera plugin if there are no objections. Thanks, Richard -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Friday, November 6, 2015 11:38 AM To: dev@cordova.apache.org

Native vs. File URIs

2015-11-06 Thread Richard Knoll
Hey all, I was wondering if anybody could clarify for me what the difference between FILE_URI and NATIVE_URI is in the camera plugin. Do we have a clear definition of either? I assumed that FILE_URI would refer to an actual path on the device (i.e. a URI using the "file" scheme) but the docs

RE: [Android] Possible solution to Camera/Media

2015-10-29 Thread Richard Knoll
Hey everyone, I just wanted to update this thread with a link to the PR I submitted as a proposed solution to this issue. Just making sure that people are aware that there is some discussion taking place in Github about this problem: https://github.com/apache/cordova-android/pull/236 Thanks,

RE: [GitHub] cordova-android pull request: API for saving/restoring plugin and ...

2015-10-28 Thread Richard Knoll
That's a pretty good point. When I was working on it, I figured that since this was a platform specific issue, mimicking the platform's API (Android's onSaveInstanceState) was the way to go. Expanding CoreAndroid's secret APIs is probably worth avoiding though. Thanks, Richard -Original

[DISCUSS] Camera plugin considerations in Android

2015-10-16 Thread Richard Knoll
Hey all, Over the past week or so I have been conducting a review of the issues for the camera plugin in JIRA and have noticed two big areas of confusion that seem to plague users in Android. I want to start a DISCUSS thread because both of these involve larger decisions to be made. 1.

Introduction

2015-10-02 Thread Richard Knoll
Hello Everyone, My name is Richard Knoll and I am just now realizing that I never sent an introduction of myself to this list. I am a software developer at Microsoft and have been one of the contributors to the website redesign for the past several weeks. I also have some experience