Github user cjpearson closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/275
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user cjpearson reopened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/275
CB-12593: (android) Fix potential FileProvider conflicts
### Platforms affected
Android
### What does this PR do?
Allows more than one plugin to use
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/274
Thanks, Joe. I messed up the commit and issue linking.
https://github.com/apache/cordova-plugin-camera/pull/275 has the same change.
---
If your project is set up for it, you can
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/275
CB-12593: (android) Fix potential FileProvider conflicts
### Platforms affected
Android
### What does this PR do?
Allows more than one plugin to use
Github user cjpearson closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
I think https://github.com/apache/cordova-plugin-camera/pull/274 may be a
better solution. Closing.
---
If your project is set up for it, you can reply to this email and have your
Github user cjpearson closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/274
CB-12959: (android) Fix potential FileProvider conflicts
### Platforms affected
Android
### What does this PR do?
Allows more than one plugin to use
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37
Since this plugin just swizzles the WKWebView class, you can make it
separate plugin instead of a fork. It might make maintenance easier. Look in
https://github.com/apache
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-docs/pull/706
CB-12880: Remove Taco.tools from the homepage
### Platforms affected
All
### What does this PR do?
Removes the link to Taco.tools
### What testing has
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
@infil00p, I'm not very familiar with the internals of cordova-android.
What do you mean by a tooling issue?
---
If your project is set up for it, you can reply to this email
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/54
CB-12751: (ios) Fix connection type when airplane mode is on
### Platforms affected
iOS
### What does this PR do?
Reachability does
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
Thanks for the feedback. I agree that it should go under the cordova
umbrella somewhere. I just wanted to show a working example in the PR.
We have an internal plugin in our
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
@stevengill could you take a look at this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/257
CB-12953: (android) move management of FileProvider out of the camera plugin
### Platforms affected
Android
### What does this PR do
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30
I think something like
[this](https://gist.github.com/cjpearson/ae2a1c12e4737549721ec3c04e617789)
should work. You can add the files to your Xcode project or create
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30
@rubenstolk, you could try creating a plugin that swizzles
`createConfigurationFromSettings` and adds your changes. Then anybody who wants
this fix can just install your
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90223157
--- Diff: src/ios/CDVWKWebViewEngine.m ---
@@ -123,6 +123,32 @@ - (void)pluginInitialize
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-ios/pull/277
It looks like the tests were failing because of the spy on writeFileSync.
I've added a fix and pulled them into this PR. I also tried to add a test to
verify the final .app is correct, but I
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-ios/pull/277
Regarding the tests, based on what I'm seeing they should not be failing.
The settings are properly added to the project, but they are ignored in the
final product.
---
If your project
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-ios/pull/277
It seems like the xcconfig settings override the buildFlag flag. When I run
this command on a starter cordova-ios 4.3.0 project, the MinimumOSVersion in
the App's Info.plist is still iOS 8.0
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-ios/pull/277
CB-11243: Fix target-device and deployment-target preferences
### Platforms affected
iOS
### What does this PR do?
Fixes target-device and deployment-target preferences
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23
CB-11997: Add crash recovery for iOS 8
### Platforms affected
iOS
### What does this PR do?
Reloads the WebView when it crashes. This behavior
Github user cjpearson closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugins/pull/27
CB-11644: (ios) Set cdvtoken cookie path to root
### Platforms affected
iOS
### What does this PR do?
Set the cdvToken cookie's path to root, so it applies to all requests
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugins/pull/26
CB-11643: return after sending error
### Platforms affected
iOS
### What does this PR do?
After an error is returned, we should return and not process
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/12
CB-10142: Allow opening WebSQL databases in WKWebView
### Platforms affected
iOS
### What does this PR do?
Allows WebSql databases
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-lib/pull/260
Thanks, @shazron. I've rebased this pr and opened a new one here
https://github.com/apache/cordova-ios/pull/233
---
If your project is set up for it, you can reply to this email and have
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-ios/pull/233
CB-9371, CB-9703: Fix how prepare handles orientation on ios
Relates to https://github.com/apache/cordova-lib/pull/260
This changes the behavior of the default orientation preference
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/94
@shazron, just did a rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-lib/pull/260
@shazron, could you please take a look at this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user cjpearson reopened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/94
CB-3360: Set custom inappbrowser user agent for ios
This uses the same OverrideUserAgent and AppendUserAgent properties as the
pull requests for cordova-ios and cordova
Github user cjpearson closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154190076
https://issues.apache.org/jira/browse/CB-9965
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154181249
@infil00p, could you take a look at this PR? I'm running into this issue
when I try to open a file that was taken from the camera plugin on Android
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/142
Add handling for SecurityException
Instead of returning UNKNOWN_ERR, return SECURITY_ERR when a
SecurityException is caught.
You can merge this pull request into a Git repository
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122255716
I think you might still want to check in user defaults first, so the uuid
value doesn't change for users who already had the app installed
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-lib/pull/260
CB-9371: Don't delete orientation preferences by default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson/cordova-lib
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-android/pull/186#issuecomment-115784095
The file transfer plugin uses this method to ensure that a url uses http or
https. We would get INVALID_URL_ERR whenever a user entered a url with a
capital
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-android/pull/186
CB-9255: make getUriType case insensitive
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson/cordova-android uri-fix
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-ios/pull/145#issuecomment-115654625
The current style is not incorrect or a bad habit. It may not follow
Apple's style, but both styles are valid and readable.
Many C programmers choose
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-plugins/pull/18#issuecomment-107043443
@Fmstrat these changes should be in the latest version. Cordova no longer
supports this as a core plugin though. I have a fork
[here](https://github.com
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-ios/pull/141
Change _state after creating logging string
Currently, the code sets `_state` immediately before creating the string to
log, so it will always print CDVWebViewDelegate: Navigation started
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/81
CB-8780: Display popover using main thread. Fixes popover slowness
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/50
CB-8773: Fix for iOS 8 keyboard not appearing on prompt
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson/cordova
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-plugins/pull/18#issuecomment-87709992
Thanks for the merge @agrieve. Unfortunately, I've just found another issue.
If I recall correctly, one of the major factors was because iOS 7 shrank
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-plugins/pull/18#issuecomment-87343580
@davidtlee If you're using the cordova command line, `cordova plugin add
https://github.com/cjpearson/cordova-plugins#master:keyboard` should work
---
If your
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/95
CB-3360: Set custom inappbrowser user agent for android
This uses the same OverrideUserAgent and AppendUserAgent properties as the
pull requests for cordova-ios and cordova
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/94
CB-3360: Set custom inappbrowser user agent for ios
This uses the same OverrideUserAgent and AppendUserAgent properties as the
pull requests for cordova-ios and cordova
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-ios/pull/133#issuecomment-82005079
That's correct. Thanks, @shazron.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/92#issuecomment-80476954
I'm seeing some extra grey area when hiding the location bar and showing
the toolbar on top.
`window.open('http://google.com', '_blank
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-ios/pull/133#issuecomment-78029460
Thanks for the feedback, Shazron. I wasn't sure how it should be brought
up, I just wanted to get the ball rolling somehow.
---
If your project is set up
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-ios/pull/133
CB-7428: Enable Swift development of Plugins
I've included the changes listed under CB-7428 into the template projects.
As part of these changed, I've moved up the minimum deployment target
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/87
CB-8552 Add toolbar option for android
This change adds the toolbar option to android. The location property
determines whether or not the URL is visible while the toolbar
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/89
CB-3750: Add loading spinner for ios
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson/cordova-plugin
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/88
CB-3750: Add loading spinner for android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson/cordova-plugin
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-lib/pull/171#issuecomment-76387512
@agrieve I've addressed your comments, could you take another look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/82
CB-8534: Add support for auth dialogs in inappbrowser plugin
When an authentication challenge is received, the inappbrowser will now
check to see if a plugin can respond
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-android/pull/160#issuecomment-75749293
@agrieve I've modified it to use --activity-name with nopt. I tried to
follow the style of the iOS create script.
---
If your project is set up for it, you
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25187402
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/160#discussion_r25187348
--- Diff: bin/create ---
@@ -23,14 +23,15 @@ var create = require('./lib/create');
var args = require('./lib/simpleargs').getArgs
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25187454
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-lib/pull/171
CB-7827: Allow user to specify android activity name
This change adds an attribute to config.xml android-activityName that can
be used to specify a custom activity name. If none is specified
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-android/pull/160
CB-7827: Allow user to specify android activity name
This change adds a parameter to create to allow the user to specify an
activity name. If none is specified it will still default
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-lib/pull/165
CB-8457: Ignore version specifier when running hooks
Trims the version specifier when running hooks. This allows platform add
hooks to run when a version specific platform add command
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugins/pull/18
CB-8337: Fix keyboardShrinksView for external keyboards, CB-8339 enable
keyboardShrinksView on iOS 7.1+
Instead of listening for keyboard show and hide events, the plugin now
listens
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/20
update docs for StatusBarBackgroundColor
The default value is no longer black. (CB-7486)
You can merge this pull request into a Git repository by running:
$ git pull https
67 matches
Mail list logo
