Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/185
Any reason why this can't be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/120
could this get merged? I have been maintaining a forked plugin for months
with this PR merged and it works well.
---
If your project is set up for it, you can reply to this email
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/120
I have merged this into my project and tested and confirm that it does what
it says on the box.
Before: simulate memory warning on the iOS simulator and audio stops
instantly
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/136
This is not a pull request. Please close this and try the Cordova slack
channel or search around on stack overflow or similar resources for issues and
support.
---
If your project
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/130
I haven't tested this yet, just found the PR while looking through various
forks.
I plan to test to mAke sure this is consistent with iOS and then will
update here
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/99
I had a PR for the same issue which has just been merged and is in master.
Installing the media plugin from github confirms the errors in xcode are
resolved.
This PR could
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/122
@shazron thanks, sorry to bug you just figured you were kind of the
gatekeeper here.
@infil00p I have been running with this PR (and the other null point PR
that was recently
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/129
@TommiKetola #122 should catch most scenarios that would cause this one to
occur. However, there is no validation that a value is passed in to the method
that this PR patches either
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/130
CB-8098 & CB-7810:(android) Added media rate for android
### Platforms affected
Android
### What does this PR do?
adds set rate function for android
this alr
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/122
@shazron - this would be a great one to get in, I am having this issue
frequently now on android with more apps having audible announcements and
prompts. Nothing like having your
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/122
So I have started to encounter the problem this fixes recently. Using
runkeeper along with my music app runkeeper will take the audio focus for it's
announcements. If it happens
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/124
This would be a nice one to get merged in for improving cross platform
compatibility, need this for one of my apps to work smoothly when syncing audio
recordings between multiple
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/116
@shazron I just checked Jira and CB-11817 is the correct Jira issue for
this issue
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/116
This is a really trivial fix could it please get merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
I will look through the proposed changes next week and resolve conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
@jcesarmobile - updated to remove that duplicate code, tested in my app and
it's working well.
---
If your project is set up for it, you can reply to this email and have your
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
Oh I see now, sorry I misunderstood.
I can definitely make that change
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/185
I have been using this pr as well and it works well, makes the toolbar have
a much more native look and feel. This definitely seems like a no brainier to
merge
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
The new methods follow what is implemented for close, where there are 2
close methods, one designed for the user to call and one for use with a
selector that the done button
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
CB-12132: (android & ios) implement hidenotclose feature
### Platforms affected
android & ios
### What does this PR do?
This adds a ne
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-android/pull/340
I have the same problem, after upgrading the platform I now get default
cordova icons for my android build, even though with the previous version of
the platform all icons and splash
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/116
@shazron any chance this could get merged? It's a really small change that
basically just fixes an oversight in the current version, which makes recording
much more efficient
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/116
I didn't add any automated tests as it wasn't relevant, this was just a
really simple bug.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/116
CB-1187: (iOS) Fix unused recording settings
### Platforms affected
iOS
### What does this PR do?
easy fix: audioSettings object wasn't being passed in when starting
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/104
Those just seem to be all of the recent commits. I'm not entirely sure why
they are attached to this PR but I don't think they are specific to what you
are asking.
Do you
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/97
This is also a problem with MP3 files where android (for whatever reason)
cannot read the duration of the file. This could be some slight corruption to
the file over time or it could
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/87
Just reading through your steps to reproduce in Jira and wanted to check
where you are seeing the problem.
First you make a recording (this seems to work).
You
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/96#issuecomment-220506090
@piyushkhare11 - this is not the right place for your question, I suggest
that you log a ticket on the cordova jira or ask in the cordova slack channel
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/87#issuecomment-207303423
@sonicwong it's not related to this as this PR is related to getPosition
for recordings.
There was however, recently a PR merged that fixed
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/77#issuecomment-207159923
@purplecabbage there are 2 single line changes on this PR, one of which is
already incorporated into master from another commit. If the second one liner
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-207159395
@purplecabbage comments on this PR could not possibly go further off topic
:) Seems to have become defacto media plugin support for a while
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-201359813
@ThunderTech-Avisolve I'm not sure what the exact limitations are with
avplayer but you could look it up in apples docs, they do have documentation
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/16#issuecomment-200148555
At this point it might be more sensible to drop the steps that auto search
in a few folders and instead have a simple explicity behaviour. This would cut
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/54#issuecomment-200146892
Apparently playAudioWhenScreenIsLocked is deprecated on iOS (from the
tickets I was reading today) anyway so this PR could probably be closed
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-200146522
Just been testing this in my project, seems to work well. One issue with
this PR is that you have deleted a closing bracket on line 510 that should
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/77#issuecomment-200146217
Note that the first change in this PR is already included in master for
v2.2.0, I have been testing with the second change also included
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-199633964
I have also hit this problem and it causes ongoing issues for my app.
Could this be checked and merged soon?
---
If your project is set up
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-199568786
@tommy1688 that change will completely break streaming audio support. All
it is doing is reverting to using avaudioplayer for everything and assuming
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-192183151
cool I'll test this out when I have a chance and see if it still behaves as
expected in my app as it uses a mix of local and streaming content
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-191648550
The avPlayer.play code is there for playing from remote sources as a
stream, it will only be triggered if the source starts with http or https
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182668004
That should fix the test for rate change as it will allow the media to
buffer before starting to count play time.
In reality actually using
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182673242
I have an audioplayer service which creates the media object with
media.play().then statement. In the then statement I wait for mediaStatus to
hit 2
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-177704439
Awesome! Glad I could contribute something back to the project!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-176651587
@purplecabbage sorry to bug you but if you could have a look at my previous
comment that would be great, I really want to get this merged as it has been
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-176651285
@imsingh where are you loading the m3u file from? If you are opening the
m3u file from the local file system it will try to play it like a local file
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-176512843
@imsingh That doesn't really have anything to do with this pull request.
I'm not sure what "MPESG Radio" is that is generating the error messa
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-173504921
@purplecabbage I have added rate control when streaming from a URL using
avplayer and tested that it works. However test case 19 still fails
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-168566368
@nuruddinbadawi install my branch of the media plugin with this command:
cordova plugin add
https://github.com/ghenry22/cordova-plugin-media.git
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-168602586
update your android platform and try again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-161844312
@snstarosciak I'm not going to be much help to you on this one
unfortunately. The media plugin is for audio and my app only plays audio not
video so I
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/63#issuecomment-161146771
It's been merged into master :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-161146304
The problem is the rate feature was added as a PR after this was submitted.
I have kept this branch up to date and merged those changes in but obviously
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-160829534
@FherPie this PR has nothing to do with the Android platform. This PR is
also 2 years old now. If you require background threading and streaming
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159765780
@dduwab @snstarosciak - glad I was able to help you guys out a bit. Good
luck with your projects!
---
If your project is set up for it, you can reply
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159765464
@purplecabbage - if I fix the conflicts with the latest updates in master
can this finally get merged? I can't see any reason for this to be held back
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/74#issuecomment-159765701
These are really simple small fixes that do not change any default
behaviour but fix fairly critical use cases, like being able to play sounds
from a url
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159777975
@purplecabbage conflicts resolved was just the version bump I put in
plugin.xml conflicting with the new version 2.0.0 bump in master, so completely
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159431966
That function just gets the directory that you would store your files in.
You can then append any file name you want to access. For example you could
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159119183
@dduwab - this PR does not require any changes to the client at all, it all
works exactly the same with all the same functions implemented in the same way
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159179817
Ok this discussion isn't really relevant to this PR at all but more related
to quirks of the file plugin that is used by the media plugin but let me try
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-158700040
It's trying to play a local file as a stream due to the path being used by
the look of it. Please try using the cordova.file.* paths to get a cdvfile
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-158699476
That actually isn't something that this code changes, that's the default
behaviour of the media plugin. Search for playing audio when locked
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-157914628
Not sure about soundcloud as I haven't tried to stream from them before.
Whether you can seek in a stream or not would probably depend on the source
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153923917
CB-9020 does say they are targeting WP 8.1 which uses the new windows
platform so this PR would also resolve CB-9020.
CB8257 seems to refer
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/141#issuecomment-153925590
I reported this and can confirm it is the case on the windows platform.
This is a trivial change to the docs but very useful information for anyone
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153925057
MS docs confirm the same, should be ms-appx:///
Committing an update to fix now.
reference:
https://msdn.microsoft.com/en-us/library
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153922252
CB-9090 is for the whitelist plugin
CB-8257 is the same issue but for the wp8 platform. This fix is for the
windows platform, I don't have native
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153926046
once merged you could also close out PR #121 as duplicate as it attempts to
solve the same issue but generates absolute paths from c:\... which
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-153949837
PR #12 & PR #18 could also be closed out as duplicate once this one is
merged which will help to clean up some older lingering PR's
---
If your pro
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153536161
@purplecabbage yep I have signed an ICLA and have already had a PR merged
into the file plugin.
I'll send you a direct message on slack with full
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153219294
my understanding is that applicationStorageDirectory is a bit redundant.
It is the same as the applicationDirectory but has a note that you can change
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153219744
added applicationStorageDirectory to defined paths and updated readme with
relevant comments for this path.
---
If your project is set up for it, you
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/143
CB-9887 cordova.file.* paths for windows platform
Update the plugin to define cordova.file.* paths for windows platform as
appropriate.
Documentation updated to show where
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/74
fix CB-9884 & CB-9885 on windows platform
CB-9884 - windows platform - add support for streaming url prefixes that do
not end in a file
extension, so the media plugin can play
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-windows/pull/123#issuecomment-151123814
tested with the mod as in the comments, resolved the error for me
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-windows/pull/123#issuecomment-151005434
Currently blocked preparing my first windows store submission by this one.
I use an external path to x64 node in visual studio 2015 so that it uses
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/121#issuecomment-150114300
Have tried this on a windows 10 universal app and had some issues.
cordova.file values seem to return a absolute path eg
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-147894924
Alkashi - nope you were quite right. I realised I had a different branch
of the plugin installed myself to test some things for Android
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-147566101
@dts - thanks for the suggestion, I have implemented this and hopefully
also fixed for playback from local files as well.
@purplecabbage
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-147205639
This pull request doesn't make any changes to the behavior of get duration
calls though, I see with my media some times 0 is returned for some files
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-147294883
master branch of the repo has no changes, changes for enabling streaming
and backgrounding of play / stop commands is implemented in a specific branch
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-146384452
Alkashi - getDuration definitely works as expected on ios devices. I use
it every day in my app and have tested it extensively on multiple devices
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-132005818
I'll look and putting something in that mimics the existing stop behavior
applied to avaudioplayer.
Any chance of this actually getting merged
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/18#issuecomment-132009862
This pull request could probably be closed.
I have added an updated pull request which implements avplayer for
streaming audio which has
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-130505127
avplayer which is used for streaming does not have an equivalent stop
method. You can just pause() and then release() there is no need to stop
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-128978709
You need to install from the #avplayer_streaming branch, just google how to
install Cordova plugins from a branch. The base plugin is just the same
Github user ghenry22 closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/60
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/62
Streaming Background threading on play
This fixes 2 issues in the Cordova Jira, both with iOS. It enables
streaming support for media playback from URLs while retaining the existing
Github user ghenry22 closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/18#issuecomment-120969822
Background playlists can already be achieved by handling you playlist in
you code, but what is really interesting here is implementing avplayer instead
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-120227841
I've added a new pull request that backgrounds all media functions, this
resolves all the should use a background thread warnings xcode that were
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/61#issuecomment-120190492
sorry this is for CB-8222
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/61
More background threading for audio
send more functions to background threads.
The previous submission fixes the UI blocking on load from URL with play(),
xcode still
Github user ghenry22 closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/125
CB-9331 cordova-plugin-file
resolves CB-9331, correct the value queried on iOS devices so that free
getFreeDiskSpace() returns a valid value instead of always returning 0.
You can
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/60#issuecomment-119106407
This resolves the same issue as PR #12, as that has been hanging for a LONG
time I have created a new pull request.
The Jira ID for this issue
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/60
CB-8222 Background threading for Audio Plugin
Start playback with background thread so that UI is not blocked when
playing sounds with the media plugin.
You can merge this pull
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/124
CB-6703cordova-plugin-file
Fix as discussed in the comments on this Jira issue.
Fix getFreeSpace always returns 0 on iOS
Works on emulator and device now.
You can
98 matches
Mail list logo
