[GitHub] cordova-windows pull request: CB-7452 Windows. Rewrite ApplyPlatfo...

2014-09-03 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/42 CB-7452 Windows. Rewrite ApplyPlatformConfig.ps1 using NodeJS https://issues.apache.org/jira/browse/CB-7452 You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-lib pull request: CB-7441 Plugman. jsproj files should be ...

2014-09-02 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-lib/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-7441 Plugman. jsproj files should be ...

2014-09-01 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/82 CB-7441 Plugman. jsproj files should be treated as xml if used with config-file https://issues.apache.org/jira/browse/CB-7441 You can merge this pull request into a Git repository by running

[GitHub] cordova-plugin-camera pull request: CB-7433 Fixes manual tests fai...

2014-08-31 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/46#issuecomment-53985313 :+1: Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: CB-6976 Windows Universal apps

2014-08-29 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-docs/pull/229 CB-6976 Windows Universal apps Updates documentation as per introducing new universal windows platform. https://issues.apache.org/jira/browse/CB-6976 You can merge this pull request

[GitHub] cordova-lib pull request: CB-7420 Windows. Plugin resource-files...

2014-08-28 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/80 CB-7420 Windows. Plugin resource-files are removed from platform during prepare https://issues.apache.org/jira/browse/CB-7420 Changed source files location from platform\www\plugins

[GitHub] cordova-lib pull request: Windows helper. Removes unnecessary $(MS...

2014-08-28 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/81 Windows helper. Removes unnecessary $(MSBuildThisFileDirectory) This property is not required since all main .jsproj and other shared project files are in the same folder You can merge

[GitHub] cordova-windows pull request: CB-7377 Whitelist. Windows build err...

2014-08-26 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/41 CB-7377 Whitelist. Windows build error due to 'invalid URI rules in config.xml https://issues.apache.org/jira/browse/CB-7377 Added logic to filter https:// access rules only. You

[GitHub] cordova-cli pull request: Add symbolic link option to for cordova ...

2014-08-26 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/191#issuecomment-53418500 I'll try the code...will report results soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-cli pull request: Add symbolic link option to for cordova ...

2014-08-26 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/191#issuecomment-53421487 requires administrative privileges to add plugin with -link option (I think is ok and nothing we can do here), otherwise works as expected * tested with cordova

[GitHub] cordova-windows pull request: Use '--win' switch instead of '--sto...

2014-08-15 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/39 Use '--win' switch instead of '--store' for Windows desktop/tablet build After additional discussion it is proposed to replace --store with --win as the most understandable

[GitHub] cordova-coho pull request: CB-7309 Coho. verify-archive incorrectl...

2014-08-14 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-coho/pull/33 CB-7309 Coho. verify-archive incorrectly parses hash output on Windows https://issues.apache.org/jira/browse/CB-7309 You can merge this pull request into a Git repository by running

[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...

2014-08-12 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-51885991 @Bosman, thx for sharing this trick! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-12 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51904349 Answering Carlos questions 1. I believe recommended solution here is placing required dependencies along with plugin (node_modules folder inside your scripts

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-12 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51905210 + sharing some my experiments with plugin hooks: WP8 JavaScript debugger implemented as cordova plugin https://github.com/sgrebnov/cordova-debug-wp8 https

[GitHub] cordova-medic pull request: Windows Universal Apps support and imp...

2014-08-11 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-medic/pull/16#issuecomment-51778314 Could someone review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-10 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51718759 Confirm this issue, @csantanapr I've cherry-picked your fix (Thx!), also added minor improvement. We may want to better formalize opts structure (special class

[GitHub] cordova-windows pull request: CB-7129 Switch to nodejs for windows...

2014-08-08 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/38#issuecomment-51608724 1. Build/run logic refactoring and improvements (many command failed if run with --help wsitches). 2. Added option to specify target version for store apps

[GitHub] cordova-windows pull request: CB-7129 Switch to nodejs for windows...

2014-08-08 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/38#issuecomment-51620450 Jesse, please let me know your consideration regarding promises usage and if there are places which should be improved. I personally tried to do my best to make

[GitHub] cordova-medic pull request: Windows Universal Apps support and imp...

2014-08-06 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-medic/pull/16 Windows Universal Apps support and improvements master.cfg - * moved shared steps to base class (PlatformTestBase), other platforms inherits base steps and can override them when

[GitHub] cordova-windows pull request: CB-7129 Switch to nodejs for windows...

2014-08-06 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/38#issuecomment-51360015 I'll perform additional iteration reviewing this and making code better. Main reason of using promises was consistency with another platforms so that we can

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-06 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51389090 btw, loooks like all tests are passed on both windows and linux --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-windows pull request: CB-7129 Switch to nodejs for windows...

2014-08-05 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/38#issuecomment-51191567 rebased, could someone review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-weinre pull request: CB-6991 Weinre fails to load in brows...

2014-08-04 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-weinre/pull/6 CB-6991 Weinre fails to load in browsers without a built-in console Weinre fails to load in browsers without a built-in development console https://issues.apache.org/jira/browse/CB-6991

[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...

2014-08-03 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50993882 Reproduced this issue on both android (return error) and ios (return first contact instead of all). Pushed fix to plugin master to explicitly define

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-01 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-50883550 Addressed @kamrik code review notes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...

2014-08-01 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50886099 Hey Sebastian, I think missing contactFindOptions means return all contacts and is correctly handled on some platforms. Is there specific platform which

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-31 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/55#discussion_r15658798 --- Diff: cordova-lib/src/hooks/scriptsFinder.js --- @@ -0,0 +1,164 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-windows pull request: CB-7129 Switch to nodejs for windows...

2014-07-22 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/38 CB-7129 Switch to nodejs for windows platform scripts https://issues.apache.org/jira/browse/CB-7129 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-wp8 pull request: CB-4655 WP8: Default native project temp...

2014-07-21 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-wp8/pull/47 CB-4655 WP8: Default native project template should be overridable at pr... ...oject creation time https://issues.apache.org/jira/browse/CB-4650 You can merge this pull request

[GitHub] cordova-lib pull request: build configuration for AppVeyor

2014-07-17 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/60 build configuration for AppVeyor You can merge this pull request into a Git repository by running: $ git pull https://github.com/sgrebnov/cordova-lib appveyor Alternatively you can

[GitHub] cordova-lib pull request: build configurations for Travis

2014-07-17 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/59 build configurations for Travis You can merge this pull request into a Git repository by running: $ git pull https://github.com/sgrebnov/cordova-lib travis Alternatively you can review

[GitHub] cordova-windows pull request: CB-7144 Windows8 run fails if replac...

2014-07-16 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/37 CB-7144 Windows8 run fails if replace default certificate https://issues.apache.org/jira/browse/CB-7144 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-cli pull request: Reverts CB-6976 Add support for Windows ...

2014-07-16 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-cli/pull/183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: Splash screen support via config.xml for...

2014-07-16 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-cli/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: Splash screen support via config.xml for...

2014-07-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/145#issuecomment-49213174 Not valid anymore, closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-cli pull request: Reverts CB-6976 Add support for Windows ...

2014-07-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/183#issuecomment-49213003 Not actual anymore, closing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: CB-3571: update the docs for the splash...

2014-07-15 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/220#discussion_r14918639 --- Diff: docs/en/edge/config_ref/images.md --- @@ -135,118 +135,60 @@ Windows8 ## Configuring Splash Screens in the CLI -Use

[GitHub] cordova-docs pull request: CB-3571: update the docs for the splash...

2014-07-15 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-docs/pull/220#issuecomment-48994108 @AxelNennker, thx for the update! LGTM now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-wp8 pull request: small fix for spaces in path

2014-07-15 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-wp8/pull/45#issuecomment-48994839 Hey @G3z, thx for the fix. Do you have iCLA signed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-docs pull request: CB-3571: update the docs for the splash...

2014-07-15 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-docs/pull/220#issuecomment-48995659 Have not seen BlackBerry10 content is removed; agree, it must be put back. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-wp8 pull request: CB-5049 Create defaults.xml that contain...

2014-07-15 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-wp8/pull/46 CB-5049 Create defaults.xml that contains platform config.xml defaults for WP8 https://issues.apache.org/jira/browse/CB-5049 Moved config.xml to a new location to be consistent

[GitHub] cordova-wp8 pull request: CB-5049 Create defaults.xml that contain...

2014-07-15 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-wp8/pull/46#issuecomment-49024255 There is a reference to config.xml in template, but it is automatically created from 'defaults.xml' after you do 'platform add'. Another way is to use create.bat

[GitHub] cordova-wp8 pull request: small fix for spaces in path

2014-07-15 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-wp8/pull/45#issuecomment-49024791 You should sign the agreement below and send copy to the secret...@apache.org http://www.apache.org/licenses/icla.txt --- If your project is set up for it, you

[GitHub] cordova-plugin-inappbrowser pull request: CB- 5109 Windows 8.1 - I...

2014-07-15 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/53#issuecomment-49037092 Thx Maxime! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-7118 iOS: add target-device and Minim...

2014-07-14 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/57#discussion_r14868912 --- Diff: cordova-lib/src/cordova/metadata/ios_parser.js --- @@ -217,6 +220,38 @@ module.exports.prototype = { self.update_overrides

[GitHub] cordova-plugin-inappbrowser pull request: CB- 5109 Windows 8.1 - I...

2014-07-14 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/53 CB- 5109 Windows 8.1 - InAppBrowser. https://issues.apache.org/jira/browse/CB-5109 Adds support of 'x-ms-webview' available in Windows 8.1 and Windows Phone 8.1

[GitHub] cordova-docs pull request: CB-3571: update the docs for the splash...

2014-07-14 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-docs/pull/220#issuecomment-48901707 Axel, could you please 1. swap Windows Phone8 and Windows8 sections so that they follow the same order as in Icons section, + use the same order in 'Supported

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-11 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-48701880 Addressed docs review notes: deprecated .cordova/hooks directory --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-geolocation pull request: CB- 5114 Windows 8.1 - Us...

2014-07-11 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/18 CB- 5114 Windows 8.1 - Use a new proxy as old geolocation methods is deprecated https://issues.apache.org/jira/browse/CB-5114 * Tested on Windows 8.0, Windows 8.1

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-11 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/55#discussion_r14821551 --- Diff: cordova-lib/src/hooks/ScriptsFinder.js --- @@ -0,0 +1,158 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-plugin-geolocation pull request: CB- 5114 Windows 8.1 - Us...

2014-07-11 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/18#issuecomment-48732503 Thx, Maxime. Updated commit as per your note. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-11 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/55#discussion_r14822338 --- Diff: cordova-lib/src/hooks/ScriptsFinder.js --- @@ -0,0 +1,158 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-lib pull request: CB-7114 Android: add support of min/max/...

2014-07-10 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/56 CB-7114 Android: add support of min/max/target SDK to config.xml https://issues.apache.org/jira/browse/CB-7114 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-7114 Android: add support of min/max/...

2014-07-10 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/56#issuecomment-48583957 http://developer.android.com/guide/topics/manifest/uses-sdk-element.html#max Future versions of Android (beyond Android 2.0.1) will no longer check

[GitHub] cordova-lib pull request: CB-7118 iOS: add target-device and Minim...

2014-07-10 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/57 CB-7118 iOS: add target-device and MinimumOSVersion support to config.xml https://issues.apache.org/jira/browse/CB-7118 You can merge this pull request into a Git repository by running

[GitHub] cordova-lib pull request: CB-7118 iOS: add target-device and Minim...

2014-07-10 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/57#issuecomment-48696309 Fixed 'update_build_settings' issue and force pushed, thank you Jesse @purplecabbage --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-lib pull request: Reverts CB-6976 Add support for Windows ...

2014-07-09 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-lib/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Reverts CB-6976 Add support for Windows ...

2014-07-09 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/43#issuecomment-48437032 It was cherry picked to rb_0.21.6 so is not required to be in master anymore. Closing... --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-wp8 pull request: CB-7060 WP8. Fix large project build per...

2014-07-09 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-wp8/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-wp8 pull request: CB-7060 WP8. Fix large project build per...

2014-07-09 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-wp8/pull/43#issuecomment-48460452 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-09 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/55 CB-6481 Add unified hooks support for cordova app and plugins https://issues.apache.org/jira/browse/CB-6481 Added the following changes and new features * Hooks can be defined

[GitHub] cordova-lib pull request: CB-7083 Missing SDKReference support on ...

2014-07-08 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/53 CB-7083 Missing SDKReference support on Windows Phone https://issues.apache.org/jira/browse/CB-7083 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-lib pull request: CB-6874 Consolidate Content tag additi...

2014-07-08 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/54 CB-6874 Consolidate Content tag additions into 1 ItemGroup Windows Phone 8 and Windows8 https://issues.apache.org/jira/browse/CB-6874 You can merge this pull request into a Git repository

[GitHub] cordova-windows pull request: use `-noprofile` when shelling out t...

2014-07-07 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/36#issuecomment-48176344 LGTM, thx @staxmanade. We just need to update .jsproj to be consistent on how we run powershell. --- If your project is set up for it, you can reply

[GitHub] cordova-wp8 pull request: CB-7060 WP8. Fix large project build per...

2014-07-02 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-wp8/pull/43 CB-7060 WP8. Fix large project build performance issue https://issues.apache.org/jira/browse/CB-7060 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-plugin-contacts pull request: fixes CB-7003 navigator.cont...

2014-07-02 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-contacts pull request: fixes CB-7003 navigator.cont...

2014-07-02 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/32#issuecomment-47791107 Verified merged version, works correct, closing.. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: CB-6481 adds plugin level hooks support

2014-07-01 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/12#issuecomment-47623059 New plugin hooks implementation is coming...closing this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: CB-6481 adds plugin level hooks support

2014-07-01 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-lib/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-contacts pull request: fixes CB-7003 navigator.cont...

2014-06-30 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/32 fixes CB-7003 navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 versions https://issues.apache.org/jira/browse/CB-7003 pickContact: added logic

[GitHub] cordova-lib pull request: disables CB-6976 Add support for Windows...

2014-06-27 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-lib/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: disables CB-6976 Add support for Windows...

2014-06-27 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-cli/pull/182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: Reverts CB-6976 Add support for Windows ...

2014-06-27 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-cli/pull/183 Reverts CB-6976 Add support for Windows Universal apps Requires to not break upcoming CLI and LIB release. This will be added back and released along with of 3.6.0. You can merge this pull

[GitHub] cordova-lib pull request: disables CB-6976 Add support for Windows...

2014-06-26 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/41 disables CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1) We should not include this functionality until new Windows platform is released. It is better to enable

[GitHub] cordova-cli pull request: disables CB-6976 Add support for Windows...

2014-06-26 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-cli/pull/182 disables CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1) We should not include this functionality until new Windows platform is released. It is better to enable

[GitHub] cordova-cli pull request: CB-6976 Add support for Windows Universa...

2014-06-22 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/181#discussion_r14055705 --- Diff: src/cli.js --- @@ -165,6 +165,20 @@ function cli(inputArgs) { throw new CordovaError(msg

[GitHub] cordova-cli pull request: CB-6976 Add support for Windows Universa...

2014-06-22 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/181#issuecomment-46787820 @kamrik, @purplecabbage thx for review and notes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-lib pull request: CB-6976 Add support for Windows Universa...

2014-06-22 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/39#discussion_r14055722 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -75,6 +75,10 @@ function cordova_git(platform) { } var url = platforms

[GitHub] cordova-lib pull request: CB-6976 Add support for Windows Universa...

2014-06-22 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/39#discussion_r14055725 --- Diff: cordova-lib/src/cordova/platforms.js --- @@ -69,10 +69,17 @@ module.exports = { }, 'windows8':{ hostos : ['win32

[GitHub] cordova-lib pull request: CB-6976 Add support for Windows Universa...

2014-06-22 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/39#discussion_r14055726 --- Diff: cordova-lib/src/cordova/platforms.js --- @@ -69,10 +69,17 @@ module.exports = { }, 'windows8':{ hostos : ['win32

[GitHub] cordova-cli pull request: CB-6728 Support chip architecture

2014-06-20 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-cli/pull/180 CB-6728 Support chip architecture https://issues.apache.org/jira/browse/CB-6728 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-windows pull request: CB-6976 Add support for Windows Univ...

2014-06-20 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/35 CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1) https://issues.apache.org/jira/browse/CB-6976 * Renamed windows8 platform to windows. * Windows

[GitHub] cordova-cli pull request: CB-6976 Add support for Windows Universa...

2014-06-20 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-cli/pull/181 CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1) https://issues.apache.org/jira/browse/CB-6976 * Allow using new windows alias to work with old windows8

[GitHub] cordova-plugin-splashscreen pull request: Splashscreen crash on WP...

2014-06-19 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/20#issuecomment-46532850 +1 and thx! @nadyaA could you pls update your fix by adding the same change to show() method as well. --- If your project is set up for it, you

[GitHub] cordova-plugin-splashscreen pull request: Splashscreen crash on WP...

2014-06-19 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/20#issuecomment-46556623 Merged, thx for the fix. Pls close PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: CB-3571: support for splash element in...

2014-06-19 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46646255 Could we also incorporate the following PR to this one before merge? It adds splash images support for iOS, WP8 and Windows8. https://github.com/AxelNennker

[GitHub] cordova-medic pull request: CB-6909 shellCmd and shellRunParam in ...

2014-06-18 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-medic/pull/11#issuecomment-46406000 +1, LGTM, tested on Windows and OS slaves --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-6970 Share win project files manipula...

2014-06-18 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/32 CB-6970 Share win project files manipulation code between cordova and plugman https://issues.apache.org/jira/browse/CB-6970 1. Shared csproj and jsproj classes 2. Updated code

[GitHub] cordova-lib pull request: CB-6954 Share events.js between cordova ...

2014-06-17 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/31 CB-6954 Share events.js between cordova and plugman https://issues.apache.org/jira/browse/CB-6954 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-46151067 Pls take a look [here](https://github.com/apache/cordova-plugin-splashscreen/blob/master/doc/index.md#android-quirks_) and [here](http://docs.phonegap.com/en

[GitHub] cordova-lib pull request: CB-3571: support for splash element in...

2014-06-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46158371 The usage LGTM. But does current implementation remove all default cordova splash screen images if there is no splash element defined? Also, on Android icons

[GitHub] cordova-lib pull request: CB-3571: support for splash element in...

2014-06-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46166927 @AxelNennker, thx for the clarification! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...

2014-05-28 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-44455699 Thx @purplecabbage . I've tested merged version and confirm it works correct on Android, iOS, WP8, Windows8, --- If your project is set up for it, you

[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...

2014-05-27 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-44281909 Is there any work left here before we can merge this? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-wp8 pull request: CB-6732 [WP8] Fix MSBuild 64 bit is not...

2014-05-21 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-wp8/pull/36 CB-6732 [WP8] Fix MSBuild 64 bit is not supported build error https://issues.apache.org/jira/browse/CB-6732 Added fix based on process bitness check and exciting appropriate query

[GitHub] cordova-plugman pull request: CB-6481 adds plugin level hooks supp...

2014-05-16 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-plugman/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugman pull request: CB-6481 adds plugin level hooks supp...

2014-05-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugman/pull/74#issuecomment-43280272 Moved to appropriate repo, closing... https://github.com/apache/cordova-lib/pull/12 --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-file pull request: wp8. fixes binary support after ...

2014-05-16 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-docs pull request: CB-2606 Documented icon usage

2014-05-15 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-docs/pull/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

<    1   2   3   4   5   >