[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/277 Ah yes, thanks for catching that! The unit test should be adequate. I'll get this pulled in. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/277 @cjpearson we need the unit tests to work first before this can be pulled in. I added those tests (which should have been there in the first place) because this PR didn't come with one

[CI STATUS REPORT] - 19 actual failures, 3 known failures

http://status.cordova.io # ACTUAL FAILURES 1. Parts of all 19 plugins are failing (seems to be temp file issues: FATAL: Unable to produce a script file java.io.IOException: Failed to create a temp file on E:\jenkins\workspace\cordova-periodic-build) # KNOWN FAILURES (CI issues) 1. cordova-lib

[GitHub] cordova-ios issue #278: CB-11243 - Added failing tests

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/278 It's not a failure in node-xcode. Therefore, the tests are incorrect somehow. Tested using: ``` #!/usr/bin/env node var xcode = require('xcode'), fs = require

[GitHub] cordova-ios issue #278: CB-11243 - Added failing tests

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/278 I'm going to run some independent tests on node-xcode to verify that updateBuildProperty is working properly (it has unit-tests already) or whether it is our test pbxproj that is faulty, etc

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/277 Evaluated this. Turns out this is not the problem - see #278 failing test for this issue which looks like a failure in node-xcode updateBuildProperty. Note that the test project pbxproj already

[GitHub] cordova-ios pull request #278: CB-11243 - Added failing tests

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/278 CB-11243 - Added failing tests ### Platforms affected iOS ### What does this PR do? Added failing tests for `target-device` and `deployment-target` preferences

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/277 Reviewing this to understand where the bug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/277 CB-11648 will be obsolete and may not be needed with https://issues.apache.org/jira/browse/CB-12127 already implemented. Example use: https://issues.apache.org/jira/browse/CB-11245

[GitHub] cordova-ios pull request #273: Cb-12098 (iOS) update supportedinterfaceorien...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/273#discussion_r87504333 --- Diff: bin/templates/project/__PROJECT_NAME__/Classes/MainViewController.m --- @@ -92,7 +92,13 @@ - (UIWebView*) newCordovaViewWithFrame:(CGRect

[GitHub] cordova-ios pull request #273: Cb-12098 (iOS) update supportedinterfaceorien...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/273#discussion_r87504252 --- Diff: CordovaLib/Classes/Public/CDVViewController.m --- @@ -419,7 +419,13 @@ - (BOOL)shouldAutorotate return YES

Re: [CI STATUS REPORT] - 2 actual failures, 2 known failures

hat > adds separate columns for different androis versions and updates the links. > > - > Best regards, Vladimir > > -Original Message- > From: Shazron [mailto:shaz...@apache.org] > Sent: Saturday, November 5, 2016 2:55 AM > To: Shazron <shaz...@apache.org> > C

Re: [NODE] Can we drop node 0.x support?

> and AppVeryor configs for it and using the features Node 4+ provides? > > Thanks, > Alexander Sorokin > > -----Original Message- > From: Shazron [mailto:shaz...@gmail.com] > Sent: Monday, August 15, 2016 11:59 AM > To: dev@cordova.apache.org > Subject: Re: [NODE] C

[GitHub] cordova-docs issue #662: CB-12127 - (ios) Add buildFlag support in build.jso...

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/662 Pull this in for cordova-ios 4.3.1 release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request #662: CB-12127 - Add buildFlag support in build.js...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/662 CB-12127 - Add buildFlag support in build.json ### Platforms affected iOS ### What does this PR do? Document the "buildFlag" option in build.json

[GitHub] cordova-ios pull request #275: CB-12127 - Add buildFlag support in build.jso...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/275 CB-12127 - Add buildFlag support in build.json ### Platforms affected iOS ### What does this PR do? Add build.json support for the "buildFlag" key.

[GitHub] cordova-plugin-splashscreen issue #117: CB-12062: (ios) Fix crash when liste...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/117 Thanks! Can you add the Apache License headers to the .h and .m files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Incompatible plugin should reject the build

See https://issues.apache.org/jira/browse/CB-12122 Right now if a plugin fails an check, it just warns. Should we make engine checks fail the build?

[GitHub] cordova-ios pull request #274: CB-12118 - Cordova run ios does not automatic...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/274 CB-12118 - Cordova run ios does not automatically deploy to device ### Platforms affected self ### What does this PR do? When you have a device connected, "co

Re: [DISCUSS] Cordova-Android 6.1 Release

gt; wrote: > > > >> Sounds good Joe. Can you re-post the official process/doc on how to > verify > >> a cordova-android release for those who may be doing it for the first > >> time? > >> > >> > >> Simon Mac Donald > >> http://sim

Re: [CI STATUS REPORT] - 2 actual failures, 2 known failures

For tracking: https://issues.apache.org/jira/browse/CB-12116 On Fri, Nov 4, 2016 at 11:34 AM, Shazron <shaz...@apache.org> wrote: > http://status.cordova.io > > > # ACTUAL FAILURES > > 1. cordova-lib (being worked on) > 2. cordova-plugin-device-motion on Android (unkn

Re: [VOTE] cordova-android@6.1.0 Release

I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ensured tests passed (AppVeyor and Travis CI) * Created and emulated new app using the platform On Thu, Nov 3, 2016 at

[DISCUSS] Schedule to drop iOS 8 support in cordova-ios@5.x

We've always only supported the currently released iOS, and the previous iOS release because of test device OS constraints. Currently our support is for iOS 10 and iOS 9. iOS 9+10 support is at 92% of users according to Apple: https://developer.apple.com/support/app-store/ Coinciding with the

[CI STATUS REPORT] - 2 actual failures, 2 known failures

http://status.cordova.io # ACTUAL FAILURES 1. cordova-lib (being worked on) 2. cordova-plugin-device-motion on Android (unknown progress) cordova-plugin-device-motion-tests.tests >>.Accelerometer (navigator.accelerometer).getCurrentAcceleration.accelerometer.spec.5 success callback

[GitHub] cordova-docs issue #659: CB-11860 Documented codeSignIdentity usage

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/659 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

Re: [VOTE] cordova-plugin-compat@1.1.0 Release

I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran coho verify-archive On Wed, Nov 2, 2016 at 3:36 PM, Steven Gill wrote: > Please review and

Re: [DISCUSS] Cordova-Android 6.1 Release

+1 For those not using Android daily, also give us guidance on testing areas of focus On Wed, Nov 2, 2016 at 9:06 AM, Joe Bowser wrote: > Hey > > While people have been talking about how critical their fix is for Cordova, > I actually found a critical issue that we missed in

Re: Release cordova-android 6.0.1?

Let's do a patch release. Calling for volunteers (committers) that are invested in this to step up. The steps are: https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md On Tue, Nov 1, 2016 at 10:03 AM, Darryl Pogue wrote: > I'd consider this

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-docs issue #655: CB-12054 - Cordova iOS 4.3.0 release announcement

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/655 @dpogue Good idea, I'll add it and update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[REVIEW] iOS 4.3.0 Release Blog Post

Please review: https://github.com/apache/cordova-docs/pull/655 Kerri, I didn't highlight your feature, that will wait until your fix gets in for 4.3.1

[GitHub] cordova-docs pull request #656: CB-12058 - Document CocoaPods support in plu...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/656 CB-12058 - Document CocoaPods support in plugin.xml tag ### Platforms affected iOS ### What does this PR do? Document CocoaPods support in plugin.xml tag. Cleaned

[GitHub] cordova-docs pull request #655: CB-12054 - Cordova iOS 4.3.0 Blog Post

GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/655 CB-12054 - Cordova iOS 4.3.0 Blog Post I'd like to push a new version with relative links to the docs in the blog, but I'm still writing the CocoaPods one, will update soon. You can merge

[GitHub] cordova-docs pull request #654: CB-12000 - (iOS 4.3.0) Add documentation for...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/654 CB-12000 - (iOS 4.3.0) Add documentation for --buildFlag cli option ### Platforms affected iOS ### What does this PR do? Document `--buildFlag` option when using

Re: [Vote] 4.4.3 Windows Release

I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ensured continuous build was green when repo was tagged * ran npm install && npm run cover On Mon, Oct 24, 2016 at 8:49 AM,

Re: [VOTE] 4.3.0 iOS Release

The vote has now closed. The results are: Positive Binding Votes: 3. Joe Bowser Shazron Abdullah Kerri Shotts The vote has passed. On Mon, Oct 24, 2016 at 11:42 AM, Kerri Shotts <kerrisho...@gmail.com> wrote: > I vote +1: > > * Ran coho audit-license-headers > * Ran coho che

Re: [Vote] Tools Release

I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran through unit tests On Sat, Oct 22, 2016 at 7:34 PM, Steven Gill wrote: > Please review and

Re: [Vote] 6.0.0 Android Release

I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Created a project with the new platform, built and ran it ok On Thu, Oct 20, 2016 at 1:33 PM, Steven Gill

Re: [DISCUSS] cordova-ios 4.3.0 release

and promote launch storyboard images then. Although if there’s a > quick way to pull the fix in, that’d be my preference… :-) > > Thoughts? > > ~ Kerri > > > On Oct 20, 2016, at 15:38, Shazron <shaz...@gmail.com> wrote: > > > > Chock full of new features:

[VOTE] 4.3.0 iOS Release

Please review and vote on this 4.3.0 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-12054 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-12054 The package

[DISCUSS] cordova-ios 4.3.0 release

Chock full of new features: - CocoaPods (static libs only) support as - Xcode 8 / iOS 10 support - buildFlag support on the command line - iPad storyboard support - others that I may have forgot All the outstanding PRs and (according to me) issues that can get fixed are in. Let me know if

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/504 Make sure to run `npm test` before re-submitting your changes. CI fail due to jshint error. `src/plugman/fetch.js: line 72, col 12, 'option' is not defined.` --- If your project is set up

Re: Apple rebrands OSX to macOS - should we follow suit?

I think it's fine. The repo is low-impact, and if you rename on GH it aliases it as well. Also, there might be changes needed in Coho and the Docs. On Tue, Oct 18, 2016 at 6:10 PM, Tobias Bocanegra wrote: > Hi, > > with the sierra update, Apple renamed OS X to macOS. I don't

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/269 So if they use `canOpenURL` they need this, but if they just use `openURL`, like our whitelist system, we don't. Therefore I believe our whitelist system with `` does not need these keys

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/269 Yeah looks like openURL does not need the key: https://developer.apple.com/reference/uikit/uiapplication/1622952-canopenurl (see last paragraph -- it has a typo, UIDefaultLaunchStoryboard

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/269 @dpogue Can you rebase? cordova-common 1.5.1 is in the repo now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-windows issue #201: CB-11993 - windows platform doesn't test all nod...

Github user shazron commented on the issue: https://github.com/apache/cordova-windows/pull/201 Failing on Travis 0.12, 4, and 6 (but works on 0.10). Env vars expected are null because Travis is on Linux and not on Windows. e.g https://github.com/apache/cordova-windows/blob

[GitHub] cordova-windows pull request #201: CB-11993 - windows platform doesn't test ...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-windows/pull/201 CB-11993 - windows platform doesn't test all node versions on appveyor and travis ### Platforms affected Self. ### What does this PR do? Makes appveyor

[GitHub] cordova-cli issue #263: CB-11913 - Re-fix appveyor.yml to use specific node ...

Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/263 Final fix that worked: downgrade to npm@2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-cli issue #263: CB-11913 - Re-fix appveyor.yml to use specific node ...

Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/263 @stevengill since `yarn` works flawlessly on `node 6` the alternative is, put all the `install` commands in a script and use `yarn` when we detect `node 6`. Kinda like my script here: https

[GitHub] cordova-cli issue #263: CB-11913 - Re-fix appveyor.yml to use specific node ...

Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/263 @stevengill unfortunately https://github.com/npm/npm/issues/9633 strikes its head (see AppVeyor failure). Usually running `npm install` again fixes it, but once the first `npm install` fails

[GitHub] cordova-lib pull request #503: CB-11994 - appveyor tests on cordova-lib are ...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/503 CB-11994 - appveyor tests on cordova-lib are not testing on all node versions ### Platforms affected Self ### What does this PR do? appveyor.yml wasn't testing

[GitHub] cordova-lib issue #502: CB-12002 - Add getAllowIntents() to ConfigParser

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/502 Let's try to get this in for the tool release for cordova-ios 4.3.0 release --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-cli issue #263: CB-11913 - Re-fix appveyor.yml to use specific node ...

Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/263 Nah its https://github.com/npm/npm/issues/10343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios issue #268: CB-11999 add message, catch exception if require fai...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/268 https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=commit;h=2cdb6074626cc4efc8ad117058c49d945ead0eb5 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-ios issue #268: CB-11999 add message, catch exception if require fai...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/268 Pulled in, but doesn't seem to have been mirrored on GH yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-android issue #341: CB-11999 add message, catch exception if require...

Github user shazron commented on the issue: https://github.com/apache/cordova-android/pull/341 LGTM. Whomever pulls this in, make sure to squash, amend the commit with the JIRA issue number --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-ios issue #268: CB-11999 add message, catch exception if require fai...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/268 LGTM. Whomever pulls this in, make sure to sqush, amend the commit with the JIRA issue number --- If your project is set up for it, you can reply to this email and have your reply appear

Re: [DISCUSS] cordova-common 1.5.1 release

+1 On Tue, Oct 11, 2016 at 4:33 PM, Steven Gill wrote: > Shaz found a bug causing cordova add platform ios (master) to fail. > https://github.com/apache/cordova-lib/pull/500 > > Fixed. Going to do a patch release for this. >

[GitHub] cordova-lib issue #500: CB-11998 - cordova platform add error with cordova-c...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/500 @RyanThomas73 thanks! Unfortunately I've already spent too much time on this one line fix, so I'm probably not going to re-visit it for now. --- If your project is set up for it, you can

[GitHub] cordova-lib pull request #500: CB-11998 - cordova platform add error with co...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/500 CB-11998 - cordova platform add error with cordova-common@1.5.0 ### Platforms affected All platforms. ### What does this PR do? Fixes "ENOENT: no such

[GitHub] cordova-cli issue #263: CB-11913 - Re-fix appveyor.yml to use specific node ...

Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/263 Now that I've got appveyor node versions "working", it reflects the node 6 failures on Travis. Now to get node 6 working (npm link shenanigans). --- If your project is set up for i

Re: camera plugin - target bigger than original picture

+1 but with caveats as I outlined in the PR. On Mon, Oct 10, 2016 at 10:16 AM, julio cesar sanchez < jcesarmob...@gmail.com> wrote: > I was the one who asked for the email as I think we should discuss it > before merging. > > I agree with Fares idea, if the height or width are greater than the >

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/238 This makes sense, but is a backwards incompatible change since the behaviour changes, and some may be using that behaviour. Either: 1. Increment the major version number

[GitHub] cordova-cli issue #262: CB-11976 - Add deprecated node version warning for 0...

Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/262 @stevengill yes, it should be `>=4.0.0` and remove the `engineStrict` key as well. I'll add it soon --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 @vladimir-kotikov good idea, I'll update it to >=4.0.0 since engineStrict is not used anymore in npm@3 -- and we should remove engineStrict anyways. This PR has moved to https://github.

[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...

GitHub user shazron reopened a pull request: https://github.com/apache/cordova-cli/pull/262 CB-11976 - Add deprecated node version warning for 0.x ### Platforms affected All. ### What does this PR do? Before running each command, it will check if the node

[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...

Github user shazron closed the pull request at: https://github.com/apache/cordova-cli/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-cli/pull/262 CB-11976 - Add deprecated node version warning for 0.x ### Platforms affected All. ### What does this PR do? Before running each command, it will check if the node

[GitHub] cordova-lib pull request #497: CB-11976 - Add deprecated node version warnin...

Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 Closing. Can't have an effective warn in here, moving to cordova-cli. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 We have to print the warning out in the getPlatformAPI method, somewhere before this line: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src

[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/265 @adzellman you'll have to close then re-open this PR to trigger Travis (yeah its flaky) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82491705 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn = findXCodeProjectIn; * @param

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82490970 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn = findXCodeProjectIn; * @param

[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 Making a change so it is shown on every command, not just `prepare` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios pull request #267: CB-11970 - Support CocoaPod pod specification...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/267 CB-11970 - Support CocoaPod pod specification other than version ### Platforms affected iOS ### What does this PR do? Add support for CocoaPod specs that are not just versions

[GitHub] cordova-ios pull request #266: CB-11729 - template file MainViewController.m...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/266 CB-11729 - template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation ### Platforms affected iOS ### What does this PR do? Remove

[GitHub] cordova-lib pull request #497: CB-11976 - Add deprecated node version warnin...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/497 CB-11976 - Add deprecated node version warning for 0.x ### Platforms affected All ### What does this PR do? Prints out a warning on `prepare` that you are using

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82344457 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -199,33 +220,54 @@ module.exports.findXCodeProjectIn = findXCodeProjectIn; * @param

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82344341 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -199,33 +220,54 @@ module.exports.findXCodeProjectIn = findXCodeProjectIn; * @param

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82344533 --- Diff: tests/spec/unit/build.spec.js --- @@ -0,0 +1,255 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

Re: [Vote] Cordova-common@1.5.0 Release

I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran npm test On Thu, Oct 6, 2016 at 10:04 PM, Steven Gill wrote: > Please review and vote on this

Re: Nightly build #169 for cordova has failed

cordova-cli test failing: > cordova@6.4.0-nightly.2016.10.6.4759c467 test /home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-cli > node node_modules/jasmine-node/bin/jasmine-node --captureExceptions --color spec .Error: Cannot find module 'dependency-ls' at

[GitHub] cordova-docs issue #648: CB-11936 - Add docs for the four new App Transport ...

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/648 Only pull in for *cordova-ios 4.3.0* release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios issue #264: CB-11936 - Support four new App Transport Security (...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/264 The tests are expected to fail. Depends on https://github.com/apache/cordova-lib/pull/496 cordova-common being pulled into this repo first. Once that is done, rebase, squash

[GitHub] cordova-lib issue #496: CB-11936 - Support four new App Transport Security (...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/496 This needs to go into the next cordova-common release, that will go into the cordova-ios platform, before cordova-ios 4.3.0 is released. --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request #496: CB-11936 - Support four new App Transport Sec...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/496 CB-11936 - Support four new App Transport Security (ATS) keys ### Platforms affected iOS ### What does this PR do? This PR is to support the feature in https://github.com

[GitHub] cordova-ios pull request #264: CB-11936 - Support four new App Transport Sec...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/264 CB-11936 - Support four new App Transport Security (ATS) keys *WORK IN PROGRESS*. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron

[GitHub] cordova-ios issue #262: CB-11957 - Update docs for remote/local notification...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/262 Merged https://github.com/apache/cordova-ios/commit/636113f047ee2c7dae742dff2beafae2121ceb62 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-ios pull request #262: CB-11957 - Update docs for remote/local notif...

Github user shazron closed the pull request at: https://github.com/apache/cordova-ios/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios issue #261: Print a warning if system ruby is not in use

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/261 Pulling this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-ios pull request #262: CB-11957 - Update docs for remote/local notif...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/262#discussion_r82043482 --- Diff: CordovaLib/Classes/Public/CDVPlugin.h --- @@ -44,6 +41,17 @@ extern NSString* const CDVViewWillLayoutSubviewsNotification; extern

[GitHub] cordova-ios issue #261: Print a warning if system ruby is not in use

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/261 Strange Travis CI failure. I can't see what's wrong. Can you close and re-open this PR to trigger a new build, perhaps its a one-off issue. --- If your project is set up for it, you can reply

[GitHub] cordova-ios pull request #262: CB-11957 - Update docs for remote/local notif...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/262 CB-11957 - Update docs for remote/local notifications removed in cordova-ios-4.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Thanks @dpogue, I'll do final tests and pull this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [Android] onPause and onResume in the background on WebViews

We could like you said make a breaking change, but allow a preference to be set. We either make the preference backwards compatible (ie KeepRunning = true) so existing apps still work the same on Cordova-Android 6, or break backwards compatibility with KeepRunning=false as default. I would

Re: Nightly build #167 for cordova has failed

We're waiting on cordova-app-hello-world to be published. Need 1 more vote! Please vote on that thread On Mon, Oct 3, 2016 at 7:52 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > Nightly build #167 for cordova has failed. > > Please check failure details on build details page at

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 @dpogue Ok, this should do it. Patch attached. [CB-11860.pre-build.clean.patch.zip](https://github.com/apache/cordova-ios/files/507552/CB-11860.pre-build.clean.patch.zip) --- If your

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 The only way I can get a consistent .ipa that has the `www` folder in it, is if we wipe the `platforms/ios/build/device` folder, will try that now. --- If your project is set up for it, you

<    2   3   4   5   6   7   8   9   10   11   >