[CORDOVA-LIB] CocoaPods CI testing stalled CB-11811

See: https://issues.apache.org/jira/browse/CB-11811 Does anyone have experience with CocoaPods testing on Travis CI? Keep getting git errors no matter what I do. Doesn't help that for each test it needs to download the whole CocoaPods repo at ~500MB

Re: [DISCUSS] Not requiring an iCLA for contributions

On Tue, Sep 13, 2016 at 10:36 AM, Joe Bowser <bows...@gmail.com> > wrote: > > > > > > > I'll agree to this, since I don't know what the definition of trivial > > is > > > > w.r.t. Apache. > > > > > > > > +1 > > > >

Re: [DISCUSS] Not requiring an iCLA for contributions

Bump. There can't be lazy consensus on this. Before I potentially waste time on drafting a proposal, trying to feel the temperature on this change. On Fri, Sep 9, 2016 at 3:34 PM, Shazron <shaz...@gmail.com> wrote: > It's up to us to decide, and right now we require the iCLA except for

Re: CB-9762 iOS Launch Storyboard update

We can either roll this in to cordova-ios 4.3.0 or cordova-ios 4.4.0. cordova-ios 4.3.0 has a new feature, CocoaPods support. On Sat, Sep 10, 2016 at 3:31 PM, Kerri Shotts wrote: > So, in playing around with my PR, I've discovered the following: > > - Travis CI fails

Re: CB-9762 iOS Launch Storyboard update

*outdated ;) On Sunday, September 11, 2016, Shazron <shaz...@gmail.com> wrote: > The docs are horribly updated. I think we were waiting on Apple to make > Xcode 7 required for submitting to the App Store, and they did that, and we > didn't notice. > > I don't consider t

[DISCUSS] Not requiring an iCLA for contributions

It's up to us to decide, and right now we require the iCLA except for trivial contributions. I want to change this to a more relaxed requirement: 1. Non-committers do not require an iCLA (you need one anyway to get an account, so that's really a non-issue) 2. Require a clear intent by the author

[GitHub] cordova-lib pull request #489: CB-11811 - Updated travis settings

GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/489 CB-11811 - Updated travis settings EXPERIMENTING. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-11811

[GitHub] cordova-ios issue #252: Add missing LD_RUNPATH_SEARCH_PATHS setting to the R...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/252 Hi, thanks for the PR. It seems that you erased the Issue Template without reading it. One of the requirements is that you create a JIRA issue and prefix the PR with the issue token, to enable

[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 @jonathanli2 Please update the prefix to the title of this PR from "CB:-9161" to "CB-9161". Any comments on this PR are not reflected in JIRA because

Re: [Discuss] Cordova-Android 6.0.x

Ask Crosswalk to: "To detach the fork and turn it into a standalone repository on GitHub, contact GitHub Support." From: https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile/ On Thu, Sep 8, 2016 at 2:46 PM, Joe Bowser wrote: > Hey > > So,

[GitHub] cordova-plugin-wkwebview-engine pull request #19: CB-11824 - Update tests to...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/19 CB-11824 - Update tests to include objective-c tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova

[GitHub] cordova-plugin-wkwebview-engine issue #17: Avoid retain cycle caused by WKUs...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Found it - CB-11818. Unfortunately I can't edit the issue title, can you please update it. Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-wkwebview-engine issue #17: Avoid retain cycle caused by WKUs...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Where's the JIRA issue? Prefix it to the title for automated tracking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: Nightly build #139 for cordova has failed

Probably a server glitch. -- Exception loading: /home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-cli/spec/cli.spec.js { [Error: Cannot find module 'cordova-lib'] code: 'MODULE_NOT_FOUND' } Error: Cannot find module 'cordova-lib' at Function.Module._resolveFilename

Re: Nightly build #137 for cordova has failed

See https://issues.apache.org/jira/browse/CB-11811 On Mon, Sep 5, 2016 at 7:53 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > Nightly build #137 for cordova has failed. > > Please check failure details on build details page at > https://builds.apache.org/job/cordova-nightly/137/

[GitHub] cordova-ios pull request #253: CB-11790 - Check that Cocoapods is installed ...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/253 CB-11790 - Check that Cocoapods is installed by checking `pod install` return code, show help text Re-factored code to be modular - Podfile and PodsJson are abstractions for the files

Re: [iOS] Feature change - updates in config.xml

Found it: https://github.com/apache/cordova-lib/blob/3654a11abc51ab3aead47a9c02ebc135424777b1/cordova-lib/src/cordova/util.js#L43 On Tue, Aug 30, 2016 at 7:24 PM, Shazron <shaz...@gmail.com> wrote: > Filed https://github.com/apache/cordova-ios/pull/246 > > I'm not sure if I shoul

Re: Nightly build #133 for cordova has succeeded!

See http://cordova.apache.org/contribute/nightly_builds.html These are not official releases, read the 'Notice' on that page for risks. On Thu, Sep 1, 2016 at 8:25 PM, Lance Hensley wrote: > How do I use this exactly? And I can't do it on a smartphone can I? > > On

Re: Error when processing doap file http://svn.apache.org/repos/asf/cordova/site/public/infra/doap_Cordova.rdf:

I'm on this. We moved it in the docs overhaul: https://github.com/apache/cordova-docs/search?utf8=%E2%9C%93=DOAP On Thu, Sep 1, 2016 at 3:33 AM, sebb wrote: > https://issues.apache.org/jira/browse/CB-11058 > > > -- Forwarded message -- > From: Projects

[GitHub] cordova-ios pull request #251: CB-11791 - 'pod install' should pass in the '...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/251 CB-11791 - 'pod install' should pass in the '--verbose' flag, if set You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios

[GitHub] cordova-ios pull request #249: CB-11789 - Generated Podfile should not have ...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/249 CB-11789 - Generated Podfile should not have an absolute path to .xcodeproj You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron

[GitHub] cordova-ios pull request #248: CB-11792 - Add Cocoapods .xcconfig includes t...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/248 CB-11792 - Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/246 Tests pass, squashing the commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/246 I am fixing the tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: [iOS] Feature change - updates in config.xml

Filed https://github.com/apache/cordova-ios/pull/246 I'm not sure if I should be hardcoding `cordova` in there. How do we dynamically get the CLI tool name? On Mon, Aug 29, 2016 at 1:57 AM, julio cesar sanchez <jcesarmob...@gmail.com > wrote: > +1 > > 2016-08-29 10:51 GMT+02:0

[GitHub] cordova-ios pull request #246: CB-11712 - changes in config.xml does ...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/246 CB-11712 - changes in config.xml does a 'search and replace all' for occurrences of the old name with the new name in the pbxproj The error message looks like this: ``` Error

Re: [iOS] Feature change - updates in config.xml

Due to lazy consensus, I will proceed with this change. On Thu, Aug 25, 2016 at 12:26 PM, Kerri Shotts <kerrisho...@gmail.com> wrote: > +1; totally fine with this. :-) > > ~ Kerri > > > On Aug 24, 2016, at 20:30, Shazron <shaz...@gmail.com> wrote: >

Nightly builds - npm publish issue

See: https://issues.apache.org/jira/browse/CB-11778 Long story short -- we need to use node 6.x to publish the npm nightlies. I know the nightly CI uses coho, is it a matter of just updating coho code and the CI picks it up, or do we have to do something else?

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 Filed https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-wkwebview-engine pull request #16: CB-11554 - too 'brutal' ap...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16 CB-11554 - too 'brutal' app reload when title is empty You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova

[GitHub] cordova-plugin-media issue #114: CB-11380 (ios) Overloaded audioFileForResou...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/114 LGTM 👍 Tested locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: cordova-plugin-media git commit: CB-11380 (ios) Updated modified method signature in the .h file

I think we should add an overload and add back the old API method, since this is effectively removing API and we don't want the hassle of a major version bump. On Friday, August 26, 2016, wrote: > Repository: cordova-plugin-media > Updated Branches: > refs/heads/master

Re: [VOTE] Cordova-create@1.0.0 release

I vote +1 * Verified archives using coho verify-archive * Ran coho check-license * Ensured tests are passing On Tue, Aug 23, 2016 at 5:03 PM, Steven Gill wrote: > Please review and vote on this cordova-create Release > by replying to this email (and keep discussion on

[GitHub] cordova-plugin-media issue #112: CB-11380 (ios) Fixed an unexpected error ca...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/112 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[iOS] Feature change - updates in config.xml

More details and discussion in: https://issues.apache.org/jira/browse/CB-11712 In brief, the proposed change is: changes in config.xml will not be allowed, and cordova will print an error, with instructions on what to do instead. The instructions will tell the user to do a `cordova platform rm

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 @briananderson1222 this is a separate feature. currently we don't offer granularity for the fallback. could you file an issue at issues.cordova.io ? Thanks! --- If your

[PULL REQUESTS] Platforms 24-08-2016

cordova-android --> 21 Pull Requests cordova-amazon-fireos --> 4 Pull Requests cordova-ios --> 4 Pull Requests cordova-windows --> 3 Pull Requests cordova-ubuntu --> 3 Pull Requests cordova-osx --> 1 Pull Requests cordova-wp8 --> 1 Pull Requests cordova-browser --> 1 Pull Requests cordova-tizen

[PULL REQUESTS] Plugins 24-08-2016

cordova-plugin-inappbrowser --> 30 Pull Requests cordova-plugin-camera --> 30 Pull Requests cordova-plugin-media --> 26 Pull Requests cordova-plugin-dialogs --> 18 Pull Requests cordova-plugin-file --> 18 Pull Requests cordova-plugin-splashscreen --> 15 Pull Requests cordova-plugin-contacts --> 15

[COHO] Pull request stats helper

As Steve has said, unfortunately our focus lately has been on platforms, not plugins. To help bring to light our PR workload, I worked on a feature to show PR stats in coho. See: See: https://github.com/apache/cordova-coho/pull/134 Typical usage: coho list-pulls --repo=plugins --stats-only

Re: CB-9963 iOS uuid should remain even after uninstall

>>> good idea, but not sure if we should add it to the device plugin or > if > > >> the > > >>> developer should use a keychain plugin to store the device.uuid value > > if > > >> we > > >>> wants to get always the same value, maybe some develope

Re: Can't visit the issues.apache.org

No idea. Try filing an INFRA issue: http://issues.apache.org/jira/browse/INFRA On Wed, Aug 24, 2016 at 12:40 AM, Zam Light wrote: > i had been visit the website: *issues.apache.org/jira > *once, > but, i can't visit it anymore. always

Re: Granting permission to Assign Improvement

Done On Tue, Aug 23, 2016 at 12:21 PM, sanjeewa kumara wrote: > Hi, > > Currently I am fixing CB-11085. can someone assign me to it? > > https://issues.apache.org/jira/browse/CB-11085 > > - > To

Re: How to run a unit test for a plugin

e, Aug 23, 2016 at 12:23 PM, Shazron <shaz...@gmail.com> wrote: > > A slower way would be to send the pull request and let the CI test it i.e > > https://github.com/apache/cordova-plugin-dialogs/pull/82 > > > > On Mon, Aug 22, 2016 at 11:50 PM, Shazron <shaz...@gma

Re: CB-9963 iOS uuid should remain even after uninstall

Done. On Tue, Aug 23, 2016 at 10:15 AM, Zam Light wrote: > Hi: > > i want to solve this issue with below link, could someone assign me to it? > > https://issues.apache.org/jira/browse/CB-9963?focusedCommentId=15432832; >

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/228 This PR needs to be re-based. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: How to run a unit test for a plugin

Install cordova-paramedic from its repo url or npmjs. See https://github.com/apache/cordova-paramedic In the root of the plugin folder: cordova-paramedic --plugin . --platform windows On Mon, Aug 22, 2016 at 11:36 PM, Deshan Kalupahana < deshankalupah...@gmail.com> wrote: > Hi, > > I'm

Re: How to run a unit test for a plugin

A slower way would be to send the pull request and let the CI test it i.e https://github.com/apache/cordova-plugin-dialogs/pull/82 On Mon, Aug 22, 2016 at 11:50 PM, Shazron <shaz...@gmail.com> wrote: > Install cordova-paramedic from its repo url or npmjs. See > https://github.com/ap

[GitHub] cordova-docs issue #630: Added android ios release blog post

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/630 For ios, we need to add the note like in cordova-ios 4.2.0: https://cordova.apache.org/announcements/2016/06/23/ios-4.2.0.html --- If your project is set up for it, you can reply

[STATS] for Cordova

We have 60 cordova repos (not all active), of that 25 are plugins (almost half). There are 554 Git repos in Apache, and we make up 10.8% of them. We have 85 committers. Lately these past few months, there has been a low amount of committers that are actively committing code (I would guess, less

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/241 Tested locally (passes - Travis CI had a hiccup with the simulator, above) and did a code review, looks good to me. Can you create a new docs PR for the new setting? It should

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Hi, Some issues I've encountered, pre-testing: 1. Can you prefix the issue with CB-10109 so it can be automatically tracked by the apache bots to https

[GitHub] cordova-android pull request #325: CB-11727 - travis ci setup is still using...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-android/pull/325 CB-11727 - travis ci setup is still using 0.10.32 node You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-android CB

[GitHub] cordova-android pull request #324: CB-11726 - Update appveyor node versions ...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-android/pull/324 CB-11726 - Update appveyor node versions to 4 and 6, so they will always use the latest versions You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-ios pull request #243: CB-11725 - Update appveyor node versions to 4...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/243 CB-11725 - Update appveyor node versions to 4 and 6, so they will always use the latest versions You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-lib pull request #483: CB-11724 - Tests on appveyor are not using di...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/483 CB-11724 - Tests on appveyor are not using different versions of node You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib

[GitHub] cordova-lib issue #481: CB-9825 - framework tag spec parsing

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/481 The 0.10 and 0.12 errors were from using String.includes, which can only be used in ES6, and that feature is only supported in node >= 4, changed to using String.indexOf instead. Wh

[GitHub] cordova-lib issue #481: CB-9825 - framework tag spec parsing

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/481 As expected, failures on 0.10 and 0.12 node, which I will try to fix: ``` Failures: 1) cocoapod plugin add and rm end-to-end installs and uninstalls plugin depending on new pod

[GitHub] cordova-lib pull request #482: CB-11723 - Tests on Travis are not using the ...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/482 CB-11723 - Tests on Travis are not using the latest 4.x and 6.x versions of node You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron

[GitHub] cordova-lib issue #467: CB-9825: tests for cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/467 Filed https://github.com/apache/cordova-lib/pull/481, this PR can be closed. I'll take any comments and apply it to the new PR. --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request #481: CB-9825 framework tag spec parsing

GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/481 CB-9825 framework tag spec parsing Squashed PR from https://github.com/apache/cordova-lib/pull/467 and will add my fixes on top of it. You can merge this pull request into a Git repository

[DOCS] Contribution ideas

I kinda like how the WebKit nightly looks: https://webkit.org/nightly/start/trunk/204581/ Some good ideas there for our contrib docs, which currently look like this: http://cordova.apache.org/contribute/ Screenshot: ​ webkit-nightly-contrib.png

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/241 I get what you are saying now, you want the "fallback" webview-engine to be your plugin. I'll review this PR soon with that in mind. --- If your project is set up for it, you

[GitHub] cordova-coho pull request #130: CB-11646 version arg optional, will grab fro...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/130#discussion_r75238878 --- Diff: src/platform-release.js --- @@ -131,6 +140,7 @@ exports.prepareReleaseBranchCommand = function*() { var repos

[GitHub] cordova-coho pull request #129: CB-11642 Update CDVAvailability.h

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/129#discussion_r75238702 --- Diff: src/platform-release.js --- @@ -162,6 +164,30 @@ exports.prepareReleaseBranchCommand = function*() { yield

Re: Carlos MIA

Hey Carlos, Appreciate your contributions to the community! Sorry to see you going away... I'm sure you'll be back, a commit here and there, a PMC vote maybe. However, when you're in Cordova, you are in for life, sorry! :P (the commit bit will always be there, I don't think we have ever removed

[COHO] check-license helper

Right now when you run `coho check-license` you might get a list of potentially incompatible packages (make sure you run it on a repo with just bundled dependencies, not dev dependencies -- we don't need to check the license on devDeps). Previously you would have to manually verify the license on

[GitHub] cordova-coho pull request #132: CB-11718 - check-license -- create a knownIs...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-coho/pull/132 CB-11718 - check-license -- create a knownIssues.json for packages that have licenses that have been manually verified Helper when you get a report for packages with unknown licenses

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/237 @dpogue Please send a PR for a docs update as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-coho pull request #131: CB-11717 - Include Unlicense as a valid lice...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-coho/pull/131 CB-11717 - Include Unlicense as a valid license in validLicenses.json Rationale: https://issues.apache.org/jira/browse/CB-11717 You can merge this pull request into a Git repository

Re: [VOTE] cordova-ios@4.2.1 release (attempt 2)

I vote +1 - verified archives using coho verify-archive - ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses, manually verified licenses when applicable - ran coho audit-license-headers over the relevant repos - ran npm test, all green - created

[GitHub] cordova-ios pull request #242: CB-11703 - travis ci setup is still using 0.1...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/242 CB-11703 - travis ci setup is still using 0.10.32 node You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-11703

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/241 I think you misunderstand that part of the code. You can already swap the default webview engine. It will use the setting "CordovaWebViewEngine" as you can see below the code you ar

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/237 cordova-common 1.4.1 has been bundled in master, and this PR now fails one unit-test (`npm run unit-tests`: ``` Failures: 1) prepare updateProject method should write out

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Thanks for this! I just merged #13, so can you rebase? I'll review after that is done. Note that the CI auto builds your PR, and it has jshint errors: https://travis

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Interesting node quirk. I think I figured out the problem with this line: https://github.com/apache/cordova-ios/pull/234/files#diff-4dd01b7c4b3f825b9b9e6f223a83ec71R97 in node 0.10

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/237 https://github.com/apache/cordova-lib/pull/466 has been merged and should be in cordova-common 1.4.1 when it is released. --- If your project is set up for it, you can reply to this email

Re: [NODE] Can we drop node 0.x support?

Also node.js 6.3.0 now supports the --inspect option, which means we can debug cordova using Chrome Dev Tools: https://mobile.twitter.com/nodejs/status/763782055788445696 (although the flag is deemed "experimental") On Mon, Aug 15, 2016 at 1:30 AM, Shazron <shaz...@gmail.com> wr

[GitHub] cordova-plugin-wkwebview-engine issue #7: Fixes CB-11074: WKWebView configur...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7 Please provide feedback on #13, I will be pulling that in soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-wkwebview-engine issue #8: CB-11074: Ensure settings from con...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8 Please provide feedback on #13, I will be pulling that in soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

Re: [NODE] Can we drop node 0.x support?

Sorry, I meant to say Node 7 will be "current" in Oct 2016, this year -- not 2017. On Mon, Aug 15, 2016 at 1:29 AM, Shazron <shaz...@gmail.com> wrote: > Our docs just specify "Download and install Node.js" which points to the > LTS version 4.4.7 at https://node

Re: [NODE] Can we drop node 0.x support?

; Kerri > > > > > > > > > > > > > > > > On Fri, Aug 12, 2016 at 8:18 PM -0500, "Jesse" < > > purplecabb...@gmail.com> > > > > wrote: > > > > > > > > > > > > > > > > > >

[NODE] Can we drop node 0.x support?

cordova-lib engine says we still do support 0.x: https://github.com/apache/cordova-lib/blob/2a178662acfad9c779114fddd815e484fc1b6f1d/cordova-lib/package.json#L16 Can we drop support? Seems time. See: https://twitter.com/feross/status/763548182416494593 "Node v0.10 will be completely UNSUPPORTED

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 LGTM! Congrats on landing your first feature into Cordova @juliascript ! (note the CI failures are for node 0.1x.x which I think we can safely say we won't support anymore) --- If your

[GitHub] cordova-lib issue #467: CB-9825: tests for cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/467 Also, node 0.1x will be completely unsupported in 50 days: https://twitter.com/feross/status/763548182416494593 (re: https://github.com/apache/cordova-lib/pull/467#issuecomment-236813577

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 1 unit-test failure: ``` Failures: 1) unit tests for pod module tear down encountered a declaration exception Message: Error: ENOENT: no such file or directory

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Recapping our chat: 5 unit test failures: ``` Failures: 1) installPodSync throws cordova error when no pod name provided Message: Error: ENOENT

[GitHub] cordova-ios pull request #240: CB-11528 - Remove verbose mode from xcrun in ...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/240 CB-11528 - Remove verbose mode from xcrun in build.js to prevent logg… …ing of environment variables. You can merge this pull request into a Git repository by running: $ git pull

Re: [Android] What is Cordova Plugin Fake, and why is it missing a gradle file?

This was not caught by CI because the e2e tests (under script 'test-build) is not part of `npm test`. My guess is the file was inadvertently not checked in to git thus the test failure. On Wed, Aug 10, 2016 at 11:39 AM, Joe Bowser wrote: > Hey > > I just noticed that travis

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Sadly Jasmine 1.x doesn't have an `afterAll` global function unlike Jasmine 2.x. You would have to nest the `describe` tests in a `describe`, sandwiched between two `it`s, the first

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 The `podMod.spec.js` tests should have a “cleanup” after all tests are run (not sure how in Jasmine 1.0) which should remove the test products `tests/spec/unit/fixtures/testProj/platforms

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Upon further review - the Podfile should not be added. The unit tests actually show the problem -- the Podfile was not created. The `spyOn` for `writeFileSync` in the tests should have

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Tests fail. I cloned cordova-ios, applied the PR patch, npm install then npm test. Perhaps you forgot to check in `tests/spec/unit/fixtures/testProj/platforms/ios/Podfile`? Log

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r73970701 --- Diff: tests/spec/unit/podMod.spec.js --- @@ -0,0 +1,107 @@ +var fs = require('fs'), + path = require('path'), + cordova = require

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r73970418 --- Diff: bin/templates/scripts/cordova/lib/podMod.js --- @@ -0,0 +1,162 @@ +var fs = require('fs'), +path = require('path'), +util

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r73966499 --- Diff: tests/spec/unit/podMod.spec.js --- @@ -0,0 +1,107 @@ +var fs = require('fs'), + path = require('path'), + cordova = require

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Can't run the tests, I get: ``` Exception loading: /Users/shazron/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js { Error: Cannot find module '/Users/shazron/Desktop/cordova-lib

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Looking at this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[iOS/macOS 10] Updates to CSP support

"The latest WebKit builds and Safari Technology Preview now support all of the features of the Content Security Policy Level 2 standard , including hashes for script and style elements." -

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 @mccraigmccraig please comment on my proposed modifications (see the comment about the unit tests) in https://issues.apache.org/jira/browse/CB-11554 --- If your project

[GitHub] cordova-plugin-wkwebview-engine issue #7: Fixes CB-11074: WKWebView configur...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7 Please see #13, and let's continue discussion there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

<    4   5   6   7   8   9   10   11   12   13   >