Dear Cordova developers and maintainers,
This is ECNU3D from GitHub. I want to propose a potential improvement for
the CDVCommandDelegateImpl.m. I filed a Github issue here:
https://github.com/apache/cordova-ios/issues/452
My primary concern is that currently Cordova doesn't have any control abou
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-docs/pull/721
CB-13195 Source Code link in footer on cordova.apache.org needs updated
### Platforms affected
N/A
### What does this PR do?
Fix the "Source Code" link in footer
Github user tony-- commented on the issue:
https://github.com/apache/cordova-docs/pull/718
Thanks for the help and the sentiment Shaz! Much appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-docs/pull/718
CB-13159: Remove Intel XDK from homepage
### Platforms affected
N/A
### What does this PR do?
Remove Intel XDK from the tools section of the homepage.
### What testing
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/323#discussion_r75392931
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -93,10 +102,24 @@ GradleBuilder.prototype.prepBuildFiles = function
Github user tony-- commented on the issue:
https://github.com/apache/cordova-android/pull/323
Just checking my understanding...
1. checkAndCopy only copies when the subProject does not have a build.gradle
2. insertExclude ensures that there is only one reference to
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/323#discussion_r75389738
--- Diff: bin/templates/cordova/lib/plugin-build.gradle ---
@@ -21,24 +21,15 @@
buildscript {
repositories {
mavenCentral
Github user tony-- commented on the issue:
https://github.com/apache/cordova-ios/pull/232
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/232#discussion_r73512970
--- Diff: tests/CordovaLibTests/CDVWhitelistTests.m ---
@@ -295,6 +295,37 @@ - (void)testAllowIntentsAndNavigations
XCTAssertEqual
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/232#discussion_r73512881
--- Diff:
CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m
---
@@ -95,23 +95,33
Github user tony-- commented on the issue:
https://github.com/apache/cordova-ios/pull/232
I ran the tests - they passed.
I wrote a manual test with an index.html that has a javascript tel: link
and an iframe with the same javascript tel: link. The index.html tel:link
works
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/232#discussion_r73358461
--- Diff:
CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m
---
@@ -95,23 +95,33
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/232#discussion_r73358362
--- Diff: tests/CordovaLibTests/CDVWhitelistTests.m ---
@@ -295,6 +295,37 @@ - (void)testAllowIntentsAndNavigations
XCTAssertEqual
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/232#discussion_r73356143
--- Diff:
CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m
---
@@ -95,23 +95,33
this on as a learning exercise.
Tony
On 5/25/16, 5:50 PM, "Joe Bowser" wrote:
>On Wed, May 25, 2016 at 1:47 PM, Homer, Tony wrote:
>
>> +1
>>
>> Would like #307 to be merged in first
>>
>>
>Done! Yay for tests!
>
>BTW, We need to re-write th
+1
Would like #307 to be merged in first
On 5/25/16, 3:31 PM, "Carlos Santana" wrote:
>+1
>
>- Carlos
>@csantanapr
>
>> On May 25, 2016, at 3:08 PM, Shazron wrote:
>>
>> +1
>>
>> Release often
>>
>>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser wrote:
>>>
>>> Hey
>>>
>>> I know that we
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-android/pull/307#issuecomment-221693379
AppVeyor timed out, not a failure related to the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-android/pull/307
CB-11292 fix broken MessageChannel after plugins are recreated
also added a new test to prevent regression - probably overkill but the
issue was hard to isolate
You can merge this pull
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-android/pull/306
CB-10096: Upgrade test project to Gradle Plugin 2.1.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tony--/cordova-android CB-10096
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218277348
There are a couple places that contributor workflow is documented:
The wiki has a [contributor workflow
page](https://wiki.apache.org/cordova
The proposal is to create a new core plugin that enables the user to
dynamically control the orientation of their app.
This plugin would be based on the W3C screen-orientation spec [1].
This was originally proposed via CB-9528 [2] (which currently has 10 votes and
16 watchers, indicating strong c
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-docs/pull/586
added CVE announcement blog post
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tony--/cordova-docs blog-post-27April2016
Alternatively
CVE-2015-5207 - Bypass of Access Restrictions in Apache Cordova iOS
Severity:
High
Vendor:
The Apache Software Foundation
Versions Affected:
cordova-ios 3.9.1 and below
Description:
Apache Cordova iOS contains 2 methods to bypass the URL access
restrictions provided by the whitelist. An attacke
CVE-2015-5208 - Arbitrary plugin execution issue in Apache Cordova iOS
Severity:
High
Vendor:
The Apache Software Foundation
Versions Affected:
cordova-ios 3.9.1 and below
Description:
An arbitrary plugin can be executed when a user clicks on a link.
Upgrade path:
Developers who are concerned
CVE-2015-5207 - Bypass of Access Restrictions in Apache Cordova iOS
Severity: High
Vendor: The Apache Software Foundation
Versions Affected:cordova-ios 3.9.1 and below
Description:Apache Cordova iOS contains 2 methods to bypass the URL access
restrictions provided by the whitelist. An attacker can
los
>> > > @csantanapr
>> > >
>> > > > On Apr 15, 2016, at 4:13 PM, Simon MacDonald <
>> > simon.macdon...@gmail.com>
>> > > wrote:
>> > > >
>> > > > I decided not to go as ApacheCon is sandwiched between two
ar there is one Cordova session on the schedule (Advanced Apache Cordova
- Hazem Saleh, IBM[1]).
It would be nice to meet up again this year.
[1]http://apachecon2016.sched.org/event/6OIr/advanced-apache-cordova-hazem-saleh-ibm
Tony
On 1/20/16, 1:48 AM, "Simon MacDonald" wrote:
>
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-ios/pull/216
CB-6992 Fix non-working create case, add new test
Added name normalization from prepare to createProject in order to support
the case where the user edits name in config.xml, then adds ios
Rancher and Crypt of the NecroDancer.
All pretty hardcore stuff, amirite? ;)
Not Steam, but I'm looking forward to picking up Twilight Princess HD for WiiU
tomorrow!
Tony
On 3/3/16, 1:41 AM, "Steven Gill" wrote:
>Welcome Jerroyd!
>
>Make sure to join us on slack! Sign
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53677145
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
var
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53622685
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
var
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/395#issuecomment-186428877
@bso-intel will you take a look, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/395#issuecomment-186425912
I'd like to see this get fixed, so I thought I'd submit a PR, but I'm a
node noob - this definitely needs to be reviewed before being merged in.
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-lib/pull/395
CB-10654 make hooks fire when platforms added from repo or dir
move `hooksRunner.fire('before_platform_'...) ` till after platform has
been resolved, pass resolved platform instead
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183488008
Thanks! I cherry-picked it into a fork; we'll let you know if it worked
for us ASAP.
---
If your project is set up for it, you can reply to this
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183376049
@jcesarmobile - thanks for explaining `presentAlertcontroller,` I see it
now.
Thanks in advance for the phonegap-plugin-barcodescanner PR!
---
If
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183153364
@jcesarmobile - With regard to
phonegap-plugin-barcodescanner+cordova-plugin-dialogs, I was chatting with
@imaffett about this. He found that reverting
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180593938
+1 this fixed the tests for me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
It took me a while to find it, but I guess you mean CB-10455?
On 2/5/16, 7:56 AM, "julio cesar sanchez" wrote:
>I think we just forgot, somebody mentioned this on slack and there is an
>issue open on JIRA.
>
>2016-02-05 13:52 GMT+01:00 Homer, Tony :
>
>> Earlier
I couldn't find any other discussion about this on the list and wondered why it
was retained for media.
Was this an oversight?
Thanks!
Tony
On 1/15/16, 4:40 PM, "Simon MacDonald" wrote:
>LGTM
>
>+1
>
>Simon Mac Donald
>http://hi.im/simonmacdonald
>
>On Fri,
Added.
On 1/31/16, 7:43 PM, "seank@gmail.com on behalf of Sean Kelly"
wrote:
>I don't appear to have the permissions to update labels in JIRA
>
>could someone add the following labels to CB-7786?
>
>cordova inappbrowser android
>
>Thanks,
>
>Sean
sts and the
>> original intent of this test was lost.
>>
>> So, yeah, this should have an intent provided to it, and this test should
>> fail. The tests definitely need to be looked at again and their usefulness
>> re-evaluated.
>>
>> On Fri, Jan 29, 2016
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-android/pull/256
fix HtmlNotFoundTest so that it passes when file not found is handled
correctly
override displayError in testActivity to send message to queue (dialogs are
not very useful in tests
HtmlNotFoundTest fails for me too.
Is it a problem that the CordovaActivity displays an error dialog?
If it is, we could override displayError in MainTestActivity.
Maybe it's simpler than that - should the test be setting an errorUrl and then
asserting that the errorUrl has been loaded?
If no er
Pretty exciting! Definitely seems like it would be cleaner.
Do you think this would be a new bridge mode?
I spent a couple minutes trying to find an example of how to use this, but
didn't come up with anything outside of the docs.
Looks like the relevant classes are WebMessage, WebMessagePort an
According to this gist[1], which is based on data from here[2], it is iPad6,7
for iPad Pro (WiFi) and iPad6,8 for iPad Pro (Cellular).
[1] https://gist.github.com/Jaybles/1323251
[2] https://www.theiphonewiki.com/wiki/Models
On 1/4/16, 6:25 PM, "Sergio Nader da Cunha Sardo"
wrote:
>ONe mor
Hi Sean,
FTFY: "ADD CAL 12-28-1999 Go all in on pets.com, retire in 2001!"
WML/HDML, so last century!
I didn't do anything with email APIs, but I worked on a project where we sent
turn-by-turn directions as WBMPs for Blackberry pagers.
Welcome to the list!
Tony
On 12
+1
Confirmed sigs & hashes with `coho verify-archive`
Verified hash matches tag with `coho verify-tags`
Re-created archive with `coho create-archive`, verified contents match release
candidate
Created app w/ `cordova platform add
https://github.com/apache/cordova-ios#4.0.1`
Ran on device and
I see the same thing as Carlos - version is still 4.0.0 in some places.
[~]$ cordova create ios401test
Creating a new cordova project.
[~]$ cd ios401test/
[~/ios401test]$ cordova platform add
https://git-wip-us.apache.org/repos/asf/cordova-ios.git#4.0.1
git cloning: https://git-wip-us.apache.org/
LGTM
On 12/10/15, 7:43 PM, "Shazron" wrote:
>Please comment and review:
>https://github.com/apache/cordova-docs/pull/439
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>For additional commands, e-mail: dev-h
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/354#issuecomment-163404133
Ok, thanks. Closing this as an incorrect fix and CB-9311 is being
addressed by
[apache/cordova-ios#182](https://github.com/apache/cordova-ios/pull/182).
---
If
Github user tony-- closed the pull request at:
https://github.com/apache/cordova-lib/pull/354
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/354#issuecomment-163396804
Right, I wasn't thinking about that - thanks @shazron. So... is this code
here for backwards compatibility? Or it just hasn't been removed yet? Sorr
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-ios/pull/182#issuecomment-163395756
If it's not too late, consider updating the URL to:
https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-lib/pull/354
CB-9311 Add support for 87x87 icon, fix reference url
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tony--/cordova-lib CB-9311
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-docs/pull/393
updated Intel XDK image
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tony--/cordova-docs update-tool-intel-xdk
Alternatively you can
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/322#issuecomment-148547339
[JIRA issue CB-9813](https://issues.apache.org/jira/browse/CB-9813)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tony-- closed the pull request at:
https://github.com/apache/cordova-docs/pull/373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-docs/pull/373
Added Intel XDK to tools list
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tony--/cordova-docs add-tool-intel-xdk
Alternatively you
I think this would be a great way to spur discussion about shared concerns.
It would be great if we could identify some opportunities to make changes
that would be beneficial for downstream distributors.
I can certainly provide a quick survey of what we do in Intel XDK.
Tony
On 10/2/15, 4:36
rds compatibility?
Tony
On 9/23/15, 1:56 PM, "Joe Bowser" wrote:
>On Wed, Sep 23, 2015 at 9:36 AM, Carlos Santana
>wrote:
>
>> No need to major version change for the Plugins, the API of the didn't
>> change.
>> Web developer still uses the same JS API
could get more
details about it.
I think he has already joined, so hopefully he will get this message and
respond :)
Tony
On 8/25/15, 7:48 PM, "Jesse" wrote:
>Should we do all 3, and make the middle day the 'big' one?
>
>
>My team is hiring!
>@purplecabbage
>
I do not know anyone from Meteor, but I did a little searching through the
repo to try to find someone who might be a good point of contact for this
topic. Slava Kim had a lot of Cordova-related commits and according to
his resume, he led Cordova integration for Meteor. I sent an email to the
add
o list one.
>
>-Steve
>
>On Thu, Aug 13, 2015 at 5:40 AM, Homer, Tony wrote:
>
>> I'm trying to validate the tools release.
>> I'm following the instructions[1], but I haven't used coho before and am
>> not sure about the results.
>>
>>
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Verified sha1s match tags with `coho verify-tags`
* Confirmed sigs & hashes with `coho verify-archive`
* Created mobilespec v
I added a comment to the PR (nit + questions about pinned versions).
Otherwise LGTM.
On 8/13/15, 2:11 AM, "Steven Gill" wrote:
>Please review. https://github.com/cordova/apache-blog-posts/pull/43
-
To unsubscribe, e-mail: dev-
I'm trying to validate the tools release.
I'm following the instructions[1], but I haven't used coho before and am not
sure about the results.
`coho audit-license-headers -r js -r lib -r cli -r plugman`
The doc warns that audit-license-headers has false positives, so I'm ignoring
the following r
I'm trying to validate the release.
I'm following the instructions[1], but I haven't used coho before and am
not sure about the results.
`coho audit-license-headers -r js -r lib -r cli -r plugman`
The doc warns that audit-license-headers has false positives, so I'm
ignoring results like:
./appveyo
I guess there is not much point to 1.1.0 until cordova-ios 4.0.0 is
released...
Is latest intentionally set to 1.0.0 as a way to avoid CB-9163 [1]?
[1] https://issues.apache.org/jira/browse/CB-9163
On 8/10/15, 2:03 PM, "Homer, Tony" wrote:
>TL;DR:
>It seems that either th
TL;DR:
It seems that either the cordova-plugin-whitelist ref in
cordova-app-hello-world is wrong
-OR-
the wrong version of cordova-app-hello-world is marked latest in npm.
I think it's the latter.
I wanted to test some details of whitelist plugin behavior on iOS.
I was expected to be able to sta
This was published to NPM, but there was never a blog post announcing the
update.
I guess this was just an oversight?
Tony
On 7/10/15, 8:51 PM, "Nikhil Khandelwal" wrote:
>This vote has passed. Thanks! The release has been published to:
>
>https://dist.apache.org/repos/d
Nikhil-
I'd like to get this PR merged in for 4.1.0:
https://github.com/apache/cordova-android/pull/182
I'll try to get it merged in today.
Tony
On 7/17/15, 12:49 PM, "Nikhil Khandelwal" wrote:
>I can take this up. Thanks! Look out for the VOTE thread s
Great, looks much better now - thanks Murat!
Can you shed some light on why this happened (and if it might happen
again)?
If the data is stale, it will hamper discovery of newly published plugins.
Thanks!
Tony
On 7/13/15, 5:43 PM, "Murat Sutunc" wrote:
>Ok, we've managed to
That's true, but that doesn't account for the difference in the size of
the result set.
The query to both npmsearch.com and npmjs.com/search is
"ecosystem:cordova".
Tony
On 7/10/15, 2:26 PM, "Jesse" wrote:
>The 370 results include lots of non-plugins.
>
&
dova
Thanks!
Tony
On 7/10/15, 1:32 PM, "Jesse" wrote:
>Sorting/filtering would be nice.
>Resist the urge to duplicate the data shown on npm!
>
>
>My team is hiring!
>@purplecabbage
>risingj.com
>
>On Fri, Jul 10, 2015 at 10:30 AM, Murat Sutunc
>wrote:
>
plugins.cordova.io is back up.
On 7/7/15, 10:07 AM, "Homer, Tony" wrote:
>Anyone know who can investigate and fix?
>
>
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>For add
Anyone know who can investigate and fix?
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/242#issuecomment-112557560
Merged commit
[2598231](https://github.com/tony--/cordova-lib/commit/25982317b26c831dbea9d6b71dd57a90b933fc68)
into apache:master, closing.
---
If your project is
Github user tony-- closed the pull request at:
https://github.com/apache/cordova-lib/pull/242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/242#issuecomment-112480771
AND I screwed up my first commit comment by prepending the word "fix"
before the JIRA issue. I will adhere to the formatting guidelines in the
future
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/242#issuecomment-112409200
Thanks @purplecabbage!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-android/pull/182#issuecomment-111531613
thanks for the feedback - addressed nits in ammended commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-android/pull/182
CB-9149: Make gradle alias subprojects in order to handle libs that dâ¦
â¦epend on libs
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-lib/pull/242
fix CB-9145 prepare can lose data during config munge
I added a test that adds access tags as described in CB-9145. This test
fails when run against master.
This is because the current
Sorry, don¹t see a DISCUSS thread and don¹t want to clutter the VOTE
thread.
Please let me know if starting a DISCUSS thread to ask a question is the
wrong way to go.
Shouldn¹t the pinned Android in Tools Release June 4th be bumped to ~4.0.2?
Currently it is ~4.0.1:
https://github.com/apache/cordo
In March, Shazron mentioned a tentative April release[1]. Can we get an
updated estimate?
Are there tasks that need help before it can move forward?
[1]
https://shazronatadobe.wordpress.com/2015/03/03/wkwebview-and-apache-cordov
a/
Thanks!
Tony
Nice job Steve!
Submitted a PR with some minor edits and a couple questions/comments:
https://github.com/cordova/apache-blog-posts/pull/37
On 4/16/15, 1:33 AM, "Steven Gill" wrote:
>Please review and send PRs.
>
>https://github.com/cordova/apache-blog-posts/blob/master/2015-04-15-plugin
>s-r
.
That being said, just to be friendly, you could get around it in the very
short term by cloning the github repo.
Then you could add the plugin from your local file system copy.
Tony
P.S. /usr/bin - very cute.
On 4/15/15, 8:42 PM, "Bin Wang" wrote:
>Hey there,
>
>I am trying
First, thanks for sharing this!
Second, I tried to download so I could read offline, but I guess the
permissions don¹t allow it? It seemed to silently fail. If that is
intended, no problem.
Thanks again, reading online now.
Tony
On 4/13/15, 4:58 PM, "Jesse" wrote:
>And I almo
Dmitry-
Thanks for the extra effort!
I¹m traveling next week and won¹t have very much time, so I¹ll just assign
one to myself for now and watch the others.
Tony
On 4/10/15, 7:49 PM, "Dmitry Blotsky" wrote:
>Hi all,
>
>I've compiled a list of JIRAs to address the
I have more of a general topic - cordova-windows vs. cordova-wp8 in the
docs.
Hopefully most of us on the list understand the distinction, but there is
still a lot of confusion.
There are some places where the docs could help make the distinction a bit
clearer.
For example, in the plugin developme
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-android/pull/173#issuecomment-91084720
Whoops, forgot to remove LifeCyclePluginTestActivity from the manifest.
Thanks for catching it!
---
If your project is set up for it, you can reply to this
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-android/pull/173#issuecomment-91052668
I think I made changes that address all of your comments. Thanks for the
feedback.
---
If your project is set up for it, you can reply to this email and have
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/173#discussion_r28019036
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -95,6 +95,9 @@ Licensed to the Apache Software Foundation (ASF) under one
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/173#discussion_r28018642
--- Diff:
test/androidTest/src/org/apache/cordova/test/CordovaPluginTest.java ---
@@ -0,0 +1,126 @@
+
+package org.apache.cordova.test
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/173#discussion_r28010484
--- Diff:
test/androidTest/src/org/apache/cordova/test/CordovaPluginTest.java ---
@@ -0,0 +1,126 @@
+
+package org.apache.cordova.test
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/173#discussion_r28009491
--- Diff:
test/androidTest/src/org/apache/cordova/test/CordovaPluginTest.java ---
@@ -0,0 +1,126 @@
+
+package org.apache.cordova.test
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/173#discussion_r28009389
--- Diff: test/src/org/apache/cordova/test/LifeCyclePluginTestActivity.java
---
@@ -0,0 +1,44 @@
+/*
+ Licensed to the Apache Software
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-android/pull/173
fix CB-8684 - support onStart/onStop lifecycle events in plugins for Android
A couple notes about this PR.
1. I feel pretty sure that CordovaActivity.shouldHandleStartOnAppViewInit
is
ApacheCon?
Tony
On 3/24/15, 1:51 PM, "Victor Sosa" wrote:
>Welcome aboard!!
>
>2015-03-24 11:47 GMT-06:00 Andrew Grieve :
>
>> Woohoo! Glad to hear more are coming!
>>
>> On Sat, Mar 21, 2015 at 11:51 AM, Ross Gardler (MS OPEN TECH) <
>> ross.gard...
1 - 100 of 122 matches
Mail list logo
