Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/408#issuecomment-194806460
The related changes for cordova android can be found here:
https://github.com/apache/cordova-android/compare/master...MSOpenTech:CB-10822?expand=1
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/408#issuecomment-194804304
https://github.com/apache/cordova-lib/commit/317cfdb374b9dfa215de77c617db0c373dc098c6
is seen here due to ASF git and Github is out of sync.
---
If your
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/408
CB-10822 Manage plugins/modules metadata using PlatformJson
JIRA https://issues.apache.org/jira/browse/CB-10822
This PR adds brings logic for storing and generating plugin
Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:
> Friendly pinging...
>
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> Sent: Friday, March 4, 2016 5:57 PM
> To: dev@cordova.a
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/406#issuecomment-194196784
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/402#discussion_r55119960
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -71,7 +71,8 @@ module.exports = function installPlugin(platform,
project_dir, id
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/396#issuecomment-192624166
Sorry for delay, @bso-intel. Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-ios/pull/201
CB-10773 Correct FRAMEWORKS_SEARCH_PATHS on win32
This is a fix https://issues.apache.org/jira/browse/CB-10773
Similar PR to `node-xcode`:
https://github.com/alunny/node-xcode
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-ios/pull/200
CB-10769 Move plugin handlers tests into platform's repo
JIRA: https://issues.apache.org/jira/browse/CB-10769
You can merge this pull request into a Git repository by running
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-docs/pull/539
CB-10788 Add blog post about browser@4.1.0 release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs CB
Please review and vote on this Cordova-browser 4.1.0 Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10788
The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10788
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/405#discussion_r55035943
--- Diff: cordova-common/src/CordovaLogger.js ---
@@ -153,6 +153,30 @@ CordovaLogger.prototype.setLevel = function (logLevel
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/268#issuecomment-192302388
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/268#discussion_r55029692
--- Diff: bin/templates/cordova/Api.js ---
@@ -91,8 +102,11 @@ function Api(platform, platformRootDir, events) {
* instance
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/268#discussion_r55029727
--- Diff: bin/templates/cordova/Api.js ---
@@ -91,8 +102,11 @@ function Api(platform, platformRootDir, events) {
* instance
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/268#discussion_r55029617
--- Diff: bin/templates/cordova/Api.js ---
@@ -29,11 +29,23 @@ var AndroidProject = require('./lib/AndroidProject');
var PlatformMunger
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/268#discussion_r55029308
--- Diff: bin/templates/cordova/loggingHelper.js ---
@@ -0,0 +1,18 @@
+var CordovaLogger = require('cordova-common').CordovaLogger
Hey, guys.
Here is a release notes for this release:
### 4.1.0 (Mar 04, 2016)
* CB-10788 Updated checked in node_modules
* CB-10650 Non-index content.src causes Splashscreen to be not displayed on
browser
* CB-9836 Add .gitattributes to prevent CRLF line endings in repos
* CB-9669 Browser exec
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/402#issuecomment-191657982
@bso-intel, LGTM apart from one comment. It also would be great if you add
a test for this.
---
If your project is set up for it, you can reply
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/402#discussion_r54849930
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -71,7 +71,8 @@ module.exports = function installPlugin(platform,
project_dir, id
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/267#issuecomment-191631596
> Is this supported in other platforms too? If not, should it be?
It sound like platform-agnostic Plugman's feature, so my think
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/155#issuecomment-191624625
> Is there also a PR for removing these from cordova-lib?
No, because the code these tests are testing is still in cordova-lib. I
think
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/155#discussion_r54697909
--- Diff: spec/unit/JsprojManager.spec.js ---
@@ -25,6 +25,7 @@ var AppxManifest =
require('../../template/cordova/lib/AppxManifest
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/57#discussion_r54605945
--- Diff: tests/plugin.xml ---
@@ -26,6 +26,8 @@
Cordova Media Capture Plugin Tests
Apache 2.0
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/17#issuecomment-190725941
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/45#issuecomment-190726091
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/44#issuecomment-190725798
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/38#issuecomment-190725571
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/57#discussion_r54565950
--- Diff: tests/plugin.xml ---
@@ -26,6 +26,8 @@
Cordova Media Capture Plugin Tests
Apache 2.0
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/83#issuecomment-190724615
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-190719953
@bso-intel, IMO there is a reason for current approach - ``
element is intended to handle `.java`, `.m` and other types of source files -
not binary
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-cli/pull/235#issuecomment-190716715
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-190708358
LGTM apart from a couple of nitpicks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54558329
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,50 @@ module.exports = function plugin(command, targets,
opts
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54558183
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,50 @@ module.exports = function plugin(command, targets,
opts
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/265#discussion_r54531747
--- Diff: bin/templates/cordova/lib/pluginHandlers.js ---
@@ -31,7 +31,7 @@ var handlers = {
if (!obj.src) throw new
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/265
CB-10729 Move plugin handlers tests for into platform's repo
JIRA: https://issues.apache.org/jira/browse/CB-10729
You can merge this pull request into a Git repository by running
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/155
CB-10730 Move plugin handlers tests for into platform's repo
JIRA: https://issues.apache.org/jira/browse/CB-10730
You can merge this pull request into a Git repository by running
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/72#issuecomment-189615537
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/65#issuecomment-189615257
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-device-orientation/pull/25#issuecomment-189615205
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-console/pull/16#issuecomment-189614983
LGTm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/32#issuecomment-189614969
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/127#issuecomment-189614910
LGTm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/127#discussion_r54331382
--- Diff: package.json ---
@@ -20,8 +20,8 @@
},
"scripts": {
"test": "npm
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/127#discussion_r54331337
--- Diff: .jscsrc ---
@@ -1,7 +1,7 @@
{
"disallowMixedSpacesAndTabs": true,
"disallowTra
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/6#issuecomment-189613962
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/49#issuecomment-189613712
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/396#issuecomment-189612511
@bso-intel, thanks. This looks good apart from the logic duplication in
`plugman/install` and `plugman/fetch`. However, this looks like is out
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54331174
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -135,13 +135,32 @@ function fetchPlugin(plugin_src, plugins_dir,
options
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/72#issuecomment-189606016
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-189269844
@andorman, i'll take care of tests. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/401#issuecomment-189262857
@nikhilkh, could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/401
CB-10462 Get rid of npmconf in favor of npm
JIRA [CB-10462](https://issues.apache.org/jira/browse/CB-10462)
You can merge this pull request into a Git repository by running
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54224163
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -135,13 +135,32 @@ function fetchPlugin(plugin_src, plugins_dir,
options
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54223240
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,21 +79,36 @@ module.exports = function installPlugin(platform,
project_dir, id
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54222593
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,21 +79,36 @@ module.exports = function installPlugin(platform,
project_dir, id
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-189176531
LGTM. @andorman, It'd be great if you could add a couple of tests for this?
@nikhilkh, it looks like `target` attribute for images
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-189172760
From what i understand the corresponding JIRA contains two separate issues
and one of them is a regression (see apache/cordova-lib#392), but second one
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/261#issuecomment-189149877
LGTM, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/398#discussion_r54081599
--- Diff: cordova-lib/src/plugman/platforms/browser.js ---
@@ -31,25 +29,7 @@ module.exports = {
return path.join(project_dir, 'www
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/398#issuecomment-188710263
Thanks for advice, @TimBarham. Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/400#issuecomment-188674424
@sgrebnov, could you take a look please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/400
CB-10583 Protect plugin preferences from adding extra Array properties
JIRA [CB-10583](https://issues.apache.org/jira/browse/CB-10583)
You can merge this pull request into a Git
Steve, do you plan to update bundled `cordova-common` as a part of this release?
-
Best regards, Vladimir
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Wednesday, February 24, 2016 8:12 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-Android
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/398#issuecomment-188373756
Looking into failures...
Another possible fix here - update `browser` platform rather than
introducing additional complexity to platform adding
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/398#issuecomment-188327164
@TimBarham, could you take a look please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/398
CB-10662 Apply project config to platform before installing any plugins
JIRA: [CB-10662](https://issues.apache.org/jira/browse/CB-10662)
This change is needed because some
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#issuecomment-188155119
Mostly LGTM apart from a few minor comments/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53911524
--- Diff: tests/tests.js ---
@@ -18,9 +18,10 @@
*
*/
-/*global cordova, exports*/
-/*jshint jasmine: true
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53911243
--- Diff: www/blackberry10/write.js ---
@@ -40,7 +40,7 @@ module.exports = function (success, fail, args) {
var uri = args[0
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53911054
--- Diff: tests/tests.js ---
@@ -3040,20 +3045,19 @@ exports.defineAutoTests = function () {
expect(entries[0
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53910671
--- Diff: src/firefoxos/FileProxy.js ---
@@ -67,10 +69,12 @@ QUIRKS:
exports.requestFileSystem = function(successCallback
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/151#issuecomment-188149151
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/84#issuecomment-188148446
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/173#issuecomment-188145591
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/177#discussion_r53838196
--- Diff: appium-tests/android/android.spec.js ---
@@ -295,13 +318,35 @@ describe('Camera tests Android.', function
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/commit/3b9face5187857d354d85f3e3f4316cbace100db#commitcomment-16238992
Thanks, @TimBarham. I'll take a look at this ASAP.
---
If your project is set up for it, you can reply
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/393#issuecomment-186137795
@nikhilkh, will do that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/394#issuecomment-186135548
@nikhilkh, updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Hey, guys.
I've opened a PR that adds a message about deprecation. Could anybody please
review that?
The only question I wanted to know your opinion on is where we should print
this message. In the PR above cordova-lib will show it each time when polyfill
is instantiated and this might be
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-185747825
The return value of `Q.then(thePromise)` is the same as for `thePromise()`
due to its' (promise) nature, so i think there is nothing changed for caller
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/394
CB-10644 Adds deprecation message about old platforms support removal
JIRA: [CB-10644](https://issues.apache.org/jira/browse/CB-10644)
You can merge this pull request into a Git
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/393#issuecomment-185703790
@TimBarham, could you please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-185703661
@TimBarham, ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/393
CB-10641 Run prepare _after_ plugins were installed
This is a fix for
[CB-10641](https://issues.apache.org/jira/browse/CB-10641) and
[CB-10586](https://issues.apache.org/jira/browse
elease build or just
> bundle dependency with release build.
>
> I think in npm3 npmshrinkwrap function was improved to be more
> deterministic
>
>
>
> On Tue, Feb 16, 2016 at 7:50 AM Vladimir Kotikov (Akvelon) <
> v-vlk...@microsoft.com> wrote:
>
>&g
The vote has now closed. The results are:
Positive Binding Votes: 4
Vladimir Kotikov
Alexander Sorokin
Sergey Grebnov
Steven Gill
The vote has passed.
-
Best regards, Vladimir
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Thursday, February 18, 2016 10:33
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#issuecomment-185276032
I think this is because of
https://developer.mozilla.org/docs/Web/API/Window/name
---
If your project is set up for it, you can reply
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/259#issuecomment-185239609
@nikhilkh, added tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#discussion_r53171195
--- Diff: .jshintrc ---
@@ -0,0 +1,16 @@
+{
+"node": true
+ , "bitwise": true
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#discussion_r53170790
--- Diff: .jshintrc ---
@@ -0,0 +1,16 @@
+{
+"node": true
--- End diff --
Should't we use `bro
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-ios/pull/194#issuecomment-185221787
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/260#discussion_r53140038
--- Diff: bin/templates/cordova/lib/run.js ---
@@ -41,8 +41,9 @@ var path = require('path'),
var self
, 2016, at 5:23 AM, Vladimir Kotikov (Akvelon)
<v-vlk...@microsoft.com> wrote:
>> cordova-windows won't as it has the dependency listed as ^1.0.0 which
>> includes minor releases.
> IMO since cordova-common is a bundled dependency, we still need for new
> relea
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-184667609
@TimBarham, updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
gt;
> > cordova-windows won't as it has the dependency listed as ^1.0.0
> > which includes minor releases.
> >
> > On Mon, Feb 15, 2016 at 6:29 AM, Vladimir Kotikov (Akvelon) <
> > v-vlk...@microsoft.com> wrote:
> >
> > > Hi, guys.
> > > I'm p
Please review and vote on this Cordova-common Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10626
Both tools have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10626/
The
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/384#discussion_r52985929
--- Diff: cordova-lib/src/cordova/build.js ---
@@ -17,22 +17,26 @@
under the License.
*/
-var cordovaUtil = require
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/389
CB-10618 Do not call prepBuildFiles for cordova-android@>=5.2.0
An implementation for
[CB-10618](https://issues.apache.org/jira/browse/CB-10618)
This PR disables call
601 - 700 of 1460 matches
Mail list logo
