[GitHub] cordova-windows pull request: CB-10193 Add BOM to www files at bui...

2016-01-05 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/134 CB-10193 Add BOM to www files at build stage instead of prepare This PR moves adding BOM to JS files from prepare to build stage. This should fix the potential problem

[DISCUSS] Cordova-windows 4.3.0 release

2016-01-05 Thread Vladimir Kotikov (Akvelon)
Hi all, I plan to do a minor cordova-windows release (bump to 4.3.0) to release PlatformApi and unified logging feature in the next couple of days. Please leave your comments and notes. Release issue: https://issues.apache.org/jira/browse/CB-10299 - Best regards, Vladimir

[GitHub] cordova-plugin-geolocation pull request: CB-10277 Android: error c...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/62#discussion_r48596423 --- Diff: www/android/geolocation.js --- @@ -52,7 +62,20 @@ module.exports = { var geo = cordova.require('cordova

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/359#discussion_r48599256 --- Diff: cordova-lib/src/plugman/install.js --- @@ -596,11 +596,14 @@ function handleInstall(actions, pluginInfo, platform, project_dir

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/359#issuecomment-167983975 IMO, better fix this by moving 'usePlatformWww' option setup to cordova-cli area of responsibility - somewhere around [src/cordova/plugin.js#L180](https

[GitHub] cordova-plugin-geolocation pull request: CB-10278 geolocation watc...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/63#issuecomment-167969937 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/58#issuecomment-167972137 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-geolocation pull request: CB-7146 Remove built-in W...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/59#issuecomment-167973201 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-geolocation pull request: CB-10278 geolocation watc...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/63#discussion_r48596899 --- Diff: www/android/geolocation.js --- @@ -38,21 +39,29 @@ module.exports = { }, watchPosition

[GitHub] cordova-plugin-geolocation pull request: CB-8443 Android: nothing ...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/61#issuecomment-167972921 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/359#discussion_r48605174 --- Diff: cordova-lib/src/plugman/install.js --- @@ -596,11 +596,14 @@ function handleInstall(actions, pluginInfo, platform, project_dir

[GitHub] cordova-plugin-statusbar pull request: CB-8720 Fix status bar posi...

2015-12-30 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/44 CB-8720 Fix status bar position when app started upside down on iOS 7 https://issues.apache.org/jira/browse/CB-8720 You can merge this pull request into a Git repository

[GitHub] cordova-plugin-statusbar pull request: CB-10118 Fixes error plugin...

2015-12-28 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/43 CB-10118 Fixes error plugin loading error in browser platform Fix for https://issues.apache.org/jira/browse/CB-10118 You can merge this pull request into a Git repository

[GitHub] cordova-plugin-statusbar pull request: CB-9513 Allow to show/hide ...

2015-12-28 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/42 CB-9513 Allow to show/hide status bar in fullscreen mode Fix for https://issues.apache.org/jira/browse/CB-9513 You can merge this pull request into a Git repository

[GitHub] cordova-docs pull request: Update index.md

2015-12-21 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-docs/pull/443#issuecomment-166402954 Я бы написал "общий для всех платформ" :) --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: CB-10193 Add deprecation notice about pr...

2015-12-21 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/356 CB-10193 Add deprecation notice about pre_package removal This PR adds an temporary polyfill for windows 'pre_package' event to keep compatibility with plugins, which uses this hook

[GitHub] cordova-cli pull request: CB-8455 added --nohooks option

2015-12-21 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-cli/pull/230#issuecomment-166267314 Merged. Thanks for update, @bso-intel --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

2015-12-18 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-165732453 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-cli pull request: CB-8455 added --nohooks option

2015-12-18 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-cli/pull/230#issuecomment-165708524 @bso-intel, could you please update documentation as well --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-cli pull request: CB-8455 added --nohooks option

2015-12-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/230#discussion_r48002044 --- Diff: src/cli.js --- @@ -79,6 +79,7 @@ function cli(inputArgs) { , 'silent' : Boolean , 'experimental' : Boolean

[GitHub] cordova-plugin-contacts pull request: CB-10117 Added new tests

2015-12-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/99#discussion_r47645743 --- Diff: tests/tests.js --- @@ -618,20 +720,86 @@ exports.defineManualTests = function(contentEl, createActionButton

[GitHub] cordova-plugin-contacts pull request: CB-10117 Added new tests

2015-12-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/99#issuecomment-164790750 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

RE: Purpose of pre_package hook for windows

2015-12-12 Thread Vladimir Kotikov (Akvelon)
Corporation -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Friday, December 11, 2015 2:27 AM To: dev@cordova.apache.org Subject: RE: Purpose of pre_package hook for windows So, the only problem here is when plugin (or user) decides to modify www

RE: Purpose of pre_package hook for windows

2015-12-11 Thread Vladimir Kotikov (Akvelon)
AFY%3d @purplecabbage https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cv-segreb%40microsoft.com%7c53012f7781224cf8372e08d300e505dc%7c72f988bf86f141af91ab2d7cd011db47%7c1=wW%2bKeY6MmNVcIOVrceLfhfpkMeUTCTbAsBrbCpkkXwg%3d On Wed, Dec 9, 2015 at 11:53 AM, Vladimir Kotikov (Akve

[GitHub] cordova-windows pull request: CB-9828 Implements PlatformApi contr...

2015-12-11 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-windows/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-windows pull request: CB-9828 Implements PlatformApi contr...

2015-12-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/132#issuecomment-163880842 This was merged in [58047a3](https://git1-us-west.apache.org/repos/asf?p=cordova-windows.git;a=commit;h=58047a3daf21dbd046a6354bf748b83f3ae7b5b9

[GitHub] cordova-android pull request: CB-10140 Use application id instead ...

2015-12-10 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/244#issuecomment-163582855 Thanks for explanation, @CookieCookson --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

2015-12-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-163182113 Isn't hooks is a CLI/LIB feature? As far as I remember, hooks fired by LIB except for `pre_package` hook for wp8/windows, so probably there is no need

[GitHub] cordova-android pull request: CB-10140 Use application id instead ...

2015-12-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/244#issuecomment-163165235 @CookieCookson, LGTM, though I'm not sure about situations when this would be useful. However the problem here is that aapt might

[GitHub] cordova-windows pull request: CB-9828 Implements PlatformApi contr...

2015-12-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/132#issuecomment-163206085 Addressed notes and fixed compatibility w/Node@0.12 Regarding logging, agree, we should move it common, but i propose to follow more general

[GitHub] cordova-plugin-contacts pull request: CB-10131 Fixed null contact ...

2015-12-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/98#issuecomment-163284932 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Purpose of pre_package hook for windows

2015-12-09 Thread Vladimir Kotikov (Akvelon)
Hi, guys. Could anyone please shed some light on the subject? Looking into PR for 'nohooks' option [1] I realized that we have a logic in Windows/wp8 parsers that fires a hooks, specific for these particular platforms. I see 2 problems with this: 1. This doesn't fits well into the

[GitHub] cordova-plugin-contacts pull request: CB-10053 Documents ContactFi...

2015-12-07 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/93#issuecomment-162797273 @dblotsky, IMO it would be easier for us, but not for the users, as they will have to look into sources. --- If your project is set up

[GitHub] cordova-plugin-device pull request: CB-9923 Update `device.platfor...

2015-12-07 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-device/pull/45 CB-9923 Update `device.platform` documentation for browser platform See the [CB-9923](https://issues.apache.org/jira/browse/CB-9923) and #25 for details You can merge

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

2015-12-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-161988854 After couple of tests this giving me a "no access to assets" error when cancelling a camera. @m-revetria solution looks more correct

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

2015-12-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161548065 @dblotsky, as @purplecabbage mentioned, there is no way to cover this by autotests, because from JS perspective everything works well - we

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

2015-12-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161549915 @dblotsky, this replaces #77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

2015-12-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161597318 @riknoll, other platforms (iOS, Windows) don't try to resolve relative paths. Instead they expect image path/URI to be absolute. Probably we

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-12-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161633720 @MarsupiL, app crash due to missing permissions, while accessing linked contacts already has been fixed in https://github.com/apache/cordova

[GitHub] cordova-android pull request: CB-10112 Parse additional CLI argume...

2015-12-02 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/241 CB-10112 Parse additional CLI arguments properly This fixes [CB-10112](https://issues.apache.org/jira/browse/CB-10112) by updating `build.js` to take an addtional platform options

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

2015-12-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161331277 No objections from my side. The PR has passed internal review, all CR notes has been addressed. @sgrebnov? --- If your project is set up for it, you can

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

2015-12-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161247540 @dblotsky, updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-12-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#discussion_r46394555 --- Diff: README.md --- @@ -217,6 +217,10 @@ function specified by the __contactSuccess__ parameter. - Windows 8 - Windows

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-12-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161241738 > Is this bug saying that the method can't find phone numbers from linked contacts, or that it can't find phone numbers at all?

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

2015-12-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#discussion_r46402705 --- Diff: src/android/ContactAccessorSdk5.java --- @@ -451,7 +452,13 @@ else if (mimetype.equals

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

2015-12-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161271526 I think this is not possible to cover this issue with our automated tests, because, strictly speaking, the plugin code stores and reads

[GitHub] cordova-lib pull request: CB-10108 Fixes android frameworks instal...

2015-12-02 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/348 CB-10108 Fixes android frameworks installation/removal This fixes [CB-10108](https://issues.apache.org/jira/browse/CB-10108) You can merge this pull request into a Git repository

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

2015-12-01 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/95 CB-8115 Save contact birthday properly This is a fix for [CB-8115](https://issues.apache.org/jira/browse/CB-8115) You can merge this pull request into a Git repository

[GitHub] cordova-plugin-contacts pull request: Return rawId

2015-12-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/68#issuecomment-160987859 @manugb, this was fixed in #87, please close this PR --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-contacts pull request: CB-10094 Android: Fixed empt...

2015-11-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/91#issuecomment-160556630 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-contacts pull request: CB-10053 Accept relative pat...

2015-11-30 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/94 CB-10053 Accept relative paths and assets URIs for contact photos JIRA issue [CB-10039](https://issues.apache.org/jira/browse/CB-10039) This is a replacement

[GitHub] cordova-plugin-contacts pull request: Solved problem add Contact p...

2015-11-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/77#issuecomment-160630915 @vincipop, looks like your changes does not handle the case, when image path is an absolute path to file outside of assets/storage directory

[GitHub] cordova-plugin-contacts pull request: CB-4921 Corrects examples by...

2015-11-30 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/92 CB-4921 Corrects examples by adding missing `multiple` option where multiple contacts are expected A small docs improvement, mentioned in [CB-4921](https

[GitHub] cordova-plugin-contacts pull request: CB-10053 Documents ContactFi...

2015-11-30 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/93 CB-10053 Documents ContactFieldType enumeration JIRA issue: [CB-10053](https://issues.apache.org/jira/browse/CB-10053) You can merge this pull request into a Git repository

[GitHub] cordova-plugin-contacts pull request: CB-6979 Don't create duplica...

2015-11-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/89#discussion_r46032879 --- Diff: src/ios/CDVContact.m --- @@ -1324,6 +1324,7 @@ - (NSObject*)extractPhotos NSMutableArray* photos = nil

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-11-26 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/88 CB-9348 Fetch phoneNumbers and emails from linked contacts too This fixes [CB-9348](https://issues.apache.org/jira/browse/CB-9348). The idea here is to fetch

[GitHub] cordova-plugin-contacts pull request: CB-6979 Don't create duplica...

2015-11-26 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/89 CB-6979 Don't create duplicates for extracted contacts photos Fix for [CB-6979](https://issues.apache.org/jira/browse/CB-6979) You can merge this pull request into a Git

[GitHub] cordova-plugin-contacts pull request: CB-3950 Do not replace custo...

2015-11-26 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/90 CB-3950 Do not replace custom labels with "Other" on contact save https://issues.apache.org/jira/browse/CB-3950 You can merge this pull request into a Git

[GitHub] cordova-plugin-contacts pull request: CB-5308 Return rawId instead...

2015-11-26 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r46023545 --- Diff: src/android/ContactAccessorSdk5.java --- @@ -1027,7 +1027,7 @@ else if (accounts.length > 1) { private Str

[GitHub] cordova-plugin-contacts pull request: CB-5308 Return rawId instead...

2015-11-26 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r46023669 --- Diff: tests/tests.js --- @@ -37,23 +37,34 @@ exports.defineAutoTests = function() { var MEDIUM_TIMEOUT = 3

[GitHub] cordova-plugin-file-transfer pull request: CB-9563 Mulptipart form...

2015-11-25 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/117#discussion_r45847057 --- Diff: src/windows/FileTransferProxy.js --- @@ -81,6 +81,8 @@ exec(win, fail, 'FileTransfer', 'upload', var

[GitHub] cordova-plugin-contacts pull request: CB-5308 Return rawId instead...

2015-11-25 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/87 CB-5308 Return rawId instead of id when modifying existing contact This fixes issue with updating existing contact, described in [CB-5308](https://issues.apache.org/jira

[GitHub] cordova-plugin-file-transfer pull request: CB-9563 Mulptipart form...

2015-11-25 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/117#discussion_r45845760 --- Diff: src/android/FileTransfer.java --- @@ -528,14 +528,18 @@ public void run

[GitHub] cordova-plugin-contacts pull request: CB-9770 Request user permiss...

2015-11-25 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer pull request: CB-9563 Mulptipart form...

2015-11-25 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/117#issuecomment-159550548 @daserge, don't forget to update plugin docs regarding this new behaviour for Windows platform --- If your project is set up

[GitHub] cordova-plugin-file-transfer pull request: CB-9563 Mulptipart form...

2015-11-25 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/117#discussion_r45845885 --- Diff: src/android/FileTransfer.java --- @@ -528,14 +528,18 @@ public void run

[GitHub] cordova-plugin-file-transfer pull request: CB-9563 Mulptipart form...

2015-11-25 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/117#issuecomment-159554231 LGTM :ship: at will --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-contacts pull request: CB-9770 Request user permiss...

2015-11-25 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/86#issuecomment-159562030 Merged in https://github.com/apache/cordova-plugin-contacts/commit/617fb764bf1c7047cfe02cf346771dd7fa38ed40 Thanks, @purplecabbage

RE: [Vote] Tools Release Cordova 5.4.1

2015-11-24 Thread Vladimir Kotikov (Akvelon)
I vote +1 * Ran coho -verify archive over RC archives * Ran npm test for relevant repos, checked out to release tag * Verified that mobilespec, created with old cli builds and runs successfully - Best regards, Vladimir -Original Message- From: Alexander Sorokin (Akvelon)

[GitHub] cordova-plugin-contacts pull request: CB-9770 Request user permiss...

2015-11-24 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/86 CB-9770 Request user permissions before picking a contact This fixes [CB-9770](https://issues.apache.org/jira/browse/CB-9770) by requesting address book permissions before

[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...

2015-11-23 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/84#issuecomment-159188305 Updated. Thanks for reviewing, @purplecabbage --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-contacts pull request: CB-7906 Prevent app crash wh...

2015-11-21 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/85 CB-7906 Prevent app crash when desiredFields option has undefined items You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...

2015-11-21 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/84 CB-8156 Call error callback on pickContact cancellation Also introduce OPERATION_CANCELLED_ERROR as an error code for reporting contact picker cancellation. You can merge

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

2015-11-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/240#issuecomment-158453018 .It does, right, but there is two problems: 1. Superspawn returns output only _after_ the underlying process exits - if the build lasts long

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

2015-11-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/240#issuecomment-158328421 @dblotsky, i propose to proceed with current approach for now, otherwise we'll have to release 'cordova-common' with updated superspawn before this fix

[GitHub] cordova-plugin-contacts pull request: CB-7021 Adds manual test for...

2015-11-19 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/83#issuecomment-158054090 @daserge, updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-9976 Reinstall plugins for platform i...

2015-11-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/344#issuecomment-157312145 Thanks, @TimBarham. The commit itself also had a wrong JIRA prefix. Updated. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-lib pull request: CB-9987 CB-9987 Reinstall plugins for pl...

2015-11-16 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/344 CB-9987 CB-9987 Reinstall plugins for platform if they were installed with cordova@<5.4.0 Fix for https://issues.apache.org/jira/browse/CB-9976 More details at JIRA You

[GitHub] cordova-lib pull request: CB-9981 path.parse only available on nod...

2015-11-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/340#issuecomment-156981607 Merged. Thanks, @apla --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: use plist@1.2 to be able to use cordova ...

2015-11-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/341#issuecomment-156044170 @rubensayshi, thanks for reporting and providing a fix --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: Cb 9964

2015-11-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/339#issuecomment-156045380 The failing test fixed in https://github.com/apache/cordova-lib/commit/6c31f4717a00a540ea9782a1543bce6dd72888f1. --- If your project is set up

[GitHub] cordova-lib pull request: Adds copying of blackberry10 splashscree...

2015-11-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/342#issuecomment-156046067 @timwindsor, the failing test fixed in https://github.com/apache/cordova-lib/commit/6c31f4717a00a540ea9782a1543bce6dd72888f1. Just to be sure you could

RE: [Vote] 4.2.0 Windows Release

2015-11-11 Thread Vladimir Kotikov (Akvelon)
I vote +1 * Verified release candidate with 'coho verify-archive' * Verified that blank app created and built successfully * Verified that upgrade from previous version succeeds - Best regards, Vladimir -Original Message- From: Alexander Sorokin (Akvelon)

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

2015-11-11 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/240 CB-9971 Redirect gradlew stderr to current process stdout This is a fix for https://issues.apache.org/jira/browse/CB-9971 You can merge this pull request into a Git repository

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

2015-11-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/240#discussion_r44585568 --- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js --- @@ -211,3 +209,46 @@ module.exports = GradleBuilder; function

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

2015-11-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/240#issuecomment-155912830 @jasongin, i will double check this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

2015-11-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/240#discussion_r44586855 --- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js --- @@ -211,3 +209,46 @@ module.exports = GradleBuilder; function

RE: CLI broke orientation settings?

2015-11-10 Thread Vladimir Kotikov (Akvelon)
The orientation is still handled by LIB (except cordova-android), so this is probably tools-related. - Best regards, Vladimir. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, November 10, 2015 7:51 PM To: dev@cordova.apache.org Subject: Re: CLI broke

[GitHub] cordova-plugin-contacts pull request: Solved problem add Contact p...

2015-11-10 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/77#issuecomment-155436002 Hi @vincipop, before merging could you please sign the Apache CLA? Also it would be great if you filed an issue in [JIRA](https

[GitHub] cordova-windows pull request: CB-9828 Implements PlatformApi contr...

2015-11-09 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/132 CB-9828 Implements PlatformApi contract for WIndows platform You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech

[GitHub] cordova-coho pull request: CB-9220 remove check that enforces comm...

2015-11-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-coho/pull/100#issuecomment-152973787 We don't. This check is not actual anymore after publishing cordova-common. Thanks, Steve, sorry for late response. --- If your project is set up

RE: [VOTE] iOS 3.9.2 release

2015-11-02 Thread Vladimir Kotikov (Akvelon)
The vote has now closed. The results are: Positive Binding Votes: 3 Vladimir Kotikov Shazron Abdullah Sergey Grebnov The vote has passed. - Best regards, Vladimir. -Original Message- From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] Sent: Monday, November 2, 2015 9:28 AM

[GitHub] cordova-docs pull request: CB-9912 Adding blog post about iOS 3.9....

2015-11-02 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/408 CB-9912 Adding blog post about iOS 3.9.2 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-9912

[REVIEW] Cordova-ios 3.9.2 blog post

2015-11-02 Thread Vladimir Kotikov (Akvelon)
Please review and comment it here: https://github.com/apache/cordova-docs/pull/408 - Best regards, Vladimir

RE: [VOTE] Cordova-common 1.0.0 release

2015-11-01 Thread Vladimir Kotikov (Akvelon)
The vote has now closed. The results are: Positive Binding Votes : 3 Vladimir Kotikov Steven Gill Carlos Santana The vote has passed. I will publish it to dist and set it as latest on npm. - Best regards, Vladimir. -Original Message- From: Carlos Santana [mailto:csantan

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

2015-10-30 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

2015-10-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/329#issuecomment-152467126 Merged in https://github.com/apache/cordova-lib/commit/b52c257fcde22e982aea7b2287b3d0b943b16df2 --- If your project is set up for it, you can reply

[DISCUSS] Cordova-ios 3.9.2 release

2015-10-30 Thread Vladimir Kotikov (Akvelon)
Created this thread to separate discussions for 3.9.2 and 4.0.0 releases I'm going to start 3.9.2 release today if no one have any objections. - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org

[VOTE] iOS 3.9.2 release

2015-10-30 Thread Vladimir Kotikov (Akvelon)
Please review and vote on this 3.9.2 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9912 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9912 The

RE: [DISCUSS] Tools Release

2015-10-29 Thread Vladimir Kotikov (Akvelon)
, October 29, 2015 5:49 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Tools Release What's the latest status on this? cordova-android master being fixed to make it green again? On Wed, Oct 28, 2015 at 7:28 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > This

<    4   5   6   7   8   9   10   11   12   13   >