Github user Titoine commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-164399884
Thanks, I understand now.
Hope to see this implemented soon. It's a critical issue for me.
Anyway, thanks you all for the great work!
---
If your projec
Github user Bnaya commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-164317441
The app will not crash but just restart itself without the user doing
anything.
The thing is that, if you want to use the picture he choose before the
re
Github user Titoine commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-164317214
Ok! With your fix or in futur update, when the app crash, is the user have
to launch it again or does It launch itself ? Or both of the case could happen ?
---
Github user Bnaya commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-164316409
@Titoine This is not a complete fix, and its not released yet
There's also corresponding changes to the camera plugin this change
When it will be released y
Github user Titoine commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-164316047
When I try my app with "Don't keep activities" on, my app crash and I have
the "unfortunately MyApp has stopped" message. The app doesn't restart. Will it
resta
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/239
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-161046740
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-160807204
Apologies for not getting to this last week like I said I would (I didn't
really have much of an Internet connection). I did some more testing on this PR
today
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158471787
I will submit a PR that updates the camera plugin to use the save-restore
API as well, which should fix CB-9189. I'll also take a look at the contacts
plugin, b
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158469875
Alright, I plan on merging this in soon. I want to do some more testing and
write some plugin-side docs before I do, but since this PR's been open a while
and I
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158229277
@Bnaya @riknoll Unless you're getting a result back from an Activity, the
plugin processes belong to the activity that was put in the background, and the
plugi
Github user Bnaya commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158226691
I will extend the scope of that issue.
This change can/should also help the apps developers to recover from
situations that the app sent to the background
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158225021
Also, I don't think you can get into a situation where you have two
Activity results pending (correct me if I'm wrong on that one).
---
If your project is set
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158224722
@Bnaya That is correct and it was intentional. Is there a need for
extending this to all plugin callbacks currently pending? The way I see it, the
burden is on
Github user Bnaya commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158220594
@riknoll, after going over the docs (which looks great btw) its seems it
supports only single plugin result
What if you wait for two or more plugins responses?
Github user Titoine commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158219586
@infil00p Before the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158217697
@Titoine Are you having problems after the patch or before? I'm not sure.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158217175
Hey all, I've added a PR to the docs repo that documents the result
callback part of this change as well as general Android lifecycle
considerations: https://gi
Github user Titoine commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-158017890
Hi,
First of all, thanks from the great work!
But I'm getting a lot of crash from this problem.
Do you have any idea when this will be merge ?
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44567817
--- Diff: framework/src/org/apache/cordova/ResumeCallback.java ---
@@ -0,0 +1,71 @@
+/*
+ Licensed to the Apache Software Foundation (AS
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44565905
--- Diff: framework/src/org/apache/cordova/ResumeCallback.java ---
@@ -0,0 +1,71 @@
+/*
+ Licensed to the Apache Software Foundation (AS
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44564738
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -147,6 +151,8 @@ public void onSaveInstanceState(Bundle outState) {
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44564318
--- Diff: framework/src/org/apache/cordova/ResumeCallback.java ---
@@ -0,0 +1,71 @@
+/*
+ Licensed to the Apache Software Foundation (A
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44563854
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -115,6 +115,10 @@ public boolean onActivityResult(int requestCode, int
re
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44563555
--- Diff: framework/src/org/apache/cordova/ResumeCallback.java ---
@@ -0,0 +1,71 @@
+/*
+ Licensed to the Apache Software Foundation (A
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44562734
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -115,6 +115,10 @@ public boolean onActivityResult(int requestCode, int
r
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44562494
--- Diff: framework/src/org/apache/cordova/CoreAndroid.java ---
@@ -113,6 +110,10 @@ else if (action.equals("exitApp")) {
}
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44562203
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -147,6 +151,8 @@ public void onSaveInstanceState(Bundle outState) {
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44561745
--- Diff: framework/src/org/apache/cordova/CordovaInterface.java ---
@@ -22,6 +22,7 @@ Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44561465
--- Diff: framework/src/org/apache/cordova/CordovaInterface.java ---
@@ -22,6 +22,7 @@ Licensed to the Apache Software Foundation (ASF) under one
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-155621243
@infil00p @purplecabbage @jasongin please review. This incorporates
feedback received on the first PR. Example plugin and application code are
linked at bottom
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-android/pull/239
CB-8917: Added pending plugin callbacks to resume event payload
This is a redo of #236 after receiving some feedback. This relates to
CB-8917 and CB-9189.
### Background
The is
32 matches
Mail list logo
