[GitHub] cordova-docs pull request: Improving In-Development ("Edge") Page ...

2015-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/362 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Improving In-Development ("Edge") Page ...

2015-09-28 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/362#issuecomment-143910289 Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-docs pull request: Improving In-Development ("Edge") Page ...

2015-09-28 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/362#issuecomment-143907323 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cordova-docs pull request: Improving In-Development ("Edge") Page ...

2015-09-28 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/362#issuecomment-143802865 This looks fine to me. My only comment is that the in development text does not make it immediately clear that the warning bubble is a link or what clicking on it

[GitHub] cordova-docs pull request: Improving In-Development ("Edge") Page ...

2015-09-27 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/362 Improving In-Development ("Edge") Page Logic - Added a "this is edge" message to edge versions. - Made nonexistent docs versions still clickable. - Now there are two messages: "this is