Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/115#issuecomment-64065820
Cool, thanks. Merged.
For the linters, looks like the authors of JSCS and jshint work together
and actually recommend using them both in combination.
https:/
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/115#issuecomment-64043986
made some style changes and renamed underscore..
Perhaps we should move to use eslint instead of jshint, I think that still
has the style checks.
---
If yo
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/115#issuecomment-63848626
Looks good overall. 2 style notes, both are optional, tell me if you prefer
not to change it:
1) Would be great if you could run jscs with the default config in
c
GitHub user gorkem opened a pull request:
https://github.com/apache/cordova-lib/pull/115
CB-6472 Merge dictionaries when updating plist files
Merges the dictionaries on plist files if both plist and the value from
plugin.xml are dictionaries. This makes it consistent with how it beh
