Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/304#discussion_r39388053
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -283,6 +283,31 @@ module.exports = function plugin(command, targets,
opts) {
}
};
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/304
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/304#discussion_r39400734
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -283,6 +283,31 @@ module.exports = function plugin(command, targets,
opts) {
}
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/304#issuecomment-140217724
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/304#issuecomment-139542072
@TimBarham, agree with you, calling a `cordova.prepare` on each plugin
add/rm might be excess. Reworked.
---
If your project is set up for it, you can
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/304#issuecomment-139157987
It seems like an ok fix for the immediate problem, but it does raise a
concern in my mind - before the Platform API changes, we didn't call `prepare`
when
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/304#issuecomment-139129776
Will review tomorrow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/304#issuecomment-138958045
@omefire, @TimBarham, please review when possible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/304
CB-9617 Do not restore plugins immediately after plugin removal
https://github.com/apache/cordova-lib/commit/14675051c400a6811a6c6171fbf92f3475244630
introduced `cordova.prepare`
