Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/510
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95627089
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95625647
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500848
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95501588
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -206,134 +178,136 @@ describe('install', function() {
beforeEach(function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95502237
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500857
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500726
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -145,30 +146,36 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95501387
--- Diff: cordova-lib/spec-plugman/create.spec.js ---
@@ -35,46 +35,42 @@ describe( 'create plugin', function() {
existsSync,
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500893
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -309,10 +341,13 @@ describe('plugin end-to-end', function() {
.then(function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500826
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500649
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -83,6 +83,7 @@ function removePlugin(id) {
var errorHandler = {
errorCallback:
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500805
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95497591
--- Diff: cordova-common/spec/ActionStack.spec.js ---
@@ -59,19 +59,19 @@ describe('action-stack', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500766
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95502073
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500793
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500754
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -199,11 +209,14 @@ describe('plugin end-to-end', function() {
.then(function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95499196
--- Diff: cordova-common/spec/CordovaCheck.spec.js ---
@@ -30,71 +30,62 @@ describe('findProjectRoot method', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500742
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -178,11 +185,14 @@ describe('plugin end-to-end', function() {
.then(function ()
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95501615
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -206,134 +178,136 @@ describe('install', function() {
beforeEach(function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500695
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -145,30 +146,36 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95502042
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -121,7 +131,8 @@ beforeEach(function () {
});
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500869
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93506823
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
});
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93502548
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
});
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93493946
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
});
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93490653
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93492375
--- Diff: cordova-lib/spec-plugman/platforms/wp8.spec.js ---
@@ -113,22 +113,21 @@ describe('wp8 project handler', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93492132
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93490510
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93490083
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
});
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93492030
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93491307
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93491264
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92903756
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -345,13 +344,14 @@ describe('install', function() {
it('should not check
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92901285
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -345,13 +344,14 @@ describe('install', function() {
it('should not check
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92901030
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -345,13 +344,14 @@ describe('install', function() {
it('should not check
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92756760
--- Diff: cordova-lib/spec-cordova/helpers.js ---
@@ -148,7 +148,7 @@ module.exports.writeConfigContent = function (appPath,
configContent) {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92713582
--- Diff: cordova-lib/spec-cordova/HooksRunner.spec.js ---
@@ -472,7 +472,7 @@ describe('HooksRunner', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92707789
--- Diff: cordova-lib/package.json ---
@@ -20,15 +20,16 @@
"dependencies": {
"aliasify": "^1.7.2",
"cordova-common": "1.5.x",
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92707699
--- Diff: cordova-common/package.json ---
@@ -28,6 +28,7 @@
"cordova-registry-mapper": "^1.1.8",
"elementtree": "^0.1.6",
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92707427
--- Diff: cordova-lib/spec-cordova/build.spec.js ---
@@ -67,7 +67,7 @@ describe('build command', function() {
describe('success', function() {
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92480797
--- Diff: cordova-lib/spec-cordova/lazy_load.spec.js ---
@@ -34,8 +34,8 @@ var lazy_load = require('../src/cordova/lazy_load'),
describe('lazy_load
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92480348
--- Diff: cordova-common/spec/CordovaCheck.spec.js ---
@@ -30,11 +30,12 @@ describe('findProjectRoot method', function() {
process.env.PWD
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/510
Fixjasmine : CB:12018 - updating tests in cordova-lib to use jasmine
instead of jasmine-node
### Platforms affected
### What does this PR do?
### What
46 matches
Mail list logo
