Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161549915
@dblotsky, this replaces #77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161597318
@riknoll, other platforms (iOS, Windows) don't try to resolve relative
paths. Instead they expect image path/URI to be absolute. Probably we
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161725537
@vladimir-kotikov That sounds good to me! I agree we should be handling
`file://android_asset` URIs
---
If your project is set up for it, you can
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161811902
I agree the file path handling code probably should be centralized in the
platform lib for each platform. But it should be done as part of a broader
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161388988
Thanks! The change looks much cleaner now. How are this PR and #77 related?
Will they both be merged in?
---
If your project is set up for it, you
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161466199
We really need to get all this file reading code in one place for Android.
The camera plugin does things a bit differently (see
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161247540
@dblotsky, updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/94#discussion_r46362158
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -1631,24 +1631,41 @@ private void
insertPhoto(ArrayList ops,
}
