[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...

2015-10-30 Thread Heshyo
Github user Heshyo commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/56#issuecomment-152468218 I just saw https://github.com/apache/cordova-plugin-dialogs/pull/60 that actually added a ```setCanceledOnTouchOutside```. I don't know if both ```setCanc

[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...

2015-10-30 Thread Heshyo
Github user Heshyo commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/56#issuecomment-152465106 ++ It's easy to tap outside of the box unintentionally. Also you may wonder what happens if you tap outside instead of clicking OK/Cancel (did I just O

[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...

2015-09-29 Thread kavka3
Github user kavka3 commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/56#issuecomment-144113273 ++ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...

2015-08-12 Thread RomainFallet
GitHub user RomainFallet opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/56 set cancelable to false by default on Android To match with the iOS behavior where all modals cannot be canceled by a click outside of it (or a back button). First of all, th