Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
This has moved to #134 @leopatras can you close this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user leopatras commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
Hi, thank you for the tip !
I created a âdevelopmentâ branch and did add the changes there (changed
also the README for ios). This seemed to work better.
(I really canât
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
My suggestion is, to make it super easy, create a new branch off
`cordova-plugin-media` master (after getting the latest from Github). Then in
this new branch, cherry-pick the 1 commit
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
Please edit the Github PR title as already requested: change `CB-1254` to
`CB-12542`
This is so Apache Cordova JIRA can auto-track comments on this PR to the
correct JIRA issue.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
Cordova CI Build has completed successfully.
**Commit** -
Github user leopatras commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
Hi , No problem for changing the commit log, but I have no idea how to
rebase the fork to avoid those extra merges.
I spent an hour on stackoverflow and did read also those smart
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
Cordova CI Build has completed successfully.
**Commit** -
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
Hi.
The title should CB-12542, you missed the 2. Change it so it's linked with
the issue.
Also, the PR is showing 13 commit's, that is wrong. Can you rebase your
Github user leopatras commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
@chmac just vote for https://issues.apache.org/jira/browse/CB-12542 to
increase the chance being accepted
---
If your project is set up for it, you can reply to this email and have
Github user chmac commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
Would be awesome to get this merged, just took me several hours to figure
out why this wasn't working until I eventually found this PR.
Thanks @leopatras for posting. ð
---
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/131
Cordova CI Build has completed successfully.
**Commit** -
13 matches
Mail list logo
