[GitHub] cordova-plugin-wkwebview-engine pull request: CB-11074: Ensure set...

2016-04-29 Thread ephemer
Github user ephemer commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8#issuecomment-215702371 @shazron in that case we'd have to remove the configuration code from updateWithInfo because we've already established that it doesn't do anything

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-11074: Ensure set...

2016-04-28 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8#issuecomment-215585938 I also commented on #7. To solve this problem, instead of having to instantiate WKWebView twice here, I think we can safely move all ini

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-11074: Ensure set...

2016-04-28 Thread ephemer
GitHub user ephemer opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8 CB-11074: Ensure settings from config.xml are taken into consideration #7 also addresses this issue but in my tests didn't work. This pull request presents a workaroun