Re: Fix crash on cordova-windows@5

2018-02-08 Thread Chris Brody
Reverting d5ddcb4 (fix for CB-12499) would resolve the test failure. (This change is not part of 5.x.) Would this be an option? If not, what else can we do to ship a release that fixes the crash on Windows 8.1? Is there anything else I can do? Workaround is still to use cordova-windows@4. This ha

Re: Fix crash on cordova-windows@5

2018-02-08 Thread Jan Piotrowski
(5.x doesn't have the broken test because VS2017 wasn't a thing back then. It's highly probably that if one would test 5.x with VS2017 it would also be broken.) (Broken test is https://issues.apache.org/jira/browse/CB-13834 if anyone wants to help me debug/understand) 2018-02-08 13:05 GMT+01:00 C

Re: Fix crash on cordova-windows@5

2018-02-08 Thread Chris Brody
The 5.0.x branch does not have the failing test. This is why I proposed fixing the crash there. If 6.0.0 would be unblocked and released today then I would be happy. On Thu, Feb 8, 2018 at 6:57 AM, julio cesar sanchez wrote: > The release of 6.0.0 is blocked because of a test, so a possible > 5

Re: Fix crash on cordova-windows@5

2018-02-08 Thread julio cesar sanchez
The release of 6.0.0 is blocked because of a test, so a possible 5.0.1/5.1.0 will probably be blocked for the same reason. If the 6.0.0 gets unblocked and can be released, is that good for you? or you need the 5.0.1/5.1.0 for some reason? 2018-02-08 12:42 GMT+01:00 Chris Brody : > I was hoping t

Re: Fix crash on cordova-windows@5

2018-02-08 Thread Chris Brody
I was hoping to get this fixed for a customer. The last time I published a change on my fork was was outdated pretty quickly. For now I will say that they have to use cordova-android@4 for Windows 8.,1 until we get a new release with this crash resolved. Since #247 was already merged into 5.0.x I

Re: Fix crash on cordova-windows@5

2018-02-08 Thread Jan Piotrowski
I do not think this change necessitates a 5.0.1 or 5.1 release. Cutting another release before 6.0.0 will just confuse people. Just fork the repo and apply the change on your fork, then use that in your app. Although if anyone wants to run the release process, I of course won't stop you. (But I wi

Fix crash on cordova-windows@5

2018-02-07 Thread Chris Brody
Hello team, Windows 8.1 (8.1-win) build crashes in cordova-windows@5.0.0 (CB-12784 & CB-13175). It took multiple attempts to fix this on the cordova-windows master branch which I thought would be released 1-2 weeks ago for 5.1.0. I discovered today that the master branch is now for cordova-windows