RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-04 Thread Vladimir Kotikov (Akvelon)
- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Thursday, February 4, 2016 7:49 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos Just an FYI for us: we do already have coverage reports: "npm run cover".

RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-03 Thread Dmitry Blotsky
ey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] Sent: Tuesday, February 2, 2016 6:08 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos +1 - I would start from identifying weak places - important functionality/met

Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-02 Thread Dmitry Blotsky
overage below this bar. > > - > Best regards, Vladimir > > > -Original Message- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Tuesday, February 2, 2016 2:22 AM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Enabling coverage reports collection and

RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-02 Thread Vladimir Kotikov (Akvelon)
- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Tuesday, February 2, 2016 2:59 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos Is this basically just adding a UI then? Kindly, Dmitry > On Feb 1, 2016, at 11:48

Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-02 Thread Carlos Santana
ot...@microsoft.com] > Sent: Tuesday, February 2, 2016 2:59 PM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Enabling coverage reports collection and analysis > for cordova repos > > Is this basically just adding a UI then? > > Kindly, > Dmitry > > > On Feb 1,

RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-02 Thread Sergey Grebnov (Akvelon)
[mailto:csantan...@gmail.com] Sent: Tuesday, February 2, 2016 4:49 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos +1 This is cool tech to add to our project It shows more transparency which for me I'm all in !! It should make

Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-01 Thread Steven Gill
Hey Vlad! This looks great! You are using istanbul for code coverage it seems. Why did you remove spec-cordova in your pr? Your [2] I think it is a great idea to include this in our repos. It would be nice to track our coverage and work on improving it. Though I do believe it is important not

Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-01 Thread Jesse
This looks good, as a metric to add. What is the impact to our workflow? are we just adding a node dependency, or are there other config/integration parts that we need to do? @purplecabbage risingj.com On Mon, Feb 1, 2016 at 2:17 PM, Steven Gill wrote: > Hey Vlad! >

RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-01 Thread Vladimir Kotikov (Akvelon)
e.org Subject: Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos This looks good, as a metric to add. What is the impact to our workflow? are we just adding a node dependency, or are there other config/integration parts that we need to do?