Re: ios-deploy questions

2018-08-02 Thread Chris Brody
Thanks Shazron, makes absolute sense. I would personally not favor viral license in the dependencies, even if not bundled. On Thu, Aug 2, 2018 at 11:16 AM Shazron wrote: > > 1. Previously we had node_modules bundled. We couldn't bundle > ios-deploy because of its viral license. The only issue is

Re: ios-deploy questions

2018-08-02 Thread Shazron
1. Previously we had node_modules bundled. We couldn't bundle ios-deploy because of its viral license. The only issue is that it tries to build on Windows, but that should be easily fixed: https://github.com/ios-control/ios-deploy/issues/355 . There should be no problem in using a dependency from

Re: ios-deploy questions

2018-08-02 Thread Jan Piotrowski
> 1. Why not make ios-deploy a dependency of cordova-ios that would then > be automatically installed? Historically, I think, commands that should be able to be called via the command line had to be installed globally with npm to work. Is this not the case any more? 2018-08-02 15:26 GMT+02:00

Re: ios-deploy questions

2018-08-02 Thread Chris Brody
To add some context: this question is moved from https://github.com/apache/cordova-docs/issues/866 I think we should clarify both of the following: * "Should this be documented in another way?" * "Should this be different?" Confirmation would be really appreciated. On Thu, Aug 2, 2018 at 9:26 AM