Re: Remove onDestroy event/channel from cordova-js

2015-01-06 Thread Andrew Grieve
The channel is defined here: https://github.com/apache/cordova-js/blob/master/src/common/channel.js#L38 and clearly labeled as an internal event. I don't think it'd be considered an API change to remove it. On Tue, Jan 6, 2015 at 7:59 PM, Joe Bowser wrote: > Are we sure the feature never worked?

Re: Remove onDestroy event/channel from cordova-js

2015-01-06 Thread Joe Bowser
Are we sure the feature never worked? I'm not wanting to kill a feature to find out that it worked on Android 2.x and that we broke someone's app. I think more testing is needed before we decide to kill it. On Tue Jan 06 2015 at 4:57:25 PM Jesse wrote: > Well, if we find that the feature never

Re: Remove onDestroy event/channel from cordova-js

2015-01-06 Thread Jesse
Well, if we find that the feature never worked, then we could just remove it. @purplecabbage risingj.com On Tue, Jan 6, 2015 at 4:52 PM, Joe Bowser wrote: > This is an API change, and this would require a major version change for > both Android and CordovaJS. > > On Tue Jan 06 2015 at 4:50:17 P

Re: Remove onDestroy event/channel from cordova-js

2015-01-06 Thread Jesse
same, seems onunload is more appropriate anyway, although devs can't expect to do much in the time before all app resources are ripped away from them. @purplecabbage risingj.com On Tue, Jan 6, 2015 at 4:47 PM, Shazron wrote: > Fine with me (iOS has no use of it) > > On Mon, Jan 5, 2015 at 12:27

Re: Remove onDestroy event/channel from cordova-js

2015-01-06 Thread Joe Bowser
This is an API change, and this would require a major version change for both Android and CordovaJS. On Tue Jan 06 2015 at 4:50:17 PM Shazron wrote: > Fine with me (iOS has no use of it) > > On Mon, Jan 5, 2015 at 12:27 PM, Jason Chase wrote: > > I'm working on CB-8210, to remove the use of jav

Re: Remove onDestroy event/channel from cordova-js

2015-01-06 Thread Shazron
Fine with me (iOS has no use of it) On Mon, Jan 5, 2015 at 12:27 PM, Jason Chase wrote: > I'm working on CB-8210, to remove the use of javascript eval()s from native > code in cordova-android. The goal is to pave the way for CSP. > > One usage was to fire the "onDestroy" event when the app is be

Remove onDestroy event/channel from cordova-js

2015-01-05 Thread Jason Chase
I'm working on CB-8210, to remove the use of javascript eval()s from native code in cordova-android. The goal is to pave the way for CSP. One usage was to fire the "onDestroy" event when the app is being destroyed. However, in my testing, I wasn't able to get this event firing on the javascript