[GitHub] cordova-lib pull request #484: [CB-11730] Modify condition of if clause to a...

2016-10-14 Thread ahirun0426
Github user ahirun0426 commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/484#discussion_r83387722 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -330,7 +330,7 @@ function copyPlugin(pinfo, plugins_dir, link) { shell.rm('-rf',

[GitHub] cordova-cli issue #263: CB-11913 - Re-fix appveyor.yml to use specific node ...

2016-10-14 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/263 @stevengill since `yarn` works flawlessly on `node 6` the alternative is, put all the `install` commands in a script and use `yarn` when we detect `node 6`. Kinda like my script here:

[GitHub] cordova-cli issue #263: CB-11913 - Re-fix appveyor.yml to use specific node ...

2016-10-14 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/263 @stevengill unfortunately https://github.com/npm/npm/issues/9633 strikes its head (see AppVeyor failure). Usually running `npm install` again fixes it, but once the first `npm install` fails it

[GitHub] cordova-lib issue #501: CB-11951 CB-11967: Respect preference default values...

2016-10-14 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-lib/pull/501 @stevengill, thanks, updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Nightly build #178 for cordova has succeeded!

2016-10-14 Thread Apache Jenkins Server
Nightly build #178 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/178/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-geolocation issue #57: Fix crash on deny permission request o...

2016-10-14 Thread gkrizek
Github user gkrizek commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/57 I can confirm that pretty much exactly what @iursevla said is happening to me. I click 'Approve' and it looks like it restarts the emulator. --- If your project is set up for it,

send sms from app

2016-10-14 Thread Alexis Saucedo
hi! i probe any sms plugins from cordova but i cant send sms directly from app, all plugins open native sms sender from cellphone, i get push button send for sender sms, you know any sms plugin or alternative from send sms directly from app?. regards!, please sorry my english.

[GitHub] cordova-plugin-file-transfer issue #161: Allowing chunkedMode to be false on...

2016-10-14 Thread abihari
Github user abihari commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/161 I ran into this issue while testing my app on an Android device as well. I modified the code similar to this PR and things work like they should. Please don't overwrite the

[GitHub] cordova-plugin-inappbrowser issue #191: CB-12010 (android) Catch FileUriExpo...

2016-10-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/191 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-inappbrowser issue #191: CB-12010 (android) Catch FileUriExpo...

2016-10-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/191 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-lib issue #484: [CB-11730] Modify condition of if clause to avoid si...

2016-10-14 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/484 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/484?src=pr) is 80.43% (diff: 100%) > Merging [#484](https://codecov.io/gh/apache/cordova-lib/pull/484?src=pr) into

[GitHub] cordova-coho pull request #142: CB-12022 Update jira-triage.md to include ti...

2016-10-14 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-coho/pull/142 CB-12022 Update jira-triage.md to include tips for how to get more info from reporters ### Platforms affected ### What does this PR do? ### What testing

[GitHub] cordova-coho pull request #142: CB-12022 Update jira-triage.md to include ti...

2016-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-coho issue #142: CB-12022 Update jira-triage.md to include tips for ...

2016-10-14 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-coho/pull/142 merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request #501: CB-11951 CB-11967: Respect preference default...

2016-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/501 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #501: CB-11951 CB-11967: Respect preference default values...

2016-10-14 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/501 Thanks for the pr @matrosov-nikita! merged! Feel free to close the issues on jira now :D --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-cli pull request #263: CB-11913 - Re-fix appveyor.yml to use specifi...

2016-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli issue #263: CB-11913 - Re-fix appveyor.yml to use specific node ...

2016-10-14 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/263 Final fix that worked: downgrade to npm@2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-cli pull request #246: CB-11100 Update dependencies to avoid install...

2016-10-14 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-cli/pull/246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser issue #191: CB-12010 (android) Catch FileUriExpo...

2016-10-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/191 Cordova CI Build has completed successfully. **Commit** -

Re: Brief introduction Octavio Bokel

2016-10-14 Thread Jesse
Welcome Octavio! I believe this is the pr: https://github.com/apache/cordova-plugin-camera/pull/239 @purplecabbage risingj.com On Thu, Oct 13, 2016 at 12:20 PM, Joe Bowser wrote: > Hey > > Can you send me a link to the PR so I can check the fix and make sure it's > not

Re: [VOTE] cordova-common@1.5.1

2016-10-14 Thread Jesse
+1 * Ran coho audit-license-headers * Ran coho check-license * Ran coho verify-archive @purplecabbage risingj.com On Thu, Oct 13, 2016 at 11:48 AM, Shazron wrote: > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure

[GitHub] cordova-plugin-inappbrowser pull request #192: CB-12020 Android and iOS: add...

2016-10-14 Thread sfrank87
GitHub user sfrank87 opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/192 CB-12020 Android and iOS: add a method to hide an InAppBrowser after it was shown ### Platforms affected Android, iOS ### What does this PR do? add a hide()

[GitHub] cordova-plugin-camera issue #190: Allowing camera plugin to set an container...

2016-10-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/190 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-inappbrowser issue #192: CB-12020 Android and iOS: add a meth...

2016-10-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/192 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-camera issue #190: Allowing camera plugin to set an container...

2016-10-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/190 Cordova CI Build has one or more failures. **Commit** -