[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87809002 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-plugin-file-transfer issue #165: CB-12107: (android) Trigger media s...

2016-11-14 Thread beatgrabe
Github user beatgrabe commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/165 @infil00p Alright…keep me updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-inappbrowser issue #196: CB-12140: (android) Content descript...

2016-11-14 Thread PhilippeMorier
Github user PhilippeMorier commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/196 @jcesarmobile, I hope this is ok. Thanks for looking into it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87810296 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87809027 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-plugin-network-information pull request #51: CB-11230 CB-11505 iOS: ...

2016-11-14 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/51 CB-11230 CB-11505 iOS: Add compatibility with IPv6 ### Platforms affected iOS ### What does this PR do? This PR adds compatibility with

[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87810709 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87808967 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87807973 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-plugin-media issue #54: Handles the "playAudioWhenScreenIsLocked" si...

2016-11-14 Thread romedius
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/54 @stevengill This is exactly the behavior. The media should pause as soon as `onPause()` is triggered and resumed on `onResume()` Currently this feature is documented as "Quirk" on

[GitHub] cordova-plugin-inappbrowser issue #196: CB-12140: (android) Content descript...

2016-11-14 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/196 Yes, it's ok, I'll merge it later, thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-windows issue #207: CB-12142: Move windows-specific logic from cordo...

2016-11-14 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-windows/pull/207 @vladimir-kotikov @daserge, I've created a Jira issue: https://issues.apache.org/jira/browse/CB-12142, fixed all your comments. Also I think it would be better to add prefix to

[GitHub] cordova-plugin-camera issue #240: CB-12086: Added NSPhotoLibraryUsageDescrip...

2016-11-14 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/240 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-media issue #54: Handles the "playAudioWhenScreenIsLocked" si...

2016-11-14 Thread romedius
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/54 @stevengill in the newer plugin version, 2.4.0 there is a `pauseAllLostFocus()` and `resumeAllGainedFocus()` functionality. Unfortunately that does not works with the

[GitHub] cordova-windows issue #207: Move windows-specific logic from cordova-common

2016-11-14 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/207 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/207?src=pr) is 75.35% (diff: 95.77%) > Merging

[GitHub] cordova-plugin-media issue #54: Handles the "playAudioWhenScreenIsLocked" si...

2016-11-14 Thread romedius
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/54 Replaced by #121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-media pull request #54: Handles the "playAudioWhenScreenIsLoc...

2016-11-14 Thread romedius
Github user romedius closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media issue #121: CB-12146: (android) Adds support for "playA...

2016-11-14 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-media/pull/121 Hey @romedius, Just to confirm, this replaces your other pr. https://github.com/apache/cordova-plugin-media/pull/54 --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-media issue #121: CB-12146: (android) Adds support for "playA...

2016-11-14 Thread romedius
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/121 Yes, I just wanted to wait with closing the other one until there is some activity on this one :) --- If your project is set up for it, you can reply to this email and have your

Nightly build #227 for cordova has succeeded!

2016-11-14 Thread Apache Jenkins Server
Nightly build #227 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/227/consoleFull - Jenkins for Apache Cordova

[CI STATUS REPORT] - 19 actual failures, 3 known failures

2016-11-14 Thread Shazron
http://status.cordova.io # ACTUAL FAILURES 1. Parts of all 19 plugins are failing (seems to be temp file issues: FATAL: Unable to produce a script file java.io.IOException: Failed to create a temp file on E:\jenkins\workspace\cordova-periodic-build) # KNOWN FAILURES (CI issues) 1. cordova-lib

[GitHub] cordova-windows pull request #210: CB-12147: (windows) Fix typo in verbose o...

2016-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87751494 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87750373 --- Diff: template/cordova/lib/ConfigChanges.js --- @@ -159,4 +160,16 @@ function generateUapCapabilities(capabilities) { }

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87752005 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87751813 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87752512 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87752877 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87752779 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87751321 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-plugin-inappbrowser issue #198: CB-12145: (android) Allow third part...

2016-11-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/198 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-network-information issue #51: CB-11230 CB-11505 iOS: Add com...

2016-11-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/51 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request #196: CB-12140: (android) Content d...

2016-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser issue #198: CB-12145: (android) Allow third part...

2016-11-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/198 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media issue #121: CB-12146: (android) Adds support for "playA...

2016-11-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/121 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/121/commits/f5e802afc24b07f88b60246106455ed6f8c31301)

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

2016-11-14 Thread cjpearson
Github user cjpearson commented on the issue: https://github.com/apache/cordova-ios/pull/277 Regarding the tests, based on what I'm seeing they should not be failing. The settings are properly added to the project, but they are ignored in the final product. --- If your project is

[GitHub] cordova-plugin-inappbrowser issue #125: CB-9445 Improves executeScript callb...

2016-11-14 Thread bash88
Github user bash88 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/125 failed for me too on iOS10.1 on iPhone 5s --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-windows issue #210: CB-12147: (windows) Fix typo in verbose output

2016-11-14 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/210 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/210?src=pr) is 74.64% (diff: 100%) > Merging

[GitHub] cordova-plugin-media pull request #121: CB-12146: (android) Adds support for...

2016-11-14 Thread romedius
GitHub user romedius opened a pull request: https://github.com/apache/cordova-plugin-media/pull/121 CB-12146: (android) Adds support for "playAudioWhenScreenIsLocked" already used in iOS ### Platforms affected Android ### What does this PR do? Handle

[GitHub] cordova-plugin-media issue #54: Handles the "playAudioWhenScreenIsLocked" si...

2016-11-14 Thread romedius
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/54 @stevengill I've created a new pull request. See: https://github.com/apache/cordova-plugin-media/pull/121 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-windows pull request #210: CB-12147: (windows) Fix typo in verbose o...

2016-11-14 Thread MSLaguana
GitHub user MSLaguana opened a pull request: https://github.com/apache/cordova-windows/pull/210 CB-12147: (windows) Fix typo in verbose output ### Platforms affected Windows ### What does this PR do? Fixes a typo that reduced the verbose output ### What

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

2016-11-14 Thread cjpearson
Github user cjpearson commented on the issue: https://github.com/apache/cordova-ios/pull/277 It seems like the xcconfig settings override the buildFlag flag. When I run this command on a starter cordova-ios 4.3.0 project, the MinimumOSVersion in the App's Info.plist is still iOS 8.0.

[GitHub] cordova-plugin-inappbrowser pull request #198: CB-12145: (android) Allow thi...

2016-11-14 Thread tmoxon
GitHub user tmoxon opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/198 CB-12145: (android) Allow third party cookies if parameter set Affects: Android 5+ Creates a new parameter for Android browser setup: acceptThirdPartyCookies. If set

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

2016-11-14 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/277 @cjpearson we need the unit tests to work first before this can be pulled in. I added those tests (which should have been there in the first place) because this PR didn't come with one but this