Re: ios-deploy questions

1. Previously we had node_modules bundled. We couldn't bundle ios-deploy because of its viral license. The only issue is that it tries to build on Windows, but that should be easily fixed: https://github.com/ios-control/ios-deploy/issues/355 . There should be no problem in using a dependency from

Re: ios-deploy questions

Thanks Shazron, makes absolute sense. I would personally not favor viral license in the dependencies, even if not bundled. On Thu, Aug 2, 2018 at 11:16 AM Shazron wrote: > > 1. Previously we had node_modules bundled. We couldn't bundle > ios-deploy because of its viral license. The only issue is

Re: WKWebView plugin - issues before baking it in to cordova-ios

Is there a place where the most popular alternative webview engines are documented? Should we add this? Should I raise an issue on cordova-docs? On Thu, Aug 2, 2018 at 11:38 AM Jan Piotrowski wrote: > > That would be really great. Thanks! > > 2018-08-02 17:16 GMT+02:00 Shazron : > > We could --

Re: WKWebView plugin - issues before baking it in to cordova-ios

That would be really great. Thanks! 2018-08-02 17:16 GMT+02:00 Shazron : > We could -- I can just add a suffix or prefix... > On Thu, Aug 2, 2018 at 11:14 PM Jan Piotrowski wrote: >> >> Couldn't the class names be changed when integrating the plugin? >> Because the console stuff is still messing

Re: WKWebView plugin - issues before baking it in to cordova-ios

On Sun, Jul 15, 2018 at 11:39 PM Shazron wrote: > > 4. XmlHttpRequests don't work, because of Cross-Origin Resource > Sharing issue (CORS). There is a workaround plugin created by Oracle > (UPL licensed, which is Apache-2.0 compatible). See > https://issues.apache.org/jira/browse/CB-10143 This

Re: WKWebView plugin - issues before baking it in to cordova-ios

yup, the class name conflict is unavoidable -- it's like when we integrated the console plugin. The bridge plugin will be able to load any webview engine plugin that has already been installed, not just the main 2. I didn't want to confuse people with too much information, since this is not an

Re: WKWebView plugin - issues before baking it in to cordova-ios

We could -- I can just add a suffix or prefix... On Thu, Aug 2, 2018 at 11:14 PM Jan Piotrowski wrote: > > Couldn't the class names be changed when integrating the plugin? > Because the console stuff is still messing with people :/ > > 2018-08-02 17:01 GMT+02:00 Shazron : > > yup, the class name

Re: [DISCUSS] [JIRA -> GitHub Issues] The way forward

> we have issues.cordova.io that right now it just redirects to jira, so > maybe we should have a web page were we list all the repos instead? +1 > >- How to manage meta-issues that concern more than one repo (Can we +1 > >productively use whatever tools GitHub provides here, or will

Re: [DISCUSS] [JIRA -> GitHub Issues] The way forward

> - How do people know in which of the numerous Cordova repos to create > their issues (especially bad for tooling) As Julio already indicated this is a communication problem, that we can solve by having a page at issues.cordova.io. Pages like https://cordova.apache.org/contribute/ also have

Re: [DISCUSS] [JIRA -> GitHub Issues] The way forward

> > For Cordova tooling I expect no one outside of the developers to > really know what happens where - but if I see it correctly we almost > don't have any tooling JIRA issues as well, right? > There's plenty tooling related JIRA issues. And rightly so. IMHO, joining all tooling packages in a

Re: WKWebView plugin - issues before baking it in to cordova-ios

Couldn't the class names be changed when integrating the plugin? Because the console stuff is still messing with people :/ 2018-08-02 17:01 GMT+02:00 Shazron : > yup, the class name conflict is unavoidable -- it's like when we > integrated the console plugin. > > The bridge plugin will be able to

Nightly build #808 for cordova has failed

Nightly build #808 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/808/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/808/consoleFull - Jenkins for Apache Cordova

Re: WKWebView plugin - issues before baking it in to cordova-ios

Our policy has been we support the currently shipping iOS version, plus one back. This is because of device version testing complexities. It may work on older iOS versions if we code it with the right safeguards, but that is not guaranteed. When iOS 12 ships this fall, we would drop iOS 10 support

Re: WKWebView plugin - issues before baking it in to cordova-ios

One concern with the Oracle plugin is that it's only patching the obvious cases of XHR and fetch, but doesn't handle things like iframes being cross origin (so no accessing the parent/child document) or local image assets being cross origin when drawn to canvas (thus tainting the canvas and making

Re: Do another cordova-android patch release?

> Also considered adding this one about Android Studio compatibility, but was > not sure if the change might be considered breaking or at least minor, so > didn't do it. What would be an argument for this to be considered breaking? 2018-08-02 13:26 GMT+02:00 julio cesar sanchez : > I've sent the

Re: WKWebView plugin - issues before baking it in to cordova-ios

Please review the draft of the blog post about this: "The Future of the iOS WebView in Apache Cordova" https://github.com/apache/cordova-docs/pull/867 On Mon, Jul 16, 2018 at 2:38 PM Shazron wrote: > > I've done with my review with all the issues that need to resolved > with the plugin before it

Re: [DISCUSS] [JIRA -> GitHub Issues] The way forward

Decision making for Apache projects is described here: https://community.apache.org/committers/decisionMaking.html So to make it official: I hereby declare that I will start implementing the stuff from my initial email if nobody objects in the next 72 hours (meaning: before next Monday). After

Re: ios-deploy questions

> 1. Why not make ios-deploy a dependency of cordova-ios that would then > be automatically installed? Historically, I think, commands that should be able to be called via the command line had to be installed globally with npm to work. Is this not the case any more? 2018-08-02 15:26 GMT+02:00

Re: WKWebView plugin - issues before baking it in to cordova-ios

Many Cordova users out there are probably using https://github.com/ionic-team/cordova-plugin-ionic-webview. Does this play any role in regards to the blog post? Should this maybe be mentioned as an anticipated question? 2018-08-02 16:31 GMT+02:00 Shazron : > Please review the draft of the blog

Re: Do another cordova-android patch release?

It bumps gradle and gradle plugin versions, which might break old things 2018-08-02 16:28 GMT+02:00 Jan Piotrowski : > > Also considered adding this one about Android Studio compatibility, but > was > > not sure if the change might be considered breaking or at least minor, so > > didn't do it. >

Re: WKWebView plugin - issues before baking it in to cordova-ios

As long as we don't break pluggable webviews, I don't think it's needed, there are other wkwebview plugins (from telerik, oracle, etc). But as some (or all) of them started as forks, there will be probably problems with duplicate class names. 2018-08-02 16:42 GMT+02:00 Jan Piotrowski : > Many

Re: [DISCUSS] [JIRA -> GitHub Issues] The way forward

+1 On Thu, Aug 2, 2018 at 10:34 AM Jan Piotrowski wrote: > > Decision making for Apache projects is described here: > https://community.apache.org/committers/decisionMaking.html > > So to make it official: > I hereby declare that I will start implementing the stuff from my > initial email if

Re: [DISCUSS] [JIRA -> GitHub Issues] The way forward

There is much I don't like about JIRA and in general I prefer GitHub issues. However, there's issues that did came up during previous discussions of this topic, and that have no proper solution that I know of - How do people know in which of the numerous Cordova repos to create their issues

Re: [DISCUSS] [JIRA -> GitHub Issues] The way forward

we have issues.cordova.io that right now it just redirects to jira, so maybe we should have a web page were we list all the repos instead? 2018-08-02 16:51 GMT+02:00 : > There is much I don't like about JIRA and in general I prefer GitHub > issues. However, there's issues that did came up during

Re: Any reason to support Xcode pre-9 on cordova-ios@4 or cordova-osx?

The only reason I can think is enterprise apps that are not distributed in App Store or hobbyist that build the apps for themselves. In this cases they might be using an older computer that can’t execute Xcode 9. But not sure is worth the effort and we can remove some code not supporting it. In

Re: [cordova-android] Fwd: Important reminder about Android targetSdkVersion requirement

cordova-android 7.0.0 targets SDK 26, 7.1.x targets SDK 27, so we are good to go. But this is why I wanted to cherry pick the plugin compatibility fixes on 7.1.x branch, so people update to those versions. And also a new CLI release with 7.1.x pinned will help (but Chris said he planning on

Re: Commit package-lock.json in next major Cordova release or not?

+1 - everything that modernizes the tooling that can be used and actually uses its added functionality is a win. 2018-08-02 7:43 GMT+02:00 Chris Brody : > Just raised https://issues.apache.org/jira/browse/CB-14248 > > Thanks for the helpful responses > On Thu, Aug 2, 2018 at 12:12 AM Shazron

[cordova-android] Fwd: Important reminder about Android targetSdkVersion requirement

Anything we should do about that for Cordova Android or the default Cordova project? What should other projects using Cordova Android do? (e.g. Ionic) -J -- Forwarded message -- From: Google Play Date: 2018-08-02 4:51 GMT+02:00 Subject: Important reminder about Android

ios-deploy questions

A couple things that I think are not clear for : 1. Why not make ios-deploy a dependency of cordova-ios that would then be automatically installed? 2. Is there a risk of mismatch

Re: [DISCUSS] [JIRA -> GitHub Issues] The way forward

What will it take to take care of a) Enable GitHub issues on all repositories via INFRA ticket? I think this is needed really badly. There are way too many cases of questions and issues being raised in the wrong place, lost in diverse discussion forums, or not even asked at all. On Wed, Aug 1,

Re: ios-deploy questions

To add some context: this question is moved from https://github.com/apache/cordova-docs/issues/866 I think we should clarify both of the following: * "Should this be documented in another way?" * "Should this be different?" Confirmation would be really appreciated. On Thu, Aug 2, 2018 at 9:26 AM

Re: Do another cordova-android patch release?

I've sent the PR with the cherry pick https://github.com/apache/cordova-android/pull/469 It include 4 commits, 3 related to the plugins and another one about simulator failing to launch. Also considered adding this one about Android Studio compatibility, but was not sure if the change might be