Can someone help, perhaps Vladimir who wrote the tests can shed some light
on how to fix this issue?
On Mon, Apr 25, 2016 at 10:57 AM, Carlos Santana
wrote:
> It's jasmine test that is failing [1]
>
> Does this means that jasmine tests are not running in a continuously?
Or slack, but slack is only searchable back the last 10k messages.
@purplecabbage
risingj.com
On Thu, Apr 28, 2016 at 5:36 PM, Shazron wrote:
> Perhaps it's time for a users mailing list. No dev is expected to answer
> questions on it.
>
> Example:
Re: cordova-lib release, I want to get this in:
https://issues.apache.org/jira/browse/CB-11009
Not sure impact yet as long as unit tests pass
On Wed, Apr 27, 2016 at 11:53 AM, Darryl Pogue wrote:
> Not a plugin, but I'd appreciate a tools release (or at least a cordova-lib
>
Perhaps it's time for a users mailing list. No dev is expected to answer
questions on it.
Example: https://httpd.apache.org/userslist.html
Right now we push people off to either:
1. Stack Overflow
2. PhoneGap Google Groups
3. Adobe PhoneGap Forums
Thoughts?
This list is for the development of Cordova itself. For
technical support questions, I recommend asking on Stack Overflow, or
on the PhoneGap Google Group, you may get help more quickly.
Although your issues sounds to be more about Oracle JET Hybrid Mobile than
Cordova, are you sure you are in
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8#issuecomment-215585938
I also commented on #7.
To solve this problem, instead of having to instantiate WKWebView twice
here, I think we can safely move all
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-215584737
@ephemer not just settings (which as you said will probably not a frequent
scenario), but setting the other delegates. updateWithInfo will be
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61504885
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -84,29 +101,49 @@ function updateConfigFilesFrom(sourceConfig,
configMunger, locations) {
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61503079
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var xmlHelpers =
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61502339
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/301#issuecomment-215561101
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61501081
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/124
Add fenced code blocks - with language hints
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikhilkh/cordova-plugin-contacts
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/301#issuecomment-215537523
Sure, you can skip them safely. This is because we ship them as 'bundled'
dependencies, since we don't run `npm install` after downloading the
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/301#issuecomment-215533601
Can I ignore all the changes under node_modules? I don't understand why
that is checked in to source control...
---
If your project is set up for it, you can
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/588
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/588#issuecomment-215531427
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/588
CB-11169: Adding new repo links to contribute page
@rakatyal
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-215524649
I tried it out a bit just now (without crosswalk). Java code changes
refreshed fine for me. The webview gets restarted of course, but my java
changes were
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/171#issuecomment-215523674
@jasongin Can you please help review? Related to apache/cordova-android#301
---
If your project is set up for it, you can reply to this email and have your
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/219#issuecomment-215523478
@jasongin Can you please help review? Related to
https://github.com/apache/cordova-android/pull/301
---
If your project is set up for it, you can reply to this
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/301#issuecomment-215523214
@jasongin Can you please help review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-215512407
@riknoll Did you test Instant Run on Android Studio? I don't expect this to
work with Crosswalk. We need help from them getting Crosswalk to work with the
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215512291
Merging this without the suggested variable name changes, as we'll be
moving away from cordova-medic soon anyway.
---
If your project is set up for it, you can
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-215511375
I built/ran mobilespec with and without crosswalk and I didn't encounter
any issues. One weird thing that did happen was that I wasn't able to increase
the
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215510394
This is a good find. Hopefully, this will fix all our issues with contacts
permissions ð
---
If your project is set up for it, you can reply to this email
The Buildbot working for ''
has noticed that the buildslave named cordova-windows-slave went away
It last disconnected at Thu Apr 28 17:33:35 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123#discussion_r61469757
--- Diff: appium-tests/common/common.spec.js ---
@@ -114,14 +116,15 @@ describe('Contacts Android', function () {
})
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123#discussion_r61469221
--- Diff: appium-tests/common/common.spec.js ---
@@ -133,7 +136,7 @@ describe('Contacts Android', function () {
function
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123#discussion_r61468850
--- Diff: appium-tests/common/common.spec.js ---
@@ -114,14 +116,15 @@ describe('Contacts Android', function () {
})
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215503182
@sarangan12 a quick search through the repo yields only 4 files with less
than 10 instances that would need to be updated.
I think it is worth the effort, :)
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215502169
@omefire Agreed. But that would involve additiional code changes which are
not related directly to this issue. You can create a seperate JIRA for it.
Also, I
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123#discussion_r61468116
--- Diff: appium-tests/common/common.spec.js ---
@@ -114,14 +116,15 @@ describe('Contacts Android', function () {
})
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123#discussion_r61467646
--- Diff: appium-tests/common/common.spec.js ---
@@ -114,14 +116,15 @@ describe('Contacts Android', function () {
})
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215501596
Hmm, we've got a case of confusing naming here. I think we should rename
```argv.app``` to ```argv.appName```. That will make the intent clearer and
prevent such
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123#discussion_r61467710
--- Diff: appium-tests/common/common.spec.js ---
@@ -133,7 +136,7 @@ describe('Contacts Android', function () {
function
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-medic/pull/101
CB-11168: Fix the appName in cordova-medic
The appName is just set to incorrect value. The appName must be
'org.apache.mobilespec'. But, when it is picked from command line arguments,
In order to support push notification in my hybrid application, I added
phonegap-plugin-push. But after adding this plugin, the application build
process takes more than 20 minutes! (10 for build and 10 for serve)
Here are the steps:
1.HYPERLINK
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61462710
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var xmlHelpers =
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61461619
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var xmlHelpers =
GitHub user ephemer opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8
CB-11074: Ensure settings from config.xml are taken into consideration
#7 also addresses this issue but in my tests didn't work.
This pull request presents a
Github user daserge commented on the pull request:
https://github.com/apache/cordova-android/pull/302#issuecomment-215487630
Reverted
https://github.com/apache/cordova-android/commit/abcaee24f9bd0e680f8d06ced5e0d363d63cffb7
to unblock the CI.
Reopened the
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/302#issuecomment-215486540
Can you explain what was the issue here and why this fixes it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/302
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215478064
## [Current coverage][cc-pull] is **79.60%**
> Merging [#432][cc-pull] into [master][cc-base-branch] will increase
coverage by **-0.49%**
```diff
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123
CB-11166 Added an Appium tests to check for contact's birthday
https://issues.apache.org/jira/browse/CB-11166
You can merge this pull request into a Git repository by running:
Github user ephemer commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-215453411
As I commented in the base repo, this PR doesn't do what it says it does
yet.
@shazron is it normal to change the settings after the
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-android/pull/302#issuecomment-215448214
## [Current coverage][cc-pull] is **100%**
> Merging [#302][cc-pull] into [master][cc-base-branch] will not change
coverage
```diff
@@
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-android/pull/302
CB-11163 Android Builds are failing in CI
CB-11133 Handle android emulator start failure (reverted from commit
abcaee24f9bd0e680f8d06ced5e0d363d63cffb7)
You can merge this pull request
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-cli/pull/246
CB-11100 Update dependencies to avoid installation warnings
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-ios/pull/219
CB-11161 Reuse PluginManager from common to add/rm plugins
A change to use `PluginManager` class to manage plugin
installation/uninstallation instead of custom logic
JIRA:
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/301
CB-11138 Reuse PluginManager from common to add/rm plugins
A change to use `PluginManager` class to manage plugin
installation/uninstallation instead of custom logic
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-windows/pull/171#issuecomment-215373720
## [Current coverage][cc-pull] is **100%**
> Merging [#171][cc-pull] into [master][cc-base-branch] will not change
coverage
```diff
@@
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/171
CB-11139 Use PluginManager from common to install/uninstall plugins
This PR removes a lot of the code, related to plugin installation in favor
of unified `PluginManager` class,
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61393298
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -295,25 +344,47 @@ function handleIcons(projectConfig, platformRoot) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61392785
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61391425
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61388176
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -84,29 +101,49 @@ function updateConfigFilesFrom(sourceConfig,
configMunger,
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61388100
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -84,29 +101,49 @@ function updateConfigFilesFrom(sourceConfig,
configMunger,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61383879
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61383391
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var
64 matches
Mail list logo