Nightly build #113 for cordova has succeeded!

2016-08-26 Thread Apache Jenkins Server 
Nightly build #113 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/113/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

2016-08-26 Thread shazron 
Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
  
Filed https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request #16: CB-11554 - too 'brutal' ap...

2016-08-26 Thread shazron 
GitHub user shazron opened a pull request:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16

CB-11554 - too 'brutal' app reload when title is empty



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-plugin-wkwebview-engine 
CB-11554

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit 6d39ff1fa0a27aeefdfb1e36af49481f18279b98
Author: Shazron Abdullah 
Date:   2016-08-27T01:05:22Z

CB-11554 - too 'brutal' app reload when title is empty




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #55: Handle extended status bar on iOS

2016-08-26 Thread goshakkk 
Github user goshakkk commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/55
  
Signed and emailed the ICLA


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[ANNOUNCE] Cordova-create@1.0.0 released

2016-08-26 Thread Steven Gill 
https://www.npmjs.com/package/cordova-create

I will blog about it in the next tools release.

Cheers,
-Steve

Re: [VOTE] Cordova-create@1.0.0 release

2016-08-26 Thread Steven Gill 
The vote has now closed. The results are:

Positive Binding Votes: 4
Steve Gill
Vladimir Kotikov
Shazron Abdullah
Jesse MacFadyen

The vote has passed.


On Fri, Aug 26, 2016 at 12:47 AM, Jesse  wrote:

> I vote +1
>
> * Verified archives using coho verify-archive
> * Ran coho check-license
> * Ensured tests are passing
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Aug 25, 2016 at 11:32 PM, Shazron  wrote:
>
> > I vote +1
> >
> > * Verified archives using coho verify-archive
> > * Ran coho check-license
> > * Ensured tests are passing
> >
> > On Tue, Aug 23, 2016 at 5:03 PM, Steven Gill 
> > wrote:
> >
> > > Please review and vote on this cordova-create Release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-11722
> > >
> > > Both tools have been published to
> > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11722/
> > >
> > > The package was published from its corresponding git tag:
> > >
> > > cordova-create: 1.0.0 (4a49545f0f)
> > >
> > > Upon a successful vote I will upload the archives to dist/, publish it
> > > to npm, and post the corresponding blog post.
> > >
> > > Voting guidelines:
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> > release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Ensured unit tests and end to end tests were passing.
> > >
> >
>

[GitHub] cordova-lib issue #486: CB-11776 check edit-config target exists

2016-08-26 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/486
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/486?src=pr) is 80.78% 
(diff: 100%)
> Merging [#486](https://codecov.io/gh/apache/cordova-lib/pull/486?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #486   diff @@
==
  Files68 68  
  Lines  5407   5407  
  Methods 857857  
  Messages  0  0  
  Branches   1048   1048  
==
  Hits   4368   4368  
  Misses 1039   1039  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[3b38b53...a7e6634](https://codecov.io/gh/apache/cordova-lib/compare/3b38b5382b9a52d1fe522514b61d3ebd6016796d...a7e6634217e187434d560ac2d32bf352662b3a25?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-26 Thread stevengill 
Github user stevengill commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/197
  
Sounds good @swbradshaw. It looks like 
https://github.com/apache/cordova-plugin-camera/commit/fed798e6c7f56e23bff994ab2c11d316c8257a78
 created some conflicts. I'll hold off on the release until I can merge this 
in. Let me know how it goes!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #114: CB-11380 (ios) Overloaded audioFileF...

2016-08-26 Thread alsorokin 
Github user alsorokin closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/114


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #114: CB-11380 (ios) Overloaded audioFileForResou...

2016-08-26 Thread alsorokin 
Github user alsorokin commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/114
  
Thanks Shazron!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #486: CB-11776 check edit-config target exists

2016-08-26 Thread ktop 
GitHub user ktop opened a pull request:

https://github.com/apache/cordova-lib/pull/486

CB-11776 check edit-config target exists

Missing a case in the conflict checking for edit-config. If the target 
doesn't exist in .json, and cannot resolve to an existing target, 
then no conflict should be found. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ktop/cordova-lib ecerror

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/486.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #486


commit a7e6634217e187434d560ac2d32bf352662b3a25
Author: ktop 
Date:   2016-08-26T21:59:46Z

CB-11776 check edit-config target exists




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-26 Thread swbradshaw 
Github user swbradshaw commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/197
  
@stevengill ill take a look this weekend. This is my first PR/rebase so 
I've got some homework to do


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-26 Thread stevengill 
Github user stevengill commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/197
  
@swbradshaw any chance you can deal with the merge conflicts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #114: CB-11380 (ios) Overloaded audioFileForResou...

2016-08-26 Thread shazron 
Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/114
  
LGTM 👍 
Tested locally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #114: CB-11380 (ios) Overloaded audioFileForResou...

2016-08-26 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/114
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/114/commits/9f0c2e3e6bc1d76dcb0759f2aaf9e4137e391b09)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #55: Handle extended status bar on iOS

2016-08-26 Thread jcesarmobile 
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/55
  
@nnixaa there are plans, but I'm waiting for @goshakkk to send his ICLA and 
make the changes I proposed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #114: CB-11380 (ios) Overloaded audioFileF...

2016-08-26 Thread alsorokin 
GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/114

CB-11380 (ios) Overloaded audioFileForResource method instead of modi…

### Platforms affected
ios

### What does this PR do?
https://issues.apache.org/jira/browse/CB-11380
Overloads the audioFileForResource method instead of modifying its 
signature because otherwise it would be an API breakage.

### What testing has been done on this change?
No testing whatsoever: I don't have an access to any iOS device till 
tomorrow. Creating this PR to let CI test the changes.

### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-media CB-11380

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #114


commit 9f0c2e3e6bc1d76dcb0759f2aaf9e4137e391b09
Author: Alexander Sorokin 
Date:   2016-08-26T18:41:51Z

CB-11380 (ios) Overloaded audioFileForResource method instead of modifying 
its signature




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #106: CB-7497: (iOS) Fix bug with a...

2016-08-26 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #104: Acc+

2016-08-26 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: cordova-plugin-media git commit: CB-11380 (ios) Updated modified method signature in the .h file

2016-08-26 Thread Alexander Sorokin (Akvelon) 
Oh, I didn’t mean to break the API.

I agree, let me do this and send the PR shortly.



Thanks,

Alexander Sorokin



From: Shazron
Sent: Friday, August 26, 2016 6:42 PM
To: alsoro...@apache.org
Cc: comm...@cordova.apache.org; 
dev@cordova.apache.org
Subject: Re: cordova-plugin-media git commit: CB-11380 (ios) Updated modified 
method signature in the .h file



I think we should add an overload and add back the old API method, since
this is effectively removing API and we don't want the hassle of a major
version bump.

On Friday, August 26, 2016,  wrote:

> Repository: cordova-plugin-media
> Updated Branches:
>   refs/heads/master 910d3c798 -> 42b279b91
>
>
> CB-11380 (ios) Updated modified method signature in the .h file
>
>
> Project: 
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%2fcordova-plugin-media%2frepo=01%7c01%7cv-alsoro%40microsoft.com%7ce58dc80986764ec64d6a08d3cdc7a502%7c72f988bf86f141af91ab2d7cd011db47%7c1=bdrJOPrWlICXFtcJ9i8pKk3DQihy0PXFfTfw%2bggueKk%3d
> Commit: 
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%2fcordova-plugin-=01%7c01%7cv-alsoro%40microsoft.com%7ce58dc80986764ec64d6a08d3cdc7a502%7c72f988bf86f141af91ab2d7cd011db47%7c1=SalJDUACrJivrjANeeckxRmqouYAchpwDZ%2bAPOTOgFw%3d
> media/commit/42b279b9
> Tree: 
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%2fcordova-plugin-=01%7c01%7cv-alsoro%40microsoft.com%7ce58dc80986764ec64d6a08d3cdc7a502%7c72f988bf86f141af91ab2d7cd011db47%7c1=SalJDUACrJivrjANeeckxRmqouYAchpwDZ%2bAPOTOgFw%3d
> media/tree/42b279b9
> Diff: 
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%2fcordova-plugin-=01%7c01%7cv-alsoro%40microsoft.com%7ce58dc80986764ec64d6a08d3cdc7a502%7c72f988bf86f141af91ab2d7cd011db47%7c1=SalJDUACrJivrjANeeckxRmqouYAchpwDZ%2bAPOTOgFw%3d
> media/diff/42b279b9
>
> Branch: refs/heads/master
> Commit: 42b279b911c4b20689290f55ecb849905d3f1673
> Parents: 910d3c7
> Author: Alexander Sorokin >
> Authored: Fri Aug 26 17:06:07 2016 +0300
> Committer: Alexander Sorokin 
> >
> Committed: Fri Aug 26 17:06:07 2016 +0300
>
> --
>  src/ios/CDVSound.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> --
>
>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%2fcordova-plugin-=01%7c01%7cv-alsoro%40microsoft.com%7ce58dc80986764ec64d6a08d3cdc7a502%7c72f988bf86f141af91ab2d7cd011db47%7c1=SalJDUACrJivrjANeeckxRmqouYAchpwDZ%2bAPOTOgFw%3d
> media/blob/42b279b9/src/ios/CDVSound.h
> --
> diff --git a/src/ios/CDVSound.h b/src/ios/CDVSound.h
> index 1dca574..c3f7a6c 100644
> --- a/src/ios/CDVSound.h
> +++ b/src/ios/CDVSound.h
> @@ -106,7 +106,7 @@ typedef NSUInteger CDVMediaMsg;
>  - (NSURL*)urlForRecording:(NSString*)resourcePath;
>  - (NSURL*)urlForPlaying:(NSString*)resourcePath;
>
> -- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath
> withId:(NSString*)mediaId doValidation:(BOOL)bValidate
> forRecording:(BOOL)bRecord;
> +- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath
> withId:(NSString*)mediaId doValidation:(BOOL)bValidate
> forRecording:(BOOL)bRecord suppressValidationErrors:(BOOL)bSuppress;
>  - (BOOL)prepareToPlay:(CDVAudioFile*)audioFile withId:(NSString*)mediaId;
>  - (NSString*)createMediaErrorWithCode:(CDVMediaError)code
> message:(NSString*)message;
>
>
>
> -
> To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
> 
> For additional commands, e-mail: commits-h...@cordova.apache.org
> 
>
>

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-08-26 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/244
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-ios/pull/244?src=pr) is 53.18% 
(diff: 11.11%)
> Merging [#244](https://codecov.io/gh/apache/cordova-ios/pull/244?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) 
will decrease coverage by **0.31%**

```diff
@@ master   #244   diff @@
==
  Files12 12  
  Lines  1028   1036 +8   
  Methods 145147 +2   
  Messages  0  0  
  Branches169171 +2   
==
+ Hits550551 +1   
- Misses  478485 +7   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[582e357...15b4fdc](https://codecov.io/gh/apache/cordova-ios/compare/582e35776f01ee03f32f0986de181bcf5eb4d232...15b4fdc6655b034888eb20122df9560c0b42195b?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #485: CB-11771 Deep symlink directories to target project ...

2016-08-26 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/485
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/485?src=pr) is 80.81% 
(diff: 88.88%)
> Merging [#485](https://codecov.io/gh/apache/cordova-lib/pull/485?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will increase coverage by **0.02%**

```diff
@@ master   #485   diff @@
==
  Files68 68  
  Lines  5407   5415 +8   
  Methods 857859 +2   
  Messages  0  0  
  Branches   1048   1050 +2   
==
+ Hits   4368   4376 +8   
  Misses 1039   1039  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[3b38b53...1eb9b20](https://codecov.io/gh/apache/cordova-lib/compare/3b38b5382b9a52d1fe522514b61d3ebd6016796d...1eb9b207718f00d0101d31c44f9a492f5c16725b?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #326: CB-11771 Deep symlink directories to target proj...

2016-08-26 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/326
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/326?src=pr) is 
33.67% (diff: 20.00%)
> Merging 
[#326](https://codecov.io/gh/apache/cordova-android/pull/326?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will decrease coverage by **0.10%**

```diff
@@ master   #326   diff @@
==
  Files11 11  
  Lines   965968 +3   
  Methods 197199 +2   
  Messages  0  0  
  Branches157158 +1   
==
  Hits326326  
- Misses  639642 +3   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[4a0a7bc...817fc3a](https://codecov.io/gh/apache/cordova-android/compare/4a0a7bc424fae14c9689f4a8a2dc250ae3a47f82...817fc3ae70443e06ea9e6e6af298e7d839b0ff2a?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #485: CB-11771 Deep symlink directories to target p...

2016-08-26 Thread mbektchiev 
GitHub user mbektchiev opened a pull request:

https://github.com/apache/cordova-lib/pull/485

CB-11771 Deep symlink directories to target project instead of linking the 
directory itself

When installing a plugin with custom library using the --link option the 
whole directory is symlinked and temporary
files leak into the original plugin directory on build. This leads to 
broken builds if the same plugin is linked in
2 projects targeting different Cordova versions.

fixes [CB-11771 Installing plugin with symlink option pollutes original 
directory with intermediate 
files](https://issues.apache.org/jira/browse/CB-11771)

related to https://github.com/apache/cordova-ios/pull/244 and 
https://github.com/apache/cordova-android/pull/326

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Icenium/cordova-lib bektchiev/deep-symlink

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #485


commit 1eb9b207718f00d0101d31c44f9a492f5c16725b
Author: Martin Bektchiev 
Date:   2016-08-26T12:08:16Z

CB-11771 Deep symlink directories to target project instead of linking the 
directory itself

When installing a plugin with custom library using the --link option the 
whole directory is symlinked and temporary
files leak into the original plugin directory on build. This leads to 
broken builds if the same plugin is linked in
2 projects targeting different Cordova versions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: cordova-plugin-media git commit: CB-11380 (ios) Updated modified method signature in the .h file

2016-08-26 Thread Shazron 
I think we should add an overload and add back the old API method, since
this is effectively removing API and we don't want the hassle of a major
version bump.

On Friday, August 26, 2016,  wrote:

> Repository: cordova-plugin-media
> Updated Branches:
>   refs/heads/master 910d3c798 -> 42b279b91
>
>
> CB-11380 (ios) Updated modified method signature in the .h file
>
>
> Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-media/repo
> Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-
> media/commit/42b279b9
> Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-
> media/tree/42b279b9
> Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-
> media/diff/42b279b9
>
> Branch: refs/heads/master
> Commit: 42b279b911c4b20689290f55ecb849905d3f1673
> Parents: 910d3c7
> Author: Alexander Sorokin >
> Authored: Fri Aug 26 17:06:07 2016 +0300
> Committer: Alexander Sorokin 
> >
> Committed: Fri Aug 26 17:06:07 2016 +0300
>
> --
>  src/ios/CDVSound.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/cordova-plugin-
> media/blob/42b279b9/src/ios/CDVSound.h
> --
> diff --git a/src/ios/CDVSound.h b/src/ios/CDVSound.h
> index 1dca574..c3f7a6c 100644
> --- a/src/ios/CDVSound.h
> +++ b/src/ios/CDVSound.h
> @@ -106,7 +106,7 @@ typedef NSUInteger CDVMediaMsg;
>  - (NSURL*)urlForRecording:(NSString*)resourcePath;
>  - (NSURL*)urlForPlaying:(NSString*)resourcePath;
>
> -- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath
> withId:(NSString*)mediaId doValidation:(BOOL)bValidate
> forRecording:(BOOL)bRecord;
> +- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath
> withId:(NSString*)mediaId doValidation:(BOOL)bValidate
> forRecording:(BOOL)bRecord suppressValidationErrors:(BOOL)bSuppress;
>  - (BOOL)prepareToPlay:(CDVAudioFile*)audioFile withId:(NSString*)mediaId;
>  - (NSString*)createMediaErrorWithCode:(CDVMediaError)code
> message:(NSString*)message;
>
>
>
> -
> To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
> 
> For additional commands, e-mail: commits-h...@cordova.apache.org
> 
>
>

[GitHub] cordova-ios pull request #244: CB-11771 Deep symlink directories to target p...

2016-08-26 Thread mbektchiev 
GitHub user mbektchiev opened a pull request:

https://github.com/apache/cordova-ios/pull/244

CB-11771 Deep symlink directories to target project instead of linking the 
directory itself

When installing a plugin with custom library using the --link option the 
whole directory is symlinked and temporary
files leak into the original plugin directory on build. This leads to 
broken builds if the same plugin is linked in
2 projects targeting different Cordova versions.

fixes [CB-11771 Installing plugin with symlink option pollutes original 
directory with intermediate 
files](https://issues.apache.org/jira/browse/CB-11771)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Icenium/cordova-ios bektchiev/deep-symlink

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #244


commit 15b4fdc6655b034888eb20122df9560c0b42195b
Author: Martin Bektchiev 
Date:   2016-08-26T14:45:59Z

CB-11771 Deep symlink directories to target project instead of linking the 
directory itself

When installing a plugin with custom library using the --link option the 
whole directory is symlinked and temporary
files leak into the original plugin directory on build. This leads to 
broken builds if the same plugin is linked in
2 projects targeting different Cordova versions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #326: CB-11771 Deep symlink directories to targ...

2016-08-26 Thread mbektchiev 
GitHub user mbektchiev opened a pull request:

https://github.com/apache/cordova-android/pull/326

CB-11771 Deep symlink directories to target project instead of linking the 
directory itself

When installing a plugin with custom library using the --link option the 
whole directory is symlinked and temporary
files leak into the original plugin directory on build. This leads to 
broken builds if the same plugin is linked in
2 projects targeting different Cordova versions.

fixes [CB-11771 Installing plugin with symlink option pollutes original 
directory with intermediate 
files](https://issues.apache.org/jira/browse/CB-11771)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Icenium/cordova-android bektchiev/deep-symlink

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/326.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #326


commit 817fc3ae70443e06ea9e6e6af298e7d839b0ff2a
Author: Martin Bektchiev 
Date:   2016-08-26T15:21:23Z

CB-11771 Deep symlink directories to target project instead of linking the 
directory itself

When installing a plugin with custom library using the --link option the 
whole directory is symlinked and temporary
files leak into the original plugin directory on build. This leads to 
broken builds if the same plugin is linked in
2 projects targeting different Cordova versions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #104: Acc+

2016-08-26 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/104
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/104/commits/42b279b911c4b20689290f55ecb849905d3f1673)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/74//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #113: CB-11757 (ios) Error out if trying to stop ...

2016-08-26 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/113
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/113/commits/ad047a1b26228717c4226289a0c4772eb02dc677)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/73//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #113: CB-11757 (ios) Error out if trying t...

2016-08-26 Thread alsorokin 
GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/113

CB-11757 (ios) Error out if trying to stop playback while in a wrong …


### Platforms affected
ios

### What does this PR do?
https://issues.apache.org/jira/browse/CB-11757
Makes ios implementation to send error callback when trying to stop the 
playback when the avPlayer is not yet ready.

### What testing has been done on this change?
Manual and automated testing on iPad 2 with iOS 8.1
Also ran modified automated tests on Android 4.4 Emulator and on desktop 
Windows 10.

### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-media CB-11757

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #113


commit ad047a1b26228717c4226289a0c4772eb02dc677
Author: Alexander Sorokin 
Date:   2016-08-26T09:48:50Z

CB-11757 (ios) Error out if trying to stop playback while in a wrong state




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[PROPOSAL] Using cordovaDependencies in core plugins

2016-08-26 Thread Vladimir Kotikov (Akvelon) 
Hey all

We've been researching ways to prevent cordova workflow breakages, caused by 
installing edge versions of the plugins, which possibly could be incompatible 
with cordova version, used by user. This is IMO a very nasty sort of problems, 
because it might cause unpredictable build- and runtime failures of cordova 
setup which has been working perfectly previously.

A typical example of this scenario is when some plugin introduces a change 
incompatible w/ some particular cordova version and doesn't update 
'cordovaDependencies' property in its' package.json correspondingly.

To prevent such breakages and avoid negative user experience I propose to start 
using `cordovaDependencies` in our core plugins in a following way:

1. For every plugin we maintain, we add `cordovaDependencies` to its' 
package.json w/ the following entry

CURRENT_PLUGIN_VERSION: { cordova: >= LATEST_SUPPORTED_CORDOVA_VERSION }

We will try to determine the LATEST_SUPPORTED_CORDOVA_VERSION based on release 
notes and most significant changes in plugins, but probably we can safely use 
6.1.0 here because new version choosing logic for `plugin add` was introduced 
in this version and older versions of cordova will not use 
`cordovaDependencies` anyway.

Also for some plugins adding such entry doesn't make sense because they will 
work with any version of cordova, so for these plugins this step could be 
omitted.

2. For every plugin we add additional 'protective' entry
  
NEXT_MAJOR_PLUGIN_VERSION: { cordova: >= 100 }
  
  There are 2 purposes for this:

  - if there is a major plugin update that potentially would broke 
compatibility with some cordova versions, this will protect users against 
installing this major update, unless plugin maintainers update 
`cordovaDependencies` by adding corresponding entry for this plugin version.

In other words, if we've introduced a breaking change and forgot to update 
`cordovaDependencies` correspondingly to reflect that the change requires a 
specific cordova version, user will not get this plugin update.

  - By some reason without such 'protective' entry in case if 
NEXT_MAJOR_PLUGIN_VERSION gets released without adding corresponding entry to 
`cordovaDependencies` (i.e. we don't have any restrictions for this version in 
`cordovaDependencies`) - cordova will fetch that version without any checks. 
This is sounds non-obviously for me and probably there is some reason behind 
installing plugin version, which we can't verify requirements for, but this is 
how it works.

3. When we introduce a change that requires us to change plugin version to 
`NEXT_MAJOR_PLUGIN_VERSION`, we go and fix `cordovaDependencies` by changing 
cordova requirement for `NEXT_MAJOR_PLUGIN_VERSION` to actual value instead of 
100 and introducing `ANOTHER_NEXT_MAJOR_PLUGIN_VERSION: { cordova: >= 100 }` 
entry.

I would love to hear any feedback about this proposal or any other ideas that 
might help us to prevent such breakages w/ cordova and plugins.

-
Best regards, Vladimir


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #104: Acc+

2016-08-26 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/104
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/104/commits/910d3c798f77c63165be508125ec313e4104b541)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/72//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #112: CB-11380 (ios) Fixed an unexpected e...

2016-08-26 Thread alsorokin 
Github user alsorokin closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/112


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #112: CB-11380 (ios) Fixed an unexpected error ca...

2016-08-26 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/112
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/112/commits/910d3c798f77c63165be508125ec313e4104b541)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] Cordova-create@1.0.0 release

2016-08-26 Thread Jesse 
I vote +1

* Verified archives using coho verify-archive
* Ran coho check-license
* Ensured tests are passing


@purplecabbage
risingj.com

On Thu, Aug 25, 2016 at 11:32 PM, Shazron  wrote:

> I vote +1
>
> * Verified archives using coho verify-archive
> * Ran coho check-license
> * Ensured tests are passing
>
> On Tue, Aug 23, 2016 at 5:03 PM, Steven Gill 
> wrote:
>
> > Please review and vote on this cordova-create Release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-11722
> >
> > Both tools have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11722/
> >
> > The package was published from its corresponding git tag:
> >
> > cordova-create: 1.0.0 (4a49545f0f)
> >
> > Upon a successful vote I will upload the archives to dist/, publish it
> > to npm, and post the corresponding blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/
> release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ensured unit tests and end to end tests were passing.
> >
>

Re: [VOTE] Cordova-create@1.0.0 release

2016-08-26 Thread Shazron 
I vote +1

* Verified archives using coho verify-archive
* Ran coho check-license
* Ensured tests are passing

On Tue, Aug 23, 2016 at 5:03 PM, Steven Gill  wrote:

> Please review and vote on this cordova-create Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-11722
>
> Both tools have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11722/
>
> The package was published from its corresponding git tag:
>
> cordova-create: 1.0.0 (4a49545f0f)
>
> Upon a successful vote I will upload the archives to dist/, publish it
> to npm, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ensured unit tests and end to end tests were passing.
>