Re: Nightly build #159 for cordova has failed

2016-09-27 Thread Shazron
I see the log where it says it can't find the 'sax' module, but when
testing it locally using:
`coho nightly --pretend` I can't replicate the error.

On Tue, Sep 27, 2016 at 7:56 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:

> Nightly build #159 for cordova has failed.
>
> Please check failure details on build details page at
> https://builds.apache.org/job/cordova-nightly/159/
> You can also take a look at build console: https://builds.apache.org/job/
> cordova-nightly/159/consoleFull
>
> -
> Jenkins for Apache Cordova
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>


Nightly build #159 for cordova has failed

2016-09-27 Thread Apache Jenkins Server
Nightly build #159 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/159/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/159/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[PROPOSAL] Separate restoring logic from prepare

2016-09-27 Thread Darryl Pogue
The complexity around these two pieces of unrelated code being tied
together is the source of unexpected behaviour and several edge case
bugs. I'd like to see them untangled:
https://github.com/cordova/cordova-discuss/pull/54

Please comment on the PR with your thoughts and suggestions.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request #129: CB-11642 Update CDVAvailability.h

2016-09-27 Thread stevengill
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/129#discussion_r80821223
  
--- Diff: src/platform-release.js ---
@@ -131,15 +133,15 @@ exports.prepareReleaseBranchCommand = function*() {
 var repos = flagutil.computeReposFromFlag(argv.r);
 var version = flagutil.validateVersionString(argv.version);
 var branchName = getVersionBranchName(version);
-
+var platform = repos.id;
--- End diff --

this is the wrong way to get platform. Instead get it from the `repo.id` 
from within the foreach below


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request #129: CB-11642 Update CDVAvailability.h

2016-09-27 Thread stevengill
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/129#discussion_r80821237
  
--- Diff: src/platform-release.js ---
@@ -162,6 +164,30 @@ exports.prepareReleaseBranchCommand = function*() {
 yield versionutil.updateRepoVersion(repo, devVersion);
 yield updateJsSnapshot(repo, devVersion);
 yield gitutil.gitCheckout(branchName);
+
+print(repo.repoName + ': ' + 'Setting VERSION to "' + version 
+ '" on branch + "4.2.x".');
--- End diff --

This line is not needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request #139: CB-11909 changed prepare-release-branch comm...

2016-09-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/139


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request #139: CB-11909 changed prepare-release-branch comm...

2016-09-27 Thread stevengill
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/139#discussion_r80819634
  
--- Diff: src/platform-release.js ---
@@ -128,14 +127,32 @@ exports.prepareReleaseBranchCommand = function*() {
'\n' +
'Usage: $0 prepare-release-branch --version=3.6.0 -r 
platform')
 );
+   
 var repos = flagutil.computeReposFromFlag(argv.r);
-var version = flagutil.validateVersionString(argv.version);
-var branchName = getVersionBranchName(version);
+var branchName = null;
+ 
 
 // First - perform precondition checks.
 yield repoupdate.updateRepos(repos, [], true);
 
 yield repoutil.forEachRepo(repos, function*(repo) {
+   
+var version = null;
+
+if (argv.version === undefined) {
+// Grabbing version from platformPackageJson
--- End diff --

Great! I'll merge it in


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request #139: CB-11909 changed prepare-release-branch comm...

2016-09-27 Thread audreyso
Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/139#discussion_r80818236
  
--- Diff: src/platform-release.js ---
@@ -128,14 +127,32 @@ exports.prepareReleaseBranchCommand = function*() {
'\n' +
'Usage: $0 prepare-release-branch --version=3.6.0 -r 
platform')
 );
+   
 var repos = flagutil.computeReposFromFlag(argv.r);
-var version = flagutil.validateVersionString(argv.version);
-var branchName = getVersionBranchName(version);
+var branchName = null;
+ 
 
 // First - perform precondition checks.
 yield repoupdate.updateRepos(repos, [], true);
 
 yield repoutil.forEachRepo(repos, function*(repo) {
+   
+var version = null;
+
+if (argv.version === undefined) {
+// Grabbing version from platformPackageJson
--- End diff --

All done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli issue #261: CB-11913 - Update travis.yml and appveyor.yml for no...

2016-09-27 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-cli/pull/261
  
Waiting for appveyor build before I pull this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request #139: CB-11909 changed prepare-release-branch comm...

2016-09-27 Thread stevengill
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/139#discussion_r80812614
  
--- Diff: src/platform-release.js ---
@@ -128,14 +127,32 @@ exports.prepareReleaseBranchCommand = function*() {
'\n' +
'Usage: $0 prepare-release-branch --version=3.6.0 -r 
platform')
 );
+   
 var repos = flagutil.computeReposFromFlag(argv.r);
-var version = flagutil.validateVersionString(argv.version);
-var branchName = getVersionBranchName(version);
+var branchName = null;
+ 
 
 // First - perform precondition checks.
 yield repoupdate.updateRepos(repos, [], true);
 
 yield repoutil.forEachRepo(repos, function*(repo) {
+   
+var version = null;
+
+if (argv.version === undefined) {
+// Grabbing version from platformPackageJson
--- End diff --

minor: can you fix the indenting? the else should be in the same vertical 
line as the if. comment should be inline with the vars, etc.

once you fix it, do a `git add platform-release.js` and then `git commit 
--amend`. This will allow you to add the change to the existing commit instead 
of creating a new commit. You will then have to push it with `git push audrey 
master --force`




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli issue #261: CB-11913 - Update travis.yml and appveyor.yml for no...

2016-09-27 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-cli/pull/261
  
This might be a clue: 
https://github.com/apache/cordova-lib/blob/63efd2174fe20b9c573b23a741257a6170dec3b6/.travis.yml#L19

https://github.com/npm/npm/issues/10343



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[DISCUSS] cordova-create@1.0.1

2016-09-27 Thread Steven Gill
any issues with this patch release?


[DISCUSS] cordova-app-hello-world@3.11.0

2016-09-27 Thread Steven Gill
Wanted to do a quick release for this. Just updated it to follow the
template docs a bit closer.
http://cordova.apache.org/docs/en/latest/guide/cli/template.html#create-a-template


[GitHub] cordova-coho pull request #139: CB-11909 changed prepare-release-branch comm...

2016-09-27 Thread audreyso
GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-coho/pull/139

CB-11909 changed prepare-release-branch command to grab version from …

CB-11909 changed prepare-release-branch command to grab version from 
package.json

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-coho master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #139


commit e6c35549ac98d61812020a2d649702dbda520df9
Author: audreyso 
Date:   2016-09-27T21:51:39Z

CB-11909 changed prepare-release-branch command to grab version from 
package.json




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
GitHub user shazron reopened a pull request:

https://github.com/apache/cordova-cli/pull/261

CB-11913 - Update travis.yml and appveyor.yml for nodes 0.12, 4, 6



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-cli CB-11913

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #261


commit 9649bbbe78d9cb22064a2b2e9c7ad63008278ce1
Author: Shazron Abdullah 
Date:   2016-09-27T20:10:14Z

CB-11913- Update travis.yml and appveyor.yml for nodes 0.12, 4, 6

commit 1ede0e567ed8cf46b3c053d6430f9f7e5c9432b7
Author: Shazron Abdullah 
Date:   2016-09-27T22:09:51Z

CB-11913 - Fixed node 6 test failure

commit 0478f84d955ea213e7984f6ffbc246873b861b73
Author: Shazron Abdullah 
Date:   2016-09-27T22:14:18Z

CB-11913 - Fixed node 6 test failure (2)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
Github user shazron closed the pull request at:

https://github.com/apache/cordova-cli/pull/261


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support

2016-09-27 Thread ogoguel
Github user ogoguel commented on the issue:

https://github.com/apache/cordova-lib/pull/219
  
+1 Still hoping to have that code validated :)
Updated the PR that was almost one year old! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
GitHub user shazron reopened a pull request:

https://github.com/apache/cordova-cli/pull/261

CB-11913 - Update travis.yml and appveyor.yml for nodes 0.12, 4, 6



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-cli CB-11913

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #261


commit 9649bbbe78d9cb22064a2b2e9c7ad63008278ce1
Author: Shazron Abdullah 
Date:   2016-09-27T20:10:14Z

CB-11913- Update travis.yml and appveyor.yml for nodes 0.12, 4, 6




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
Github user shazron closed the pull request at:

https://github.com/apache/cordova-cli/pull/261


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli issue #261: CB-11913 - Update travis.yml and appveyor.yml for no...

2016-09-27 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-cli/pull/261
  
Looks like its failing on node 6 (did the build twice on Travis just in 
case). I reproduced this locally by following the install section on 
travis.yml. 

The `cordova-lib/cordova-common/node_modules` folder doesn't contain the 
`ansi` module: it only contains the `promise-matchers`, `rewire`, `shelljs`, 
`q`, `semver` and `underscore` packages. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
Github user shazron closed the pull request at:

https://github.com/apache/cordova-cli/pull/261


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
GitHub user shazron reopened a pull request:

https://github.com/apache/cordova-cli/pull/261

CB-11913 - Update travis.yml and appveyor.yml for nodes 0.12, 4, 6



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-cli CB-11913

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #261


commit 9649bbbe78d9cb22064a2b2e9c7ad63008278ce1
Author: Shazron Abdullah 
Date:   2016-09-27T20:10:14Z

CB-11913- Update travis.yml and appveyor.yml for nodes 0.12, 4, 6




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli issue #261: CB-11913 - Update travis.yml and appveyor.yml for no...

2016-09-27 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-cli/pull/261
  
Seems like there is no AppVeyor setup for this repo. Requested it: 
https://issues.apache.org/jira/browse/INFRA-12668


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli pull request #261: CB-11913- Update travis.yml and appveyor.yml ...

2016-09-27 Thread shazron
GitHub user shazron opened a pull request:

https://github.com/apache/cordova-cli/pull/261

CB-11913- Update travis.yml and appveyor.yml for nodes 0.12, 4, 6



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-cli CB-11913

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #261


commit 9649bbbe78d9cb22064a2b2e9c7ad63008278ce1
Author: Shazron Abdullah 
Date:   2016-09-27T20:10:14Z

CB-11913- Update travis.yml and appveyor.yml for nodes 0.12, 4, 6




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [CORDOVA.IO] New re-directs for contribution

2016-09-27 Thread Shazron
Full list of re-directs that most will not know about:

ci.cordova.io
docs.cordova.io
slack.cordova.io
issues.cordova.io
git.cordova.io
status.cordova.io
plugins.cordova.io
telemetry.cordova.io
weinre.cordova.io
contribute.cordova.io
easyfix.cordova.io


On Tue, Sep 27, 2016 at 10:27 AM, Shazron  wrote:

> Added:
> 1. http://contribute.cordova.io  -- Contribute page on our website
> 2. http://easyfix.cordova.io -- 'easyfix' label on JIRA
>
> Please use these easy to remember URLs in your social media
> correspondence! :)
> We need as many contributors as we can.
>
> Thank you!
>
>
>


[CORDOVA.IO] New re-directs for contribution

2016-09-27 Thread Shazron
Added:
1. http://contribute.cordova.io  -- Contribute page on our website
2. http://easyfix.cordova.io -- 'easyfix' label on JIRA

Please use these easy to remember URLs in your social media correspondence!
:)
We need as many contributors as we can.

Thank you!


[GitHub] cordova-plugin-file-transfer issue #143: CB-11118: Add support for Array and...

2016-09-27 Thread VinceOPS
Github user VinceOPS commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/143
  
+1, and thanks :).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support

2016-09-27 Thread tabrindle
Github user tabrindle commented on the issue:

https://github.com/apache/cordova-lib/pull/219
  
Can we look into this again? Being able to handle multiple targets is more 
important now that other application extensions like for messages are being 
used. Currently any time we install a plugin, it is going to our messages app 
extension target. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-vibration issue #32: index.md(jp)

2016-09-27 Thread jcesarmobile
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-vibration/pull/32
  
Thanks for the PR, but the translations are done using 
[crowdin](https://crowdin.com/project/cordova/ja#), if you want to contribute 
you can do it there
Can you please close this PR?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-vibration issue #41: Documentation in portuguese of Brazil

2016-09-27 Thread jcesarmobile
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-vibration/pull/41
  
Thanks for the PR, but the translations are done using 
[crowdin](https://crowdin.com/project/cordova/pt-BR#), if you want to 
contribute you can do it there



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-vibration pull request #41: Documentation in portuguese of Br...

2016-09-27 Thread Leomhl
Github user Leomhl closed the pull request at:

https://github.com/apache/cordova-plugin-vibration/pull/41


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

2016-09-27 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/492?src=pr) is 80.38% 
(diff: 100%)
> Merging [#492](https://codecov.io/gh/apache/cordova-lib/pull/492?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #492   diff @@
==
  Files67 67  
  Lines  5184   5184  
  Methods 835835  
  Messages  0  0  
  Branches   1005   1005  
==
  Hits   4167   4167  
  Misses 1017   1017  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[63efd21...de8a367](https://codecov.io/gh/apache/cordova-lib/compare/63efd2174fe20b9c573b23a741257a6170dec3b6...de8a367fe4fe553ace4a72c0b5edb12135589270?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

2016-09-27 Thread ktop
Github user ktop commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
Thanks, I fixed the errors. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android issue #308: CB-11343: Handle Java versions after JEP-223

2016-09-27 Thread ankon
Github user ankon commented on the issue:

https://github.com/apache/cordova-android/pull/308
  
I'm not sure I follow here. In any case, what is needed to get this 
forward, and prepare the plugin for actually working with JDK 9?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar issue #51: New feature 'styleAndroidTranslucent'

2016-09-27 Thread kosssi
Github user kosssi commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/51
  
👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-media issue #117: CB-11641 android: add 'message' field to me...

2016-09-27 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/117
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/117/commits/9d0261c3ac9b7ccd1dc0d6873bd181f5121e6e68)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-media pull request #117: CB-11641 android: add 'message' fiel...

2016-09-27 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/117

CB-11641 android: add 'message' field to media error



### Platforms affected
Android

### What does this PR do?
It was not possible before to get error message.This updated Android 
implementation to return error code with message similar to iOS.

### What testing has been done on this change?
Auto test

### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matrosov-nikita/cordova-plugin-media 
CB-11641-check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #117


commit 9d0261c3ac9b7ccd1dc0d6873bd181f5121e6e68
Author: Nikita Matrosov 
Date:   2016-09-27T06:49:24Z

CB-11641 android: add 'message' field to media error

It was not possible before to get error message.This updated Android 
implementation to return error code with message similar to iOS.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org