[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

[alsorokin]

Github user alsorokin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92337971
  
--- Diff: appium-tests/common/common.spec.js ---
@@ -242,7 +248,6 @@ describe('Contacts Android', function () {
 
 describe('Picking contacts', function () {
 afterEach(function (done) {
-checkSession(done);
--- End diff --

I think it is still needed in `afterEach` so we wouldn't try to remove test 
contacts (which means calling driver's methods) after a skipped spec.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DRAFT] [REPORT] Cordova - December 2016

[Filip Maj]

LGTM

On Tue, Dec 13, 2016 at 5:11 PM, Shazron  wrote:
> I will send this out later tonight/early tomorrow if there are no comments:
>
> https://github.com/cordova/apache-board-reports/blob/master/2016/2016-12.md

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DRAFT] [REPORT] Cordova - December 2016

[Shazron]

I will send this out later tonight/early tomorrow if there are no comments:

https://github.com/cordova/apache-board-reports/blob/master/2016/2016-12.md

[GitHub] cordova-lib pull request #507: CB-12197 : replaced/removed multiple occuranc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/507


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #2: Update YoikScreenOrientat...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #5: change console.log to sho...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #3: Typo on YoikScreenOrienta...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #4: Fixes JIRA bug CB-11628

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #4: Fixes JIRA bug CB-11628

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/4
  
This pull request is missing about 10 tests.
There is also some weird history happening, ex. 
`www/screenorientation.android.js → tests/tests.js`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/143
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/143/commits/8c96fa7896fb39078d818122825e4ef59f8336b2)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/63//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

[filmaj]

Github user filmaj commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92285052
  
--- Diff: appium-tests/common/common.spec.js ---
@@ -242,7 +248,6 @@ describe('Contacts Android', function () {
 
 describe('Picking contacts', function () {
 afterEach(function (done) {
-checkSession(done);
--- End diff --

I still left the removal of this check, @alsorokin, as I don't think it 
makes sense to put in the `afterEach`. With the spec itself invoking 
`checkSession`, if the appium session failed to start, it would get caught in 
the spec. In fact, we could probably get away with checking the session only 
immediately after the initial `should connect to an appium endpoint properly` 
spec. Any further checks beyond that would not behave any differently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #509: CB-12163 Add reference attrib to resource-fil...

[ktop]

GitHub user ktop opened a pull request:

https://github.com/apache/cordova-lib/pull/509

CB-12163 Add reference attrib to resource-file for Windows



### Platforms affected
cordova-common for Windows

### What does this PR do?
Adds a new attribute to the resource-file tag for Windows. The attribute is 
for moving the current functionality of "referencing files" to be switched on 
by this flag in order to bring back the copy functionality to be default for 
resource-file. 

ex. 
```


```

### What testing has been done on this change?
Manual testing and unit testing. Need to pull in changes from the 
cordova-windows pull request to get it to work properly. 

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ktop/cordova-lib cb12163

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #509


commit 9d69d3df1d765ad9c05ece48864fc47c6c3e7061
Author: ktop 
Date:   2016-12-12T19:35:04Z

CB-12163 Add reference attrib to resource-file for Windows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #508: CB-11908 Add tests for edit-config in config....

[ktop]

GitHub user ktop opened a pull request:

https://github.com/apache/cordova-lib/pull/508

CB-11908 Add tests for edit-config in config.xml and fix typo



### Platforms affected
cordova-common

### What does this PR do?
I had this commit ready to go, but forgot to commit and push it. Here I'm 
adding tests for the 'edit-config' functionality that was added to config.xml. 

### What testing has been done on this change?
Manual tests and adding unit tests. 

### Checklist
- [x ] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ktop/cordova-lib editconfigxml

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/508.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #508


commit aa4c6e8380c6e5edf1bf20a508b450e64a1d6e7c
Author: ktop 
Date:   2016-12-09T19:53:50Z

CB-11908 Add tests for edit-config in config.xml and fix typo

Add one more test case




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSSION] Windows tag, what should it be doing?

[Karen Tran]

No problem. I'll work on getting the copy functionality and reference flag
in and then I can take a look at your suggestion. Sounds like a useful
feature to me.

On Tue, Dec 13, 2016 at 3:36 AM, Котиков Владимир <
kotikov.vladi...@gmail.com> wrote:

> Hey Karen, sorry for last minute response.
>
> I’m _personally_ +1 for getting back the original behavior (i.e. copy
> instead of referencing the original files), I only think that we’d to make
> sure that the case, described in https://github.com/apache/
> cordova-windows/pull/139 still works with that new flag (I can help with
> verification).
>
> Also, nobody has asked if this would be a reason for a major version
> change? Technically we’re going to break the things, so yes, but from the
> other side it’s kind of regression and unexpected change that needs to be
> fixed. IMO it should be at least minor bump, since we’re going to add a new
> flag
>
> + another suggestion about implementation: IMO the main confusing point
> with the original behavior (copying and then referencing copied file) was
> that if you have two tags:
>
> 
> 
>
> the second one would silently overwrite the first one and the user will
> get some cryptic errors at _runtime_. I propose to make copying logic a bit
> smarter and at least emit a warning when one resource would overwrite
> another and suggest using a flag to add a reference, rather than copy files.
>
>
>
> On 12/12/16, 20:23, "Karen Tran"  wrote:
>
> Does anyone have any other objections?
> Otherwise I'll proceed to work on this tomorrow.
>
> On Thu, Dec 8, 2016 at 8:03 PM, Shazron  wrote:
>
> > +1 sounds good
> >
> > On Thu, Dec 8, 2016 at 4:36 PM, Karen Tran 
> wrote:
> >
> > > I dug up the old pull request for this behavior change (
> > > https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-windows%
> 2Fpull%2F139=02%7C01%7Cv-vlkoti%40microsoft.com%
> 7Cfd5830ed12474774b88d08d422b3a5de%7C72f988bf86f141af91ab2d7cd011
> db47%7C1%7C0%7C636171602363520388=QYSHbcwPFrPlhItNTNMHYifiuzXo5u
> 9nzOt3Z0tuZ%2FQ%3D=0) and it seems like
> > the
> > > main goal for the change was to be able to have .dll files
> specific to
> > > different architectures without having different target locations
> for
> > each
> > > of them and make the .dll files visible in Visual Studio so that
> Visual
> > > Studio can reference them.
> > > ^Correct me if I'm wrong here...
> > >
> > > I tested the following two sets and now have a better
> understanding of
> > why
> > > this behavior was added, but I'm not entirely sure why it had to
> replace
> > > the copy in the first place as opposed to adding a flag to do
> referencing
> > > instead of copy. Having both behavior in resource-file is probably
> okay
> > > since they are kind of similar.
> > >
> > > Set 1.
> > > 
> > > 
> > > - With copy, this behaves the exact same as the referencing
> behavior.
> > > - The only difference between each behavior is the path where
> Visual
> > Studio
> > > will point to the file, copy will point to the target and
> reference will
> > > point to src
> > >
> > > Set 2.
> > > 
> > > 
> > > - With copy, only the x64 foo.dll will be used since the second
> > >  would overwrite the first one. In Visual Studio,
> the
> > > foo.dll when targeting x86 or x64 will point to the same x64
> foo.dll. So
> > > this is the issue with copy for this specific case.
> > > - With referencing, Visual Studio will properly reference the
> correct
> > > foo.dll because it's pointing to the src path and there is no
> overwriting
> > > here.
> > >
> > > I will propose that resource-file should default to copy and the
> > reference
> > > behavior should be set by a flag. This is what it should have been
> when
> > the
> > > behavior was changed, so I think it's worth making the switch back
> to
> > copy
> > > even though it will be breaking a few users (because right now it
> might
> > > unknowingly be breaking more users who have long since been
> expecting
> > > resource-file to copy; it was never documented that resource-file
> had
> > > changed at all). Resource-file wasn't intended for .dll, but for
> actual
> > > resources like json, images, xml, and my case properties files. So
> this
> > is
> > > a big issue if some of these resources aren't available to the app
> at run
> > > time.
> > >  https%3A%2F%2Fgithub.com%2Fktop%2Fcordova-windows%
> 2Ftree%2Fcb12163=02%7C01%7Cv-vlkoti%40microsoft.com%
> 7Cfd5830ed12474774b88d08d422b3a5de%7C72f988bf86f141af91ab2d7cd011
> db47%7C1%7C0%7C636171602363520388=kEEUSKDlHlthoEP0eh6KVJp8KHdxAD
> caUfWInh7foPU%3D=0>
> > >
> > > TL;DR
> > > I propose 

[GitHub] cordova-plugin-inappbrowser issue #115: Support for passing request headers ...

[helloworld20160101]

Github user helloworld20160101 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/115
  
Would there be any chance for ios as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

[alsorokin]

Github user alsorokin commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/18#discussion_r92190252
  
--- Diff: package.json ---
@@ -51,7 +51,7 @@
 "wd": "^0.4.0"
   },
   "devDependencies": {
-"jasmine-node": "~1",
-"jshint": "^2.6.0"
+"jshint": "^2.6.0",
+"appium": "1.5.3"
--- End diff --

We call this method only when running Appium tests locally, so we save time 
in all other runs - we don't have to install pretty heavy `appium` module when 
running on Sauce Labs, for example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

[filmaj]

Github user filmaj commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92190238
  
--- Diff: appium-tests/common/common.spec.js ---
@@ -228,11 +228,18 @@ describe('Contacts Android', function () {
 function checkSession(done) {
 if (failedToStart) {
 fail('Failed to start a session');
-done();
 }
+done();
--- End diff --

Ah, what the hell, you are right! This is bizarre: calling `fail` in a 
`beforeEach` _does not prevent the spec from executing_. The spec gets marked 
as failed correctly, but it still runs through the entire spec. It seems like 
this is a known (and open) issue in Jasmine: 
https://github.com/jasmine/jasmine/issues/577

G, that's annoying. I wanted to clean the test code up by moving the 
session check into a `beforeEach` :(. Sigh...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

[filmaj]

Github user filmaj commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92186809
  
--- Diff: appium-tests/common/common.spec.js ---
@@ -228,11 +228,18 @@ describe('Contacts Android', function () {
 function checkSession(done) {
 if (failedToStart) {
 fail('Failed to start a session');
-done();
 }
+done();
--- End diff --

In the failing case, the call to `fail` should blow the spec up, no? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #218: CB-12238 [Windows] Colorize titlebar to match sp...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-windows/pull/218
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-windows/pull/218?src=pr) is 
76.13% (diff: 100%)
> Merging 
[#218](https://codecov.io/gh/apache/cordova-windows/pull/218?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #218   diff @@
==
  Files16 16  
  Lines  2204   2204  
  Methods 413413  
  Messages  0  0  
  Branches430430  
==
  Hits   1678   1678  
  Misses  526526  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[707bf96...f6d766a](https://codecov.io/gh/apache/cordova-windows/compare/707bf962823b9585a22dfaa3ffa6f0185562df5a...f6d766a6c3efb9deddcb7bb7bdcd060162f18f20?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #218: CB-12238 [Windows] Colorize titlebar to m...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/218

CB-12238 [Windows] Colorize titlebar to match splash bg color



### Platforms affected
Windows

### What does this PR do?
Colorize titlebar to match splash background color

### What testing has been done on this change?
Manual testing

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-windows CB-12238

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #218


commit f6d766a6c3efb9deddcb7bb7bdcd060162f18f20
Author: daserge 
Date:   2016-12-13T12:34:42Z

CB-12238 [Windows] Colorize titlebar to match splash bg color




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/217
  
Pls also see corresponding documentation update here: 
https://github.com/apache/cordova-docs/pull/668


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #668: CB-12239 (windows) Add documentation about b...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-docs/pull/668

CB-12239 (windows) Add documentation about build flags for Windows



### Platforms affected

Windows

### What does this PR do?

Documents use of `buildFlag` option

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.


![image](https://cloud.githubusercontent.com/assets/3857604/21137756/0ce2c024-c13c-11e6-9e8d-43243de1559e.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladimir-kotikov/cordova-docs CB-12239

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/668.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #668


commit 9fc8b3aafaf75091ce03aa68d474f7bd7943d517
Author: Vladimir Kotikov 
Date:   2016-12-06T14:58:31Z

CB-12239 Add documentation about build flags for Windows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/217
  
@TimBarham, @alsorokin, @daserge, could you please take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-windows/pull/217
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-windows/pull/217?src=pr) is 
76.22% (diff: 63.63%)
> Merging 
[#217](https://codecov.io/gh/apache/cordova-windows/pull/217?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) 
will increase coverage by **0.09%**

```diff
@@ master   #217   diff @@
==
  Files16 16  
  Lines  2204   2204  
  Methods 413412 -1   
  Messages  0  0  
  Branches430433 +3   
==
+ Hits   1678   1680 +2   
+ Misses  526524 -2   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[707bf96...6308e69](https://codecov.io/gh/apache/cordova-windows/compare/707bf962823b9585a22dfaa3ffa6f0185562df5a...6308e6974f5499857254fb79c91ded422b46486f?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-windows/pull/217

CB-12239 Add buildFlag option similar to iOS



### What does this PR do?

This PR adds `buildFlag` CLI argument and corresponding option for 
`build.json` file (similar to iOS) to allow users to pass arbitrary options 
directly to MSBuild


### What testing has been done on this change?

Added new tests, ran unit and e2e tests

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladimir-kotikov/cordova-windows 
build-flags-support

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #217


commit 6308e6974f5499857254fb79c91ded422b46486f
Author: Vladimir Kotikov 
Date:   2016-12-12T15:45:51Z

CB-12239 Add buildFlag option similar to iOS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

[alsorokin]

Github user alsorokin commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/18#discussion_r92122133
  
--- Diff: lib/paramedic.js ---
@@ -271,9 +271,13 @@ ParamedicRunner.prototype.runLocalTests = function () {
 })
 .then(function(command) {
 self.setPermissions();
-logger.normal('cordova-paramedic: running command ' + command);
 
-return execPromise(command);
+if (!self.config.runMainTests()) {
--- End diff --

My bad, it actually works because the Android emulator gets started by 
`ParamedicTargetChooser`.
Then the aforementioned comment should also be deleted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSSION] Windows tag, what should it be doing?

[Котиков Владимир]

Hey Karen, sorry for last minute response.

I’m _personally_ +1 for getting back the original behavior (i.e. copy instead 
of referencing the original files), I only think that we’d to make sure that 
the case, described in https://github.com/apache/cordova-windows/pull/139 still 
works with that new flag (I can help with verification).

Also, nobody has asked if this would be a reason for a major version change? 
Technically we’re going to break the things, so yes, but from the other side 
it’s kind of regression and unexpected change that needs to be fixed. IMO it 
should be at least minor bump, since we’re going to add a new flag

+ another suggestion about implementation: IMO the main confusing point with 
the original behavior (copying and then referencing copied file) was that if 
you have two tags:




the second one would silently overwrite the first one and the user will get 
some cryptic errors at _runtime_. I propose to make copying logic a bit smarter 
and at least emit a warning when one resource would overwrite another and 
suggest using a flag to add a reference, rather than copy files.



On 12/12/16, 20:23, "Karen Tran"  wrote:

Does anyone have any other objections?
Otherwise I'll proceed to work on this tomorrow.

On Thu, Dec 8, 2016 at 8:03 PM, Shazron  wrote:

> +1 sounds good
>
> On Thu, Dec 8, 2016 at 4:36 PM, Karen Tran  wrote:
>
> > I dug up the old pull request for this behavior change (
> > 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-windows%2Fpull%2F139=02%7C01%7Cv-vlkoti%40microsoft.com%7Cfd5830ed12474774b88d08d422b3a5de%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636171602363520388=QYSHbcwPFrPlhItNTNMHYifiuzXo5u9nzOt3Z0tuZ%2FQ%3D=0)
 and it seems like
> the
> > main goal for the change was to be able to have .dll files specific to
> > different architectures without having different target locations for
> each
> > of them and make the .dll files visible in Visual Studio so that Visual
> > Studio can reference them.
> > ^Correct me if I'm wrong here...
> >
> > I tested the following two sets and now have a better understanding of
> why
> > this behavior was added, but I'm not entirely sure why it had to replace
> > the copy in the first place as opposed to adding a flag to do 
referencing
> > instead of copy. Having both behavior in resource-file is probably okay
> > since they are kind of similar.
> >
> > Set 1.
> > 
> > 
> > - With copy, this behaves the exact same as the referencing behavior.
> > - The only difference between each behavior is the path where Visual
> Studio
> > will point to the file, copy will point to the target and reference will
> > point to src
> >
> > Set 2.
> > 
> > 
> > - With copy, only the x64 foo.dll will be used since the second
> >  would overwrite the first one. In Visual Studio, the
> > foo.dll when targeting x86 or x64 will point to the same x64 foo.dll. So
> > this is the issue with copy for this specific case.
> > - With referencing, Visual Studio will properly reference the correct
> > foo.dll because it's pointing to the src path and there is no 
overwriting
> > here.
> >
> > I will propose that resource-file should default to copy and the
> reference
> > behavior should be set by a flag. This is what it should have been when
> the
> > behavior was changed, so I think it's worth making the switch back to
> copy
> > even though it will be breaking a few users (because right now it might
> > unknowingly be breaking more users who have long since been expecting
> > resource-file to copy; it was never documented that resource-file had
> > changed at all). Resource-file wasn't intended for .dll, but for actual
> > resources like json, images, xml, and my case properties files. So this
> is
> > a big issue if some of these resources aren't available to the app at 
run
> > time.
> > 

> >
> > TL;DR
> > I propose setting copy as default and the reference behavior with a flag
> > because this is what it should have been in the first place.
> >
> > On Wed, Dec 7, 2016 at 5:58 PM, Karen Tran  wrote:
> >
> > > Sorry I missed this, it was in my spam folder.
> > >
> > > I think the general consensus is that  should 
definitely
> > > have the copy function added back. Not sure if it was clear if we came
> > to a
> > > conclusion on