Nightly build #363 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #363 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/363/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #317: Add logging for malformed data

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/317
  
This PR is missing a JIRA issue, as part of the Checklist. Please file an 
issue at:
http://issues.apache.org/jira/browse/CB

... so it can be tracked and evaluated by the devs, and you can be notified.

Sign up here:
https://issues.apache.org/jira/secure/Signup!default.jspa

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #533: CB-12250 CB-12409 iOS: Fix bug with escaping ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/533


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #555: CB-12786: Improve logic for searching plugin ...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/555#discussion_r119971709
  
--- Diff: cordova-fetch/index.js ---
@@ -148,9 +148,15 @@ function trimID(target) {
 target = parts[1];
 }
 
-//If local path exists, set target to final directory
+// If local path exists, try to get plugin id from package.json or set 
target to final directory
 if (fs.existsSync(target)) {
-target = path.basename(target);
+var pluginId, pkgJsonPath = path.join(target, 'package.json');
+
+if (fs.existsSync(pkgJsonPath)) {
+pluginId = JSON.parse(fs.readFileSync(pkgJsonPath)).cordova.id;
--- End diff --

I think it was due to packageJson.name potentially being different then 
plugin.xml id field. But I don't know of any plugins with this and I'm not sure 
it makes sense to have that distinction anymore. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #317: Add logging for malformed data

[rafael-chavez]

GitHub user rafael-chavez opened a pull request:

https://github.com/apache/cordova-ios/pull/317

Add logging for malformed data



### Platforms affected

iOS

### What does this PR do?

Prints the malformed data created by the process for further debugging.

### What testing has been done on this change?

Hard to reproduce, but sometimes the evaulateJavascript method on WKWebView 
creates a malformed JSON string. 

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rafael-chavez/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/317.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #317


commit e0a5c0e0bb71f582be8f30e08e23a06b09d00b08
Author: rafael-chavez 
Date:   2017-06-02T23:28:01Z

Add logging for malformed data




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #560: CB-12762 : point package.json repo items to g...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/560


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #556: CB-12777 : Removed unneeded fixtures in cordo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/556


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #560: CB-12762 : point package.json repo items to github m...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/560
  
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr=h1) 
Report
> Merging 
[#560](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/546612060bdab16ea88ed3a6e3ee8c1f29ffab3d?src=pr=desc)
 will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-lib/pull/560/graphs/tree.svg?width=650=pr=KwBjKMXLqA=150)](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr=tree)

```diff
@@   Coverage Diff   @@
##   master #560   +/-   ##
===
  Coverage   80.13%   80.13%   
===
  Files  57   57   
  Lines3956 3956   
  Branches  831  831   
===
  Hits 3170 3170   
  Misses786  786
```



--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr=footer). 
Last update 
[5466120...6428dd3](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #559: Display deprecation message when installing a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/559


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #560: CB-12762 : point package.json repo items to github m...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/560
  
@audreyso can you update the package.json in cordova-fetch, cordova-common 
and cordova-serve as well for this pr?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #557: CB-12787: Fix plugin installation with --link option

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/557
  
merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #557: CB-12787: Fix plugin installation with --link...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/557


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #555: CB-12786: Improve logic for searching plugin ...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/555#discussion_r119950730
  
--- Diff: cordova-fetch/index.js ---
@@ -148,9 +148,15 @@ function trimID(target) {
 target = parts[1];
 }
 
-//If local path exists, set target to final directory
+// If local path exists, try to get plugin id from package.json or set 
target to final directory
 if (fs.existsSync(target)) {
-target = path.basename(target);
+var pluginId, pkgJsonPath = path.join(target, 'package.json');
+
+if (fs.existsSync(pkgJsonPath)) {
+pluginId = JSON.parse(fs.readFileSync(pkgJsonPath)).cordova.id;
--- End diff --

why use `pkgJsonPath.cordova.id` instead of `pkgJsonPath.cordova.name` ? I 
don't even remember why we have `cordova.id` anymore haha. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #554: CB-12738: Cordova ignores plugin dependency version ...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/554
  
merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #554: CB-12738: Cordova ignores plugin dependency v...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/554


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Incompatible plugin should reject the build

[Kerri Shotts]

+1 Fail (I think principle of least surprise applies here; most devs would 
expect an incompatible plugin to fail the build.)

~ Kerri

> On Jun 2, 2017, at 12:15, Shazron  wrote:
> 
> Consensus on this long stewing issue of 7 months?
> 
> If you deleted the thread:
> 1. Issue https://issues.apache.org/jira/browse/CB-12122
> 2. Thread https://s.apache.org/ofqR
> 
> +1 on engine check failing the build.
> Questions that need answered: Does cordova-fetch on cordova@7 do this
> already, like Simon said?
> 
> 
> On Mon, Nov 7, 2016 at 6:34 PM, Simon MacDonald 
> wrote:
> 
>> I think an engine check should fail the build. If there plugin version
>> they are trying to use will not work with the version of cordova or
>> platform they are currently using in their project it should not
>> build. Folks can screw up their semver in config.xml and end up
>> pulling in a plugin version that doesn't work with the CLI they are
>> currently using so stuff will just be horribly broken without them
>> knowing.
>> 
>> Also, I thought the new cordova-fetch was supposed to prevent this
>> sort of thing?
>> Simon Mac Donald
>> http://simonmacdonald.com
>> 
>> 
>> On Mon, Nov 7, 2016 at 8:24 PM, Shazron  wrote:
>>> See https://issues.apache.org/jira/browse/CB-12122
>>> 
>>> Right now if a plugin fails an  check, it just warns. Should we
>>> make engine checks fail the build?
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>> 
>> 

Re: Incompatible plugin should reject the build

[Jesse]

+1 Fail and freak out so everyone knows!


@purplecabbage
risingj.com

On Fri, Jun 2, 2017 at 10:59 AM, Steven Gill  wrote:

> You are right in that we don't fail the build when a incompatible plugin
> fails to install.
>
> cordova-fetch doesn't change this behavior as it is install time vs fetch
> time. Also this is a difference between using cordovaDependencies in
> package.json vs engine in config.xml. If a CordovaDependencies check fails,
> cordova would try to fetch a version that did work. If a engine check
> fails, it skips installing it. If cordova users don't read the warning,
> they may think the plugin was installed without issue.
>
> I'm down to change this behavior to fail.
>
> On Fri, Jun 2, 2017 at 10:15 AM, Shazron  wrote:
>
> > Consensus on this long stewing issue of 7 months?
> >
> > If you deleted the thread:
> > 1. Issue https://issues.apache.org/jira/browse/CB-12122
> > 2. Thread https://s.apache.org/ofqR
> >
> > +1 on engine check failing the build.
> > Questions that need answered: Does cordova-fetch on cordova@7 do this
> > already, like Simon said?
> >
> >
> > On Mon, Nov 7, 2016 at 6:34 PM, Simon MacDonald <
> simon.macdon...@gmail.com
> > >
> > wrote:
> >
> > > I think an engine check should fail the build. If there plugin version
> > > they are trying to use will not work with the version of cordova or
> > > platform they are currently using in their project it should not
> > > build. Folks can screw up their semver in config.xml and end up
> > > pulling in a plugin version that doesn't work with the CLI they are
> > > currently using so stuff will just be horribly broken without them
> > > knowing.
> > >
> > > Also, I thought the new cordova-fetch was supposed to prevent this
> > > sort of thing?
> > > Simon Mac Donald
> > > http://simonmacdonald.com
> > >
> > >
> > > On Mon, Nov 7, 2016 at 8:24 PM, Shazron  wrote:
> > > > See https://issues.apache.org/jira/browse/CB-12122
> > > >
> > > > Right now if a plugin fails an  check, it just warns. Should
> > we
> > > > make engine checks fail the build?
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #558: CB-12766 Consistently write JSON with 2 space...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/558


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx pull request #37: CB-12762 : point package.json repo items to gi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-osx/pull/37


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request #36: CB-12762 : point package.j...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Incompatible plugin should reject the build

[Steven Gill]

You are right in that we don't fail the build when a incompatible plugin
fails to install.

cordova-fetch doesn't change this behavior as it is install time vs fetch
time. Also this is a difference between using cordovaDependencies in
package.json vs engine in config.xml. If a CordovaDependencies check fails,
cordova would try to fetch a version that did work. If a engine check
fails, it skips installing it. If cordova users don't read the warning,
they may think the plugin was installed without issue.

I'm down to change this behavior to fail.

On Fri, Jun 2, 2017 at 10:15 AM, Shazron  wrote:

> Consensus on this long stewing issue of 7 months?
>
> If you deleted the thread:
> 1. Issue https://issues.apache.org/jira/browse/CB-12122
> 2. Thread https://s.apache.org/ofqR
>
> +1 on engine check failing the build.
> Questions that need answered: Does cordova-fetch on cordova@7 do this
> already, like Simon said?
>
>
> On Mon, Nov 7, 2016 at 6:34 PM, Simon MacDonald  >
> wrote:
>
> > I think an engine check should fail the build. If there plugin version
> > they are trying to use will not work with the version of cordova or
> > platform they are currently using in their project it should not
> > build. Folks can screw up their semver in config.xml and end up
> > pulling in a plugin version that doesn't work with the CLI they are
> > currently using so stuff will just be horribly broken without them
> > knowing.
> >
> > Also, I thought the new cordova-fetch was supposed to prevent this
> > sort of thing?
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> >
> > On Mon, Nov 7, 2016 at 8:24 PM, Shazron  wrote:
> > > See https://issues.apache.org/jira/browse/CB-12122
> > >
> > > Right now if a plugin fails an  check, it just warns. Should
> we
> > > make engine checks fail the build?
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

[GitHub] cordova-plugin-wkwebview-engine issue #36: CB-12762 : point package.json rep...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36/commits/4b803231f9c274eac14f4906e8bbde5ff938781d)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/19/)

 2 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Incompatible plugin should reject the build

[Shazron]

Consensus on this long stewing issue of 7 months?

If you deleted the thread:
1. Issue https://issues.apache.org/jira/browse/CB-12122
2. Thread https://s.apache.org/ofqR

+1 on engine check failing the build.
Questions that need answered: Does cordova-fetch on cordova@7 do this
already, like Simon said?


On Mon, Nov 7, 2016 at 6:34 PM, Simon MacDonald 
wrote:

> I think an engine check should fail the build. If there plugin version
> they are trying to use will not work with the version of cordova or
> platform they are currently using in their project it should not
> build. Folks can screw up their semver in config.xml and end up
> pulling in a plugin version that doesn't work with the CLI they are
> currently using so stuff will just be horribly broken without them
> knowing.
>
> Also, I thought the new cordova-fetch was supposed to prevent this
> sort of thing?
> Simon Mac Donald
> http://simonmacdonald.com
>
>
> On Mon, Nov 7, 2016 at 8:24 PM, Shazron  wrote:
> > See https://issues.apache.org/jira/browse/CB-12122
> >
> > Right now if a plugin fails an  check, it just warns. Should we
> > make engine checks fail the build?
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-console issue #22: Fix for : https://issues.apache.org/jira/b...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-console/pull/22
  
Also, please change the title to have a prefix of "CB-12168" so it can be 
auto-tracked in JIRA.
This was already covered in the Github Pull Request template that you 
erased when a pull request was started.

e.g. "CB-12168 - my issue description here"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request #36: CB-12762 : point package.j...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36

CB-12762 : point package.json repo items to github mirrors instead of…

… apache repos site



### Platforms affected


### What does this PR do?
Point package.json repo items to github mirrors instead of apache repos 
site.

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-plugin-wkwebview-engine 
CB-12762

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 4b803231f9c274eac14f4906e8bbde5ff938781d
Author: Audrey So 
Date:   2017-06-02T16:59:05Z

CB-12762 : point package.json repo items to github mirrors instead of 
apache repos site




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #269: CB-12764: (android) Adapt Appium te...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/269


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console issue #22: Fix for : https://issues.apache.org/jira/b...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-console/pull/22
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-console/pull/22/commits/a24fa611cf8b0d9929695726ede12605fd5ee218)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/122/)

 8 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request #22: Fix for : https://issues.apache.org...

[sruthakeerthikotla]

GitHub user sruthakeerthikotla opened a pull request:

https://github.com/apache/cordova-plugin-console/pull/22

Fix for : https://issues.apache.org/jira/browse/CB-12168

CB-12168: (ios) Fix to update to ios's new logging function.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sruthakeerthikotla/cordova-plugin-console 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-console/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22


commit a24fa611cf8b0d9929695726ede12605fd5ee218
Author: sruthakeerthikotla 
Date:   2017-06-02T14:51:14Z

CB-12168(ios):"Fix to upgrade to ios 10+ logging"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #269: CB-12764: (android) Adapt Appium tests for...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/269
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/269/commits/1b218cd8a0e155dff2ee03a04a45a84977cb2fdc)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/173/)

 316 tests run, 34 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #269: CB-12764: (android) Adapt Appium te...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/269

CB-12764: (android) Adapt Appium tests for Android 7

### Platforms affected
Android

### What does this PR do?
https://issues.apache.org/jira/browse/CB-12764
Adapts Appium tests to run on Android 7 emulator on Sauce Labs

### What testing has been done on this change?
countless runs on Sauce Labs (i guess these tests currently don't work 
locally)

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #269


commit 1b218cd8a0e155dff2ee03a04a45a84977cb2fdc
Author: Alexander Sorokin 
Date:   2017-06-02T12:02:01Z

CB-12764: (android) Adapt Appium tests for Android 7




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #268: CB-12873: Add customization options for ca...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/268
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/268/commits/8c02fe49b9a812dd90ee58d9defc99784daac7cd)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/172/)

 316 tests run, 28 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #268: CB-12873: Add customization options for ca...

[alsorokin]

Github user alsorokin commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/268
  
cordova-qa: rerun tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org