[GitHub] cordova-cli pull request #283: CB-12901 Cli Refactor

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-cli/pull/283

CB-12901 Cli Refactor

### What does this PR do?

- fixed failing tests.
- adjusted tests to call cordova instead of cordova.raw
- added tests to compare cordova.raw and cordova
- changed some console.log to logger.log
- help module returns help text and does not print it
-- this is to make testing easier and not have it spit all over jasmine 
output. 
- various minor refactors, removed some un-needed promises etc.
- added timeoutInSecs property to make user prompts testable without 
waiting for 30 seconds
- this includes @stevengill 's previous pr

### Platforms affected
tooling


### What testing has been done on this change?

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-cli RefactorWithCB-12901

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #283


commit a4c71847702793fc24cdfe393f954e4b2f1fc863
Author: Steve Gill 
Date:   2017-06-16T21:37:07Z

CB-12901: removed .raw from cordova-lib calls

commit a24ec7968f4b271d9c3487980d29b3766b690053
Author: Jesse MacFadyen 
Date:   2017-06-20T05:17:56Z

fixed lines that were too long, test was failing

commit a26a73a420f71c972094513580921070a9026a47
Author: Jesse MacFadyen 
Date:   2017-06-20T05:19:06Z

added timeoutInSecs property to make user prompts testable without waiting 
for 30 seconds

commit 310d6b0a1c33d2289b8909fc61d13b46c7ca5950
Author: Jesse MacFadyen 
Date:   2017-06-20T05:22:13Z

adjusted tests to call cordova instead of cordova.raw, added tests to 
compare cordova.raw and cordova, changed some console.log to logger.log; help 
module returns help text and does not print it, this is to make testing easier 
and not have it spit all over jasmine output. various minor refactors, removed 
some un-needed promises




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #380 for cordova has failed

[Apache Jenkins Server]

Nightly build #380 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/380/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/380/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #564: removed some circular deps, got some tests pa...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/564


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #564: removed some circular deps, got some tests passing

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-lib/pull/564
  
Went ahead and merged this one in. Will chip away at remaining e2e test 
failures from here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/386
  
Ahh! That's it! Very nice. Works flawlessy on my end!


![images](https://user-images.githubusercontent.com/52645/27299857-4d772116-54f3-11e7-9baf-069e6c13506e.jpg)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[macdonst]

Github user macdonst commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r122787134
  
--- Diff: cordova-lib/cordova.js ---
@@ -1486,6 +1486,26 @@ module.exports = {
 
 bootstrap: function() {
 
+var cache = navigator.serviceWorker.register;
--- End diff --

This seems like a great solution for detecting if a service worker has been 
registered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[macdonst]

Github user macdonst commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r122782989
  
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
 "locations":this.locations,
 "root": this.root,
 "name": this.platform,
-"version": { "version" : "1.0.0" },
+"version": { "version" : "1.0.0" }, // um, todo!
 "projectConfig": this.config
 };
 };
 
 Api.prototype.prepare = function (cordovaProject,options) {
 
 // First cleanup current config and merge project's one into own
-var defaultConfig = path.join(this.locations.platformRootDir,'cordova',
+var defaultConfigPath = 
path.join(this.locations.platformRootDir,'cordova',
 'defaults.xml');
-
-var ownConfig = this.locations.configXml;
-
+var ownConfigPath = this.locations.configXml;
 var sourceCfg = cordovaProject.projectConfig;
+
 // If defaults.xml is present, overwrite platform config.xml with it.
 // Otherwise save whatever is there as defaults so it can be
 // restored or copy project config into platform if none exists.
-if (fs.existsSync(defaultConfig)) {
+if (fs.existsSync(defaultConfigPath)) {
 this.events.emit('verbose', 'Generating config.xml from defaults 
for platform "' + this.platform + '"');
-shell.cp('-f', defaultConfig, ownConfig);
-} else if (fs.existsSync(ownConfig)) {
-shell.cp('-f', ownConfig, defaultConfig);
-} else {
-shell.cp('-f', sourceCfg.path, ownConfig);
+shell.cp('-f', defaultConfigPath, ownConfigPath);
+}
+else if (fs.existsSync(ownConfigPath)) {
+this.events.emit('verbose', 'Generating defaults.xml from own 
config.xml for platform "' + this.platform + '"');
+shell.cp('-f', ownConfigPath, defaultConfigPath);
+}
+else {
+this.events.emit('verbose', 'case 3"' + this.platform + '"');
+shell.cp('-f', sourceCfg.path, ownConfigPath);
 }
 
-// this._munger.reapply_global_munge().save_all();
-
-this.config = new ConfigParser(ownConfig);
+// merge our configs
+this.config = new ConfigParser(ownConfigPath);
 xmlHelpers.mergeXml(cordovaProject.projectConfig.doc.getroot(),
-this.config.doc.getroot(), this.platform, true);
+this.config.doc.getroot(),
+this.platform, true);
 this.config.write();
 
-/*
-"browser": {
-"parser_file": "../cordova/metadata/browser_parser",
-"handler_file": "../plugman/platforms/browser",
-"url": 
"https://git-wip-us.apache.org/repos/asf?p=cordova-browser.git;,
-"version": "~4.1.0",
-"deprecated": false
-}
-*/
-
 // Update own www dir with project's www assets and plugins' assets 
and js-files
 this.parser.update_www(cordovaProject.locations.www);
 
+// Copy or Create manifest.json
+// todo: move this to a manifest helper module
+// output path
+var manifestPath = path.join(this.locations.www,'manifest.json');
+var srcManifestPath 
=path.join(cordovaProject.locations.www,'manifest.json');
+if(fs.existsSync(srcManifestPath)) {
+// just blindly copy it to our output/www
+// todo: validate it? ensure all properties we expect exist?
+this.events.emit('verbose','copying ' + srcManifestPath + ' => ' + 
manifestPath);
+shell.cp('-f',srcManifestPath,manifestPath);
+}
+else {
+var manifestJson = {
+"background_color": "#000",
+"display": "standalone"
+};
+if(this.config){
+if(this.config.name()) {
+manifestJson.name = this.config.name();
+}
+if(this.config.shortName()) {
+manifestJson.short_name = this.config.shortName();
+}
+if(this.config.packageName()) {
+manifestJson.version = this.config.packageName();
+}
+if(this.config.description()) {
+manifestJson.description = this.config.description();
+}
+if(this.config.author()) {
+manifestJson.author = this.config.author();
+}
+// icons
+var icons = this.config.getStaticResources('browser','icon');
+var manifestIcons = icons.map(function(icon) {
+// given a tag like this :
+// 
+/* configParser returns 

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[macdonst]

Github user macdonst commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r122785379
  
--- Diff: bin/template/www/cordova-sw.js ---
@@ -0,0 +1,23 @@
+
+// Note, these will be updated automatically at build time
+var CACHE_VERSION = '%CACHE_VERSION%';
+var CACHE_LIST = ['CACHE_VALUES'];
+
+this.addEventListener('install', function(event) {
+// Perform install steps
+console.log("cordova service worker is installing.");
+event.waitUntil(caches.open(CACHE_VERSION)
+.then(function(cache) {
+return cache.addAll(CACHE_LIST);
+}));
+});
+
+this.addEventListener('activate', function(event) {
+// Perform activate steps
+console.log("cordova service worker is activated.");
+});
+
+this.addEventListener('fetch', function(event) {
+console.log("cordova service worker : fetch : " + event.request.url);
+event.respondWith(caches.match(event.request));
--- End diff --

All the examples I've seen from Google program this a bit more defensively:

```
  event.respondWith(
caches.match(event.request)
  .then(function(response) {
// Cache hit - return response
if (response) {
  return response;
}
return fetch(event.request);
  }
)
  );
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[macdonst]

Github user macdonst commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r122786300
  
--- Diff: bin/template/www/manifest.json ---
@@ -0,0 +1,21 @@
+{
+  "name": "My App",
+  "short_name":"My Ap",
+  "description": "Description of your app from template",
+  "start_url": "index.html",
+  "scope":"index.html",
+  "icons": [{
+"src": "img/logo.png",
+"sizes": "192x192",
+"type": "image/png"
+  }, {
+"src": "img/splash.png",
--- End diff --

I don't think we need the splash in the list of icons. Chrome will use the 
background_color, short_name and icon closest to 128dp to create a splash 
screen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[macdonst]

Github user macdonst commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r122780778
  
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
 "locations":this.locations,
 "root": this.root,
 "name": this.platform,
-"version": { "version" : "1.0.0" },
+"version": { "version" : "1.0.0" }, // um, todo!
 "projectConfig": this.config
 };
 };
 
 Api.prototype.prepare = function (cordovaProject,options) {
 
 // First cleanup current config and merge project's one into own
-var defaultConfig = path.join(this.locations.platformRootDir,'cordova',
+var defaultConfigPath = 
path.join(this.locations.platformRootDir,'cordova',
 'defaults.xml');
-
-var ownConfig = this.locations.configXml;
-
+var ownConfigPath = this.locations.configXml;
 var sourceCfg = cordovaProject.projectConfig;
+
 // If defaults.xml is present, overwrite platform config.xml with it.
 // Otherwise save whatever is there as defaults so it can be
 // restored or copy project config into platform if none exists.
-if (fs.existsSync(defaultConfig)) {
+if (fs.existsSync(defaultConfigPath)) {
 this.events.emit('verbose', 'Generating config.xml from defaults 
for platform "' + this.platform + '"');
-shell.cp('-f', defaultConfig, ownConfig);
-} else if (fs.existsSync(ownConfig)) {
-shell.cp('-f', ownConfig, defaultConfig);
-} else {
-shell.cp('-f', sourceCfg.path, ownConfig);
+shell.cp('-f', defaultConfigPath, ownConfigPath);
+}
+else if (fs.existsSync(ownConfigPath)) {
+this.events.emit('verbose', 'Generating defaults.xml from own 
config.xml for platform "' + this.platform + '"');
+shell.cp('-f', ownConfigPath, defaultConfigPath);
+}
+else {
+this.events.emit('verbose', 'case 3"' + this.platform + '"');
+shell.cp('-f', sourceCfg.path, ownConfigPath);
 }
 
-// this._munger.reapply_global_munge().save_all();
-
-this.config = new ConfigParser(ownConfig);
+// merge our configs
+this.config = new ConfigParser(ownConfigPath);
 xmlHelpers.mergeXml(cordovaProject.projectConfig.doc.getroot(),
-this.config.doc.getroot(), this.platform, true);
+this.config.doc.getroot(),
+this.platform, true);
 this.config.write();
 
-/*
-"browser": {
-"parser_file": "../cordova/metadata/browser_parser",
-"handler_file": "../plugman/platforms/browser",
-"url": 
"https://git-wip-us.apache.org/repos/asf?p=cordova-browser.git;,
-"version": "~4.1.0",
-"deprecated": false
-}
-*/
-
 // Update own www dir with project's www assets and plugins' assets 
and js-files
 this.parser.update_www(cordovaProject.locations.www);
 
+// Copy or Create manifest.json
+// todo: move this to a manifest helper module
+// output path
+var manifestPath = path.join(this.locations.www,'manifest.json');
+var srcManifestPath 
=path.join(cordovaProject.locations.www,'manifest.json');
+if(fs.existsSync(srcManifestPath)) {
+// just blindly copy it to our output/www
+// todo: validate it? ensure all properties we expect exist?
+this.events.emit('verbose','copying ' + srcManifestPath + ' => ' + 
manifestPath);
+shell.cp('-f',srcManifestPath,manifestPath);
+}
+else {
+var manifestJson = {
+"background_color": "#000",
--- End diff --

Just wondering if `background_color` default should be white instead. Not 
opposed to black as it is probably close to 50/50.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[macdonst]

Github user macdonst commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r122783962
  
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
 "locations":this.locations,
 "root": this.root,
 "name": this.platform,
-"version": { "version" : "1.0.0" },
+"version": { "version" : "1.0.0" }, // um, todo!
 "projectConfig": this.config
 };
 };
 
 Api.prototype.prepare = function (cordovaProject,options) {
 
 // First cleanup current config and merge project's one into own
-var defaultConfig = path.join(this.locations.platformRootDir,'cordova',
+var defaultConfigPath = 
path.join(this.locations.platformRootDir,'cordova',
 'defaults.xml');
-
-var ownConfig = this.locations.configXml;
-
+var ownConfigPath = this.locations.configXml;
 var sourceCfg = cordovaProject.projectConfig;
+
 // If defaults.xml is present, overwrite platform config.xml with it.
 // Otherwise save whatever is there as defaults so it can be
 // restored or copy project config into platform if none exists.
-if (fs.existsSync(defaultConfig)) {
+if (fs.existsSync(defaultConfigPath)) {
 this.events.emit('verbose', 'Generating config.xml from defaults 
for platform "' + this.platform + '"');
-shell.cp('-f', defaultConfig, ownConfig);
-} else if (fs.existsSync(ownConfig)) {
-shell.cp('-f', ownConfig, defaultConfig);
-} else {
-shell.cp('-f', sourceCfg.path, ownConfig);
+shell.cp('-f', defaultConfigPath, ownConfigPath);
+}
+else if (fs.existsSync(ownConfigPath)) {
+this.events.emit('verbose', 'Generating defaults.xml from own 
config.xml for platform "' + this.platform + '"');
+shell.cp('-f', ownConfigPath, defaultConfigPath);
+}
+else {
+this.events.emit('verbose', 'case 3"' + this.platform + '"');
+shell.cp('-f', sourceCfg.path, ownConfigPath);
 }
 
-// this._munger.reapply_global_munge().save_all();
-
-this.config = new ConfigParser(ownConfig);
+// merge our configs
+this.config = new ConfigParser(ownConfigPath);
 xmlHelpers.mergeXml(cordovaProject.projectConfig.doc.getroot(),
-this.config.doc.getroot(), this.platform, true);
+this.config.doc.getroot(),
+this.platform, true);
 this.config.write();
 
-/*
-"browser": {
-"parser_file": "../cordova/metadata/browser_parser",
-"handler_file": "../plugman/platforms/browser",
-"url": 
"https://git-wip-us.apache.org/repos/asf?p=cordova-browser.git;,
-"version": "~4.1.0",
-"deprecated": false
-}
-*/
-
 // Update own www dir with project's www assets and plugins' assets 
and js-files
 this.parser.update_www(cordovaProject.locations.www);
 
+// Copy or Create manifest.json
+// todo: move this to a manifest helper module
+// output path
+var manifestPath = path.join(this.locations.www,'manifest.json');
+var srcManifestPath 
=path.join(cordovaProject.locations.www,'manifest.json');
+if(fs.existsSync(srcManifestPath)) {
+// just blindly copy it to our output/www
+// todo: validate it? ensure all properties we expect exist?
+this.events.emit('verbose','copying ' + srcManifestPath + ' => ' + 
manifestPath);
+shell.cp('-f',srcManifestPath,manifestPath);
+}
+else {
+var manifestJson = {
+"background_color": "#000",
+"display": "standalone"
+};
+if(this.config){
+if(this.config.name()) {
+manifestJson.name = this.config.name();
+}
+if(this.config.shortName()) {
+manifestJson.short_name = this.config.shortName();
+}
+if(this.config.packageName()) {
+manifestJson.version = this.config.packageName();
+}
+if(this.config.description()) {
+manifestJson.description = this.config.description();
+}
+if(this.config.author()) {
+manifestJson.author = this.config.author();
+}
+// icons
+var icons = this.config.getStaticResources('browser','icon');
+var manifestIcons = icons.map(function(icon) {
+// given a tag like this :
+// 
+/* configParser returns 

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[macdonst]

Github user macdonst commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r122786410
  
--- Diff: cordova-js-src/confighelper.js ---
@@ -61,14 +61,9 @@ function readConfig(success, error) {
 }
 };
 
-if ("ActiveXObject" in window) {
-// Needed for XHR-ing via file:// protocol in IE
-xhr = new window.ActiveXObject("MSXML2.XMLHTTP");
--- End diff --

Hahahahahaha, I'm so old.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[macdonst]

Github user macdonst commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r122782108
  
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
 "locations":this.locations,
 "root": this.root,
 "name": this.platform,
-"version": { "version" : "1.0.0" },
+"version": { "version" : "1.0.0" }, // um, todo!
 "projectConfig": this.config
 };
 };
 
 Api.prototype.prepare = function (cordovaProject,options) {
 
 // First cleanup current config and merge project's one into own
-var defaultConfig = path.join(this.locations.platformRootDir,'cordova',
+var defaultConfigPath = 
path.join(this.locations.platformRootDir,'cordova',
 'defaults.xml');
-
-var ownConfig = this.locations.configXml;
-
+var ownConfigPath = this.locations.configXml;
 var sourceCfg = cordovaProject.projectConfig;
+
 // If defaults.xml is present, overwrite platform config.xml with it.
 // Otherwise save whatever is there as defaults so it can be
 // restored or copy project config into platform if none exists.
-if (fs.existsSync(defaultConfig)) {
+if (fs.existsSync(defaultConfigPath)) {
 this.events.emit('verbose', 'Generating config.xml from defaults 
for platform "' + this.platform + '"');
-shell.cp('-f', defaultConfig, ownConfig);
-} else if (fs.existsSync(ownConfig)) {
-shell.cp('-f', ownConfig, defaultConfig);
-} else {
-shell.cp('-f', sourceCfg.path, ownConfig);
+shell.cp('-f', defaultConfigPath, ownConfigPath);
+}
+else if (fs.existsSync(ownConfigPath)) {
+this.events.emit('verbose', 'Generating defaults.xml from own 
config.xml for platform "' + this.platform + '"');
+shell.cp('-f', ownConfigPath, defaultConfigPath);
+}
+else {
+this.events.emit('verbose', 'case 3"' + this.platform + '"');
+shell.cp('-f', sourceCfg.path, ownConfigPath);
 }
 
-// this._munger.reapply_global_munge().save_all();
-
-this.config = new ConfigParser(ownConfig);
+// merge our configs
+this.config = new ConfigParser(ownConfigPath);
 xmlHelpers.mergeXml(cordovaProject.projectConfig.doc.getroot(),
-this.config.doc.getroot(), this.platform, true);
+this.config.doc.getroot(),
+this.platform, true);
 this.config.write();
 
-/*
-"browser": {
-"parser_file": "../cordova/metadata/browser_parser",
-"handler_file": "../plugman/platforms/browser",
-"url": 
"https://git-wip-us.apache.org/repos/asf?p=cordova-browser.git;,
-"version": "~4.1.0",
-"deprecated": false
-}
-*/
-
 // Update own www dir with project's www assets and plugins' assets 
and js-files
 this.parser.update_www(cordovaProject.locations.www);
 
+// Copy or Create manifest.json
+// todo: move this to a manifest helper module
+// output path
+var manifestPath = path.join(this.locations.www,'manifest.json');
+var srcManifestPath 
=path.join(cordovaProject.locations.www,'manifest.json');
+if(fs.existsSync(srcManifestPath)) {
+// just blindly copy it to our output/www
+// todo: validate it? ensure all properties we expect exist?
+this.events.emit('verbose','copying ' + srcManifestPath + ' => ' + 
manifestPath);
+shell.cp('-f',srcManifestPath,manifestPath);
+}
+else {
+var manifestJson = {
+"background_color": "#000",
+"display": "standalone"
+};
+if(this.config){
+if(this.config.name()) {
+manifestJson.name = this.config.name();
+}
+if(this.config.shortName()) {
+manifestJson.short_name = this.config.shortName();
+}
+if(this.config.packageName()) {
+manifestJson.version = this.config.packageName();
+}
+if(this.config.description()) {
+manifestJson.description = this.config.description();
+}
+if(this.config.author()) {
+manifestJson.author = this.config.author();
+}
+// icons
+var icons = this.config.getStaticResources('browser','icon');
+var manifestIcons = icons.map(function(icon) {
+// given a tag like this :
+// 
+/* configParser returns 

[GitHub] cordova-lib pull request #564: removed some circular deps, got some tests pa...

[stevengill]

GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-lib/pull/564

removed some circular deps, got some tests passing



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/564.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #564


commit a7f55ecc9e0feaef7eebb881b1a64bfea1988b77
Author: Steve Gill 
Date:   2017-06-19T18:21:06Z

removed some circular deps, got some tests passing




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

[audreyso]

Github user audreyso commented on the issue:

https://github.com/apache/cordova-android/pull/386
  
Ohh thank you for that clarification @filmaj . So I did the following: 
1.  Left the project root level eslint file to keep--> root: true
2. Removed eslint config files from spec/e2e & spec/unit and just placed it 
in spec/.eslintrc.yml
3. Took out root:true from spec/.eslintrc.yml and just included ONE rule 
env: jasmine: true


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

[ccorcos]

Github user ccorcos commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
  
Hmm. Is JIRA down?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/386
  
I think one more tweak would be good:

So by putting `root:true` into the spec/**/ directories' eslintrc files, 
when eslint searches up the directory tree to find an eslintrc file, once it 
finds the file, it'll stop searching further. eslint, however, supports 
"cascading" or combining multiple config files into one. We can leverage this 
to define one project-level eslintrc file in the root of the project dir, but 
then also have additional eslintrc files in project subdirectories if there are 
specific rules we want to apply per-directory.

So I think what we want to do is:
 - have the project-root-directory-level eslintrc file specify `root:true`
 - any subdirectory-level eslintrc files _not_ to specify `root:true`
   - this would then cause eslint to apply the rules from subdirectories, 
but keep going to search for further rules, and in our case, it would keep 
going until it hit the project-root-directory-level eslintrc, apply those 
rules, and because that one has `root:true`, stop there.
 - additionally, in this repo, both the spec/e2e and spec/unit directories 
need just a single additional rule: `env: jasmine: true`. So we could actually 
put a single eslintrc file under `/spec/.eslintrc.yml` and have it contain only 
the one `env: jasmine: true` rule. Since root is not set to true for the 
`spec/.eslintrc.yml` file, it'll go up one more directory and apply the 
project-level eslintrc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

[audreyso]

Github user audreyso commented on the issue:

https://github.com/apache/cordova-android/pull/386
  
Thanks! @filmaj That makes sense and seems easier than having to add in 
/*eslint-env:  jasmine*/ in every file.  I made some changes and added .eslint 
configs where they are needed. Let me know if you have any other suggestions or 
feedback!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request #37: CB-10376, CB-12037: (ios) ...

[ccorcos]

Github user ccorcos closed the pull request at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

[ccorcos]

Github user ccorcos commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37
  
@cjpearson really cool. I'll do that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DRAFT] Apache Cordova Board Report - June 2017

[Shazron]

Thank you! Submitting now.

On Mon, Jun 19, 2017 at 7:40 AM, Filip Maj  wrote:

> Just one nit:
>
> "have request Gitbox access" --> "have requested Gitbox access"
>
> LGTM otherwise!
>
> On Sun, Jun 18, 2017 at 3:40 PM,   wrote:
> > LGTM.
> >
> > Sent from my phone.
> >
> > ___
> > Kerri Shotts
> > photoKandy Studios, LLC
> >
> > On the Web: http://www.photokandy.com/
> >
> > Social Media:
> >   Twitter: @photokandy, http://twitter.com/photokandy
> >   Tumblr: http://photokandy.tumblr.com/
> >   Github: https://github.com/kerrishotts
> > https://github.com/organizations/
> photokandyStudios
> >   CoderWall: https://coderwall.com/kerrishotts
> >
> > Apps on the Apple Store:
> >   https://itunes.apple.com/us/artist/photokandy-studios-llc/
> id498577828
> >
> > Books:
> >  http://www.packtpub.com/phonegap-2-mobile-application-
> hotshot/book
> >   http://www.packtpub.com/phonegap-social-app-development/book
> >
> >> On Jun 18, 2017, at 15:13, Shazron  wrote:
> >>
> >> Please review and comment if necessary.
> >>
> >> I would like a couple of +1 or LGTM before I send it off on Monday
> >>
> >> https://github.com/cordova/apache-board-reports/blob/
> master/2017/2017-06.md
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-camera issue #271: Incorrect "JIRA issue tracker" link in Rea...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/271
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/271/commits/7155b636d5e29dde003199a4d653247b798bcd6b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/177/)

 316 tests run, 34 skipped, 2 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DRAFT] Apache Cordova Board Report - June 2017

[Filip Maj]

Just one nit:

"have request Gitbox access" --> "have requested Gitbox access"

LGTM otherwise!

On Sun, Jun 18, 2017 at 3:40 PM,   wrote:
> LGTM.
>
> Sent from my phone.
>
> ___
> Kerri Shotts
> photoKandy Studios, LLC
>
> On the Web: http://www.photokandy.com/
>
> Social Media:
>   Twitter: @photokandy, http://twitter.com/photokandy
>   Tumblr: http://photokandy.tumblr.com/
>   Github: https://github.com/kerrishotts
> https://github.com/organizations/photokandyStudios
>   CoderWall: https://coderwall.com/kerrishotts
>
> Apps on the Apple Store:
>   
> https://itunes.apple.com/us/artist/photokandy-studios-llc/id498577828
>
> Books:
>  http://www.packtpub.com/phonegap-2-mobile-application-hotshot/book
>   http://www.packtpub.com/phonegap-social-app-development/book
>
>> On Jun 18, 2017, at 15:13, Shazron  wrote:
>>
>> Please review and comment if necessary.
>>
>> I would like a couple of +1 or LGTM before I send it off on Monday
>>
>> https://github.com/cordova/apache-board-reports/blob/master/2017/2017-06.md

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #271: Incorrect "JIRA issue tracker" link in Rea...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/271
  
Thanks for the PR!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #271: Incorrect "JIRA issue tracker" link...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/271


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #138: CB-12671 iOS: Fix auto-test with stopping m...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/138
  
@matrosov-nikita with your new committership, feel free to merge this in 
yourself :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #271: Incorrect "JIRA issue tracker" link...

[jacquesdev]

GitHub user jacquesdev opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/271

Incorrect "JIRA issue tracker" link in Readme

Fixed incorrect "JIRA issue tracker" link in Readme

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/OLIOEX/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #271


commit 7155b636d5e29dde003199a4d653247b798bcd6b
Author: Jacques de Villiers 
Date:   2017-06-19T13:37:15Z

Incorrect "JIRA issue tracker" link in Readme




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Apache cordova screen size

[julio cesar sanchez]

Hi.

This mail list is to talk about the Cordova project development, not for
support while using it.

There are plenty of ways of getting the screen size, javascript provides
the screen object, window object also provides a innerHeight and innerWidth
properties, also document.documentElement object has clientHeight and
clientWidth.

But those values might not match or can be different per platform or per
version, so it's better if you check them all and see if any of them
returns what you expect.

If not, you can search for a screen plugin, and if there is none, then you
can create one following this guide
https://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html


2017-06-19 10:45 GMT+02:00 antonis katsikadamos <
antonis.katsikada...@nmc2.eu>:

> Hello.
>
>
>
> Is there a plug-in or a way to get the device’s screen width and height?
>
>
>
> Thank you in advance for your response,
>
>
>
> *Antonis Katsikadamos | ** Senior software engineer*
>
> [image: unnamed]
>
>
> *---*
>
> *NEW MEDIA CONCEPT* *|* *39, 17th Noemvriou 1973 Str. – Cholargos **|** GR
> 155 62 **|** Athens **|* *Greece **|*
>
> *T: +30 215 510 68 28 **|** F: +30 215 510 68 27 **|*
>
> *Visit us at**:*
>
> *http://blog.nmc2.eu/ *
>
> *http://www.facebook.com/nmc2.eu * *|*
>
>
> *---*
>
>
>
>
> 
>  Virus-free.
> www.avast.com
> 
> <#m_2299075537218911270_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>

RE: Nightly build #379 for cordova has failed

[alsorokin]

Someone has added coho to the list of published repos:
https://builds.apache.org/job/cordova-nightly/jobConfigHistory/showDiffFiles?timestamp1=2017-05-31_05-15-50=2017-06-08_00-38-59

For some reason, it tries to publish "dev" version and not "nightly".
Anyone already looking into it? I'm going to take a look tomorrow if no one 
replies. 

Thanks,
Alexander Sorokin

-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] 
Sent: Monday, June 19, 2017 5:52 AM
To: Vladimir Kotikov (Akvelon) ; dev@cordova.apache.org
Subject: Nightly build #379 for cordova has failed

Nightly build #379 for cordova has failed.

Please check failure details on build details page at 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuilds.apache.org%2Fjob%2Fcordova-nightly%2F379%2F=02%7C01%7Cv-alsoro%40microsoft.com%7Cf363a34a0fd5457d80ee08d4b6be36de%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636334375461332879=bq%2B0BXx97eHc42NzqhbHh%2FFBSO8El%2Bpe1qwvvDCKPXU%3D=0
You can also take a look at build console: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuilds.apache.org%2Fjob%2Fcordova-nightly%2F379%2FconsoleFull=02%7C01%7Cv-alsoro%40microsoft.com%7Cf363a34a0fd5457d80ee08d4b6be36de%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636334375461332879=xlMpDpXFKsPGqKyUPIMCM2tFCyZQrxlWlVB7uw%2BVTp0%3D=0

-
Jenkins for Apache Cordova


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Apache cordova screen size

[antonis katsikadamos]

Hello. 

 

Is there a plug-in or a way to get the device's screen width and height?

 

Thank you in advance for your response,

 

Antonis Katsikadamos |  Senior software engineer




---

NEW MEDIA CONCEPT | 39, 17th Noemvriou 1973 Str. - Cholargos | GR 155 62 |
Athens | Greece |

T: +30 215 510 68 28 | F: +30 215 510 68 27 |

Visit us at:

  http://blog.nmc2.eu/

  http://www.facebook.com/nmc2.eu |


---

 



---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

[GitHub] cordova-plugin-inappbrowser pull request #210: CB-12367: Modernize styling o...

[shazron]

Github user shazron commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/210#discussion_r122649041
  
--- Diff: src/ios/CDVInAppBrowser.m ---
@@ -539,115 +545,212 @@ -(void)dealloc {
 - (void)createViews
 {
 // We create the views in code for primarily for ease of upgrades and 
not requiring an external .xib to be included
+UIBarButtonItem* flexibleSpaceButton = [[UIBarButtonItem alloc] 
initWithBarButtonSystemItem:UIBarButtonSystemItemFlexibleSpace target:nil 
action:nil];
+UIBarButtonItem* fixedSpaceButton = [[UIBarButtonItem alloc] 
initWithBarButtonSystemItem:UIBarButtonSystemItemFixedSpace target:nil 
action:nil];
+fixedSpaceButton.width = 20;
 
-CGRect webViewBounds = self.view.bounds;
-BOOL toolbarIsAtBottom = ![_browserOptions.toolbarposition 
isEqualToString:kInAppBrowserToolbarBarPositionTop];
-webViewBounds.size.height -= _browserOptions.location ? FOOTER_HEIGHT 
: TOOLBAR_HEIGHT;
-self.webView = [[UIWebView alloc] initWithFrame:webViewBounds];
+self.webView = [self buildWebView];
+self.spinner = [self buildSpinner];
+self.toolbar = [self buildToolbar];
+
+self.addressLabel = [self buildAddressLabel];
+self.addressBar = [self buildAddressBar:self.addressLabel];
 
-self.webView.autoresizingMask = (UIViewAutoresizingFlexibleWidth | 
UIViewAutoresizingFlexibleHeight);
+self.closeButton = [self buildCloseButton];
+self.forwardButton = [self buildForwardButton];
+self.backButton = [self buildBackButton];
+
+[self.toolbar setItems:@[self.closeButton, flexibleSpaceButton, 
self.backButton, fixedSpaceButton, self.forwardButton]];
+
+self.view.backgroundColor = [UIColor whiteColor];
+
+if (IsAtLeastiOSVersion(@"7.0")) {
--- End diff --

1. 
https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#engines-and-engine
2. 
https://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html#specifying-cordova-dependencies


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #210: CB-12367: Modernize styling o...

[shazron]

Github user shazron commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/210#discussion_r122648718
  
--- Diff: src/ios/CDVInAppBrowser.m ---
@@ -539,115 +545,212 @@ -(void)dealloc {
 - (void)createViews
 {
 // We create the views in code for primarily for ease of upgrades and 
not requiring an external .xib to be included
+UIBarButtonItem* flexibleSpaceButton = [[UIBarButtonItem alloc] 
initWithBarButtonSystemItem:UIBarButtonSystemItemFlexibleSpace target:nil 
action:nil];
+UIBarButtonItem* fixedSpaceButton = [[UIBarButtonItem alloc] 
initWithBarButtonSystemItem:UIBarButtonSystemItemFixedSpace target:nil 
action:nil];
+fixedSpaceButton.width = 20;
 
-CGRect webViewBounds = self.view.bounds;
-BOOL toolbarIsAtBottom = ![_browserOptions.toolbarposition 
isEqualToString:kInAppBrowserToolbarBarPositionTop];
-webViewBounds.size.height -= _browserOptions.location ? FOOTER_HEIGHT 
: TOOLBAR_HEIGHT;
-self.webView = [[UIWebView alloc] initWithFrame:webViewBounds];
+self.webView = [self buildWebView];
+self.spinner = [self buildSpinner];
+self.toolbar = [self buildToolbar];
+
+self.addressLabel = [self buildAddressLabel];
+self.addressBar = [self buildAddressBar:self.addressLabel];
 
-self.webView.autoresizingMask = (UIViewAutoresizingFlexibleWidth | 
UIViewAutoresizingFlexibleHeight);
+self.closeButton = [self buildCloseButton];
+self.forwardButton = [self buildForwardButton];
+self.backButton = [self buildBackButton];
+
+[self.toolbar setItems:@[self.closeButton, flexibleSpaceButton, 
self.backButton, fixedSpaceButton, self.forwardButton]];
+
+self.view.backgroundColor = [UIColor whiteColor];
+
+if (IsAtLeastiOSVersion(@"7.0")) {
--- End diff --

Any reason we should worry about older iOS versions anymore? The latest iOS 
platform release cordova-ios@4.4.0 only supports iOS 9 and up. 

To support older iOS versions (so users can fall back to older plugin 
versions for their platform version), you can add engine tag support like so: 
1. 
https://github.com/phonegap/phonegap-plugin-push/blob/464636b9ae257afc712cfebcc1ed11425590c509/plugin.xml#L14-L18
2. 
https://github.com/phonegap/phonegap-plugin-push/blob/464636b9ae257afc712cfebcc1ed11425590c509/package.json#L33-L51


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #210: CB-12367: Modernize styling of iOS I...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/210
  
Thank you for the PR.
Since this is only adding a feature (tintcolor), and changing behaviour of 
a feature (toolbarstyle), the version should be bumped a minor to 1.8.0. (we 
follow semver). No breaking changes thus this is not a major version bump.

I would have to test this on an iPad before I can merge it in.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file issue #207: CB-12930: (windows) Fix getDirectory trailin...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/207
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/207/commits/6555f2a9e2bbefbd464487b9aafbe5af5093a053)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/5/)

 915 tests run, 7 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org