[GitHub] cordova-cli pull request: Unified config.xml syntax

2014-04-11 Thread gorkem
Github user gorkem closed the pull request at: https://github.com/apache/cordova-cli/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-17 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-cli/pull/165 CB-6469 - Restore plugins from config.xml Adds a save command to save the state of the installed plugins. Changes prepare so that config.xml is read and any missing plugins are installed. Adds

[GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-18 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-cli/pull/165#issuecomment-40837864 JSON parse is a Copy/paste problem. I have based the implemantation of save from an earlier prototype I had that did a bower like json file. Updated now. --- If

[GitHub] cordova-cli pull request: CLI implementation for the save and rest...

2014-05-13 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-cli/pull/176 CLI implementation for the save and restore plugins Adds a new save command to CLI which persists the currently added plugins to config.xml. There is also an accompanying restore command

[GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-13 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-cli/pull/165#issuecomment-43031932 new PR coming --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-13 Thread gorkem
Github user gorkem closed the pull request at: https://github.com/apache/cordova-cli/pull/165 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-15 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-cli/pull/176#issuecomment-43131037 I am not %100 sure about how the experimental works but here is my shot --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-cli pull request: CLI docs for save and restore plugins

2014-05-21 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-cli/pull/177 CLI docs for save and restore plugins Document update for the save and restore plugins commands You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-cli pull request: CB-6756 Add save and restore platforms

2014-05-26 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-cli/pull/178 CB-6756 Add save and restore platforms Adds the platforms subcommand for save and restore You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-lib pull request: CB-6756 Initial implementation for the s...

2014-06-18 Thread gorkem
Github user gorkem closed the pull request at: https://github.com/apache/cordova-lib/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-6756 Initial implementation for the s...

2014-06-18 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/18#issuecomment-46499679 closing as merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-6756 Initial implementation for the s...

2014-06-18 Thread gorkem
GitHub user gorkem reopened a pull request: https://github.com/apache/cordova-lib/pull/18 CB-6756 Initial implementation for the save and restore platforms command Adds implementation of the save and restore command for platforms. It also enhances the ConfigParser to support engine

[GitHub] cordova-lib pull request: CB-6756 Initial implementation for the s...

2014-06-18 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/18#issuecomment-46500220 My bad. this is restore platforms.. Restore plugins is already merged. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: url and local save/restore support

2014-09-14 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/86 url and local save/restore support Implements save and restore for plugins that are coming from local file system or from a git repo. Also makes a change so that the dependency plugins are

[GitHub] cordova-lib pull request: [CB-4731] avoid duplicates when merging ...

2014-09-24 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/91 [CB-4731] avoid duplicates when merging arrays removes duplicate entries from arrays when modifying plist files You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugman pull request: update help for plugman info

2014-09-26 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-plugman/pull/79 update help for plugman info Make plugin id is needed clearer You can merge this pull request into a Git repository by running: $ git pull https://github.com/gorkem/cordova-plugman CB

[GitHub] cordova-lib pull request: [CB-5989] - Default to $PROJECT_NAME-Inf...

2014-09-29 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/95 [CB-5989] - Default to $PROJECT_NAME-Info.plist when searching for plist... If a Info.plist file is given with asterisk and there are multiple matches default to use the file for the project

[GitHub] cordova-lib pull request: [CB-7820] cordova platfrom restore stops...

2014-10-18 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/106 [CB-7820] cordova platfrom restore stops if a platforms fails to restore handles restoration for each platform separately so that if one fails installation for others continues. Also makes

[GitHub] cordova-lib pull request: [CB-7820] cordova platfrom restore stops...

2014-10-20 Thread gorkem
Github user gorkem commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/106#discussion_r19126554 --- Diff: cordova-lib/src/cordova/restore.js --- @@ -54,7 +54,22 @@ function installPlatformsFromConfigXML(cfg){ if(!targets || !targets.length

[GitHub] cordova-lib pull request: CB-6472 Merge dictionaries when updating...

2014-10-27 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/115 CB-6472 Merge dictionaries when updating plist files Merges the dictionaries on plist files if both plist and the value from plugin.xml are dictionaries. This makes it consistent with how it

[GitHub] cordova-cli pull request: support for searchpath option to restore...

2014-11-14 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-cli/pull/197 support for searchpath option to restore plugins Correctly passes the searchpath option to restore command. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: Support for searchpath option when resto...

2014-11-14 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/120 Support for searchpath option when restoring plugins passes the searchpath option to plugin add You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-lib pull request: Support for searchpath option when resto...

2014-11-20 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/120#issuecomment-63835895 @kamrik this has a counterpart on CLI repo https://github.com/apache/cordova-cli/pull/197. Can you also take care of that? --- If your project is set up for it, you

[GitHub] cordova-lib pull request: CB-6472 Merge dictionaries when updating...

2014-11-21 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/115#issuecomment-64043986 made some style changes and renamed underscore.. Perhaps we should move to use eslint instead of jshint, I think that still has the style checks. --- If

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-01-08 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/143 Auto save restore for plugins uses .cordova/config.json to automatically save or restore plugins to/from config.xml on a project You can merge this pull request into a Git repository by

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-01-08 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/143#issuecomment-69240637 @omefire Correct did that because plugman has its own hooks, I think, it may be useful to keep the config.xml updated for them --- If your project is set up for it

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-01-08 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/143#issuecomment-69242088 @agrieve Good catch. It is dumb luck this was working correctly. Updated the PR --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

2015-02-02 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72534613 @omefire can we enhance this to do the save if config_json has an auto_save option on regardless of the --save flag on the command. I will remove the corresponding

[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

2015-02-02 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72536059 @omefire Do you have a corresponding PR for plugins? Do you plan to create one? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

2015-02-02 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72537095 No, just go ahead.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-04 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72903015 @omefire Squash this to a single one commit? It will be easier for me to take it into the rest of the save restore changes. --- If your project is set up for it

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-05 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73172414 @omefire I am integrating your changes to mine to implement the full circle. One thing that I have noticed this does not support the url based case for instance the

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73527863 IMHO it is(or was) premature to drop this single PR by itself to master. This new flag --save flag should replace the save command, save command is not removed by

[GitHub] cordova-lib pull request: CB-8420 'cordova plugin add' should retr...

2015-02-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/162#issuecomment-73638713 -1 since we agreed to have auto restore for plugins I do not think this feature will be used at all. --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: [ADD] GET attribute 'version' config.xml...

2015-02-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/161#issuecomment-73638976 There is a new implementation of restore cooking, which auto restores engines and also does handle the version. As part of that work restore command will vanish

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73641308 Already done most of it un https://github.com/gorkem/cordova-lib/tree/save_restore_final and https://github.com/gorkem/cordova-cli/tree/save_restore_final

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-02-12 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/166 Save/Restore for plugins and platforms I think this is a good point to merge these features.. It provides most of the functionality and frankly I am tired of rebasing/merging. Several

[GitHub] cordova-cli pull request: Save/Restore for plugins and platforms C...

2015-02-12 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-cli/pull/209 Save/Restore for plugins and platforms CLI changes Also see https://github.com/apache/cordova-lib/pull/166 Remove save and restore command and updates docs for plugin save You can

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-02-13 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/166#issuecomment-74284189 Save logic is a bit disorganized because I was expecting @omefire to implement it for plugins as well, so I have whipped up something. I will probably make another

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-02-13 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/166#issuecomment-74294685 sure... as long as there plugin install logic uses variables from config.xml, which does not. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-19 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75103410 I wonder if it is worth to do an auto convert from old syntax when we encounter it? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: CB-8499 `cordova platform save` should s...

2015-02-20 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/170#issuecomment-75350562 Is platforms.json an existing file? Is it used anywhere else? I suspect that it is a new file and I am not sure if it is really needed --- If your project is set

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-02-23 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/166#issuecomment-75547919 I think I have addressed the concerns with the latest. If everyone is cool with it, we should go ahead and merge them in. --- If your project is set up for it, you

[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-23 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75658796 @omefire this looks OK and would like to get it in. The dependencies have changed though save.js and restore.js are gone. I could not quickly spot anything on

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-02-23 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/143#issuecomment-75690753 closing as this is obsolete --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-02-23 Thread gorkem
Github user gorkem closed the pull request at: https://github.com/apache/cordova-lib/pull/143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-8577 BugFix 'cordova plugin add

2015-02-27 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76510698 If we change this now it will just make the migration from to logic more complex. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: CB-8577 BugFix 'cordova plugin add

2015-02-28 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76528103 Correct, let's do the change together with the change. My plan is to have some sort of migration logic with that as well to help old friends. At this moment,

[GitHub] cordova-lib pull request: CB-8577 BugFix 'cordova plugin add

2015-03-01 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76639381 Ahhh. I see what you mean now. I think we should fix this on the Config.getFeature(id) so that the existing information on config.xml files are not discarded

[GitHub] cordova-lib pull request: CB-8577 BugFix 'cordova plugin add

2015-03-01 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76643012 I agree, but this is temporary. Special params are going away with the plugin tag. And ConfigParser's current implementation already does a special treatme

[GitHub] cordova-lib pull request: Deprecate the old feature syntax from co...

2015-03-09 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/182 Deprecate the old feature syntax from config.xml Deprecates the feature syntax and starts using the new plugin tags for defining plugins. Adjusts the tests for the new logic. The old feature

[GitHub] cordova-lib pull request: CB-8521 `cordova plugin save` should sav...

2015-03-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/178#issuecomment-77955805 I think this saves **all** the installed plugins to config.xml. The dependency plugins ( those plugins that were installed as a dependency of another) should never

[GitHub] cordova-lib pull request: CB-8521 `cordova plugin save` should sav...

2015-03-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/178#issuecomment-77956329 I was just testing com.ibm.mobile.cordova.ibmpush for something else which seems to pull in another large plugin --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-77969339 Should we close this? #182 removes all this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: Deprecate the old feature syntax from co...

2015-03-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/182#issuecomment-77969729 @omefire see the changes on test-config.xml for examples of the new tag --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: Deprecate the old feature syntax from co...

2015-03-11 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/182#issuecomment-78261223 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: Deprecate the old feature syntax from co...

2015-03-12 Thread gorkem
Github user gorkem closed the pull request at: https://github.com/apache/cordova-lib/pull/182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-04-14 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/166#issuecomment-92777120 correct. `restore` command is removed and restoration happens during `prepare`. You can call `cordova prepare` explicitly to get the similar results to `restore

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-06-08 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/224#issuecomment-110066248 @marcuspridham PR looks. Do you have Apache CLA signed? I can not seem to find it if you have. Before I can merge this one, you need to sign Apache’s Contributor

[GitHub] cordova-cli pull request: CB-9784 Remove CLI logger levels prefixe...

2015-10-12 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-cli/pull/224#issuecomment-147553471 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...

2015-10-21 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/328 CB-9736 - Extra main activity generated when an android package name specified Removes the old package name after the new one is created. If the package name is different You can merge

[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...

2015-10-22 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/328#issuecomment-150394486 @stevengill Yes, created CB-9844 to follow up. This one is still valid for fixing older android engines though. --- If your project is set up for it, you can reply

[GitHub] cordova-android pull request: CB-9844 Remove old .java after renam...

2015-10-27 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-android/pull/233#issuecomment-151513478 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request:

2015-11-18 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/commit/a7e71227d2157e677c3ce495341c83916f9b272f#commitcomment-14483903 It is documented in http://cordova.apache.org/docs/en/5.4.0/platform_plugin_versioning_ref/index.html --- If your project

Re: config.xml - phonegap properties

2013-04-30 Thread Gorkem Ercan
n the cli's template. -- Gorkem -- Gorkem http://www.gorkem-ercan.com On Tue, Apr 30, 2013 at 1:58 PM, Michael Brooks wrote: > Hi Andreas, > > Good catch and we've already logged this issue as CB-3279 [1]. > > I haven't had a chance to investigate it, but I imagine it

Re: config.xml - phonegap properties

2013-05-06 Thread Gorkem Ercan
coming your way. -- Gorkem -- Gorkem http://www.gorkem-ercan.com On Mon, May 6, 2013 at 3:42 PM, Filip Maj wrote: > Thanks Andrew! > > On 5/6/13 12:12 PM, "Andrew Grieve" wrote: > > >I merged these on Friday :) > > > > > >On Tue, Apr 30, 2013 at 5:

Re: [Android] Can rename DroidGap to CordovaActivity?

2013-05-10 Thread Gorkem Ercan
Should this also update the TAG value for logs? https://github.com/apache/cordova-android/pull/52 -- Gorkem http://www.gorkem-ercan.com On Tue, May 7, 2013 at 12:54 PM, Joe Bowser wrote: > Done! I've committed it so that when we pull things in they should go > to the right place.

Re: Changes to config.xml

2013-05-11 Thread Gorkem Ercan
This was actually my change. I think this would possibly cause a break only if the plugin is already defined as tag and plugin.xml defines it again with tag. Is that the case? If so we can do a priority selection until the tag is completely retired. -- Gorkem -- Gorkem On Fri, May 10, 2013

Re: Removal of from config.xml

2013-05-16 Thread Gorkem Ercan
+1 for a deprecation period -- Gorkem On Thu, May 16, 2013 at 3:45 PM, Filip Maj wrote: > We deprecated this recently. Can we leave an empty element in > config.xml for each platform while the deprecation window is still open? > This way tooling such as plugman can still add eleme

Re: Unified config.xml

2013-05-16 Thread Gorkem Ercan
Without knowing much about wp plugins, would there be necessity to differentiate between wp7 and wp8? So that param name would be for wp7-package for wp7. -- Gorkem On Thursday, May 16, 2013, Jesse wrote: > Should we be aiming to ship 2.8.0 with a unified version of config.xml in > the te

Re: iOS ScreenCapture plugin for Cordova

2013-05-16 Thread Gorkem Ercan
> > > thanks! > > > > > > > > > > > > Brian: I'll try to get this going with Plugman and let you know > how > > > it > > > > > > goes. > > > > > > > > > > > > Thanks! > > > > > > -Aaron > > > > > > > > > > > > > > > > > > On Mon, Apr 15, 2013 at 1:10 PM, Brian LeRoux > wrote: > > > > > > > > > > > >> My only feedback would be to see if you can get it working w/ > > > Plugman! > > > > > [1] > > > > > >> (And if not lets file issues [2] to ensure it can.) > > > > > >> > > > > > >> [1] https://github.com/apache/cordova-plugman > > > > > >> [2] http://issues.cordova.io > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > > >> On Mon, Apr 15, 2013 at 11:01 AM, Max Woghiren < > m...@chromium.org > > > > > > > > wrote: > > > > > >> > > > > > >> > Hi Aaron, > > > > > >> > > > > > > >> > One quick, general Objective-C thing I noticed: when creating > > > > -- -- Gorkem

Re: Changing config and plugin XML namespace

2013-05-17 Thread Gorkem Ercan
Is there a use for a cordova namespace once the config.xml moves from plugins to feature? -- Gorkem -- Gorkem On Fri, May 17, 2013 at 11:25 AM, Shazron wrote: > +1 > > On Friday, May 17, 2013, Filip Maj wrote: > > > Sounds good to me > > > > On 5/17/13 8:07

Re: Unified config.xml

2013-05-21 Thread Gorkem Ercan
Another option is to use wp- for common and and wp8 and wp7 for the version specific ones. I agree with getting more wp8 only plugins. -- Gorkem On Friday, May 17, 2013, Jesse MacFadyen wrote: > Hi Gorkem, > > Since your question I have given this some thought. For the most part > w

Re: Baby Grieve

2013-05-31 Thread Gorkem Ercan
Congrats! My best wishes to Grieve family. -- Gorkem On Fri, May 31, 2013 at 2:23 PM, Shazron wrote: > Congrats Andrew!! :) > > > > On Fri, May 31, 2013 at 7:00 AM, Andrew Grieve > wrote: > > > Coming 1 month early > > > > Everett Arend Grieve born

Re: [CB-1108] Migrate config.xml to the W3C spec

2013-06-09 Thread Gorkem Ercan
#comment-13679171 on locations. I think extensions to icon and a new directory on the cli project structure is needed. -- Gorkem On Fri, Jun 7, 2013 at 4:09 PM, Shazron wrote: > It'll be nice to be on the same page for config.xml for 3.0.0 We should > decide what to do with this iss

Re: Accessing internet data via CELL_2G, CELL_3G or CELL_4G:

2013-06-13 Thread Gorkem Ercan
#Connection -- Gorkem -- Gorkem On Thu, Jun 13, 2013 at 8:02 AM, Otavio Soccol wrote: > > > Hi, > > I would like to know if there is a way of accessing internet > data with a device that is not connected to the internet via Wi-Fi or > Ethernet. > > > Is there a way of

Re: Is a config.xml without an author valid?

2013-07-16 Thread Gorkem Ercan
It should be OK if author is missing. I have tools that does validation and moreover it has zero or one occurrence on the spec. http://www.w3.org/TR/widgets/#the-author-element-and-its-attributes -- Gorkem On Tue, Jul 16, 2013 at 11:48 AM, Filip Maj wrote: > I think it should be necessary

Re: Releases in a 3.0 World

2013-08-06 Thread Gorkem Ercan
Another disadvantage is, this may cause downstream distributions of Cordova to get fragmented. -- Gorkem On Tue, Aug 6, 2013 at 4:43 PM, Andrew Grieve wrote: > Want to have this as a discussion starter. > > We've previously established that: > 1. Releases for plugman &

Re: Releases in a 3.0 World

2013-08-07 Thread Gorkem Ercan
same situation today. However, today we do provide a version and guidance that tells everyone cordova version X.X should be. I am afraid that if all parts of cordova can release independently that will blur. -- Gorkem On Wed, Aug 7, 2013 at 10:32 AM, Andrew Grieve wrote: > Gorkem, could you e

Plugman behavior with assets

2013-08-22 Thread Gorkem Ercan
$project/www folder. Does it make sense that these files are copied under $project/www or merges/$platform/ if they are platform specific rather than directly into platform projects? -- Gorkem

Re: Plugman behavior with assets

2013-08-26 Thread Gorkem Ercan
? -- Gorkem On Mon, Aug 26, 2013 at 10:16 AM, Braden Shepherdson wrote: > This was a deliberate decision. We want the $project/www and > $project/merges/* to be strictly user files only. This makes the user code > easy to version control and prevents all kinds of horrible clobbering bugs, &

Re: config.xml refactoring

2013-08-28 Thread Gorkem Ercan
problem. I guess use case/requirement here is not to have config.xml differences between platforms. As a note we treat platforms/... directory as generated content (and regenerate them when needed). -- Gorkem On Wed, Aug 28, 2013 at 1:49 PM, Braden Shepherdson wrote: > So we have several bugs[1

Re: Platforms Meet-up @ Waterloo

2013-10-11 Thread Gorkem Ercan
+1 would like to come, Red Hat is interested to contribute on platforms as well. -- Gorkem On Wed, Oct 9, 2013 at 10:10 AM, Andrew Grieve wrote: > Working via email is fun, but seeing each other in person is fun too! > > I'd like to invite committers / active contributors who ar

Re: third-party cordova plugin registry

2013-10-15 Thread Gorkem Ercan
in cordova registry. The other experimental stuff should live elsewhere but be easily consumable for the brave. -- Gorkem On Sat, Oct 12, 2013 at 9:02 PM, Joni Rustulka wrote: > I started work on an updated UI for the cordova registry yesterday, > coincidentally. > > -j >

Re: third-party cordova plugin registry

2013-10-15 Thread Gorkem Ercan
? -- Gorkem On Tue, Oct 15, 2013 at 9:56 PM, Anis KADRI wrote: > I agree that they should be encouraged. > > configuration is stored in plugman (even for cordova-cli) and one can > easily set a registry with `plugman config set registry > http://newregistry' (exactly like

Re: new meta data for plugin.xml

2013-10-18 Thread Gorkem Ercan
. -- Gorkem On Fri, Oct 18, 2013 at 1:12 PM, Michal Mocny wrote: > +1 to repo / issue / website / docs etc metadata > > -1 *for now* to dependencies at specific versions, and testing related > changes like , just because its not clear what the right solution to > these problems is.

a new client for download stats

2013-10-20 Thread Gorkem Ercan
an stay as a ghost downloader and do not ping after a successful download. -- Gorkem

Re: BlackBerry 10 plugins and config.xml

2013-11-03 Thread Gorkem Ercan
Perhaps it should be the other platforms that should match the Blackberry behavior. AFAIK plugman does not guarantee feature names to be unique. -- Gorkem On Sun, Nov 03, 2013 at 01:00:47PM -0500, Don Coleman wrote: > I'm trying to update a BlackBerry 10 plugin to use Cordova 3.1.0.

Re: HTML 5 platform

2013-11-04 Thread Gorkem Ercan
I think Ripple already does a good job at providing the core funtionality for testing. A "platform" may make sense only for Cordova plugin. They can provide provide mocks (or a fully working version) that will work with ripple/browser. -- Gorkem On Mon, Nov 04, 2013 at 03:51:

Re: HTML 5 platform

2013-11-05 Thread Gorkem Ercan
/browsersim-news-4.1.0.Beta1.html -- Gorkem On Tue, Nov 05, 2013 at 11:02:01AM -0500, James Jong wrote: > thanks Michal! will have to try that out sometime. > -James Jong > > On Nov 5, 2013, at 10:17 AM, Michal Mocny wrote: > > > http://en.wikipedia.org/wiki/Chromi

Android target level for CLI

2013-11-05 Thread Gorkem Ercan
Hello, Does anyone recall the reason for CLI to having "android-17" as a hard target dependency. -- Gorkem

Re: android target level

2013-11-07 Thread Gorkem Ercan
-- Gorkem On Thu, Nov 7, 2013 at 7:51 AM, Brian LeRoux wrote: > Axel: you are correct that we want as many devices as possible. This is why > we've always set to the highest level. If you set to the highest level it > is inclusive to all platforms before it (that we decide to supp

Re: tag, and accessing the plugin list

2013-11-13 Thread Gorkem Ercan
Hey Braden, Why is not the current tags sufficient for this? -- Gorkem On Wed, Nov 13, 2013 at 2:32 PM, Braden Shepherdson wrote: > Hey folks, > > We've been kicking around the idea of getting at which plugins/versions are > installed, at runtime. In order to make that happe

Re: tag, and accessing the plugin list

2013-11-13 Thread Gorkem Ercan
plugins out there that are still using that tag for instance [1] is from barcode scanner plugin from the registry. As an alternate, tag can be used and id and version info can be injected as additional tags by plugman. [1] -- Gorkem On Wed, Nov 13, 2013 at 3:23 PM

Re: tag, and accessing the plugin list

2013-11-13 Thread Gorkem Ercan
. And apparently adobe sf just had a coffee break... -- Gorkem On Wed, Nov 13, 2013 at 4:27 PM, Braden Shepherdson wrote: > I'm open to changing the names to something else, since I realize there > used to be a tag and tags inside, before we used > . > > Adding these as par

Re: tag, and accessing the plugin list

2013-11-13 Thread Gorkem Ercan
ullah > > wrote: > > > > > > > Brian: plugin mapping "service js name" -> "service native > name/class" > > > > > > > > On 11/13/13 2:36 PM, "Brian LeRoux" wrote: > > > > > >

Re: Moving .cordova/config.json -> cordova.json

2014-01-01 Thread Gorkem Ercan
. Since .cordova is basically a marker for CLI for the root of an app I think renaming config.xml should provide the same functionality. -- Gorkem On Tue, Dec 31, 2013 at 1:19 PM, Andrew Grieve wrote: > Thanks for the feedback! > > I don't think we should move files around automat

Re: Moving .cordova/config.json -> cordova.json

2014-01-02 Thread Gorkem Ercan
Are the platform locations set by Cordova CLI already? I know phonegap does it and I actually wish to add it to Cordova CLI as well [1] but I thought it was not implemented on CLI. [1] https://issues.apache.org/jira/browse/CB-5218 In any case, engine info can go into cordova.xml. -- Gorkem On

Re: Moving .cordova/config.json -> cordova.json

2014-01-02 Thread Gorkem Ercan
part of CLI's configuration -- Gorkem On Thu, Jan 02, 2014 at 01:28:12PM -0500, Andrew Grieve wrote: > Hmm, good point about absolute paths. > > I think if you're using an override there though, that you could set it to > a relative path for shared projects. Same thing wi

Re: Moving .cordova/config.json -> cordova.json

2014-01-02 Thread Gorkem Ercan
and have only the cordova.xml to carry project specific properties. -- Gorkem On Thu, Jan 02, 2014 at 12:16:57PM -0800, Brian LeRoux wrote: > Considering http://wiki.apache.org/cordova/ConfigurationFiles I'm not sure > we want more config either. > > Perhaps we n

  1   2   3   >