Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154574485
Looks fine, but maybe we should just remove this check and do this another
way.
---
If your project is set up for it, you can reply to this email
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154577826
I think that's what #112 does.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154187370
Can you create a JIRA issue for this, so I know what I'm testing?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#discussion_r44106504
--- Diff: src/android/ContentFilesystem.java ---
@@ -18,22 +18,19 @@ Licensed to the Apache Software Foundation (ASF) under
one
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-153969952
@charlesverge, do you have an ICLA signed for this? Usually when people
write entire new methods, I need an ICLA before I can accept public
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-docs/pull/409
Update to plugin.md regarding Cordova-Android 5.0.x changes
Also changed out-of-date debugging information. Also, the Android
Permissions information was completely missing from the plugin
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/132#issuecomment-153199173
That permission request looks fine. I really wish we could communicate why
we need the damn permission.
---
If your project is set up for it, you can
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-152660125
Where are you adding the unit test? We currently don't have a way to unit
test plugins.
---
If your project is set up for it, you can reply
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/53#issuecomment-152604278
Rebased this code in, closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/78#issuecomment-152604483
Rebased into master, closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/71#issuecomment-152604611
Rebased, Closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151959575
Can we get an updated Camera plugin branch with the same branch name so
that we can work off the same code? Also, an example app for this may be a
good idea
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152024614
I turned on "Don't keep activities" on both a Moto E (Android 4.4.1) and a
Samsung Galaxy S6 Edge (Android 5.1) to test this, and I'm not able to act
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-151176788
Is there a JIRA issue related to this pull request. We need to be able to
see what the problem is before we can talk about this issue. We're
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/128#issuecomment-150695843
Closing pull request. Code has now been rebased and merged.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-150703173
@cojomojo Won't this still have the problem you found when you filed this?
https://issues.apache.org/jira/browse/CB-9506
---
If your project is set up
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149986619
I agree with @purplecabbage, and I'm still -1 on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-149992603
Does this actually work if you have a signficantly large application
loading in the background? Or is this going to cause more white flashes
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/223#issuecomment-149619074
I rebased this into the repository, closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149027648
-1 to this as well. This wouldn't be consistent on Android, since we're
using Intents to launch a camera, and it's possible some devices wouldn't have
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/93#issuecomment-148098334
I've added a smaller fix in the Marshmallow camera to provide a real path,
but it doesn't work with remote files. We're not accepting this code
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-148106620
This is a good idea, since this removed a required permission from the
Audio plugin. Can you ask on the Cordova list if there's a reason this isn't
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-147443002
Can this wait until after my Cordova-Android 5.0.x pull request is merged
in? checkForDuplicateImage requires a permission on Android 6.0+ and I want
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/226#issuecomment-147458901
Why is all of element-tree and the other npm dependencies checked in? That
seems very odd, and makes it harder to figure out what's going on.
---
If your
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/78#issuecomment-147040788
@maheshravva Your question has nothing to do with this pull request.
Please ask your question on Stack Overflow, or on a different forum
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/135
Adding permissions, giving read seems to give write access as well
This is so we can write to the shared directory if we need to.
You can merge this pull request into a Git repository
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/128
Marshmallow/Cordova Android 5.0.x compatibility changes
This patch also fixes a long-standing issue with files not actually being
returned, and instead Content URIs being returned
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-android/pull/220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/220#issuecomment-144519379
Going to close and issue a new pull request based on the prior pull request.
---
If your project is set up for it, you can reply to this email and have your
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/52
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/222#issuecomment-144543404
Check out #223 for the new API updates, it's a lot of the same code, but
abstracts the permission checking code out of the individual plugins.
---
If your
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/223
Cordova-Android 5.0/Marshmallow Updates - Take 2
This has some changes based on the feedback from Pull Request #220
You can merge this pull request into a Git repository by running
GitHub user infil00p reopened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/125
Marshmallow/Cordova Android 5.0.x compatibility changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infil00p/cordova
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40473698
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40475167
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/78#discussion_r40477508
--- Diff: src/android/ContactManager.java ---
@@ -48,13 +54,66 @@ Licensed to the Apache Software Foundation (ASF) under
one
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40476918
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40478236
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/220
Current Cordova-Android 5.0 changes.
These are the changes to Cordova-Android that make it a 5.0 change. This
is a very minor major release, since we're literally just adding the ability
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/78
Changes for Cordova Android 5.0/Marshmallow Functionality
This includes a refactor since many of the methods had to be pulled out of
the if/else statement.
You can merge this pull
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/125
Marshmallow/Cordova Android 5.0.x compatibility changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infil00p/cordova-plugin
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/71
Cordova-Android 5.0/Marshmallow Updates
This one had to be re-written because of our workflow. The PHONE_STATE
permission needs to be removed in favour of AudioFocus
You can merge
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40387288
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -161,4 +164,35 @@ public ActivityResultHolder(int requestCode, int
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/52
Creation of the Geolocation Plugin entirely for permissions handling on
Marshmallow.
This is an ugly hack, but it works. It may make sense for a webview to
come packaged
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/99#issuecomment-135206061
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;a=commit;h=2b31723708256c08c5209308eb6ccfb03e2ab990
---
If your
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/99#issuecomment-135205895
Oops. I forgot to do the comment to close this when I merged it. Can you
please do this?
---
If your project is set up for it, you can reply
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-133185529
You removed part of the cropping functionality, we can't accept this pull
request as it is.
---
If your project is set up for it, you can reply
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/93#issuecomment-119692899
Does this have a corresponding JIRA issue? Also, I'm going to talk about
this on the dev list before pulling it in.
---
If your project is set up
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-android/pull/192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/192#issuecomment-119032970
Didn't read the plugin info. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/192
CB-9298: Preferences are now passed to the Cordova Interface
I'm doing a pull request instead of just slamming this in because this is
actually a pretty important change that will impact
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-113225945
Agree with @purplecabbage, the iOS whitespace stripping is a blocker.
---
If your project is set up for it, you can reply to this email and have
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112232035
Why does this pull request touch iOS? Can you make it so that it's only
Android?
---
If your project is set up for it, you can reply
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/36#issuecomment-104742963
Just as @jcesarmobile said, there are no modules needed, therefore this
should be closed. Because this is a copy of the repository
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/151#discussion_r23665332
--- Diff: framework/src/org/apache/cordova/ICordovaCookieManager.java ---
@@ -0,0 +1,45 @@
+/*
+ Licensed to the Apache Software
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/134#issuecomment-66163613
Glad that this is taking spinners out. Those spinners have been a personal
pet-peeve for years.
---
If your project is set up for it, you can reply
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/134#issuecomment-66163749
This looks good, let's merge it in. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/24#issuecomment-64906784
I have no idea why Amazon FireOS still has a Geolocation plugin. This is
clearly a bug.
---
If your project is set up for it, you can reply
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-48951400
init() has been recently deprecated. I'm not convinced that this is
solving a problem that we currently have. I'm not in favour of having
Factories just
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46241179
I've accepted the first two and did the last fix at the same time. Can you
close this pull request, since I don't remember how Apache wants us to do
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/13#issuecomment-40491756
Actually, you're right. Android generally returns 3gp and mp4 files.
Returning an AVI container may mess things up.
---
If your project is set
301 - 368 of 368 matches
Mail list logo
