[GitHub] cordova-android issue #352: CB-12291: (android) Add x86_64, arm64 and armeab...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-android/pull/352 @infil00p Can you please review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #352: CB-12291: (android) Add x86_64, arm64 and...
Github user mbektchiev closed the pull request at: https://github.com/apache/cordova-android/pull/352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #352: CB-12291: (android) Add x86_64, arm64 and...
GitHub user mbektchiev reopened a pull request: https://github.com/apache/cordova-android/pull/352 CB-12291: (android) Add x86_64, arm64 and armeabi architecture flavors ### Platforms affected android ### What does this PR do? Add `armeabi`, `arm64-v8a` and `x86_64` ### What testing has been done on this change? Built and checked for existence of the native libraries in the resulting `.apk`s using `--gradleArg=-PcdvBuildMultipleApks=true` and `--gradleArg=-PcdvBuildArch=` with `armeabi`, `arm`, `arm64`, `x86`, `x86_64` on a project having https://github.com/couchbaselabs/Couchbase-Lite-PhoneGap-Plugin installed. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. *I'm not sure what tests to add and whether they're necessary so I'm checking this item.* fixes https://issues.apache.org/jira/browse/CB-12291 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-android include-armeabi-dir Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/352.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #352 commit aaa12087e2ba6505c6b0eb7c8a024833bfd9feb7 Author: Martin Bektchiev <martin.bektch...@telerik.com> Date: 2015-12-09T07:30:37Z CB-12291: (android) Add x86_64, arm64 and armeabi architecture flavors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #352: Include armeabi, arm64-v8a and x86_64 libs
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-android/pull/352 After some more thinking about this issue, I think it will be better to provide 3 more flavors: for `arm`, `arm64` and `x86_64` architectures. I will change the PR accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #314: Document lib-file for Android
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-docs/pull/314 Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #326: CB-11771 Deep symlink directories to target proj...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-android/pull/326 Can someone please review this PR? apache/cordova-ios#244 is already merged and in order to fix the issue we need this one and https://github.com/apache/cordova-lib/pull/485 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #485: CB-11771 Deep symlink directories to target project ...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-lib/pull/485 Can someone please review this PR? https://github.com/apache/cordova-ios/pull/244 is already merged and in order to fix the issue we need this one and https://github.com/apache/cordova-android/pull/326 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 Thanks, @shazron I noticed that you've marked the Jira Issue as resolved. In order to completely fix it we should also merge https://github.com/apache/cordova-android/pull/326 and https://github.com/apache/cordova-lib/pull/485. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #244: CB-11771 Deep symlink directories to target p...
Github user mbektchiev closed the pull request at: https://github.com/apache/cordova-ios/pull/244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 You're right, it seems that currently the `--link` option is disregarded in the `resource-file` and `framework` handlers. I've changed them and now you can see the difference in the linking style with the `phonegap-facebook-plugin`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 See https://github.com/Wizcorp/phonegap-facebook-plugin/tree/master/platforms/android/FacebookLib and https://github.com/Telerik-Verified-Plugins/Telerik-AppFeedback/tree/master/src/android/FeedbackLib as two examples of such libraries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 I'm not sure if the same behavior can be reproduced with `cordova-ios`. But since the code is exactly the same as the one in `cordova-android` I thought it might be good idea to keep it consistent and fix it here as well. Basically the scenario is to install a plugin which contains a custom Android library code with `--link`. All intermediate build files are created inside a `build` sub-directory and they leak into the plugin's directory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #485: CB-11771 Deep symlink directories to target p...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/485 CB-11771 Deep symlink directories to target project instead of linking the directory itself When installing a plugin with custom library using the --link option the whole directory is symlinked and temporary files leak into the original plugin directory on build. This leads to broken builds if the same plugin is linked in 2 projects targeting different Cordova versions. fixes [CB-11771 Installing plugin with symlink option pollutes original directory with intermediate files](https://issues.apache.org/jira/browse/CB-11771) related to https://github.com/apache/cordova-ios/pull/244 and https://github.com/apache/cordova-android/pull/326 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/deep-symlink Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/485.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #485 commit 1eb9b207718f00d0101d31c44f9a492f5c16725b Author: Martin Bektchiev <martin.bektch...@telerik.com> Date: 2016-08-26T12:08:16Z CB-11771 Deep symlink directories to target project instead of linking the directory itself When installing a plugin with custom library using the --link option the whole directory is symlinked and temporary files leak into the original plugin directory on build. This leads to broken builds if the same plugin is linked in 2 projects targeting different Cordova versions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #244: CB-11771 Deep symlink directories to target p...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-ios/pull/244 CB-11771 Deep symlink directories to target project instead of linking the directory itself When installing a plugin with custom library using the --link option the whole directory is symlinked and temporary files leak into the original plugin directory on build. This leads to broken builds if the same plugin is linked in 2 projects targeting different Cordova versions. fixes [CB-11771 Installing plugin with symlink option pollutes original directory with intermediate files](https://issues.apache.org/jira/browse/CB-11771) You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-ios bektchiev/deep-symlink Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/244.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #244 commit 15b4fdc6655b034888eb20122df9560c0b42195b Author: Martin Bektchiev <martin.bektch...@telerik.com> Date: 2016-08-26T14:45:59Z CB-11771 Deep symlink directories to target project instead of linking the directory itself When installing a plugin with custom library using the --link option the whole directory is symlinked and temporary files leak into the original plugin directory on build. This leads to broken builds if the same plugin is linked in 2 projects targeting different Cordova versions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #326: CB-11771 Deep symlink directories to targ...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-android/pull/326 CB-11771 Deep symlink directories to target project instead of linking the directory itself When installing a plugin with custom library using the --link option the whole directory is symlinked and temporary files leak into the original plugin directory on build. This leads to broken builds if the same plugin is linked in 2 projects targeting different Cordova versions. fixes [CB-11771 Installing plugin with symlink option pollutes original directory with intermediate files](https://issues.apache.org/jira/browse/CB-11771) You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-android bektchiev/deep-symlink Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/326.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #326 commit 817fc3ae70443e06ea9e6e6af298e7d839b0ff2a Author: Martin Bektchiev <martin.bektch...@telerik.com> Date: 2016-08-26T15:21:23Z CB-11771 Deep symlink directories to target project instead of linking the directory itself When installing a plugin with custom library using the --link option the whole directory is symlinked and temporary files leak into the original plugin directory on build. This leads to broken builds if the same plugin is linked in 2 projects targeting different Cordova versions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Document lib-file for Android
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-docs/pull/314#issuecomment-197412441 @dblotsky The currently existing behavior of the `lib-file` element for Android hasn't been documented so far. I've modified the PR and think that it's worth merging it this way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/290#issuecomment-185053836 Won't fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...
Github user mbektchiev closed the pull request at: https://github.com/apache/cordova-lib/pull/290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fix lint warnings
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/120#issuecomment-171249916 Sorry for the delayed response. I reproduce it when I change the compileSdkVersion to 23 through the `target=android-23` line in `platforms/android/project.properties` and then do a signed release build. If you think that removing the lines altogether is acceptable, we can fix it this way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Include native libraries from armeab...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-android/pull/243#issuecomment-165095165 @infil00p @stevengill @vladimir-kotikov Can someone review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Include native libraries from armeab...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-android/pull/243 Include native libraries from armeabi directory when producing armv7 apk If a Cordova Android project contains `.so` files located in the `lib/armeabi` directory, they will not be included in the final apk when building for the `armv7` architecture with `cdvBuildMultipleApks` set to `true` You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-android include-armeabi-dir Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/243.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #243 commit 6b71726091217dfe0de71563038ecc1faff57592 Author: Martin Bektchiev <martin.bektch...@telerik.com> Date: 2015-12-09T07:30:37Z Include native libraries from armeabi directory when producing armv7 apk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/289#issuecomment-159824863 @stevengill do you think this can be merged now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Default value for required variables
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-docs/pull/415#issuecomment-155318013 Here's the JIRA issue which added this support: https://issues.apache.org/jira/browse/CB-9162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/289#issuecomment-155330596 Rebased on latest master and now tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Default value for required variables
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-docs/pull/415 Default value for required variables You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-docs bektchiev/default-value Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/415.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #415 commit e4d1266767009f22af61552f6265d31ecc17aa5c Author: Martin Bektchiev <mart...@gmail.com> Date: 2015-11-06T08:51:48Z Default value for required variables --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fix lint warnings
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/120 Fix lint warnings The latest Android build tools output the following errors when building a project containing the InAppBrowser plugin in release configuration: ``` :lintVitalRelease /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:555: Error: Expected resource of type id [ResourceType] actionButtonContainer.setId(1); ~ /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:563: Error: Expected resource of type id [ResourceType] back.setId(2); ~ /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:587: Error: Expected resource of type id [ResourceType] forward.setId(3); ~ /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:610: Error: Expected resource of type id [ResourceType] edittext.setId(4); ~ /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:633: Error: Expected resource of type id [ResourceType] close.setId(5); ~ /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:679: Error: Expected resource of type id [ResourceType] inAppWebView.setId(6); ~ Explanation for issues of type "ResourceType": Ensures that resource id's passed to APIs are of the right type; for example, calling Resources.getColor(R.string.name) is wrong. 6 errors, 0 warnings ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-plugin-inappbrowser bektchiev/fix-lint-errors Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/120.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #120 commit b9fd644401f2a7744b37cddb4465b84ad782f929 Author: Martin Bektchiev <martin.bektch...@telerik.com> Date: 2015-10-27T07:58:12Z Fix lint warnings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/290#issuecomment-147354095 Because these dependencies are only when using gradle. For projects that work with ant you have no way to refer a single jar. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/290#issuecomment-140394396 ping @stevengill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/289#issuecomment-137356795 @stevengill Can you please review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/290 CB-7015 Add support for parent and custom attributes in lib-file element This enables referring to libraries from the Android SDK directory. Refs https://issues.apache.org/jira/browse/CB-7015 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/CB-7015 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/290.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #290 commit d11ea52a745ca88e5c08050128b7374eed77b63e Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2015-08-26T14:11:14Z CB-7015 Add support for parent and custom attributes in lib-file element This enables referring to libraries from the Android SDK directory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-7015 Support copying a lib-file from...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-docs/pull/314 CB-7015 Support copying a lib-file from the SDK directory Documents the behavior introduced with: https://github.com/apache/cordova-lib/pull/290 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-docs bektchiev/CB-7015 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/314.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #314 commit 95013100c88d4f80bdfaa7bebd6f9cfef4bb1241 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2015-08-27T10:58:17Z CB-7015 Support copying a lib-file from the SDK directory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9048 Clean up git cloned directories
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/222 CB-9048 Clean up git cloned directories Fixes https://issues.apache.org/jira/browse/CB-9048 Also fix ***jshint*** error: `src/gitclone.js: line 71, col 106, Mixed double and single quotes.` You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/CB-9048-git-directory-leaks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/222.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #222 commit 233ae18ceaa3d49f2f3203a04691ef7a7f712553 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2015-05-20T06:31:59Z CB-9048 Clean up git cloned directories --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8757 - Resolve symlinks in order to a...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/212#issuecomment-99119782 @agrieve I moved the fixes to `install.js` and `uninstall.js`. Do you think it's OK now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8757 - Resolve symlinks in order to a...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/212#issuecomment-99200674 Done. I hadn't noticed the failing test, because it's failing only on Mac, but I hadn't run the tests on a Mac. :four_leaf_clover: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugman pull request: CB-8757 - Resolve any symlinks in or...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-plugman/pull/83#issuecomment-99005935 You're right. I have opened a [new PR](https://github.com/apache/cordova-lib/pull/212) which should be better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugman pull request: CB-8757 - Resolve any symlinks in or...
Github user mbektchiev closed the pull request at: https://github.com/apache/cordova-plugman/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugman pull request: CB-8757 - Resolve any symlinks in or...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-plugman/pull/83 CB-8757 - Resolve any symlinks in order to avoid relative path issues You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-plugman bektchiev/resolve-symlinks-in-paths Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugman/pull/83.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #83 commit 46b968ddf4bc7feea869529c4c800b31631a5dac Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2015-05-04T09:34:43Z CB-8757 - Resolve any symlinks in order to avoid relative path issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8757 Make paths with --link relative ...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/192 CB-8757 Make paths with --link relative to the real project path Fixes https://issues.apache.org/jira/browse/CB-8757 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/CB-8757 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #192 commit cb7f38c554cb98644509b7fdca49dd476f95ecd0 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2015-03-26T15:09:06Z CB-8757 Make paths with --link relative to the real project path --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8155 Do not fail plugin installation ...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/129 CB-8155 Do not fail plugin installation from git url with --link This is wrong when installing a local plugin with dependencies from git repositories. https://issues.apache.org/jira/browse/CB-8155 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/dont-fail-git-plugin-with-link Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 commit 678cfedb7c0ac24ec801726b5b0193c58a0fbdda Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-12-12T15:00:33Z CB-8155 Do not fail plugin installation from git url with --link This is wrong when installing a local plugin with dependencies from git repositories. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7496 Fix --link option for plugman in...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/85#issuecomment-56060031 Can anyone please review? :bug: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: Add support for plugin symbolic links
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/78#discussion_r17232882
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -104,7 +104,12 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
return Q();
}
-shell.rm('-rf', plugin_dir);
+if (fs.lstatSync(plugin_dir).isSymbolicLink()) {
--- End diff --
This check is not necessary. `shell.rm` already removes symbolic links
correctly.
See: https://github.com/arturadib/shelljs/blob/master/src/rm.js#L117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: Add support for plugin symbolic links
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/78#discussion_r17243247
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -104,7 +104,12 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
return Q();
}
-shell.rm('-rf', plugin_dir);
+if (fs.lstatSync(plugin_dir).isSymbolicLink()) {
--- End diff --
@smistry-toushay You're right, it seems that the referred to version of the
shelljs module (`shelljs: 0.1.x`) is rather old and doesn't handle symlinks
correctly.
I think that it would be better to upgrade to the latest version instead of
working around the issues of the old one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-7496 Fix --link option for plugman in...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/85 CB-7496 Fix --link option for plugman install There is support for a --link option for the install command which instead of copying the plugin should make a symbolic link to its original location but it's not working. refs https://issues.apache.org/jira/browse/CB-7496 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/fix-install-link-option Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/85.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #85 commit 434c3abfc3561109b4391e439dc6afe86bffdc71 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-09-08T11:21:21Z CB-7496 Fix --link option for plugman install --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: Add support for plugin symbolic links
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/78#discussion_r17245409
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -104,7 +104,12 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
return Q();
}
-shell.rm('-rf', plugin_dir);
+if (fs.lstatSync(plugin_dir).isSymbolicLink()) {
--- End diff --
I implemented the option for plugman because it didn't work there also.
Here's my pull request which also updates the shelljs library version:
https://github.com/apache/cordova-lib/pull/85.
I verified that all unit tests pass and that it doesn't delete the target
directory of a symbolic link - so you can safely remove this code, afterwards.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-android pull request: CB-7265: Fix crash in shouldOverride...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-android/pull/111 CB-7265: Fix crash in shouldOverrideUrlLoading on Android 4.0.3 Application built with Cordova 3.5.1 running on a device with Android 4.0.3 crashes when the webview is redirected to a custom url scheme. See https://issues.apache.org/jira/browse/CB-7265 More easily reproducible by adding the following line in JS: `window.location=custom://;` You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-android bektchiev/CB-7265-custom-url-scheme-crash Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/111.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #111 commit 28111dafa2b3e44d07f947c784c932b6e4ee2159 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-08-06T12:24:51Z CB-7265: Fix crash on Android 4.0.3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-mobile-spec pull request: Fix arguments order in contacts....
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/72#issuecomment-49305119 Closing this PR as it is no longer valid. The arguments order has been restored: https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js#L44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-mobile-spec pull request: Fix arguments order in contacts....
Github user mbektchiev closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-plugin-file/pull/58 CB-6571 Fix getParentForLocalURL to work correctly with directories with trailing '/' Fixes 2 failing unit tests in mobile spec. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-plugin-file bektchiev/fix-android-get-parent-with-trailing-slash Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 6990df01c98fa146d5f0ca3d125c63b103411d5e Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-06-30T15:21:08Z CB-6571 Fix getParentForLocalURL to work correctly with directories with trailing '/' Fixes 2 failing unit tests in mobile spec. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47554562 My first attempt didn't fix the second unit test -- 112. Now both must be fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47559238 No, I have all 131 tests passing. But I am not using the latest spec project -- mine is from [https://github.com/Icenium/cordova-mobile-spec/commits/fix-automatic-tests](https://github.com/Icenium/cordova-mobile-spec/commits/fix-automatic-tests). I am sorry but I have to go now and won't be available till next week. So I hope the fixes are good and get merged by then. :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-media-capture pull request: CB-6978 captureImage() ...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/20 CB-6978 captureImage() function fails in Android The reason is that the Intent which should write the file has no permissions in the application's cache directory by default. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-plugin-media-capture bektchiev/CB-6978-captureImage-fails Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media-capture/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit de6fb48138a8283618b907a94a86ef4e9c370a56 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-06-26T07:11:29Z CB-6978 captureImage() function fails in Android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-mobile-spec pull request: Fix arguments order in contacts....
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/72 Fix arguments order in contacts.find calls You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-mobile-spec bektchiev/fix-contacts-find-call Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit bcd3400cb23234bc80f36dd18874032bbd44b41c Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-06-23T12:12:26Z Fix arguments order in contacts.find calls --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-mobile-spec pull request: Fix failing battery tests. Add a...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/73 Fix failing battery tests. Add a dummy battery listener to avoid updates in the middle of a test case You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-mobile-spec bektchiev/fix-battery-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 commit 005641907754e04895135e502ef9fcb6f24d353f Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-06-23T13:25:29Z Fix failing battery tests. Add a dummy battery listener to avoid updates in the middle of a test case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6698 Fix 'android update lib-project'...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/36 CB-6698 Fix 'android update lib-project' command to work with paths containing spaces You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/fix-android-lib-paths-with-spaces Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit f48e9b5d633ef212969a57053b7af1abaa71a129 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-06-19T17:29:15Z CB-6698 Fix 'android update lib-project' command to work with paths containing spaces --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: Update properties-parser to version 0.2....
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/27 Update properties-parser to version 0.2.3 Version 0.2.2 had issues with duplicating the whole .properties file contents in some cases. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/upgrade-properties-parser Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit b498e256d55a8123d84d655ef51004946db0ad06 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-06-13T13:11:10Z Update properties-parser to version 0.2.3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6698 Automatically copy sub-libraries...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/29 CB-6698 Automatically copy sub-libraries to project's directory You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/auto-copy-android-libs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit bb3284ca8aa65fc85fde99210dcdf68c13dc785c Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-06-13T15:12:02Z Revert CB-6698 Resolve android framework relative to plugin_dir when custom=true This reverts commit 04588a42067a5ba0d303f4b69f99f44640c3b9e0. commit d049da772107ed6fd3501e458ccc63bc3e254594 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-06-13T16:00:36Z CB-6698 Automatically copy sub-libraries to project's directory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: Refer properties-parser package from NPM
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/24#issuecomment-45307627 I think that it's OK to not expect the end of lines. I am opening a new pull request with the fixed tests. I am sorry for breaking the build, I should've re-run the tests regardless of how small this change seemed to be. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: Fix android framework unit tests to no...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/25 Fix android framework unit tests to not expect end of line. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/refer-properties-parser-from-npm Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit 6539e41ea1d82ce234b18a97a7df85fabba0a15e Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-06-06T06:43:42Z Fix android framework unit tests to not expect end of line. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: Refer properties-parser package from NPM
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/24#issuecomment-45342579 :) Thank you, Mark. Then maybe the build script should be made to completely remove **node_modules** before running `npm install`. This should detect errors with changed npm module versions in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: Refer properties-parser package from NPM
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/24 Refer properties-parser package from NPM You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/refer-properties-parser-from-npm Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/24.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #24 commit 2a647edc31176d743cbcc1f6a1e74f3799500af7 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-06-04T14:11:12Z Refer properties-parser package from NPM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-docs pull request: Document CB-6344-and-CB-6698:
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-docs/pull/210 Document CB-6344-and-CB-6698: * after attribute for config-changes * framework element for Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-docs bektchiev/document-CB-6344-and-CB-6698 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/210.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #210 commit ac012d93d4d857ae850127f7f15c2cfb6a01c74b Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-06-04T15:22:03Z Document CB-6344-and-CB-6698: * after attribute for config-changes * framework element for Android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6698: Support library references for ...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/21#issuecomment-45105399 Thank you for merging and tipping me for the docs! I created a pull request for the docs: https://github.com/apache/cordova-docs/pull/210 and I am closing this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6698: Support library references for ...
Github user mbektchiev closed the pull request at: https://github.com/apache/cordova-lib/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6698: Support library references for ...
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/21#discussion_r13329193
--- Diff: cordova-lib/src/plugman/platforms/android.js ---
@@ -80,10 +84,115 @@ module.exports = {
},
framework: {
install:function(source_el, plugin_dir, project_dir, plugin_id) {
-events.emit('verbose', 'framework.install is not supported for
android');
+var src = source_el.attrib.src;
+var custom = source_el.attrib.custom;
+if (!src) throw new Error('src not specified in framework
element');
+
+events.emit('verbose', Installing Android library: + src);
+var parent = source_el.attrib.parent;
+var parentDir = parent ? path.resolve(project_dir, parent) :
project_dir;
+var subDir;
+if (custom) {
+subDir = path.resolve(project_dir, src);
+} else {
+var localProperties =
properties_parser.createEditor(path.resolve(project_dir, local.properties));
+subDir = path.resolve(localProperties.get(sdk.dir), src);
+}
+var projectConfig =
module.exports.parseProjectFile(project_dir);
+projectConfig.addSubProject(parentDir, subDir);
},
uninstall:function(source_el, project_dir, plugin_id) {
-events.emit('verbose', 'framework.uninstall is not supported
for android');
+var src = source_el.attrib.src;
+if (!src) throw new Error('src not specified in framework
element');
+
+events.emit('verbose', Uninstalling Android library: + src);
+var parent = source_el.attrib.parent;
+var parentDir = parent ? path.resolve(project_dir, parent) :
project_dir;
+var subDir = path.resolve(project_dir, src);
+var projectConfig =
module.exports.parseProjectFile(project_dir);
+projectConfig.removeSubProject(parentDir, subDir);
}
+},
+parseProjectFile: function(project_dir){
+if (!projectFileCache[project_dir]) {
+projectFileCache[project_dir] = {
--- End diff --
I totally agree! I extracted it in a separate js.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6698: Support library references for ...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/21 CB-6698: Support library references for Android via the framework tag The framework tag can be contain the following attributes: * **src** - (**required**) relative path to the directory containing the referenced library project. * **custom** - (optional) specifies how to treat **src**. If **true** it is a relative path from the application project's directory, otherwise -- the Android SDK directory. * **parent** - (optional) relative path to the directory containing the project to which to add the reference. The default is the application project. Example: A plugin that installs a library (**FeedbackLib**) which refers another library from the Android SDK (**appcompat**) ```xml source-file src=src/android/FeedbackLib target-dir=./ / framework src=FeedbackLib custom=true / framework src=extras/android/support/v7/appcompat parent=FeedbackLib / ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib bektchiev/framework-tag-for-android Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit 0227d7bb7831ad1dfe0c6531e319bf8106256a03 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-05-27T11:53:19Z CB-6698: Support library references for Android via the framework tag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6711: Use parseProjectFile when worki...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/15#issuecomment-44412361 Ping. Anyone willing to review? :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6711: Use parseProjectFile when worki...
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/15#discussion_r13134717
--- Diff: cordova-lib/src/plugman/util/config-changes.js ---
@@ -510,8 +509,7 @@ function ConfigFile_load() {
self.data = xml_helpers.parseElementtreeSync(filepath);
} else if (ext == '.pbxproj') {
self.type = 'pbxproj';
-self.data = xcode.project(filepath);
-self.data.parseSync();
+self.data = platforms.ios.parseProjectFile(self.project_dir).xcode;
--- End diff --
Yes, the reason is that parseProjectFile() caches the parsed project and
changes made without it get overwritten. This is observed when the --plugin
option is specified more than once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6711: Use parseProjectFile when worki...
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/15#discussion_r13135048
--- Diff: cordova-lib/src/plugman/util/config-changes.js ---
@@ -510,8 +509,7 @@ function ConfigFile_load() {
self.data = xml_helpers.parseElementtreeSync(filepath);
} else if (ext == '.pbxproj') {
self.type = 'pbxproj';
-self.data = xcode.project(filepath);
-self.data.parseSync();
+self.data = platforms.ios.parseProjectFile(self.project_dir).xcode;
--- End diff --
`parseProjectFile` is called when processing the action-stack, so even if
we skip the call here, it will eventually happen. What was the purpose of this
optimization? I think that it may only have effect on the unit tests execution
time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: Fix spy to return a default platform JSO...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-cli/pull/157 Fix spy to return a default platform JSON instead of an empty object Fixes broken tests because of the refactoring in plugman regarding CB-6344 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-cli fix-unit-tests-for-CB-6344 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #157 commit 766357377ba6b7c4c316a539365c0baffc3a3993 Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2014-04-01T14:23:11Z Fix spy to return a default platform JSON instead of an empty object Fixes broken tests because of the refactoring in plugman regarding CB-6344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugman pull request: CB-6344: Specify after which sibling...
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-plugman/pull/69
CB-6344: Specify after which sibling to add config-changes in plugin.xml
* refactor munges - now they are in a more extensible form
(munge.files[file].parents[parent][index] { xml, count, after })
* add an after parameter to graftXML which contains a list of possible
predecessor elements separated by semicolon
* fix unit tests and add new ones
https://github.com/apache/cordova-cli/pull/157 fixes the tests which failed
the previous time these changes got merged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-plugman
config-file-after-option
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugman/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
commit 6b7a9e043d2091436aafce84d60ea753486d
Author: Martin Bektchiev martin.bektch...@telerik.com
Date: 2014-03-26T08:15:39Z
CB-6344: Specify after which sibling to add config-changes in plugin.xml
* refactor munges - now they are in a more extensible form
(munge.files[file].parents[parent][index] { xml, count, after })
* add an after parameter to graftXML which contains a list of possible
predecessor elements separated by semicolon
* fix unit tests and add new ones
github: close #68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugman pull request: CB-6344: Specify after which sibling...
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-plugman/pull/68
CB-6344: Specify after which sibling to add config-changes in plugin.xml
* refactor munges - now they are in a more extensible form
(`munge.files[file].parents[parent][index] { xml, count, after }`)
* add an after parameter to graftXML which contains a list of possible
predecessor elements separated by semicolon
* fix unit tests and add new ones
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-plugman
config-file-after-option
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugman/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
commit 0616f1fefd24cad93715f16b6cabb94d3356e0cb
Author: Martin Bektchiev martin.bektch...@telerik.com
Date: 2014-03-26T08:15:39Z
CB-6344: Specify after which sibling to add config-changes in plugin.xml
* refactor munges - now they are in a more extensible form
(munge.files[file].parents[parent][index] { xml, count, after })
* add an after parameter to graftXML which contains a list of possible
predecessor elements separated by semicolon
* fix unit tests and add new ones
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
