[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/386 I believe in you, you can do it!  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user audreyso commented on the issue: https://github.com/apache/cordova-android/pull/386 I think I have permission, but haven't ever done it before! @filmaj --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/386 Do you not have permissions to merge, or do you have your hands full with other work? Happy to merge this in for you but if it's a permission issue please let me know so that I can fix that :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user audreyso commented on the issue: https://github.com/apache/cordova-android/pull/386 I rebased this morning! @filmaj @infil00p If anyone has time to merge it in, that would be great :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/386 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/386 Ahh! That's it! Very nice. Works flawlessy on my end!  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user audreyso commented on the issue: https://github.com/apache/cordova-android/pull/386 Ohh thank you for that clarification @filmaj . So I did the following: 1. Left the project root level eslint file to keep--> root: true 2. Removed eslint config files from spec/e2e & spec/unit and just placed it in spec/.eslintrc.yml 3. Took out root:true from spec/.eslintrc.yml and just included ONE rule env: jasmine: true --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/386 I think one more tweak would be good: So by putting `root:true` into the spec/**/ directories' eslintrc files, when eslint searches up the directory tree to find an eslintrc file, once it finds the file, it'll stop searching further. eslint, however, supports "cascading" or combining multiple config files into one. We can leverage this to define one project-level eslintrc file in the root of the project dir, but then also have additional eslintrc files in project subdirectories if there are specific rules we want to apply per-directory. So I think what we want to do is: - have the project-root-directory-level eslintrc file specify `root:true` - any subdirectory-level eslintrc files _not_ to specify `root:true` - this would then cause eslint to apply the rules from subdirectories, but keep going to search for further rules, and in our case, it would keep going until it hit the project-root-directory-level eslintrc, apply those rules, and because that one has `root:true`, stop there. - additionally, in this repo, both the spec/e2e and spec/unit directories need just a single additional rule: `env: jasmine: true`. So we could actually put a single eslintrc file under `/spec/.eslintrc.yml` and have it contain only the one `env: jasmine: true` rule. Since root is not set to true for the `spec/.eslintrc.yml` file, it'll go up one more directory and apply the project-level eslintrc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user audreyso commented on the issue: https://github.com/apache/cordova-android/pull/386 Thanks! @filmaj That makes sense and seems easier than having to add in /*eslint-env: jasmine*/ in every file. I made some changes and added .eslint configs where they are needed. Let me know if you have any other suggestions or feedback! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/386 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=h1) Report > Merging [#386](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/3a6e898b12eac31dfc16a4c526dfba8fab158723?src=pr=desc) will **increase** coverage by `2.18%`. > The diff coverage is `51.13%`. [](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree) ```diff @@Coverage Diff@@ ## master#386 +/- ## = + Coverage 39.52% 41.7% +2.18% = Files 16 16 Lines15511489 -62 Branches 277 278 +1 = + Hits 613 621 +8 + Misses938 868 -70 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree) | Coverage Π| | |---|---|---| | [bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==) | `37.5% <0%> (+4.16%)` | :arrow_up: | | [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `15.38% <0%> (ø)` | :arrow_up: | | [bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz) | `94.73% <100%> (ø)` | :arrow_up: | | [bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=) | `35.13% <100%> (-0.87%)` | :arrow_down: | | [...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz) | `20.43% <20.93%> (+0.43%)` | :arrow_up: | | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `22.44% <26.31%> (+4.26%)` | :arrow_up: | | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `13.43% <31.57%> (+3.08%)` | :arrow_up: | | [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `34.14% <33.33%> (+3.03%)` | :arrow_up: | | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `26.98% <37.5%> (+9.07%)` | :arrow_up: | | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `40.81% <41.93%> (+2.47%)` | :arrow_up: | | ... and [6 more](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=footer). Last update [3a6e898...875ea35](https://codecov.io/gh/apache/cordova-android/pull/386?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
