Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
@reidab @jcesarmobile filed https://issues.apache.org/jira/browse/CB-12457
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
@reidab Can you create a new issue for that on issues.cordova.io?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user reidab commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
Following this change I'm seeing my IAB windows overlapping the status bar
in all presentation modes. Dropping the `windowLevel` of the `tmpWindow` to
`UIWindowLevelNormal` seems
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
Merging and lightly testing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nerdmed commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
@shazron @manucorporat, i know its christmas time but guys lets forward.
This i hanging around long enough and people are working with forks to run in
production, this really
Github user Glenndejaeger commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
Any idea when this PR will be merged into the official plugin's code base?
Don't want to use a forked version for a long time
---
If your project is set up for it, you
Github user jlchereau commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
I have experienced the defect described here with oAuth flows but
considering [Google deprecation of webviews for oAuth
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
I agree with @jonathanli2, as this way is a bit hackish, I think it's
better doing it were it's strictly necessary to fix the bug
---
If your project is set up for it,
Github user jonathanli2 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
Would it be better to add an if condition check, and only apply the change
if WKWebView is used? so that the change will not affect UIWebView's old
behavior by any chance.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dylanvdmerwe commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
Any updates with this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nerdmed commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
@shazron @manucorporat any progress here? Would be great to see this PR
getting merged!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
Cordova CI Build has completed successfully.
**Commit** -
Github user manucorporat commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
@shazron done!
renamed to tmpWindow and tmpController
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ephemer commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
@manucorporat the term is reference counted and deinited / cleaned up.
"Garbage Collection" sounds like heresy to my ears, but the principles are
somewhat similar, so you're
Github user manucorporat commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
@ephemer sure! I can rename it! it was just a funny name (bad clean code
practice haha)
> does the window clean itself up if its rootViewController dismisses
itself, or
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dotNetkow commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
Developer here that originally requested this change. To lend more credence
to @manucorporat's changes: I tested them on an iPhone 6 running iOS 10 - works
now as expected.
18 matches
Mail list logo
