Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/268#discussion_r24805472
--- Diff: app/addons/databases/tests/nightwatch/createsView.js ---
@@ -1,65 +0,0 @@
-// Licensed under the Apache License, Version 2.0
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/273
Highlight User managment section
Highlights user managment section when it is active
Fixes COUCHDB-2584
You can merge this pull request into a Git repository by running:
$ git
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-74504792
@Poltergeist there is a slight bug. When I try delete a database the
database name doesn't appear in the modal. See screenshot. I've added a comment
on how
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#discussion_r24748949
--- Diff: app/addons/documents/views.js ---
@@ -145,9 +145,16 @@ function (app, FauxtonAPI, Components, Documents,
template: addons
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/272
View name resets
When creating a new view if a user changed the reduce editor settings the
view name would reset
back to original
This fixes COUCHDB-2582
You can merge
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24734807
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -0,0 +1,238 @@
+// Licensed under the Apache License, Version 2.0
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-74468883
@benkeen making good progress. As I mentioned in the previous comment, the
way the filter is added needs to be a controlled component.
---
If your project
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24657816
--- Diff: app/addons/documents/changes/changes-header.react.jsx ---
@@ -0,0 +1,236 @@
+// Licensed under the Apache License, Version 2.0
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24657971
--- Diff: app/addons/documents/changes/changes-header.react.jsx ---
@@ -0,0 +1,236 @@
+// Licensed under the Apache License, Version 2.0
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24658179
--- Diff: app/addons/documents/changes/changes-header.react.jsx ---
@@ -0,0 +1,236 @@
+// Licensed under the Apache License, Version 2.0
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24658378
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -20,6 +20,7 @@ define([
function(FauxtonAPI, React, Stores, Actions) {
var
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24658328
--- Diff: app/addons/documents/tests/changesHeader.componentsSpec.react.jsx
---
@@ -0,0 +1,138 @@
+// Licensed under the Apache License
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24658263
--- Diff: app/addons/documents/changes/stores.js ---
@@ -0,0 +1,73 @@
+// Licensed under the Apache License, Version 2.0 (the License); you
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24658385
--- Diff: app/addons/fauxton/stores.js ---
@@ -185,6 +185,7 @@ function(app, FauxtonAPI, ActionTypes) {
Stores.navBarStore = new
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/258#issuecomment-73920466
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/263#issuecomment-73850525
I'm not sure about this. This is where we check the [custom
beforeUnloads](https://github.com/apache/couchdb-fauxton/blob/master/app/core/router.js#L26-L47
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#discussion_r24480945
--- Diff: app/addons/cors/components.react.jsx ---
@@ -232,7 +251,7 @@ define([
enableCorsChange: function (event
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#issuecomment-73851522
Looking good @michellephung. Can you write a test for the page does not
return an empty origin, if specific origins is set, but there are no domains
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/252#issuecomment-73685878
This is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/300#issuecomment-73697007
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-73691017
@Poltergeist @robertkowalski this looks great. Could you add a few tests
for this.
---
If your project is set up for it, you can reply to this email
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/258#issuecomment-73691181
@michellephung this looks good but the tests are still failing. We cannot
merge this in until the tests are passing.
---
If your project is set up
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/257
Fix new doc page
Change new to New Document
Fix '' to use previous link
This fixes COUCHDB-2564
You can merge this pull request into a Git repository by running
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/256#issuecomment-72450801
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/246#issuecomment-72454489
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/256
Fix changes keeping filter in memory
This fixes COUCHDB-2563
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/255#issuecomment-72440455
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/257#issuecomment-72469431
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/254#issuecomment-72416437
+1 nice work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-72416166
@ocelotpotpie could you close this ticket. CORS is merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/250#issuecomment-72416142
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/250#issuecomment-72000595
Thanks @michellephung and @robertkowalski I've made some fixes. Could you
take another look.
---
If your project is set up for it, you can reply
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/252
Remove old modules
Neither of these modules are used any more. Time to remove them
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/242#discussion_r23686237
--- Diff: app/addons/documents/header/header.react.jsx ---
@@ -0,0 +1,245 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/235
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/235#issuecomment-71810426
Merged :rocket:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/242#issuecomment-71859635
This is looking good. Nice tests. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/250#issuecomment-71652467
@robertkowalski you have to enter a domain and press 'Save'.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/235#issuecomment-71605269
thanks @benkeen and @michellephung. I've made some of those fixes.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/250
CORS configuration
CORS configuration in the config section. I've kept it to the simplest
settings required for a user to enable and use CORS.
You can merge this pull request
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/250#issuecomment-71643477
Thanks @robertkowalski for the review. I've fixed all the issues you have
spotted.
---
If your project is set up for it, you can reply to this email
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/235#issuecomment-71430075
@robertkowalski @benkeen @michellephung this has been rebased. I would
appreciate it if you could take another look.
---
If your project is set up
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/242#discussion_r23518669
--- Diff: app/addons/documents/header/header.actions.js ---
@@ -0,0 +1,62 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/242#discussion_r23518829
--- Diff: app/addons/documents/header/header.react.jsx ---
@@ -0,0 +1,239 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-71431491
This is not needed anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/242#issuecomment-71433398
@robertkowalski @seanbarclay do we need both Select All and Deselect All
buttons displayed at all times? Wouldn't it make sense that initially the user
only
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/244#issuecomment-71434816
+1 works for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/241#issuecomment-71187810
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/242#discussion_r23378339
--- Diff: app/addons/documents/header/header.actions.js ---
@@ -0,0 +1,62 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/245#issuecomment-70987690
This also fixes https://issues.apache.org/jira/browse/COUCHDB-2555
---
If your project is set up for it, you can reply to this email and have your
reply
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/242#issuecomment-71030009
@robertkowalski this is coming along nicely. The code is looking excellent
---
If your project is set up for it, you can reply to this email and have your
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb/pull/298
New Licenses used in Fauxton
Licenses for:
React.js
Flux.js
es5-shim.js
Also fix the moment.js path
You can merge this pull request into a Git repository by running
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70617627
Thanks for reviewing. This is merged. Woo first React work in :+1:
---
If your project is set up for it, you can reply to this email and have your
reply
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/238#discussion_r23215119
--- Diff: assets/less/fauxton.less ---
@@ -185,15 +185,32 @@ table.databases {
}
}
-.notification-icon {
- padding
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/238#issuecomment-70646304
+1 nice clean up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/238#issuecomment-70637928
This looks good. I've added a comment on less style. But otherwise I'm +1
---
If your project is set up for it, you can reply to this email and have your
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/239#issuecomment-70685936
+1. Could we also do a `grunt release` in travis so we know that doesn't
fail.
---
If your project is set up for it, you can reply to this email and have
GitHub user garrensmith reopened a pull request:
https://github.com/apache/couchdb-fauxton/pull/233
React building blocks and navbar
I've decided to break up #216 into two. This is the first one. It is the
main react dependancies along with the main navigation bar done in React.js
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70496317
+1 working nicely
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/236#issuecomment-70496410
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/230#issuecomment-70467796
+1 nice work @benkeen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/233
React building blocks and navbar
I've decided to break up #216 into two. This is the first one. It is the
main react dependancies along with the main navigation bar done in React.js
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70481974
I've getting a 'Uncaught TypeError: Cannot read property 'preventDefault'
of undefined' in the console. This happens if I click on the 'x' then wait 1
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70482380
@robertkowalski I've fixed the './base' path and replaced with '. I
haven't added a separate commit for the whitespace this time as I want to
reduce
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/232#issuecomment-70468265
@sebastianrothbucher this looks good to me. +1, you can merge it. Thanks
for the pull request
---
If your project is set up for it, you can reply
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/231#issuecomment-70467188
@benkeen this doesn't quite work. If I click on the permissions page, all
the design docs listed in the sidebar disappear.
---
If your project is set up
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/235
React index editor
This is part two of #216. This is the index editor. This required #233 to
land first.
You can merge this pull request into a Git repository by running:
$ git
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70481697
I've broken this into two smaller pull requests for easier merging. They
are #233 and #235
---
If your project is set up for it, you can reply
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70361832
thanks @robertkowalski, I've removed the footer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70087509
@robertkowalski @benkeen I've fixed the all the issues you both have
mentioned. The one thing is I cannot get the animation for the final part any
smoother
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22848698
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -0,0 +1,170 @@
+// Licensed under the Apache License, Version 2.0 (the License); you
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69721484
@robertkowalski, @benkeen I've fixed all the issues you have mentioned and
rebased again master.
---
If your project is set up for it, you can reply
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22875319
--- Diff: app/addons/documents/actions.js ---
@@ -0,0 +1,164 @@
+// Licensed under the Apache License, Version 2.0 (the License); you may
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69776649
@robertkowalski I've pushed a new commit with all your feedback. The only
thing I haven't done is convert all the expect's to asserts.
---
If your project
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/207#issuecomment-69600409
+1 looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/207#discussion_r22802312
--- Diff: app/addons/compaction/routes.js ---
@@ -17,29 +17,25 @@ define([
// Modules
addons/compaction/views
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/207#discussion_r22796555
--- Diff: app/addons/documents/shared-resources.js ---
@@ -0,0 +1,317 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/222#issuecomment-69305757
@benkeen this is great. But can you add the moment.js licensing to couchdb
in LICENSE and NOTICE.
---
If your project is set up for it, you can reply
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/216
Adding React into Fauxton
This is the building blocks for using React in Fauxton. The index editor
and the main side header link are now done in React with a flux pattern.
You can
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22652275
--- Diff: app/core/store.js ---
@@ -0,0 +1,34 @@
+// Licensed under the Apache License, Version 2.0 (the License); you may
not
+// use
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/218#issuecomment-69200054
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/207#discussion_r22637683
--- Diff: app/addons/documents/shared-resources.js ---
@@ -0,0 +1,317 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/210#issuecomment-69143218
+1 That is a nice solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/213#issuecomment-68859918
merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/210#issuecomment-68832058
@benkeen this is a nice idea. The code needs some neatening up. Rather
create an object that hides away the fact that you using localStorage to keep
state
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/213
remove sidebar class and set sidebar width in #sidebar-content
Without this fix the sidebar goes across into the main section like this:
