Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/180#issuecomment-38259646
This has been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb/pull/180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/137#issuecomment-38260382
Refactoring the ViewEditor is a great idea, unfortunately @BigBlueHat this
PR is not ready to be merged into master. Two things need to be done to make it
usable
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/180#issuecomment-38142527
The PR is now updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/180#issuecomment-38151931
I've added some keys validation. It now checks the keys and determines if
it is an array or not. It also has an error message next to the keys if the
input
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/180#issuecomment-38157022
Could you give me an example of valid Json. I don't quite understand what
you are inputting.
All misspelling thanks to my iPhone
On 20 Mar 2014
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/180#issuecomment-38031755
+1 I'm happy with this. @kxepal what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/167#issuecomment-38032551
What are the steps to replicate this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/180#discussion_r10650864
--- Diff: src/fauxton/app/addons/documents/views.js ---
@@ -1090,20 +1117,48 @@ function(app, FauxtonAPI, Components, Documents,
Databases, pouchdb
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/180#discussion_r10650925
--- Diff: src/fauxton/app/addons/documents/views.js ---
@@ -1090,20 +1117,48 @@ function(app, FauxtonAPI, Components, Documents,
Databases, pouchdb
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/180#discussion_r10650943
--- Diff: src/fauxton/app/addons/documents/views.js ---
@@ -1178,6 +1233,17 @@ function(app, FauxtonAPI, Components, Documents,
Databases, pouchdb
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/182#issuecomment-37811322
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb/pull/177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/177#issuecomment-37648292
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/178#discussion_r10609856
--- Diff: src/fauxton/app/addons/config/views.js ---
@@ -111,34 +163,58 @@ function (app, FauxtonAPI, Config
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/179#issuecomment-37659787
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/137#discussion_r10613508
--- Diff: src/fauxton/app/addons/documents/views.js ---
@@ -1324,9 +1353,13 @@ function(app, FauxtonAPI, Components, Documents,
Databases, pouchdb
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/137#issuecomment-37666090
hey @BigBlueHat, so far looking good. The only issue I'm getting is that
you can save a coffeescript view to a design doc thats javascript. I think we
have to do
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/137#discussion_r10615562
--- Diff: src/fauxton/app/addons/config/resources.js ---
@@ -63,6 +63,7 @@ function (app, FauxtonAPI) {
parse: function (resp
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/137#discussion_r10615649
--- Diff: src/fauxton/app/addons/documents/views.js ---
@@ -1324,9 +1353,13 @@ function(app, FauxtonAPI, Components, Documents,
Databases, pouchdb
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/137#discussion_r10615703
--- Diff: src/fauxton/app/addons/documents/views.js ---
@@ -1598,6 +1633,11 @@ function(app, FauxtonAPI, Components, Documents,
Databases, pouchdb
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb/pull/180
Improved Query Options
Improved query options view. With all the query options broken up and
grouped more appropriately.
You can merge this pull request into a Git repository by running
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/181#issuecomment-37690064
merged, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb/pull/182
2116 remove cache
Remove Caching from Fauxton
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb 2116-remove-cache
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/182#issuecomment-37709298
The pr is fine it's just that the github mirror had not updated and was not
in sync with couchdb master when I created the PR.
All misspelling thanks to my
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb/pull/177
Fauxton new view creation fix
Fixes issue COUCHDB-2201
Creating a view fails because of of two issues:
* design doc info is created and rendered
* it expects the routeObject
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/177#discussion_r10571619
--- Diff: src/fauxton/app/addons/documents/routes.js ---
@@ -300,6 +292,24 @@ function(app, FauxtonAPI, Documents, Databases
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/169#issuecomment-37224244
I'm +1 on this. It makes sense to return the promise so that the user can
manage the request.
---
If your project is set up for it, you can reply to this email
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/171#issuecomment-37227431
this works for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb/pull/162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/153#issuecomment-37106140
@ziggythehamster as this is just a mirror of the Couchdb repo. We cannot
close this pull request even though it has been merged. Could you close this
pull request
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/168#issuecomment-37028505
Thanks @willholley. merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/167#issuecomment-36906752
+1, thanks for the contribution. I think @deathbearbrown can squash when
merging.
---
If your project is set up for it, you can reply to this email and have your
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/167#discussion_r10351608
--- Diff: src/fauxton/app/addons/auth/resources.js ---
@@ -20,6 +20,18 @@ function (app, FauxtonAPI, CouchdbSession) {
var Auth = new
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36604411
@kxepal Can you explain what you mean by the 50 and 100 limits not working?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/161#issuecomment-36491345
Thanks @willholley, I've merged this. You can close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb/pull/162
New pagination
This is a much pagination for Fauxton.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb paginate-api-options
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10244737
--- Diff: src/fauxton/app/addons/documents/resources.js ---
@@ -274,20 +338,31 @@ function(app, FauxtonAPI) {
Documents.AllDocs
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10244755
--- Diff: src/fauxton/app/addons/documents/routes.js ---
@@ -170,9 +168,11 @@ function(app, FauxtonAPI, Documents, Databases
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10245597
--- Diff: src/fauxton/test/mocha/chai.js ---
@@ -27,10 +27,14 @@ function require(path, parent, orig) {
// perform real require()
--- End diff
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/153#issuecomment-35476190
This looks fine to me. My only concern would be is that licensed correctly?
What is the correct way of licensing content from the Mozilla Developer Network
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/153#issuecomment-35481965
Thats actually a better idea and should hopefully prevent any other issues.
@ziggythehamster could you change this PR to rather include the es5-shim. You
will also
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/153#issuecomment-35508275
Great. Looking forward to it.
On 19 Feb 2014, at 5:07 PM, Keith Gable notificati...@github.com wrote:
@garrensmith - I like the ES5 Shim much
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/153#issuecomment-35518341
@BigBlueHat I understand your frustration. But we need to find a balance
between merging quickly and making sure they the right patch for Couchdb
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/153#issuecomment-35520319
Ok I'm happy with the $.indexOf fix. It is the easiest fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb/pull/136
Fauxton file reorder
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb fauxton-file-reorder
Alternatively you can review
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb/pull/39
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb/pull/46
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb/pull/46
move addon templates into own file and better addon file defaults
Exported the addon templates to their own files and made the addon file
defaults a little more practical.
You can merge
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb/pull/39
logs can be sent as json
If you request the couchdb logs (http://127.0.0.1:5984/_log). I want the
option of getting them returned in json format. This makes it much easier to
work
801 - 852 of 852 matches
Mail list logo
