+1
MacOS 10.15.3 (ulimit -n 1)
Checksums and sig match
make check passes cleanly
> On 13 Feb 2020, at 17:55, Jan Lehnardt wrote:
>
>>
>> On 13. Feb 2020, at 17:56, Joan Touzet wrote:
>>
>> With this vote, we are now at 3 +1 PMC votes - a minimum for releasing.
>>
>> Everyone - please
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/460#discussion_r106920376
--- Diff: .gitignore ---
@@ -4,7 +4,6 @@ config.erl
install.mk
rel/*.config
rel/dev*
-rel/snap*
--- End diff --
ooh I
Github user rnewson closed the pull request at:
https://github.com/apache/couchdb/pull/460
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Author: rnewson
Date: Thu Dec 8 10:30:39 2016
New Revision: 17318
Log:
add 2.0.0.1 windows binary/sig/checksums
Added:
release/couchdb/binary/win/2.0.0.1/
release/couchdb/binary/win/2.0.0.1/apache-couchdb-2.0.0.1.msi (with props)
release/couchdb/binary/win/2.0.0.1/apache-couchdb
Repository: couchdb-admin
Updated Branches:
refs/heads/master c641ad202 -> 01ce44893
fix typo
Project: http://git-wip-us.apache.org/repos/asf/couchdb-admin/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-admin/commit/01ce4489
Tree:
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/1#discussion_r48264818
--- Diff: readme.markdown ---
@@ -3,44 +3,80 @@ CouchDB CI Setup
Mission statement: Create a new continuous integration infrastructure
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/1#discussion_r48261940
--- Diff: ansible/roles/ubuntu-worker/tasks/dependencies.yml ---
@@ -0,0 +1,59 @@
+- name: import the Erlang Solutions key into apt
+ apt_key
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/1#discussion_r48264677
--- Diff: readme.markdown ---
@@ -3,44 +3,80 @@ CouchDB CI Setup
Mission statement: Create a new continuous integration infrastructure
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/1#discussion_r48265648
--- Diff: readme.markdown ---
@@ -3,44 +3,80 @@ CouchDB CI Setup
Mission statement: Create a new continuous integration infrastructure
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-log-lager/pull/1#issuecomment-146475703
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/2#issuecomment-125987775
+1 after squash.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-couch-epi/pull/5
Restore R14 compatibility
CouchDB 2.0 will be compatible with R14. Support for R14 to be dropped
after.
closes COUCHDB-2755
You can merge this pull request into a Git
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/4#issuecomment-122035479
+1 after squash.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-epi/pull/4#discussion_r34583538
--- Diff: src/couch_epi_data.erl ---
@@ -88,7 +88,8 @@ handle_call(stop, _From, State) -
handle_call(_Request, _From, State) -
{reply
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/3#issuecomment-120914932
I'll talk with @iilyak. I don't know why, or much like, the use of tuples
for single values (`{epi_key, Key}` and `{modules, [Modules]}`.
---
If your project
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-couch-epi/pull/3
Fix function_clause in childspec
Make couch_epi_functions:childspec's result match expectations of
couch_epi_functions:start_link function.
You can merge this pull request into a Git
Repository: couchdb-couch-epi
Updated Branches:
refs/heads/master baa9a3556 - bb5d37bbe
get version from git like other repos
Project: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/commit/bb5d37bb
Tree:
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/1#issuecomment-115187113
@iilyak merged to asf, congrats and great work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Add couch_epi_data
Project: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/commit/59bbd8ee
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/tree/59bbd8ee
Diff:
Update documentation
Project: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/commit/2530af38
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/tree/2530af38
Diff:
Repository: couchdb-couch-epi
Updated Branches:
refs/heads/master cf2e463b2 - baa9a3556
http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/blob/32ba6e79/test/fixtures/app_data1.cfg
--
diff --git
Initial version
Add `ignore_providers` option
Rename `hash(FilePath)` into `hashof_file(FilePath)`
Use monitor to unsubscribe when subscriber die
Rename couch_epi:all into couch_epi:dump
Remove modules from dispatch on termination
Add all/any convinence funs to couch_epi
Document
Use code_change to trigger generation of a module
Previously we did periodic check of hashes for every provider module.
We switch to code_change use. Which would be called if specify modules
argument in child spec of the supervisor from where we register our
provider module.
We rely on this bit
Rewrite test suite to test new functionality
Project: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/commit/baa9a355
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/tree/baa9a355
Diff:
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/1#issuecomment-115023322
can you squash? not necessarily to one but to whatever makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply
Repository: couchdb-couch-epi
Updated Branches:
refs/heads/master [created] cf2e463b2
Add .gitignore
Project: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-couch-epi/commit/cf2e463b
Tree:
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-config/pull/3#issuecomment-110678055
I'd rather we didn't waste time enhancing this to work for unicode, which
leaves two choices;
1) abandon this work
2) restore the original string
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-config/pull/3#discussion_r31925176
--- Diff: src/config.erl ---
@@ -177,9 +182,19 @@ delete(Section, Key, Reason) -
delete(Sec, Key, Persist, Reason) when is_binary(Sec
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-config/pull/3#discussion_r31727769
--- Diff: src/config.erl ---
@@ -177,9 +182,19 @@ delete(Section, Key, Reason) -
delete(Sec, Key, Persist, Reason) when is_binary(Sec
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/20#issuecomment-108923480
+1 after proplist fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/11#issuecomment-108030339
I'm +1 after fixing the owner/2 issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31550558
--- Diff: src/couch_replicator_manager.erl ---
@@ -451,7 +487,14 @@ maybe_start_replication(State, DbName, DocId, RepDoc
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31550497
--- Diff: src/couch_replicator_api_wrap.erl ---
@@ -83,9 +83,16 @@ db_open(#httpdb{} = Db1, _Options, Create) -
ok
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31570119
--- Diff: src/couch_replicator_api_wrap.erl ---
@@ -83,9 +83,16 @@ db_open(#httpdb{} = Db1, _Options, Create) -
ok
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31549393
--- Diff: src/couch_replicator_manager.erl ---
@@ -403,13 +442,10 @@ process_update(State, DbName, {Change}) -
end
end
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31549334
--- Diff: src/couch_replicator_manager.erl ---
@@ -403,13 +442,10 @@ process_update(State, DbName, {Change}) -
end
end
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31550134
--- Diff: src/couch_replicator_manager.erl ---
@@ -403,13 +442,10 @@ process_update(State, DbName, {Change}) -
end
end
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/54#issuecomment-107393470
+1 after variable name changed for consistency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/54#discussion_r31414907
--- Diff: src/couch_db.erl ---
@@ -332,8 +332,13 @@ get_db_info(Db) -
{ok, FileSize} = couch_file:bytes(Fd),
{ok, DbReduction
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/8#issuecomment-107075786
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/14#issuecomment-107075633
+1 (cc @nolanlawson).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/49#issuecomment-102085805
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/34#discussion_r29371280
--- Diff: src/chttpd.erl ---
@@ -535,7 +535,15 @@ json_body_obj(Httpd) -
doc_etag(#doc{revs={Start, [DiskRev
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/28#discussion_r26745607
--- Diff: src/chttpd_db.erl ---
@@ -93,7 +93,7 @@ handle_changes_req1(#httpd{}=Req, Db) -
couch_stats:decrement_counter([couchdb
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/26#issuecomment-74664640
added without tests. :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/33#issuecomment-71436687
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rnewson closed the pull request at:
https://github.com/apache/couchdb-couch-replicator/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/3#issuecomment-69914867
oh, this happened ages ago in 363093f480fb5df6e337c9de308f0be9b31da783,
derp.
---
If your project is set up for it, you can reply to this email
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/3#issuecomment-69912288
+1, I'll try to get to this today unless you beat me to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/225#issuecomment-69602280
Could you explain what the change is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/27#issuecomment-68520978
I'm confused. Why rename the directory if you're going to make the delete
async? It seems the entire fix is just to spawn a process to do the cleanup
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/27#discussion_r22408655
--- Diff: src/couch_file.erl ---
@@ -257,13 +257,43 @@ nuke_dir(RootDelDir, Dir) -
init_delete_dir(RootDir) -
Dir = filename:join
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/27#discussion_r22416091
--- Diff: src/couch_file.erl ---
@@ -257,13 +257,43 @@ nuke_dir(RootDelDir, Dir) -
init_delete_dir(RootDir) -
Dir = filename:join
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/292#issuecomment-68483544
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/24#issuecomment-68452362
I don't think deduping on MD5 is sufficiently robust for a database.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/24#issuecomment-68453103
Use the md5 digest as a strong hint that we've seen this content before,
but verify for byte identity (read both attachments, compare exhaustively), and
obviously
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-couch-replicator/pull/5
Retrieve headers case-insensitively
COUCHDB-1637
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb-couch-replicator
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/18#issuecomment-67546111
any change to the http layer unfortunately has to be done twice to be
acceptable for inclusion. once here, and again in
`https://github.com/apache/couchdb-chttpd
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/6#discussion_r21738688
--- Diff: src/fabric_doc_update.erl ---
@@ -97,6 +98,28 @@ handle_message({not_found, no_db_file} = X, Worker,
Acc0) -
handle_message({bad_request
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/6#issuecomment-66760612
+1, pulling this up seems the obvious way to avoid the conflicts/branching
from doing it at the shards. Don't we also want to inhibit these handlers
firing again
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/21#discussion_r21388010
--- Diff: src/couch_auth_cache.erl ---
@@ -42,12 +43,18 @@
-spec get_user_creds(UserName::string() | binary()) -
-Credentials
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/21#issuecomment-65829472
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21099269
--- Diff: test/chttpd_handler_reload_test.erl ---
@@ -0,0 +1,111 @@
+% Licensed under the Apache License, Version 2.0 (the License); you
may
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/284#issuecomment-64892750
This is reverting commit
https://github.com/apache/couchdb/commit/ecb23f5af2d0f7d2277265dcacf6c0c49d0d1f16
which deliberately switched this behavior
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/284#issuecomment-64907484
I'm all for improving this, I filed COUCHDB-1175 myself because neither the
behavior before or after the original change here satisfied every use. That
ticket, as you
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/284#issuecomment-64911732
That's the trick. If they're equal (which they usually are), then
preferring html over json breaks jquery (and other libs I guess) and
preferring json over html breaks
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/284#issuecomment-64911996
I proposed this semantic on the ticket;
if Accept line is *exactly* application/json, then send application/json,
otherwise send text/html.
That puts
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/278#discussion_r20993032
--- Diff: src/couch_replicator/src/couch_replicator_api_wrap.hrl ---
@@ -24,7 +24,10 @@
retries = 10,
wait = 250, % milliseconds
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-documentation/pull/6#issuecomment-64387955
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/9#issuecomment-63777185
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-documentation/pull/6#issuecomment-63799529
This is not the only place we do this, I think a note here is not
sufficient.
---
If your project is set up for it, you can reply to this email and have
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/284#issuecomment-63241296
hrm, but this code was ported to chttpd from couch_httpd originally...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/269#issuecomment-63038803
Great change, I particularly like that we have another implementation of
PBKDF2; it helps confirm we're adhering to the standard and not just the
implementation inside
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/278#issuecomment-62772993
an ETS table for a single key/value pair seems like overkill to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/278#discussion_r20241293
--- Diff: src/couch_replicator/src/couch_replicator_api_wrap.hrl ---
@@ -24,7 +24,10 @@
retries = 10,
wait = 250, % milliseconds
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/278#discussion_r20241721
--- Diff: src/couch_replicator/src/couch_replicator_httpc.erl ---
@@ -131,6 +171,90 @@ process_stream_response(ReqId, Worker, HttpDb, Params,
Callback
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/278#discussion_r20241954
--- Diff: src/couchdb/couch_httpd_auth.erl ---
@@ -188,8 +188,12 @@
cookie_authentication_handler(#httpd{mochi_req=MochiReq}=Req
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/278#issuecomment-62774848
Lots of good changes here but I'm not quite +1. This also should be against
https://github.com/apache/couchdb-couch-replicator repo.
---
If your project is set up
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/8#issuecomment-62775843
needs to refer to a JIRA ticket (and not refer to a private vendor's bug
tracker).
---
If your project is set up for it, you can reply to this email
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/10#discussion_r20248063
--- Diff: .gitignore ---
@@ -0,0 +1,7 @@
+*~
+*.beam
+deps
+ebin
+doc
--- End diff --
or docs
---
If your
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/10#discussion_r20248053
--- Diff: .gitignore ---
@@ -0,0 +1,7 @@
+*~
+*.beam
+deps
--- End diff --
this project has no deps
---
If your
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/10#discussion_r20248074
--- Diff: .gitignore ---
@@ -0,0 +1,7 @@
+*~
+*.beam
+deps
+ebin
--- End diff --
ebin/
---
If your project is set
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/10#issuecomment-62787744
and add .rebar for the weird hidden directory that seems to get created. :D
---
If your project is set up for it, you can reply to this email and have your
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/281#issuecomment-62443440
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/128#issuecomment-61712554
aha!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/13#issuecomment-61416287
I don't see why it won't work, just add another clause for
update_histogram/2 which tests the second argument for `when is_function(Fun,
0)` then perform
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/13#issuecomment-61416361
For the descriptions in the comments, I suggest only;
Count the number of rejections by validate_doc_update functions
and
Track the time
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-couch-stats/pull/3
update_histogram with timing of a function
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb-couch-stats histogram-fun
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/13#issuecomment-61418366
https://github.com/apache/couchdb-couch-stats/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-stats/pull/3#discussion_r19714082
--- Diff: src/couch_stats.erl ---
@@ -87,8 +87,19 @@ decrement_counter(Name) -
decrement_counter(Name, Value) -
notify(Name, {dec
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-stats/pull/3#issuecomment-61423253
merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/13#issuecomment-61428290
+1
Sent from my iPhone
On 2 Nov 2014, at 22:47, Alexander Shorin notificati...@github.com
wrote:
Fixed typo and styling space
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/13#discussion_r19705053
--- Diff: priv/stats_descriptions.cfg ---
@@ -182,3 +182,11 @@
{type, counter},
{desc, number of couch_server LRU operations skipped
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/13#discussion_r19705058
--- Diff: priv/stats_descriptions.cfg ---
@@ -182,3 +182,11 @@
{type, counter},
{desc, number of couch_server LRU operations skipped
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/13#discussion_r19705065
--- Diff: src/couch_db.erl ---
@@ -582,18 +582,27 @@ validate_ddoc(DbName, DDoc) -
end.
validate_doc_update_int(Db, Doc
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/13#discussion_r19705074
--- Diff: src/couch_query_servers.erl ---
@@ -260,15 +260,27 @@ get_number(Key, Props) -
validate_doc_update(DDoc, EditDoc, DiskDoc, Ctx, SecObj
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/13#issuecomment-61372852
+1 to the code changes after addressing my comments, I also think the
comments on the commits themselves need editing. They are very long and not
very clear. Happy
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/13#discussion_r19705160
--- Diff: src/couch_db.erl ---
@@ -582,18 +582,27 @@ validate_ddoc(DbName, DDoc) -
end.
validate_doc_update_int(Db, Doc
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/13#discussion_r19705187
--- Diff: src/couch_query_servers.erl ---
@@ -260,15 +260,27 @@ get_number(Key, Props) -
validate_doc_update(DDoc, EditDoc, DiskDoc, Ctx, SecObj
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/12#issuecomment-61243097
Ah, true, true. It exists in new versions but not old.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
1 - 100 of 205 matches
Mail list logo
