Re: [2/5] git commit: use couch_db calls instead of couch_btree

2011-11-09 Thread Filipe David Manana
Randall, I have to disagree on this one. The reason to not call couch_db:get_design_docs/1 is to avoid reading the body of the documents, which is not needed. Plus, couch_db:get_design_docs/1 skips deleted documents, which will causes _changes rows to be skipped. On Wed, Nov 9, 2011 at 10:07

Re: [2/5] git commit: use couch_db calls instead of couch_btree

2011-11-09 Thread Benoit Chesneau
On Wed, Nov 9, 2011 at 11:27 AM, Filipe David Manana fdman...@apache.org wrote: Randall, I have to disagree on this one. The reason to not call couch_db:get_design_docs/1 is to avoid reading the body of the documents, which is not needed. Plus, couch_db:get_design_docs/1 skips deleted

Re: [2/5] git commit: use couch_db calls instead of couch_btree

2011-11-09 Thread Robert Newson
Randall, Did we miss the chance to review this work before it landed? B. On 9 November 2011 10:36, Benoit Chesneau bchesn...@gmail.com wrote: On Wed, Nov 9, 2011 at 11:27 AM, Filipe David Manana fdman...@apache.org wrote: Randall, I have to disagree on this one. The reason to not call

Re: [2/5] git commit: use couch_db calls instead of couch_btree

2011-11-09 Thread Randall Leeds
On Wed, Nov 9, 2011 at 02:48, Robert Newson rnew...@apache.org wrote: Randall, Did we miss the chance to review this work before it landed? Yes. Sorry. I thought it was more trivial than it was. I owe it to Filipe for catching the mistake. While I changed get_design_docs not to get the body by

Re: [2/5] git commit: use couch_db calls instead of couch_btree

2011-11-09 Thread Randall Leeds
On Wed, Nov 9, 2011 at 11:00, Randall Leeds randall.le...@gmail.com wrote: On Wed, Nov 9, 2011 at 02:48, Robert Newson rnew...@apache.org wrote: Randall, Did we miss the chance to review this work before it landed? Yes. Sorry. I thought it was more trivial than it was. I owe it to Filipe

Re: [2/5] git commit: use couch_db calls instead of couch_btree

2011-11-09 Thread Filipe David Manana
On Wed, Nov 9, 2011 at 7:00 PM, Randall Leeds randall.le...@gmail.com wrote: On Wed, Nov 9, 2011 at 02:48, Robert Newson rnew...@apache.org wrote: Randall, Did we miss the chance to review this work before it landed? Yes. Sorry. I thought it was more trivial than it was. I owe it to Filipe