Re: [5/5] git commit: fix improper comparison on filtered changes

2011-11-09 Thread Filipe David Manana
Randall, which test exactly was failing in changes.js? I've never had such failure locally. If it's due to browser caching, it would be a good idea to add a test to test/etap/073-changes.t On Wed, Nov 9, 2011 at 10:07 AM, rand...@apache.org wrote: fix improper comparison on filtered changes

Re: [5/5] git commit: fix improper comparison on filtered changes

2011-11-09 Thread Randall Leeds
On Wed, Nov 9, 2011 at 02:51, Filipe David Manana fdman...@apache.org wrote: Randall, which test exactly was failing in changes.js? It was the andmore-only section near the end: T(line.seq == 8) T(line.id == andmore) The problem is that seq _should_ be strictly greater than since. If you look

Re: [5/5] git commit: fix improper comparison on filtered changes

2011-11-09 Thread Filipe David Manana
On Wed, Nov 9, 2011 at 6:43 PM, Randall Leeds randall.le...@gmail.com wrote: On Wed, Nov 9, 2011 at 02:51, Filipe David Manana fdman...@apache.org wrote: Randall, which test exactly was failing in changes.js? It was the andmore-only section near the end: T(line.seq == 8) T(line.id ==