Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch/pull/19#issuecomment-99483638
All unrelated commits are removed. PR is rebased against current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/19#discussion_r29760699
--- Diff: src/couch_db_updater.erl ---
@@ -605,10 +605,41 @@ init_db(DbName, Filepath, Fd, Header0, Options) ->
Db
end.
Github user iilyak commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/19#discussion_r29758581
--- Diff: src/couch_db_updater.erl ---
@@ -605,10 +605,41 @@ init_db(DbName, Filepath, Fd, Header0, Options) ->
Db
end.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/19#discussion_r29682825
--- Diff: src/couch_db_updater.erl ---
@@ -605,10 +605,41 @@ init_db(DbName, Filepath, Fd, Header0, Options) ->
Db
end.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/19#issuecomment-97882276
@iilyak partially. So far it's all the fine. I'll give you more feedback
over the May's day holidays.
---
If your project is set up for it, you can reply to this em
Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch/pull/19#issuecomment-97833004
@kxepal: Did you have chance to test it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/19#issuecomment-95154777
Update: going to test this thoroughly during the week. I really miss most
part of couch_httpd_multipart now ):
---
If your project is set up for it, you can reply t
Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch/pull/19#issuecomment-66633528
@NorthNick PR is a tool for this. Careful review by peers. The PR was
reopened to signal that @kxepal's comment was addressed.
This PR also depend on
ht
Github user NorthNick commented on the pull request:
https://github.com/apache/couchdb-couch/pull/19#issuecomment-66614068
@iilyak what is the current status of this PR? It looks as though it was
killed off and then resuscitated. If it's still alive, I agree with @davisp
that this is
GitHub user iilyak reopened a pull request:
https://github.com/apache/couchdb-couch/pull/19
Refactor/multipart stream
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iilyak/couchdb-couch refactor/multipart_stream
Alternatively y
Github user iilyak closed the pull request at:
https://github.com/apache/couchdb-couch/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-couch/pull/19#issuecomment-66406876
There be dragons in this code so I'd like to hold off until someone can
find time to make sure there are zero behavior changes. I've fixed a number of
bugs in this p
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/19#issuecomment-66404314
LGFM, however, you need to rebase your PR since it contains some
@robertkowalski commits for unknown reason.
@rnewson , @davisp , @NorthNick what do you thi
13 matches
Mail list logo
